This fixes regression CORE-16289 where we could not longer
move the taskbar at a different than default location,
as WindowSnap would interfere.
Many Thanks to the patches author Doug Lyons.
Eventually the heuristic that we use here to identify the
taskbar via used window-styles could be improved later.
Theoretically possible that it bails out on some other windows.
The regression was introduced by 0.4.12-dev-373-g
7e396787ed
patch is a backport from master 0.4.13-dev-962-g
4193b8d8ac
A very old regression. The visible symptom for us was, that the Apply button in our
desk.cpl was always visible, even in case no user input was done in the dlg yet.
I am still a bit afraid, because this patch is quite new and
it might unhide issues otherwhere, but since it fixes a regression,
I decided to take that risk.
This patch is a backport of 0.4.13-dev-908-g
344d559935
Multiple invocations of ImageList_Destroy() could lead to double-free and
would crash applications since 0.4.12-RC-27-g
89f3036245
Many Thanks to patches author Mark Jansen.
Master is also affected by this bug but did not receive the fix yet.
We unintentionally introduced CORE-16299 by
0.4.12-RC-47-g
625a5a0780
Thx to author Doug Lyons for this patch!
Master is also affected, but will be serviced later.
as the release data is close and we have to manage the risk.
This reverts last commit and all menu related code back to the state of
0.4.12-dev-369-g
007ec0310c
Although Mark Jansen seems to be on a very promising path in master,
we still revert one last time for this release to the more well known
state we had during 0.4.12dev'ing.
This will fix regressions CORE-16298, CORE-16297
and will keep CORE-15863 in fixed state.
Systray and nested desktop popups do work very well like this.
We therefore intentionally and willingly have to accept the broken
partial-offscreen-menus of CORE-15733.
Those are not as important as the other tickets.
Meanwhile we keep on improving master based on the more recent states.
to fix regression CORE-15863
This is the work that Mark jansen committed into master
0.4.13-dev-791-g
a59df3858c
and
0.4.13-dev-792-g
7c45a646e9
and
0.4.13-dev-793-g
b5c6af459c
squashed into one single commit for 0.4.12RC.
It's not perfect yet anymore for positioning the
popup for systray icons if they contain many entries.
And also not perfect when pressing the context menu key
on desktop after a .lnk has been started,
but overall gives a better user-experience for nested popups
on the desktop, which is much more important.
We can build up on top of it later in master.
v6 comboboxes default to displaying up to 30entries and
give a bad user experience in 2nd stage
where we usually have low vertical screen resolution.
Therefore limit the height of the expanded boxes to
bring us close to how they were drawn before 0.4.12-dev-882-g
e3e173ffaa
Adding CBS_NOINTEGRALHEIGHT gives similar result for both:
comctl32 v5 and v6 comboboxes.
Similar commit went into 0.4.13-dev-740-g
8b67edd8fa
This fixes fonts not being displayed properly within an edit in
Precise Calculator application.
Jim Tabor intended to structurally use flTextAlign over
lTextAlign internally within IntExtTextOutW().
He initially committed these changes in 0.4.12-dev-805-g
3377fe184e
But we unintentionally lost these changes via 0.4.12-RC-26-g
486fd83a95
Many thanks to Doug Lyons who helped a lot with fixing CORE-16133.
We also corrected this issue in master via 0.4.13-dev-707-g
0e4db883e5 and 0.4.13-dev-712-g
64e182e429
By removing font substitution for 'Microsoft Sans Serif'.
Thanks to the patches author Katayama Hirofumi MZ.
This is a partial revert of the guilty rev
master guilty 0.4.13-dev-9-g
811faed421
RC guilty 0.4.12-RC-13-g
8d3def0529
VBox test result:
https://reactos.org/testman/compare.php?ids=68497,68499
This fixes high chance for BSOD 0x50 PAGE_FAULT_IN_NONPAGED_AREA
when booting after DVDwriteNow has been installed.
Many thanks to the fixes author Thomas Faber.
We believe this was a regression of SVN r55835
6ebf8c2537
The fix has not been applied to master yet.
The goal of this is to revive the VBox-testbot that failed miserably
like the VBox-one in
https://build.reactos.org/#/builders/9/builds/24947
all the way through the 0.4.12RCs, because 0.4.12-dev was in a poor state
upon branching.
cherry picked from commit 0.4.13-dev-23-g
7334567211
TT_OS2.usWinAscent and TT_OS2.usWinDescent must be treated as FT_Short.
These values affect font metrics.
This PR will fix CORE-14994 that regressed by 0.4.10-dev-466-g
35f62fc5ba
cherry picked from commit 0.4.13-dev-483-g
641a0ea99b
In CNotifyToolbar::AddButton tbBtn.iBitmap (imagelist-index)
was initialized with 0. TightVNC adds the icon without NIF_ICON flag.
So the wrong icon index was kept and later replaced.
This fixes an old regression visible since SVN r68893
cherry picked from commit 0.4.13-dev-481-g
8d6c9e844c
In PDEVOBJ_vRefreshModeList, find a proper match for the current
display mode instead of assuming a constant index.
Both tickets regressed by SVN r74404
384affe098
Many thanks to the patches author Thomas Faber.
cherry picked from commit 0.4.13-dev-456-g
00e882c2b1
Fixes "STDU Viewer 1.6.375 crashing"
A regression of 0.4.12-dev-933-g
7143e411c4
Proposed changes of author Baruch Rutman aka "peterooch" peterooch@gmail.com:
- Use the total extent (width) and font metrics (height) as values
to put in the lpSize variable instead of calling ScriptString_pSize()
in the LpkGetTextExtentExPoint() function.
- Use GetTextExtentExPointWPri in more cases as another effort to get the data.
Many thanks for that prompt fix!
Master got fixed similar in 0.4.13-dev-445-g
22064d7787
Pressing Next-button in setup of "1C Enterprise (training version) 8.3.10.2252"
did not have any effect anymore. Setup could not be completed anymore.
The regession was introduced to ros by 0.4.8-dev-739-g
f8b992f2d3
and was confirmed being a Wine-regression in
https://bugs.winehq.org/show_bug.cgi?id=45445
Thanks to Fabian Maurer for communicating to Wine and thanks to
Thomas Faber for regenerating cond.tab.c from the fixed source file cond.y
using BISON.
I also committed the same fix to master during 0.4.13-dev.
Thanks to Thomas Faber, author of the patch.
I depend on external testers here for confirmation of effectiveness.
We think the problem was unhidden by 0.4.12-dev-757-g
789cfd3ddc
and surrounding works.
When traversing the device tree, keep a reference to the current device.
Devices can be deleted during the traversal, so in order to keep
the tree walk intact without use-after-free situations,
this just keeps the PDO around until we no longer need the device node.
It could be argued that this is a hack, however implementing it the "correct way"
(I haven't actually researched how Windows does this) is unlikely to be possible
with our current PNP manager -- so this should keep us going for a while.
Most likely not correct, as it breaks comctl32:buttonv6 tests
https://reactos.org/testman/compare.php?ids=68146,68147
But greatly improves perceived flickering when hovering
with the mouse about buttons in unthemed mode.
We still fear that this workaround could break buttons that
intend to change their appearance when being hovered.
We workaround only the RC, but will leave master affected for now.
The problems began when we committed the two SxS commits
0.4.8-dev-502-g
7000fe2340
and
0.4.8-dev-503-g
f318a25e10
Since then incompatible comctl32 v5/v6 imagelist were in mixed usage.
The new comctl32 patch fixes the following regressions:
- CORE-14433 MSVCPP 6 installer browseForFolder-dlg lacked icons
- CORE-14433 MS Word Viewer 2003 open-dlg lacked icons
- CORE-15118 OCR CuneiForm 12 lacked icons in the menubar
- CORE-15892 DosBOX 0.74.2 NSIS-installer lacked checkboxes
- CORE-15529 Bulk Rename utility lacked icons
Fixing comctl32 directly was applied to 0.4.12RC for the first time.
Older releases always used a partial SxS revert instead.
Master is still unpatched to date.
The fix is a combination of the first 4 commits of PR#1211 and
the attached is_valid.diff. Thanks to everyone involved:
Giannis Adamopoulos, Mark Jansen and Andreas Maier!
by reverting essential parts of "Font rotation at arbitrary angles"
which was once committed in several steps:
Initial commit (PR#1207)
0.4.12-dev-243-g
f757a13519
broke font rendering for GTK apps CORE-15623
Second commit (PR#1238)
0.4.12-dev-558-g
64987cf273
restored font rendering in GTK apps but introduced slowdown CORE-16020
Katayama agreed to the temporal revert and will try to come up later
with a performance optimized version.
We revert in 0.4.12-RC and 0.4.13-dev.
The revert will cause failure-increases in gdi32:TextTransform.
to protect our latest improvement of showing correct cpl icons in taskswitch
CORE-16086
This reverts commit
0.4.12-dev-437-g
484943d04f
which was done in context of CORE-15672
(without being able to resolve that ticket)
0.4.12-dev-437 contrasts our latest information c.f. Raymond Chen's article:
http://blogs.msdn.com/b/oldnewthing/archive/2007/10/08/5351207.aspx
Eventually we should select the icon instead using that same algorithm.
JIRA-user "Illen" reported booting from his Z170 controller worked up to
0.4.12-dev-936-g89aaf0e
and would refuse booting - beginning with uniata commit
0.4.12-dev-937-g
b546130731
For sure this workaround is just a temporary and no proper solution,
but was confirmed to be working by "Illen". We have no clear understanding of the real bug yet.
Can be replaced by something better at any time.
It was just committed into the RC, master remains affected.
The patch was not committed to master yet. Currently is still under review in PR-1599.
The patch also improves the rendering of disabled menubar buttons for SumatraPDF CORE-10601.
Even after the patch we are not perfect at deciding when to draw masked
and when to draw desaturated in 32bpp, but it definitely improves end users experience.
Many Thanks to the patches author
Andreas Maier <staubim@quantentunnel.de>
JIRA-nick: andy-123
This avoids at startup of Instant Messenger "QIP 2005 8095"
a message-box with "OLE Error 8004001".
The issue is a subtask of CORE-11537
Many Thanks to the patches author
Andreas Maier <staubim@quantentunnel.de>
JIRA-nick: andy-123
Note you still need to install Gecko 2.40 and Samba 1.3 from rapps for QIP.
cherry picked from commit 0.4.13-dev-327-g
bc3eed68ca
This is a squashed backmerge of
PR1572 FLOAT in IntEscapeMatrix
0.4.13-dev-255-g
0137096449
PR1574 FLOAT for orientation
0.4.13-dev-257-g
fabbd7c1c1
PR1576 FLOAT in ftGdiGetGlyphOutline
0.4.13-dev-270-g
86046a9bf4
Those 3 commits were part of CORE-15838.
All those regressions have been introduced during 0.4.12-dev'ing.
to the workaround in last commit 0.4.12-RC-19-g
700779e643
Many thanks to reviewer jimtabor for this very prompt review!
I tested, the new state still succeeds in CORE-15477, CORE-14979, CORE-15599, CORE-15600, CORE-15654
Fixes 'multiple apps leaving the taskbar visible erroneously when switching into fullscreen.'
Please note that the problem with taskbar staying visible is only fixed for some, but not all apps
(see CORE-11242 for some still failing examples, e.g: Bound Around).
We now have the same state in 0.4.12RCs, that we just have committed to master in 0.4.13-dev-247-g
0f29b3faa7
Fixes 'multiple apps leaving the taskbar visible erroneously when switching into fullscreen.'
Please note that the problem with taskbar staying visible is only fixed for some, but not all apps (see CORE-11242 for examples).
This partially reverts commit 09ab5ea7ed (SVN r75407)
I applied this interim solution into 0.4.12RCs for the very first time and rls-tests still
have to prove it being free of obvious side-effects.
Theoretically we could still switch to a better solution at any time.
The workaround never was applied to master to date.
https://reactos.org/testman/compare.php?ids=67536,67539
The regression was unhidden by MSI-winesync 1.5.10 almost 7years ago:
8939969e21
Finally we can fix it by adding MS enumerator extension to Jscript.
Many thanks to the patches author
Andreas Maier <staubim@quantentunnel.de>
JIRA-nick: andy-123
The patch is WIP and was not committed to master yet.
https://reactos.org/testman/compare.php?ids=67482,67485
Resizing a themed window does not longer show a flashing rectangle in the title-bar after the fix.
Still this seems to be work-in-progress even after this first commit, but makes me happy for 0.4.12RCs
for now.
See CORE-7166 & CORE-15934.
cherry picked from commit 0.4.13-dev-8-g
cfdf36e442
The font size was a bit larger than expected.
FireFox will show checkmarks correctly in View menu.
This is a partial revert of 0.4.10-dev-466-g
35f62fc5ba
cherry picked from commit 0.4.13-dev-110-g
19fc9415bf
Fix font enumeration part 2 (#1492)
Eliminate some bugs about font enumeration.
- Add "Microsoft Sans Serif" font substitution.
- Fix and improve the treatment of the nominal font names.
- Split IntGetFontFamilyInfo function from NtGdiGetFontFamilyInfo.
- Add DoFontSystemUnittest function for font system unittest to GDI32.
- Call DoFontSystemUnittest function at CreateFontIndirectW first call.
cherry picked from commit 0.4.13-dev-9-g
811faed421
Fixes regression CORE-15785.
When LOGFONT.lfFaceName[0] == 0, then enumeration of font substitutes had failed.
CORE-15785 commit 2 of 2
cherry picked from commit 0.4.13-dev-107-g
ae8417fd90
Make gdi32!IntFontFamilyListUnique function std::unique compatible.
Previous code didn't set the first entry correctly.
CORE-15785 commit 1 of 2
cherry picked from commit 0.4.13-dev-5-g
ae80eb824e
This reverts 0.4.12-RC-2-g
f57e9ed926
and therefore brings the SxS state back to master. It allows many SxS-dependent apps to run again that broke by the new 0.4.12-workaround.
e.g: Miranda 0.10.48
Unfortunately this will expose many issues for the first time in the 0.4.12release (same way like in master),
that I could properly hide in all past releases by a different workaround (that we can not longer use due to heavy 0.4.12-dev SxS works)
This commit reintroduces:
- CORE-14433 MSVCPP 6 installer open-dlg, MS Word Viewer 2003 open-dlg lacks icons
- CORE-15118 OCR CuneiForm 12 lacks icons in the menubar
- CORE-15892 DosBOX 0.74.2 NSIS-installer lacks checkboxes
We think that all those issues are caused by incompatible comctl32 v5/v6 imagelists actually.
If time will allow it, I might experiment with some macros later to hide the comctl32-issue leaving SxS intact.
By applying for the first time clientFix.patch from CORE-15911 contributed by JIRA-user 'I_Kill_Bugs'.
The patch acts as a better replacement for a workaround of DougLyons from CORE-15429
that aimed to hide the issue for our file-browser only.
The new approach gave good results for the testbots
https://reactos.org/testman/compare.php?ids=66723,66729
but wasn't tested much yet. In case it causes any problems during testing-cycle,
I might eventually switch back to our old workaround instead from the last releases.
After the DC work is done while before releasing the DC flush the GDI batch.
See CORE-15905. Someone may need to notify wine about this change.
cherry picked from commit 0.4.13-dev-7-g
84d518b190
to avoid CORE-15384 "ros corrupts FAT16 partition"
This reverts commit 0.4.11-dev-210-g
2a80ae2bb6
Like we did in 0.4.11rls.
I would happily switch over to a proper working fix from master later.
I would also do that if it appeared only after this interim solution got committed.
(cherry picked from commit 78cd6265d9)
Fixes the icons on some buttons being flipped vertically.
Known affected apps: Lazarus IDE, Double Commander, Peazip.
Beside that it also fixes transparency regressions in DVDStyler 3.0.4 (CORE-14701).
Thanks to patches author Doug Lyons.
The patch has not been committed to master yet and has the known side-effect
of introducing flipped icons in the options-listview of Double-Commander
that are drawn correctly without the hackfix.
like in last release
(cherry picked from commit b906163dc1)
This brings us back to before commit 0.4.10-dev-55-g
7af3969e9f
and therefore downgrades D3D8,D3D9,DDRAW,WINED3D to 3.3 for this rls.
This is same versions as we had in 0.4.10rls (I used same revert then)
Purpose of this revert is to fix crashes when Ddraw apps switch
into fullscreen with VBEMP and inbuilt Mesa.
I tested, before:
DxDiag crashed when switching to fullscreen,
Diablo II crashed immediately,
Monster-Truck-Madness 2 demo crashed after main menu
Afterwards all of these apps do run.
DXTN does still work after that, even with VBEMP and inbuilt Mesa.
This will be the interim fix, which I will keep for rls at least
until someone manages to fix CORE-14955 properly in master with current Wine.
analog to 0.4.10-RC-17-g
bb4c55d650
