Commit graph

3890 commits

Author SHA1 Message Date
Katayama Hirofumi MZ
90a5b9a83f
[SHELL32] RecycleBin5: Make it C++ (#7174)
Modernize code.
JIRA issue: CORE-19595
Rewrite RecycleBin5 in C++.
2024-07-29 09:20:36 +09:00
Katayama Hirofumi MZ
22b913928f
[SHELL32] RecycleBin5Enum: Make it C++ (#7173)
Modernize code.
JIRA issue: CORE-19595
Rewrite RecycleBin5Enum in C++.
2024-07-29 08:14:02 +09:00
Katayama Hirofumi MZ
ec24b54731
[IMM32][NTUSER] Use HandleToUlong, UlongToHandle etc. macros (#7180)
Respect coding standard.
JIRA issue: N/A
- Use HandleToUlong, UlongToHandle,
  UlongToPtr etc. macros for type
  casting.
- Remove redundant casts.
2024-07-29 07:15:44 +09:00
Whindmar Saksit
a8b33400a2
[INF][BOOTDATA][SETUPAPI] Use Inf instead of Cmd.exe to register IExplore (#7171)
This moves the IExplore registration from cmd.exe (established in 4a4060ce3c (r52196) for CORE-1370) to syssetup.inf to avoid console popups on first boot.
2024-07-24 22:55:29 +02:00
Katayama Hirofumi MZ
6910fa624f
[SHELL32] RecycleBinGeneric: Make it C++ (#7169)
Modernize code.
JIRA issue: CORE-19595
Rewrite RecycleBinGeneric in C++.
2024-07-24 12:16:37 +09:00
Katayama Hirofumi MZ
72116d0558
[SHELL32] RecycleBinGenericEnum: Make it C++ (#7167)
Modernize code.
JIRA issue: CORE-19595
Rewrite RecycleBinGenericEnum
in C++.
2024-07-24 11:24:56 +09:00
Whindmar Saksit
d5aca44042
[SHELL32] Forward CDefaultContextMenu::InvokeCommand parameters to ShellExecute (#7172) 2024-07-23 18:58:02 +02:00
Katayama Hirofumi MZ
876d1c2dc8
[SHELL32] Use DECLARE_INTERFACE_ for IRecycleBin5 (#7168)
Improve interoperability between
C and C++.
JIRA issue: CORE-19595
Rewrite IRecycleBin5 interface
by using STDMETHOD and
DECLARE_INTERFACE_ macro.
2024-07-23 22:21:11 +09:00
Katayama Hirofumi MZ
166c7ee33c
[SHELL32] CRecycleBin: Add backshash if path is drive only (#7170)
JIRA issue: CORE-18006
If the original location is drive
only (C:, D: etc.), then append a
backslash.
2024-07-23 15:46:18 +09:00
Katayama Hirofumi MZ
b40046f426
[SHELL32] ShellExecCmdLine: Use SearchPathW (#7166)
Based on @Doug-Lyons
shlexec-winR-fonts.patch.
#4932 (f691efe) introduced
some regression.
JIRA issue: CORE-19688
Call SearchPathW function before
PathFindOnPathExW call in
ShellExecCmdLine function.
2024-07-23 15:08:16 +09:00
Whindmar Saksit
6219a1abe5
[BROWSEUI][SHELL32] Ignore navigation requests during browser destruction (#7161)
PR #7141 causes calls to IShellBrowser::BrowseObject while the shell browser is in the middle of destruction and the ShellView ListView has already been destroyed and DefView is not prepared for this.
2024-07-22 21:25:58 +02:00
Whindmar Saksit
f6a25d48d5
[SHELL32] Invoke the ItemIDList of shortcuts (#7152)
Invoking the IDList as if the target was double-clicked in Explorer fixes shortcuts to control panel items (both .cpl and ShellFolder types).

CORE-19690
2024-07-22 19:31:48 +02:00
Katayama Hirofumi MZ
7f0e8a3697 [SHELL32] RecycleBinGenericEnum: Convert tabs to spaces
CORE-19595
2024-07-22 13:24:12 +09:00
Eric Kohl
f24fbb655e [SETUPAPI] Implement CM_Dup_Range_List() and CM_Test_Range_Available() 2024-07-21 16:32:28 +02:00
Katayama Hirofumi MZ
b6b82fee3f
[SHELL32] Refactor CShellLink::DoOpen (#7149)
Reduce code. Modernize code.
JIRA issue: N/A
Use CStringW and CComHeapPtr<WCHAR> for
dynamic allocation.
2024-07-21 10:08:16 +09:00
Eric Kohl
894ad4f17d [SETUPAPI] Implement CM_Free_Res_Des_Handle() and improve CM_Get_Next_Re_Des_Ex() 2024-07-20 22:20:36 +02:00
Katayama Hirofumi MZ
39077a7bf0
[BROWSEUI][SHDOCVW][SDK] Fix INamespaceProxy interface (#7156)
Use correct interface definition for standardization.
JIRA issue: CORE-19686
Use INamespaceProxy interface
that is documented in the
Microsoft official site
( https://learn.microsoft.com/en-us/previous-versions/windows/internet-explorer/ie-developer/platform-apis/ee318424%28v=vs.85%29 )
and Windows 10 PSDK
(see um/ienamespacecontrol.idl file).
2024-07-20 19:59:48 +09:00
Whindmar Saksit
802dc9714b
[SHELL32][SHLWAPI][BROWSEUI][EXPLORER] Save folder view state (#7127)
Saves/restores the Listview icon mode, columns and sort info per-folder.
2024-07-19 14:40:20 +02:00
Whindmar Saksit
fa95a96e9b
[SHELL32] Use correct PIDL and name when dropping to create a shortcut (#6999)
Ask for the editing name instead of the parsing name to get a suitable shortcut name for PIDL items.
2024-07-19 13:37:53 +02:00
Katayama Hirofumi MZ
089788a52a
[SHELL32][SHELL32_APITEST] ShellExecute should accept invalid directory (#7150)
Implement parsing SHELLEXECUTEINFO.lpDirectory.
Enhance ShellExecuteEx testcase for invalid directory.
2024-07-19 17:40:36 +09:00
Tomáš Veselý
466a19817f
[COMCTL32][USER32] STATIC: Fix grayed drawing (#7024)
CORE-15298

Use DrawTextW() to correctly render disabled grayed text.
Applies to both dll\win32\comctl32\static.c and win32ss\user\user32\controls\static.c

A similar solution is already used by button.c!BUTTON_DrawLabel().
2024-07-18 22:03:36 +02:00
Mas Ahmad Muhammad
69b382a1ac
[TRANSLATION] Update Indonesian (id-ID) translation (#7147)
Update Indonesian Translation for explorer.exe shell dlls:
explorer, browseui, ieframe, shell32.
2024-07-18 18:18:07 +02:00
Jose Carlos Jesus
187be834c0
[SHELL32] Update Portuguese (pt-PT) translation (#6939)
- Update translation;
- Fix typos;
- Add file header.

Co-authored-by: Stanislav Motylkov <x86corez@gmail.com>
Co-authored-by: Joachim Henze <joachim.henze@reactos.org>
2024-07-18 18:08:09 +02:00
Katayama Hirofumi MZ
69931a4a7d
[SHDOCVW] Initial implementation of Favorites bar (#7146)
First step to Favorites bar support.
Menu: [View]→[Explorer bar]
→[Favorites]

JIRA issue: CORE-19686

- Add CFavBand.cpp, CFavBand.h,
  favband.rgs, and resource.h files.
- Modify CMakeLists.txt.
- Add IDS_ADD and IDS_ORGANIZE
  resource strings.
- Implement empty Favorites bar.
- The treeview is not populated yet.
- The Add button is not
  implemented yet.
2024-07-18 23:21:40 +09:00
Andrei Miloiu
4a13f1ec3c
[OLEDLG] Update Romanian (ro-RO) translation (#6774) 2024-07-16 21:45:10 +02:00
Andrei Miloiu
9f9431bc7b
[COMCTL32] Update Romanian (ro-RO) translation (#6874) 2024-07-16 21:42:40 +02:00
Andrei Miloiu
f200a34964
[SETUPAPI] Update Romanian (ro-RO) translation (#6843) 2024-07-16 21:41:46 +02:00
Andrei Miloiu
fc7a2179d1
[USERENV] Update Romanian (ro-RO) translation (#6831) 2024-07-16 21:40:21 +02:00
Andrei Miloiu
61286667f4
[MPR] Update Romanian (ro-RO) translation (#6866) 2024-07-16 21:36:22 +02:00
Andrei Miloiu
479c5499d1
[MSACM32] Update Romanian (ro-RO) translation (#6875) 2024-07-16 21:35:27 +02:00
Andrei Miloiu
f33186b15b
[AVIFIL32] Update Romanian (ro-RO) translation (#6876) 2024-07-16 21:33:35 +02:00
Andrei Miloiu
0d175e2f8f
[MSVFW32] Update Romanian (ro-RO) translation (#6878) 2024-07-16 21:30:17 +02:00
Andrei Miloiu
2229991bc0
[CREDUI] Update Romanian (ro-RO) translation (#6732) 2024-07-16 21:09:25 +02:00
Andrei Miloiu
0d0db4a796
[NEWDEV] Update Romanian (ro-RO) translation (#6663) 2024-07-16 20:38:49 +02:00
Andrei Miloiu
cab86826e9
[MSGINA] Update Romanian (ro-RO) translation (#6536) 2024-07-16 20:28:05 +02:00
Andrei Miloiu
3ac92d4c2e
[RASDLG] Update Romanian (ro-RO) translation (#6537) 2024-07-16 20:20:46 +02:00
Whindmar Saksit
0ba96ad05e
[SHELL32] Don't update statusbar during drag operation (#7144) 2024-07-16 20:01:59 +02:00
Katayama Hirofumi MZ
580824ae1f
[BROWSEUI] CExplorerBand: Refresh on change notification (#7141)
Update UI on filesystem change.
JIRA issue: CORE-12619
- Add Refresh and RefreshRecurse
  methods.
- Add IsTreeItemInEnum,
  TreeItemHasThisChild,
  GetItemEnum, and
  ItemHasAnyChild helper
  methods.
- Delete RenameItem, DeleteItem
  and RefreshTreePidl methods
  and _ReparsePIDL function.
- Add WM_TIMER message
  handler (OnTimer) to delay
  refreshing.
- Refresh TreeView on change
  notification.
2024-07-16 21:21:41 +09:00
Katayama Hirofumi MZ
6f277e9766
[SHELL32] shlexec.cpp: Parse 'shell:' and '::{CLSID}' (#7126)
JIRA issue: CORE-14177
JIRA issue: CORE-17482
- Add SHELL_InvokePidl helper
  function.
- Call SHParseDisplayName and
  SHELL_InvokePidl in a specific
  condition.
2024-07-15 21:16:04 +09:00
Katayama Hirofumi MZ
0574987b20 [BROWSEUI] Use override keyword and STDMETHODIMP_
CORE-19469
2024-07-14 10:59:10 +09:00
Katayama Hirofumi MZ
7bec458077
[BROWSEUI] CExplorerBand: Use SHCNRF_NewDelivery method (#7133)
Refactoring. Optimize for speed.
JIRA issue: CORE-12619
- Update file headers.
- Make some parameter type LPITEMIDLIST
  LPCITEMIDLIST (Add const).
- Add OnChangeNotify method.
- Use SHCNRF_NewDelivery method for speed.
- Add some SAL annotations.
2024-07-14 10:50:18 +09:00
Katayama Hirofumi MZ
465b9cef25
[SHELL32] ShellAboutW: IDD_ABOUT offset is (20, 20) (#7132)
JIRA issue: CORE-17084
Change IDD_ABOUT resource
dialog offset to (20, 20).
2024-07-11 17:20:45 +09:00
Katayama Hirofumi MZ
0fbf4fb8fb
[BROWSEUI] Fix confusion of StrDupW and SHStrDupW (#7135)
Fix memory leaks.
SHStrDupW uses CoTaskMemAlloc.
StrDupW uses LocalAlloc.
They are different.
JIRA issue: N/A
Use SHStrDupW instead of StrDupW.
2024-07-11 17:19:57 +09:00
Hermès Bélusca-Maïto
c02289a08a
[UXTHEME][NTUSER] Check class style for CS_NOCLOSE instead of window style (#7130)
CORE-11569, CORE-19684

Addendum to commit 71bed0f5f8 (PR #7123).

The problem in uxtheme was introduced in commit 685084b63c (as part
of a fix for CORE-17203), because it was a copy-paste and adaptation
of the corresponding code in `ntuser/nonclient.c!NC_DoButton()`.

The bugs in `win32ss/user/ntuser/defwnd.c` (and `nonclient.c` as fixed by
the previous commit) were in turn introduced from the migration of menu
and related code from user32 to win32k, see commit 6dfa71c487 (r68904).
2024-07-10 19:49:09 +02:00
Katayama Hirofumi MZ
9f68f482c1
[BROWSEUI] Check focus before opening AutoComplete (#7128)
Unexpectedly remaining
AutoComplete list is annoying.
JIRA issue: CORE-19685
- Add CAutoComplete::
  m_bEditHasFocus to watch
  focus.
- Update m_bEditHasFocus on
  WM_SETFOCUS and
  WM_KILLFOCUS messages on
  Edit window procedure.
- Don't open AutoComplete list
  when m_bEditHasFocus was
  FALSE.
2024-07-10 22:47:02 +09:00
Whindmar Saksit
2e08238c7c
[SHELL32] CDefaultContextMenu must respect the default verb list (#7090) 2024-07-09 20:01:50 +02:00
Whindmar Saksit
5b78381a53
[BROWSEUI][SHELL32] Implement BrowseObject flags (#7086)
* [BROWSEUI][SHELL32] Implement BrowseObject flags

Respect CABINETSTATE::fNewWindowMode if no other flags are relevant
2024-07-09 20:00:54 +02:00
Stanislav Motylkov
a629258e4a [SHELL32] Update Russian (ru-RU) translation
Addendum to:
- fd39a292af, dc97c0d109.
- 5308a606dc. CORE-12562
- 3da9e7e251. CORE-16944 CORE-19597

Also fix overlapping window controls.
2024-07-09 19:52:53 +03:00
Stanislav Motylkov
4b9eec2d3b [MSUTB] Add Russian (ru-RU) translation
Also fix overlapping window controls.
Addendum to f4460c3fcd. CORE-19363
2024-07-09 19:32:12 +03:00
Katayama Hirofumi MZ
d7289cf2e9
[BROWSEUI] AutoComplete: Close before opening IME candidates (#7115)
The auto-complete window and
the IME candidate window were
conflicting each other.
JIRA issue: CORE-19268
Call HideDropDown method
when processing
IMN_OPENCANDIDATE message.
2024-07-10 00:05:28 +09:00