Commit graph

77799 commits

Author SHA1 Message Date
Oleg Dubinskiy
3904423d8f [PSDK] Import vsbackup.idl from Wine and enable it in CMakeLists.txt
Required by vssapi stubs CORE-9511.
2020-06-07 19:45:05 +02:00
Oleg Dubinskiy
9994a4309c [PSDK] Add some missing definitions from Wine in vss.idl
Required by vssapi stubs and Wine's vsbackup.idl CORE-9511.
2020-06-07 19:45:05 +02:00
Oleg Dubinskiy
eac44a7f9d [PSDK] Replace our vswriter.h by Wine's vswriter.idl and enable it in CMakeLists.txt
Required by vssapi stubs CORE-9511.
Our current vswriter.h has no some needed definitions, but simple adding them in the current header is not an option, since Wine's vsbackup.idl (which is required too) depends on it.
Then it will not need to add ROS-specific diff(s) in Wine's vsbackup.idl.
2020-06-07 19:45:05 +02:00
Charles Ambrye
99dd292553
[CHARMAP] Functionality Improvements and Bug Fixes (#2560)
- Resize the window slightly when compiled with REMOVE_ADVANCED to avoid deadspace at the bottom of the window.

- Skip over the non-printable characters by starting with character ' ' + 1.

- Instead of iterating over every cell, simply compute the cell x and y using the CellSize.

- Modify behaviour of charmap to allow large character render on mouse move, only hiding the larger character on double click.

- Simplify math for moving window to be on desktop.
Added FIXME to highlight this doesn't work well on multi-monitor setups.
Changed xPos and yPos to LONG since negative numbers are valid on multi-monitor setups.

- Do not draw invalid glyphs on the map (can happen when switching fonts or filtering existing font).
- Do not allow mouse-over of invalid glyphs.

- Fix bug that caused the Help button to remain enabled as it was being modified before it was even created.
- Do a better job at finding the correct glyph under the mouse.

- Ensure the active cell is cleared correctly.

- Invalidate the rect around the previously active cell to ensure it gets redrawn as inactive.

- Fix bug from CORE-10518 (initial active cell was not being invalidated on scroll).

- Do not try to copy a character to the output if there is no active cell selected.

- Populate the advanced portion of the screen with several built-in code pages (the list is hardcoded so that we don't enumerate everything).

- Add functionality to filter the character map by a code page (called a character set in this program).

- Some fonts list 0x0000 as drawable, even when it isn't, so ignore any valid glyphs that contain it.
2020-06-07 19:34:45 +02:00
Oleg Dubinskiy
31e00140d3
[RPCRT4] Export NdrCreateServerInterfaceFromStub as stub
Required by MS ole32.dll CORE-15395, CORE-17004.
2020-06-07 14:08:58 +02:00
Thomas Faber
185591368d [SHELLBARS] Add missing psdk dependency. 2020-06-06 23:02:35 +02:00
Thomas Faber
789c88c185 [MSTASK] Add netapi32 dependency to ensure atsvc_c.h is available. 2020-06-06 23:02:35 +02:00
George Bișoc
38c01a8429
[NTDLL_APITEST] Add ProcessWx86Information testcase for NtXxxInformationProcess (#2852) 2020-06-06 21:38:37 +02:00
Amine Khaldi
139a3d6661
[CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2020-06-06 21:58:41 +03:00
Serge Gautherie
4cd7b3a3df
[HHPCOMP] Fix 2 MSVC C4101 warnings (#2392)
"...\chmc\chmc.c(671): warning C4101: 'code': unreferenced local variable"
"...\chmc\chmc.c(671): warning C4101: 'len': unreferenced local variable"
2020-06-06 18:42:47 +02:00
Serge Gautherie
abe1dd31c4
[SHLWAPI] lang/*.rc : Enforce aa-BB filenames (#2816) 2020-06-06 18:25:43 +02:00
Serge Gautherie
1e861d9759
[NFSD] readdir_copy_shortname(): Add needed brackets to '*name_size_out' (#2856)
CORE-17078
2020-06-06 18:21:05 +02:00
Serge Gautherie
e7440eff8f
[APPHELP_APITEST] Properly handle a couple 'malloc()/free()' (#2898)
Detected by Cppcheck: memleak, redundantAssignment.
Addendum to 78280ad2 (r71226).
2020-06-06 17:58:34 +02:00
Serge Gautherie
3051eb0e48
[NTOSKRNL] Add 'DECLSPEC_NORETURN' to a few 'KeBugCheck*()' (#2896) 2020-06-06 17:50:14 +02:00
George Bișoc
d4acd8cc91
[NTDLL_APITEST] Add NtSetInformationThread testcase (#2793) 2020-06-06 17:48:39 +02:00
George Bișoc
a7dd057ce2
[NTDLL_APITEST] Add ProcessBasePriority and ProcessRaisePriority classes unit tests (#2740)
ProcessRaisePriority expects a buffer input information argument of KPRIORITY type definition as shown in this documentation (see the PROCESS_INFORMATION_CLASS structure members list of classes).
https://undocumented.ntinternals.net/index.html?page=UserMode%2FUndocumented%20Functions%2FNT%20Objects%2FProcess%2FNtSetInformationProcess.html
2020-06-06 17:47:38 +02:00
Thomas Faber
4f49a9c792
[NTOS:KE] Save ExceptionList in the assembly version of KiEnterTrap. CORE-15723
If SEH is used in a C trap handler, the exception frame will be
registered before the call to KiEnterTrap, which means we save
the wrong trap handler. We'll therefore also restore this wrong
frame for the excepting code, resulting in a stale SEH chain.

We avoid this problem by saving the handler in the assembly
trap entry code instead of from C. While SEH in a C trap handler
should now theoretically be safe, we still forbid it through
asserts in the C KiEnterTrap variants to make any potential
future problems more obvious. Should this functionality be
needed at some point and deemed safe, these asserts can then be
removed.
2020-06-06 08:44:30 +02:00
Thomas Faber
d40ff3ca98
[NTOS:KE] Split KiCheckForSListFault into its own function. CORE-15723
This avoids SEH in a trap handler.
See the following commit for more details.
2020-06-06 08:42:22 +02:00
Thomas Faber
4dedc8ff52
[RTL] Add FPO information to RtlpExecuteHandler. CORE-15723 2020-06-06 08:40:20 +02:00
Serge Gautherie
5d88487cd1
[CDMAKE] Add 'DECLSPEC_NORETURN' to 'error_exit()' (#2893)
Detected by Cppcheck: doubleFree.
2020-06-05 13:57:49 +02:00
Serge Gautherie
6808e40b3b
[SDK:RTL] RtlValidAcl(): Improve ACL error messages (#2833)
CORE-11506
2020-06-05 00:20:20 +03:00
Serge Gautherie
8140203940
[KERNEL32] FatalAppExitW: Add an 'UNREFERENCED_LOCAL_VARIABLE(Status)' (#2883)
Addendum to 21d2accad3 (r71793).
2020-06-04 23:35:54 +03:00
Serge Gautherie
450425028c
[IPHLPAPI] getNumInterfacesInt(): Remove 'if()' redundant condition (#2884)
No impact.

Detected by Cppcheck: redundantCondition.
Addendum to 1fe3a2d6c3 (r9788).
2020-06-04 23:26:28 +03:00
Dmitry Borisov
17c5fb8866
[HALXBOX] Fix clock drift (#2889)
Add a new rollover table for Original Xbox (base frequency is 1.125000 MHz).
This fixes potential time issues in kernel and drivers.

CORE-16216
2020-06-03 02:14:16 +03:00
Stanislav Motylkov
092bc78a42
[FREELDR] Fix register offset
Addendum to 10e52f6.
2020-06-03 02:04:07 +03:00
Katayama Hirofumi MZ
7c9a8c0b89
[SHELL32] Improve readability of filesystem notification (#2737)
Improve human readability of filesystem change notification.
- Rename the identifiers for human readabilities.
- Split the code into CFilePathList and CDirectoryWatcher classes.
- Encapsulation of code.
CORE-13950
2020-06-02 18:42:07 +09:00
Jose Carlos Jesus
3dad100ea4
[TRANSLATION] Add/update Portuguese translation (#2850)
- Add translation for: iernonce, modmui.
- Update translation for: jscript, msports, shell32.
2020-06-01 20:48:58 +02:00
Jose Carlos Jesus
8189133865
[TRANSLATION] Add/Update Portuguese translation for some shell extensions (#2845)
- Add translation for: devcpux, netplwiz, ntobjshex, stobject, zipfldr.
- Update translation for: sendmail.
2020-06-01 20:31:06 +02:00
Serge Gautherie
b5af1eb44a
[CSRSRV] CsrUnhandledExceptionFilter: Check RtlAdjustPrivilege() result (#2864)
And remove unused NtRaiseHardError() Status assignment.

Detected by Cppcheck: redundantAssignment.
Related to commit d221bdfb (r55647).
2020-06-01 20:20:31 +02:00
Serge Gautherie
7094297b7a
[APISETS] Fix some functions that are NT10(v1607)+ (#2738)
- *_onexit_*() are NT10(v1607)+
- *_seh_filter_*() are NT10(v1607)+ actually

CORE-16700
2020-06-01 20:04:32 +03:00
He Yang
e5886f862f
[RAPPS] Update Chinese (Taiwan) translation (#2873) 2020-06-01 14:30:53 +03:00
Serge Gautherie
4425bd8db3
[CSRSRV] CsrSetProcessSecurity(): Check 1st NtQueryInformationToken() result (#2862)
Also:
* Add 1 NtClose(hToken), in an error case.
* Do not call RtlFreeHeap(..., ..., NULL).

Follow-up to #2857.
2020-06-01 14:17:29 +03:00
Serge Gautherie
64fea1dbd0
[MSGINA] gui: Improve DlgData_LoadBitmaps() (#2520)
And let bar timer depend on the bar image only.

Addendum to 623dd26cce.
2020-06-01 12:26:53 +03:00
Serge Gautherie
6baa151888
[APISETS] Some API sets are NT10+ and win32 only (Part 1/2) (#2805)
* api-ms-win-downlevel-shell32-l1-1-0.dll is NT10+ and win32 only
* api-ms-win-shcore-obsolete-l1-1-0.dll is NT10+ and win32 only
* api-ms-win-downlevel-shlwapi-l2-1-0.dll is NT10+ and win32 only

CORE-8880
2020-06-01 12:20:13 +03:00
Serge Gautherie
701e6c6a2f
[SNDREC32] Use ShellAboutW(..., ..., NULL, ...) (#2827)
Addendum to 82e4efea77.
2020-06-01 12:17:29 +03:00
Serge Gautherie
95e5877027
[USER32] MDIClientWndProc_common(): Properly sync to old Wine (#2843)
No impact.

Missed part of
fb6304119a

Detected by Cppcheck: identicalInnerCondition.
Addendum to 303ece2421 (r72520).
2020-06-01 12:14:38 +03:00
Serge Gautherie
ceccaae311
[NTOS:MM] MmDeleteProcessAddressSpace(): Move 'Address' to where it belongs (#2865)
No impact.

Detected by Cppcheck: unusedVariable.
Addendum to 2dade10d54.
2020-06-01 12:10:11 +03:00
Serge Gautherie
703c56beb3
[REACTOS] RegQueryValueExW() wants bytes, not chars (#2876)
Cherry-pick:
a359e02666
0662da18b8
e4e5eda3d9

CORE-9665

Co-authored-by: Victor Martinez <vicmarcal@gmail.com>
2020-06-01 12:06:49 +03:00
Stanislav Motylkov
1c504f4c57
[INF] Add better device descriptions for Original Xbox
CORE-16216
2020-06-01 00:30:51 +03:00
Eric Kohl
505b9f8052 [SCHEDSVC] Implement the job start time calculation for given days of month 2020-05-31 22:33:49 +02:00
Eric Kohl
d70c64bde0 [SCHEDSVC] Fix the job start time calculation for given days of week. 2020-05-31 15:49:22 +02:00
Timo Kreuzer
cb99761bc1 [NTDLL] Use lowest OS version GUID in the application manifest, instead of highest 2020-05-31 13:14:01 +02:00
Timo Kreuzer
0ed8b916e4 [MSTASK] Add C stubs and comment out decorated exports
MSVC's LINK is not able to export both the undecorated and decorated symbol from the same dll. This results in an incoherence between the spec file entries and the actual exports, breaking the dll export versioning.
2020-05-31 12:26:37 +02:00
Mark Jansen
2d9b385715 [NTOSKRNL] Group files in the project file based on directory layout 2020-05-29 21:10:10 +02:00
Victor Perevertkin
2dc9f0ae43
[GITHUB] Set up necessary environment variables for Flex and Bison
Decrease ccache size, based on observations
Print ccache statistics in the end of build
2020-05-28 23:11:53 +03:00
Thomas Faber
e4066536c2
[CPPRT][CRT] Avoid extern assembly declarations with no type. CORE-17088
Fixes build with ML 14.26.
2020-05-28 14:26:48 +02:00
Katayama Hirofumi MZ
99b52df014
[SHELL32][INCLUDE] Improve CheckEscapesA/W (#2795)
Fix and improve shell32!CheckEscapesA/W functions.
Add a testcase for shell32!CheckEscapesA/W to shell32_apitest.
2020-05-28 10:58:26 +09:00
Serge Gautherie
9a614c82e1
[LABEL] wmain(): Initialize 'szBuffer' (#2867)
Detected by Cppcheck: uninitvar.
2020-05-27 17:05:33 +02:00
Serge Gautherie
938df97b54
[WIN32K:NTUSER] NC_IconForWindow(): Remove redundant if() (#2842)
No impact.

Detected by Cppcheck: identicalInnerCondition.
Addendum to 98060c28c8 (r60622).
2020-05-26 20:25:39 +02:00
Serge Gautherie
11345aedd8
[FORMATTING] [CMAKE] Remove space in 'if (' (#2847) 2020-05-26 20:24:02 +02:00