Commit graph

71955 commits

Author SHA1 Message Date
Pierre Schweitzer 2cf9a69bce
[NTOSKRNL] Addendum to 8a8cb4d: don't print uninit pointer. 2018-05-23 08:44:43 +02:00
Pierre Schweitzer 8a8cb4d890
[NTOSKRNL] Only consider SharedCacheMap value once ViewLock is acquired.
This avoids a really nasty race condition in our cache controler where
two concurrents could try to initialize cache on the same file.
This had two nasty effects: first shared map was purely leaked and erased
by the second one. And the private cache map, allocated on the first shared
cache map couldn't be freed and was leading to Mm BSOD (free in a middle of
a block).

This was often triggered while building ReactOS on ReactOS (with multi threads).
With that patch, I cannot crash anylonger while building ReactOS.

CORE-14634
2018-05-23 08:41:46 +02:00
Eric Kohl 39281f0f70 [MSGINA] Clear the password on logoff 2018-05-23 00:27:11 +02:00
Eric Kohl 8828567086 [MSGIINA] Make sure we do not leak bitmaps 2018-05-23 00:24:53 +02:00
Pierre Schweitzer b4363068d1
[FASTFAT] Properly handle IRPs that can wait and these that cannot.
CORE-14634
2018-05-22 21:30:08 +02:00
Eric Kohl 8c5cf73018 [MSGINA] Always stop the automatic login after the first try
Fixes CORE-14643
2018-05-22 21:19:58 +02:00
Eric Kohl 46dcab7ab1 [WINLOGON] Ignore the CTRL+SHIFT+ESC hotkey when the session is not in the logged-on state
Should fix CORE-13478
2018-05-22 18:14:42 +02:00
Eric Kohl 47567abf27 [MSGINA] Do not try to impersonate the user on shutdown when we are already logged off 2018-05-22 17:35:33 +02:00
Eric Kohl 4c4c6e88b3 [MSGINA] Close the LSA handle on shutdown 2018-05-22 17:31:20 +02:00
Eric Kohl bab4d87ac8 [MSGINA] Close the user token in WlxLogoff 2018-05-22 16:32:10 +02:00
Eric Kohl c98b8dc98c [MSGINA] Rename context variable: Domain -> DomainName 2018-05-22 14:39:38 +02:00
Eric Kohl 1f0fe38634 [WINLOGON] Prevent shell restart when the user is logged off 2018-05-22 14:36:55 +02:00
Eric Kohl b784c7bfba [BOOTDATA][MSGINA][SYSSETUP] Rename the DefaultDomain registry value to DefaultDomainName 2018-05-22 11:30:27 +02:00
Eric Kohl 665926d38b [MSGINA] Add the IgnoreShiftOverride feature again 2018-05-22 11:06:38 +02:00
Eric Kohl 0d308f4b6e [MSGINA] Simplify the auto logon code path
- Get rid of DoAutoLogon() and the AutoLogonState variable.
- Handle the auto logon in the normal logon code path instead.
- Set bAutoAdminLogon to FALSE on a successful login. This will prevent another automatic logon after a logoff.
- The IgnoreShiftOverride feature got lost by this change but I will add it again.
2018-05-21 16:29:02 +02:00
Pierre Schweitzer 3dc07c91f8
[WINLOGON] Fix build. 2018-05-21 11:33:02 +02:00
Eric Kohl 02f3cb5381 [WINLOGON] Close all dialog boxes on SAS
CORE-13593
2018-05-21 11:21:42 +02:00
Pierre Schweitzer e9e14be661
[FASTFAT] Properly queue pending write IRPs.
Addendum to 30b836b
2018-05-21 10:41:59 +02:00
Pierre Schweitzer 30b836bf3f
[FASTFAT] When extending a file, also lock the DirResource.
This avoids race conditions under high IOs and thus corruption on
the FS, or assertions failures in the kernel.
Easily triggered by building ReactOS on ReactOS ;-).
2018-05-21 10:30:14 +02:00
Eric Kohl 0fbaea843e [SETUPAPI] Add stubs for CM_Detect_Resource_Conflict and CM_Detect_Resource_Conflict_Ex 2018-05-21 02:30:35 +02:00
Hermès Bélusca-Maïto 1eca625839
[CONUTILS] Remove old code; modify an informative note. 2018-05-20 22:39:21 +02:00
Joachim Henze cfb8f97968 [SDK] "0.4.10-dev" Starts here.
tag will be added in next commit.
2018-05-20 20:35:12 +02:00
Hermès Bélusca-Maïto ddd03a8973
[CMD] Use string-safe call to build the new console title (possibly truncated, we don't care), avoiding any buffer overflow. Caught by David Quintana. 2018-05-20 19:57:43 +02:00
Hermès Bélusca-Maïto 7b618314c2
[USETUP] Remove now-unneeded file. 2018-05-20 19:27:57 +02:00
Hermès Bélusca-Maïto cb679a8917
[BOOTDATA] Set the 'BootExecute' SMSS value to an empty value as we do not want AutoChk to start when booting the LiveCD. CORE-14633
Add also a missing closing quote.
2018-05-20 18:34:35 +02:00
Hermès Bélusca-Maïto edc0aeb5a8
[SETUPAPI] Fix MSVC build; pathetic GCC/LD didn't see we were using two different prototypes for these functions. 2018-05-20 15:32:06 +02:00
Pierre Schweitzer a10f6c7a0c
[FASTFAT] Fail if allocating the stream FO fails. 2018-05-20 13:53:43 +02:00
Eric Kohl b250eb5f3e [SAMSRV] SamrChangePasswordUser: Check StoredLmEmpty and StoredNtEmpty instead of checking StoredNtEmpty twice 2018-05-20 11:53:01 +02:00
Eric Kohl d1c376f37d [SETUPAPI] Implement CM_Get_Resource_Conflict_Count and add stubs for CM_Get_Resource_Conflict_DetailsA/W 2018-05-20 11:48:39 +02:00
Pierre Schweitzer f99f48045d
[EVENTMSG] Add French translation. 2018-05-20 11:36:00 +02:00
Joachim Henze 6d5aae4865 [OLE32] Restore 4 cur files (+ note diff) to fix CORE-14608 2018-05-20 01:41:34 +02:00
Hermès Bélusca-Maïto de87a936ce
[NTOS] Demote an ASSERT to a mere DPRINT since we only support registry hives with cluster size == 1 in any case so far (other sizes are UNIMPLEMENTED!) 2018-05-19 22:07:06 +02:00
Eric Kohl cee1817e06 [SETUPAPI] Implement CM_Free_Resource_Conflict_Handle() and CM_Query_Resource_Conflict_List() 2018-05-19 18:12:28 +02:00
Katayama Hirofumi MZ 82a5983504 [SHELL32] Allow deleting a file type/extension (#553)
CORE-12906
2018-05-19 16:12:11 +02:00
Eric Kohl d7e40954d5 [SETUPAPI] Add CM_Free_Resource_Conflict_Handle and CM_Query_Resource_Conflict_List stubs 2018-05-19 15:14:30 +02:00
Pierre Schweitzer 7283f3cfd9
[FASTFAT] Addendum to d69f318 2018-05-19 13:46:34 +02:00
Eric Kohl de824808b7 [USETUP] Use _wcstoui64() instead of atoi() to convert the partition size in order to prevent unexpected misinterpretation of leading zeroes. 2018-05-19 13:33:28 +02:00
Adam Słaboń 72ad0fe70b [TRANSLATION] Polish translation update (#554)
- Added translations for cmdutils (at, clip, comp, eventcreate, mode, taskkill, wmic) and zipfldr.
- Updated translations for cmdutils (reg), drwtsn32, mmc, eventvwr, shell32 and cpl applets (console, input).
2018-05-19 13:17:49 +02:00
Eric Kohl 76eeb35148 [BOOTDATA] Add the (still disabled) faeroese keyboard layout
CORE-13127
2018-05-19 12:41:37 +02:00
Eric Kohl 8a2cc3cdda [USETUP] Improved entering of partition size
Patch by Эдуард.

CORE-13249
2018-05-19 12:09:58 +02:00
Pierre Schweitzer d69f31848e
[FASTFAT] Misc. fixes spotted by Thomas. 2018-05-19 10:07:14 +02:00
Pierre Schweitzer 7c01587680
[FASTFAT] Completely rewrite support for dirty volumes.
Until now, our support for dirty volumes was totally broken
to a point where, on FAT32 volume, the dirty couldn't even
be written nor read from the disk.

This commit totally rewrites its handling, for both FAT16 and FAT32
so that it's now fully functionnal. Furthermore, it also gets
totally compatible with our vfatlib, and thus, autochk.
Now, on mount, FastFAT will check if the volume is dirty or not, and
autochk will be able to ask for a repair if dirty. vfatlib will
repair the volume and remove the dirty bit. So that, on next
reboot, the volume will be mounted clean.

As a reminder, the dirty bit is set immediately after mounting
the volume, so that, if you crash or have a powercut, autochk
will always attempt to repair your volume (with more or less,
that's FAT!).

If you want to experience without breaking your FAT volume,
just boot, open a cmd prompt and type: fsutil dirty set c:
and reboot!

CORE-13758
CORE-13760
CORE-13759
2018-05-18 23:05:05 +02:00
Pierre Schweitzer efa75dd5b2
[FASTFAT] Allow locking system volume on boot.
This is a hack, and totally not the default behavior.
But it will allow autochk locking the boot volume in
order to verify it on boot, in case it would have
been improperly dismounted.

CORE-13759
2018-05-18 23:05:05 +02:00
Katayama Hirofumi MZ bfb19dd251 [SHELL32] Fix usage of DeferWindowPos (fix of #544) (#552) 2018-05-18 22:27:22 +02:00
Mark Jansen bb5db143f0
[DRWTSN32] Use GetCommandLineW for CommandLineToArgvW.
Spotted by Hermès
2018-05-18 18:27:36 +02:00
Pierre Schweitzer a837694518
[FASTFAT] Uninit directory cache on last handle close.
CORE-14629
CORE-14557
2018-05-18 14:51:24 +02:00
Pierre Schweitzer 3c3ebe3320
[FASTFAT] Only initialize directory cache on use.
This avoids initializing cache directly on directory
open/create.
The advantage is we reduce the load on cache manager
and on memory manager by avoiding creating everytime
a stream file object, and initializing cache for it.

This will avoid initializing cache for started
applications 'current directory' which is just opened
for having a valid handle but no read/write is performed
in it, by default.

This is a step forward for autochk.

CORE-14629
2018-05-18 14:09:30 +02:00
Katayama Hirofumi MZ f20bdf1994 [SHELL32] Add 'Create New Extension' IDD_NEWEXTENSION dialog (#544)
A 'Create New Extension' dialog is implemented, which enables the user to add a new file extension.
CORE-12906
2018-05-18 12:47:52 +02:00
Pierre Schweitzer 5d743b7bd7
[FASTFAT] When attaching our FCB to a FO, also set the VPB.
Spotted by Alex.
2018-05-18 10:30:52 +02:00
Wexpo Lyu 1d11d56d1a [TRANSLATION][DRWTSN32] Add zh-CN translation. (#549) 2018-05-17 19:57:57 +02:00