Commit graph

73879 commits

Author SHA1 Message Date
Eric Kohl d5c74ae6fe [NET] Load netmsg.dll right from the start and print some messages using netmsg.dll rather than local strings.
@Translators: Please start translating messages from netmsgmsg.mc and errorcodes.mc (located in sdk\include\reactos\mc). They will be used instead of local strings.
2018-12-23 14:18:51 +01:00
Hermès Bélusca-Maïto 2955ed91ab
[UMPNPMGR] Use HeapReAlloc() to reallocate the PnP events buffer. Fix a memory leak in DeviceInstallThread(). 2018-12-23 14:09:17 +01:00
Hermès Bélusca-Maïto 9e18da43fe
[UMPNPMGR] Minor formatting, and enable a DPRINT1 in case NtGetPlugPlayEvent() fails and the PnpEventThread() thread unexpectedly terminates due to that. 2018-12-23 14:09:16 +01:00
Pierre Schweitzer cdc419eb18
[KMTESTS:CC] Fix a typo, definitely showing this code path is not used during the test 2018-12-23 12:31:14 +01:00
Pierre Schweitzer 1a267045f8
[NTOSKRNL] Honor files that shouldn't be lazy written 2018-12-23 12:10:58 +01:00
Pierre Schweitzer 34b6a28764
[KMTESTS:CC] Add tests showing a dirty VACB isn't flushed on file growing
CORE-11819
2018-12-23 12:04:39 +01:00
Pierre Schweitzer 0917c64812
[NTOSKRNL] When growing a file, invalid the last VACB so that it can be refreshed
This will avoid corruption when a file size is little grown and read afterwards.
Up to now, FSD where reading 0es instead of expected data, causing corruption.

This fixes MS FastFAT not being able to mount a FAT volume in ReactOS, corrupting
the FAT.
This also fixes the CcSetFileSizes kmtest tests.

This is based on a patch by Thomas Faber.

CORE-11819
2018-12-23 11:19:14 +01:00
Eric Kohl 5efe6f00a9 [NETMSG] Fix message table include statement and build netmsg.dll. 2018-12-22 19:04:55 +01:00
Eric Kohl 5c6eeb5018 [MC] Remove some useless quotation marks from message strings. 2018-12-22 19:04:54 +01:00
Pierre Schweitzer 9cbd1cad0e
[FONTSUB] Fix build² 2018-12-22 15:02:16 +01:00
Pierre Schweitzer 6b4d6d40d6
[FONTSUB] Fix build 2018-12-22 14:52:02 +01:00
Pierre Schweitzer 0b5c1503c4
[KMTESTS:CC] Add a trace to identify failing tests 2018-12-22 14:36:45 +01:00
Luo Yufan eca1aa87a4 [TRANSLATION] Update Chinese shortcut translation (#1179)
* [INF] Update Traditional Chinese translation.
* [ROSAPPS] Update Chinese translation.
* [FONTSUB] Add Traditional Chinese translation.
* [FONTSUB] Add Traditional Chinese translation.
* [FONTSUB] Update Simplified Chinese translation.
* [ROSAPPS] Update Chinese translation.
* [FONTSUB] Update Simplified Chinese translation.
2018-12-22 22:35:33 +09:00
Pierre Schweitzer f7c0236fc1
[KMTESTS:CC] Add more tests for SetFileSizes
These are covered by Thomas' patch.

CORE-11819
2018-12-22 12:42:05 +01:00
Pierre Schweitzer ba5d6e977b
[KMTESTS:CC] Add tests for CcSetFileSizes
These are passing in W2K3 but failing in ReactOS.

CORE-11819
2018-12-22 12:32:02 +01:00
Thomas Faber c086edf366
[USP10] Don't mix character and glyph index caches. CORE-14226
Import Wine commits by Nikolay Sivov:
* d1e618d31da usp10: Use glyph index consistently in ScriptGetGlyphABCWidth().
* 8d018d8d1da usp10: Make sure metrics cache is used with glyph indices only.
* eda3a3e37da usp10: Remove extra parentheses.

Fixes font display in UltraISO and GOG installers.

See also https://bugs.winehq.org/show_bug.cgi?id=44410
2018-12-22 11:29:24 +01:00
Serge Gautherie 4d1f13cf77 [NTOS:CC] CcCanIWrite(): Use BYTES_TO_PAGES(Length) 2018-12-21 19:20:59 +01:00
Pierre Schweitzer 8785b10917
[IPHLPAPI_APITEST] Add tests for GetOwnerModuleFromUdpEntry 2018-12-21 19:17:11 +01:00
Pierre Schweitzer 78d703933d
[SDK] Define GetOwnerModuleFromUdpEntry() 2018-12-21 19:17:11 +01:00
Pierre Schweitzer f42a6c16f2
[IPHLPAPI_APITEST] Add tests for GetExtendedUdpTable 2018-12-21 19:17:11 +01:00
Oleg Dubinskiy 637fcbb9bc [COMDLG32] Update Ukrainian translation for NEWFILEOPENV2ORD dialog (#1175) 2018-12-21 16:49:05 +01:00
Oleg Dubinskiy 3d1e8143c2 [COMDLG32] Update Russian translation for NEWFILEOPENV2ORD dialog (#1174) 2018-12-21 16:48:36 +01:00
Pierre Schweitzer 1435ff95b4
[NTOSKRNL] Don't call AcquireForLazyWrite with the master lock held
This incorrect behavior was leading to a call at too high IRQL for paged code.
This was triggered by MS FastFAT.

ReleaseFromLazyWrite call was already correctly called to that regard.

CORE-11819
2018-12-21 08:46:40 +01:00
Serge Gautherie 85cd2849c0 [D3DCOMPILER_43] Fix a MSVC-x64 warning about dxbc_init() (#1173)
"...\utils.c(561) : warning C4028: formal parameter 2 different from declaration"

Cherry-pick:
ffe9346120
CORE-7538
2018-12-21 02:53:42 +01:00
Lee Schroeder 94e4c696e5 [THEMEUI][BOOTDATA] Add the Red, White, Blue Classic Color Scheme for Classic Theme, and Localization (#1059)
Adds the 'Red, White, and Blue' Color Scheme used by the Classic Theme and adds localization for all the color schemes into themeui.dll.

Translators, please check the language files for potential copypasta errors.
2018-12-21 00:38:45 +01:00
Hermès Bélusca-Maïto b2bad34b9b
[NTOS] Addendum to 03873aee: check that the computed size of the OEM-converted string is less than MAXUSHORT. 2018-12-21 00:34:56 +01:00
Serge Gautherie 5c77cd9050 [LOG2LINES] Partially sync output format from command line input (#1109) 2018-12-21 00:27:01 +01:00
Serge Gautherie c2083ed360 [JSCRIPT] Fix a MSVC-x64 warning about to_uint32() (#1172)
"...\jsutils.c(679) : warning C4028: formal parameter 3 different from declaration"

Cherry-pick:
961d5c8ed0
CORE-7538
2018-12-21 00:07:24 +01:00
Katayama Hirofumi MZ edc849490d [ROSAPPS][VGAFONTEDIT] Refactor on OpenInfo 2018-12-20 23:37:08 +09:00
Katayama Hirofumi MZ 0a723a2c75 [ROSAPPS][VGAFONTEDIT] Fix memory leaks 2018-12-20 23:19:01 +09:00
Luo Yufan b460183366 [TRANSLATION] Update Chinese translation. (#1170)
* [BROWSEUI] Update Traditional Chinese translation.
* [BROWSEUI] Update Simplified Chinese translation.
* [SHELL32] Update Traditional Chinese translation.
* [REGEDIT] Update Traditional Chinese translation.
* [BROWSEUI] Update Traditional Chinese translation.
2018-12-20 22:40:03 +09:00
Katayama Hirofumi MZ 56297438a5 [ROSAPPS][VGAFONTEDIT] String/Memory check 2018-12-20 22:33:59 +09:00
Jared Smudde fb8fe4a08c [DEVMGMT] Replace the blurry 32pixel icon with a clearer one. (#1169)
Device Manager's icon improvement.
2018-12-20 17:38:32 +09:00
Katayama Hirofumi MZ 6d63d76655
[USETUP][NTDLL_APITEST][KBDROST] Allow non-Latin codepage users to build ReactOS on MSVC (Retrial of #1150) (#1168)
- The converter is code7bit I made. code7bit: https://github.com/katahiromz/code7bit
- This converter converts non-clean characters in string literals.
- However I couldn't erase a ton of codepage C4819 warnings.
- CORE-15447

You can edit an European source file as follows:
- Right click the file in the Solution Explorer.
- Select "Open With...".
- Choose "C++ Source Code Editor (with encoding)".
- Choose "Central European (Windows) - Codepage 1260".
2018-12-20 17:25:32 +09:00
Pierre Schweitzer daf9743c7b
[NTOSKRNL] Check that caller has the priviliege to unload a driver
Also, probe the service name when unloading a driver if called from
user-mode. This will avoid that userland applications can trigger an
invalid read in the kernel (and thus, a BSOD).

CORE-15468
2018-12-20 08:50:51 +01:00
Hermès Bélusca-Maïto bc5acd8102
[NTOS] Minor formatting + don't hardcode sizeof(UCHAR) value. 2018-12-20 03:47:46 +01:00
Hermès Bélusca-Maïto f4597b5540
[NTOS] Addendum to d8cb37bf: return the correct Status from NtAllocateUuids(). 2018-12-20 03:47:45 +01:00
Hermès Bélusca-Maïto 03873aeef3
[NTOS] Fixes for NtDisplayString().
- Require the user to have TCB privilege for using this function.
- Probe and capture the user-provided string (and avoid usermode-triggered BSODS ;-)
- Allocate the OEM-converted string in *NonPagedPool* because we are
  going to transmit the buffer to BOOTVID.
2018-12-20 03:47:36 +01:00
Luo Yufan 25d076789a [TRANSLATION] Update Traditional Chinese translation. (#1166)
Translations for DESK, HDWWIZ, SYSDM, TIMEDATE and BROWSEUI.

If any Taiwanese contributors are present, please help improving the translations!
2018-12-20 03:25:12 +01:00
Stanislav Motylkov c1f0e89e21 [NETSHELL] Use distinct icon for connection status window (#1167)
CORE-15445
2018-12-20 00:35:22 +01:00
Pierre Schweitzer 4f8b041bf0
[NTOSKRNL] Drop the ViewLock mutex in favour of the master spin lock
This will allow Cc calls during DPC, which is required by MS FastFAT

CORE-11819
2018-12-19 22:51:45 +01:00
Eric Kohl b67dbdbea5 [NTOSKRNL] Fix indentation. No code changes. 2018-12-19 19:18:21 +01:00
Eric Kohl 7e56b21ad6 [NTOSKRNL] Fix indentation. No code changes. 2018-12-19 19:18:20 +01:00
Giannis Adamopoulos 1a8d9f12d6 [NTUSER] Implement creating the system threads
- Add UserCreateSystemThread function that will signal csrss to create a new system thread.
- NtUserCreateWindowStation: Create the raw input thread and the desktop thread when the IO window station gets created.
- IntMakeHungWindowGhosted: Create the ghost system thread that will own all ghost windows.
- Let the raw input thread manage the window station of csrss.

[USERSRV] Remove system threads creating hack
- Implement SrvCreateSystemThreads
- Don't create the system threads in UserServerDllInitialization.
2018-12-19 16:13:18 +02:00
Giannis Adamopoulos 9924da34cc [USERSRV] Add definition for the USER_CREATE_SYSTEM_THREAD api message 2018-12-19 16:13:18 +02:00
Giannis Adamopoulos 3ec7b163c9 [WINSRV] Add a hack to fix giving the api port to win32k
- Register our api port with win32k in SrvRegisterLogonProcess because UserClientConnect is never really called.

[NTUSER] Silence a noisy trace
2018-12-19 16:13:18 +02:00
Giannis Adamopoulos dad76af8a4 [NTUSER] Fix desktop and window station assignment for csrss
- NtUserSetInformationThread: Stub UserThreadUseActiveDesktop and UserThreadRestoreDesktop
- Properly mark the first thread that enters win32k belonging to csrss. At this point we assume that since gpepCSRSS isn't initialized yet, it probably is the first thread.

[WINSRV] Use NtUserSetInformationThread to set the current desktop when needed
-When csrss needs to use user32 or enter win32k, it first needs to assign the current thread to a desktop.
2018-12-19 16:13:18 +02:00
Giannis Adamopoulos 298a46acbf [NTUSER] Don't crash when the current thread doesn't have a desktop 2018-12-19 16:13:18 +02:00
Giannis Adamopoulos b2a5f5dbb3 [WINSRV] Fix setting the console title 2018-12-19 16:13:18 +02:00
Baruch Rutman 3d991ea5a7 [TRANSLATION][USETUP] Complete Hebrew translation (#1163)
- Code-page 862, Hebrew text is in visual order.
- Use escape sequences for quotation marks.
2018-12-19 13:20:18 +01:00