Mark Jansen
1d68fe209f
[SYSSETUP] Use the calculated full path
2021-06-05 22:14:34 +02:00
Joachim Henze
864e20b881
[MSI] setup should not enumerate read-only CDRoms as install-targets CORE-14432
...
We decided to check a bit different than Wine currently does.
Wine checks for
if (GetVolumeInformationW(ptr, NULL, 0, NULL, 0, &flags, NULL, 0) && flags & FILE_READ_ONLY_VOLUME)
to exclude read-only-media while we (for now) check for
if (GetDriveTypeW(ptr) == DRIVE_CDROM)
For now this gives us the benefit of covering also CDROM drives, that do not have
a CD put into it.
That does not work properly for us with the Wine patch yet, but it does for Wine!
So this maybe points to some other bug in ros, maybe in our CDROM(FS)-drivers?
In the future we should also test this on other read-only-media in Windows e.g.
a read-only USB stick to decide whether we want to stick with our current solution
or whether we want to switch to Wines solution or whether we want to logically OR
both conditions!
Thanks to Doug Lyons for providing what *currently* does work best for us!
VBox https://reactos.org/testman/compare.php?ids=77537,77546 (no change)
KVM https://reactos.org/testman/compare.php?ids=77531,77541 (no change)
2021-06-05 21:27:40 +02:00
Serge Gautherie
83fcd65700
[MPR] spec: Add stubs, document parameter types, stub-enable 2 functions ( #3696 )
...
* Add 20 stubs from mpr.dll v5.2.3790.3959.
* Document some parameter types from https://github.com/Microsoft/winfile/
* Change WNetGetDirectoryType[A|W] to no-op stubs
CORE-14376
2021-06-05 20:49:41 +02:00
Timo Kreuzer
11ffa31155
[BROWSEUI] Fix broken code
2021-06-04 09:15:55 +02:00
Piotr Hetnarowicz
4771551c74
[BROWSEUI] Polish translation update ( #3703 )
2021-06-02 11:53:07 +02:00
Piotr Hetnarowicz
d05a20e7b3
[SHELL32] Polish translation update ( #3701 )
2021-06-02 11:50:54 +02:00
Eric Kohl
7b970c67a8
[NETCFGX] Create unique network connection names
2021-05-30 21:12:58 +02:00
Mark Jansen
f0bee6c4bc
[SHELL32] CDefView: Prevent use after free
...
While updating the item, the LVIF_STATE would be requested,
for which the old lParam would be accessed.
2021-05-26 22:57:43 +02:00
Eric Kohl
894cc4ac0c
[dnsapi][dnsrslvr] Implement DnsFlushResolverCacheEntry_A/_UTF8/_W
2021-05-24 14:43:30 +02:00
Mark Jansen
9fcdc68182
[SHELL32] Include the folder path in logging
2021-05-22 16:34:54 +02:00
Mark Jansen
b58c3d73ca
[RTL][KERNEL32] Move the STUB printing code to a place where it's actually called
2021-05-22 16:33:19 +02:00
Joachim Henze
cf6c191f69
[SHELL32] *.rc Whitespace fixes just, no functional change
...
Motivation to fix them in master is to avoid having to also port them back
when porting back nearby code.
2021-05-15 03:44:48 +02:00
Catalin Gabriel Draghita
2636cff09f
[SHELL32] Show Product version on About dialog bmp ( #3621 )
...
The About dialog banner will now show the correspondent Product version selected on install.
This will make it easier to tell which edition of ReactOS is installed.
2021-05-08 15:54:32 +09:00
Mas Ahmad Muhammad
fd4d8f550c
[TRANSLATION] indonesian add and update apps/shell translation
2021-05-05 11:34:28 +02:00
Jérôme Gardou
523912536e
[KERNEL32] Sync NLS RC files with wine 6.7
...
Mostly for having them UTF-8 encoded
2021-05-03 22:00:57 +02:00
Jérôme Gardou
061c7ecb1a
[FRAMEDYN] Fix the whole situation with regards to wchar_t
...
Alias CHSTRING_WCHAR to unsigned short and use inline wrappers
to be able to use the thing with modern compilers
Put the GCC aliases into the public header.
Enable build with clang-cl
2021-05-03 22:00:57 +02:00
Serge Gautherie
249f2388bd
[REACTOS] Fix parameter types on some exports ( #3217 )
...
Fix some wrong parameter types on some exports in NTDLL, KERNEL32, WTSAPI32, and NTOSKRNL.
2021-05-01 21:11:34 +02:00
Jérôme Gardou
e470b58376
[REACTOS] Explicitly link against pseh & include pseh headers in a few places
2021-04-28 13:10:23 +02:00
Jérôme Gardou
9ef5a7eb7a
[CMAKE] Fix compilation with newer windres versions
...
Also use clang as preprocessor when using it
Also, use *our* headers instead of the platform ones
2021-04-27 11:54:12 +02:00
Hermès Bélusca-Maïto
869a914cfd
[SYSSETUP] Forgot to update the ROS banner after 2021. Addendum to b570fac1
.
2021-04-26 02:21:59 +02:00
George Bișoc
1cf1892b14
[COMCTL32] Fix an incorrect returned value for ImageList_Remove
...
Thanks goes to Kyle Katarn. Had to make a commit myself due to author's account being deleted.
Signed-off-by: Kyle Katarn <contact@kcsoftwares.com>
2021-04-24 20:13:56 +02:00
George Bișoc
84b3fecb26
[MSGINA] Determine which kind of dialog box is before terminating it
...
Do a sanity check onto the dialog box type before terminating it. As it stands now, a call of PostQuitMessage() is invoked even when the dialog box is modal. This is illegal due to the fact that the shutdown dialog box is initiated by the "Security" main window thus WlxDialogBoxParam.
A call to PostQuitMessage onto a modal dialog box leads to a undefined behaviour, as it'll not just terminate the thread but also eventually killing the Winlogon process whose the thread belongs to.
CORE-17535
2021-04-22 13:30:55 +02:00
Eric Kohl
32428a39ed
[NEWDEV] Set the CM_PROB_FAILED_INSTALL problem code on failed install
...
CORE-17527
2021-04-20 22:00:41 +02:00
Serge Gautherie
0dedb9b474
[WINLOGON][MPR][SDK] WNetClearConnections: Fix function parameter type ( #3480 )
...
Addendum to 62f79fae93
.
Signed-off-by: Serge Gautherie <reactos-git_serge_171003@gautherie.fr>
2021-04-18 21:58:44 +03:00
Hervé Poussineau
af9df93274
[WS2_32] Create registry keys Protocol_Catalog9/NameSpace_Catalog5 if needed
...
This fixes networking in LiveCD and installation in 2nd stage.
CORE-17514
2021-04-17 23:57:41 +02:00
Eric Kohl
9e947e2b2b
[DEVMGR] Get rid of the unknown device class hack
...
Treat the unknown device class like any other device class.
CORE-17527
2021-04-16 23:45:08 +02:00
Eric Kohl
3fa57b8ff7
[NEWDEV] When a device install fails, set the 'Unknown' device class for that device
...
CORE-17527
2021-04-15 21:49:32 +02:00
Serge Gautherie
1758c3831b
[MSHTML] MSVC: There is no 'error C4028' anymore
...
MSVC amd64
'...\dll\win32\mshtml\nsio.c(3755): error C4028: formal parameter 3 different from declaration'
was fixed by 5ed1867
.
CORE-7538
2021-04-14 20:55:57 +02:00
Tibor Lajos Füzi
ea04edce2d
[TRANSLATION] Add/update Hungarian translation for solitaire, spider solitaire, rapps, usetup, cpl/timedate, shell32, user32
2021-04-14 16:16:24 +02:00
Hervé Poussineau
e044df8736
[SETUPAPI] Correctly enumerate non-installed devices in SetupDiGetClassDevsExW
...
Always try to read the correct device GUID from registry, even if GUID filter is disabled.
CORE-17527
2021-04-11 15:12:02 +02:00
Hervé Poussineau
f9df7af28a
[SETUPAPI] Reimplement SetupDiBuildClassInfoListExW using CM_* functions
...
We can now enumerate device classes on other computers.
2021-04-11 15:12:02 +02:00
Hervé Poussineau
8da00cd97c
[SETUPAPI] Fix CM_Open_Class_Key_ExW, when pClassGuid is used
...
Braces around GUID were missing.
2021-04-11 15:12:02 +02:00
Chan Chilung
6b700c6af1
[TRANSLATION] Chinese Traditional (zh-TW) translation update ( #3526 )
...
*Add Chinese Traditional translation for:
- [THEMES]
- [HIVESFT]
- [HIVEDEF]
- [HIVECLS]
- [SCREENSAVERS]
- [VGAFONTEDIT]
- [KERNEL32]
- [TASKLIST]
- [MYDOCS]
- [MSXML3R]
- INFs
*Chinese Traditional translation update for:
PR 3399
- [MSGINA]
- [SHELL32]
PR 3422
- [SOLITAIRE]
Others...
*Wine translation sync
2021-04-11 10:59:19 +02:00
George Bișoc
2ae526a039
[SHELL32] Do not format the partition if it's a system drive
...
Implement a sanity check helper which determines if the partition is a system drive or not based on the %SystemDrive% environment variable, preventing the user from nuking accidentally the partition with ReactOS system files installed. :P
NOTE: This code serves as a temporary measure to prevent accidental formatting of the system drive. In the future most of this code has to be totally rewritten (and stopping syncing with WINE altogether) as well as FMIFS library code so that we're on par in terms of compatibility with Windows.
2021-04-10 17:38:23 +02:00
Eric Kohl
c2757032c8
[DEVMGR] Use FlagsEx to check for DI_FLAGSEX_POWERPAGE_ADDED
2021-04-10 16:22:47 +02:00
Eric Kohl
ab0bbeb126
[DEVMGR] UpdateDevInfo: Enable built-in property pages by default
...
CORE-17532
2021-04-10 15:50:37 +02:00
Victor Perevertkin
74ec94e12c
[CMAKE] Some options are only supported by GCC, don't use them for clang
...
These are (so far):
-Wno-format-overflow
-Wno-nonnull-compare
-Wno-old-style-declaration
-Wno-unused-but-set-variable
2021-04-09 03:58:19 +03:00
Mark Jansen
2587d72ef7
[WINSXS] Add some amd64 manifests
...
Co-authored-by: Timo Kreuzer <timo.kreuzer@reactos.org>
2021-04-08 20:48:24 +03:00
Katayama Hirofumi MZ
773ad7aebc
[BROWSEUI] auto-completion: Support large number items ( #3592 )
...
If the items are too many, enable filtering in item enumeration. CORE-9281
2021-04-08 15:02:05 +09:00
Eric Kohl
e4646bc5d1
[SETUPAPI] SetupDiInstallDevice: Do not fail if the .inf file does not have a .Services section
...
CORE-17530
2021-04-07 21:39:55 +02:00
Hervé Poussineau
4d25869e0e
[SYSSETUP] Manually start PlugPlay service, and wait for it before continuing
...
That way, class installers are already registered before installing devices.
CORE-17538
2021-04-07 19:35:50 +02:00
Katayama Hirofumi MZ
2fd058dce6
[BROWSEUI] Reduce IAutoComplete failures ( #3590 )
...
- Delete OnEditUpdate method.
- Improve the expand condition.
CORE-9281
2021-04-07 13:38:22 +09:00
Katayama Hirofumi MZ
2eaf0afcd2
[BROWSEUI] auto-completion: Reduce failures in ACListISF ( #3589 )
...
Reduce failures in ACListISF testcase. Skip left space in auto-completion. Accept the pair of drive letter and colon. CORE-9281
2021-04-06 21:56:40 +09:00
Katayama Hirofumi MZ
fefac1fb1d
[BROWSEUI] Accept environment variables in ACLO_FILESYSDIRS
...
Properly handle ACLO_FILESYSDIRS. CORE-9281
2021-04-05 22:20:01 +09:00
Katayama Hirofumi MZ
badcfb2f7d
[BROWSEUI] Accept environment variables on auto-completion
...
Expand %WINDIR%, %SystemRoot% etc. at CACListISF::Expand. CORE-9281
2021-04-05 17:20:35 +09:00
Katayama Hirofumi MZ
a5950308fd
[BROWSEUI] Follow-up of #3582
...
Also fixes VK_HOME and VK_END. CORE-9281
2021-04-05 07:43:40 +09:00
Katayama Hirofumi MZ
ab7d8f3616
[BROWSEUI][BROWSEUI_APITEST] Add CLSID_ACLHistory stubs ( #3582 )
...
- Initial implement CLSID_ACLHistory as stub.
- Add IACLHistory testcase into browseui_apitest.
CORE-9281
2021-04-05 04:20:18 +09:00
Eric Kohl
6c4b4a107b
[DEVMGR] Display hexadecimal values of Capabilities, ConfigFlags, DevnodeFlags and CsFlags
2021-04-04 11:44:38 +02:00
Serge Gautherie
28dadda8be
[CMAKE] Properly generate all Bison and Flex files at build time
...
This fully reverts 09c4d0a
.
Addendum to 5375e33
.
CORE-15991
2021-04-03 21:50:08 +03:00
Katayama Hirofumi MZ
206156fad5
[BROWSEUI] Fix auto-completion on relative paths ( #3578 )
...
Fix the CLSID_ACListISF object about relative paths. If the given path is relative at CACListISF::Expand, then convert it to a full path. CORE-9281
2021-04-03 20:38:25 +09:00