Commit graph

67509 commits

Author SHA1 Message Date
Hermès Bélusca-Maïto 17b4930a9d [NETAPI32]: Fix misusage of a pointer, that caused a crash when using the command "net localgroup". Address one of the problems described in CORE-11081.
Note that those ((ULONG_PTR)the_pointer + sizeof(type_pointed_by_the_pointer)) could be somewhat short cut into: (the_pointer + 1) (with the_pointer being of type *type_pointed_by_the_pointer). But anyway...

svn path=/trunk/; revision=73457
2016-12-15 14:45:58 +00:00
Hermès Bélusca-Maïto ea3f263fca [NET]: Correct one entry in the help list of commands.
svn path=/trunk/; revision=73456
2016-12-15 13:00:06 +00:00
Robert Naumann 399406609d [MSTSC] Decrease the size of the header font as it was cropped in some languages.
svn path=/trunk/; revision=73455
2016-12-14 21:10:35 +00:00
Mark Jansen f62aa585d6 [USRMGR] Load 32bit icons for groups tab. Patch by Jared Smudde. CORE-12547 #resolve #comment Thanks!
svn path=/trunk/; revision=73454
2016-12-14 20:33:39 +00:00
Mark Jansen 3180d93edf [APPSHIM_APITEST] Update display mode shim tests to show some difference in versions + add extra tests. CORE-11927
svn path=/trunk/; revision=73453
2016-12-14 19:19:57 +00:00
Mark Jansen 80d548b608 [REGEDIT] Make the UpdateStatusBar function actually update the statusbar, instead of sending garbage to the treeview. CORE-10803
svn path=/trunk/; revision=73452
2016-12-13 21:47:22 +00:00
James Tabor c88489858d [User32]
- Patch by Katayama Hirofumi MZ : DrawFrameControl draws bad. See CORE-12573.

svn path=/trunk/; revision=73451
2016-12-13 17:49:34 +00:00
James Tabor d41da9f33b [User32]
- Sync/Port wine UI code for drawing.

svn path=/trunk/; revision=73450
2016-12-13 17:27:37 +00:00
Pierre Schweitzer 0afae481fa [NET/USE]
On enumeration, don't print raw status

svn path=/trunk/; revision=73449
2016-12-11 10:23:02 +00:00
Pierre Schweitzer 332071647d [NET/USE]
Get rid of COUNT_OF

svn path=/trunk/; revision=73448
2016-12-11 09:15:16 +00:00
Pierre Schweitzer fb4e02aa90 [NET/USE]
Allow some strings to be translated

svn path=/trunk/; revision=73447
2016-12-11 09:01:22 +00:00
Pierre Schweitzer 270d0ba79a [NET/USE]
In case of an error, display the error message.

svn path=/trunk/; revision=73446
2016-12-10 22:12:53 +00:00
Thomas Faber 762bec692a [KMTESTS]
- Add a missing newline

svn path=/trunk/; revision=73445
2016-12-10 11:59:41 +00:00
Giannis Adamopoulos 744f1fb179 [SHELL32]
- Add a separate string for the unknown file types and rename the first column to Name from File.
- Note to translators: Please update translations based on the changes in the English strings.
Patch by Amber.
CORE-12530

svn path=/trunk/; revision=73444
2016-12-09 21:31:23 +00:00
Giannis Adamopoulos 14a6ac2ce8 [BOOT] LiveCD: Create all profile subdirectories that Shell wants. Patch by Serge Gautherie. CORE-12527
svn path=/trunk/; revision=73443
2016-12-09 20:40:52 +00:00
Giannis Adamopoulos 7e9b3d61c0 [SETUPAPI] - Add missing error checks in do_file_copyW. Patch by Carlo Bramini. CORE-12471
svn path=/trunk/; revision=73442
2016-12-09 18:39:11 +00:00
Giannis Adamopoulos 3bee65b985 [USETUP] -Fix setting the language id when compiling for a single language. CORE-10958
svn path=/trunk/; revision=73441
2016-12-09 18:30:50 +00:00
Hermès Bélusca-Maïto 74b479fa67 [USERENV]
- Use a better variable type for the 'Environment' parameter of SetUserEnvironmentVariable, AppendUserEnvironmentVariable, SetUserEnvironment, SetSystemEnvironment, so as to avoid useless casts.
- Add old-style parameter annotations for exported functions (at least);
- Add an implementation comment about setting HOMEDRIVE/HOMEPATH;
- Use ARRAYSIZE() instead of hardcoded buffer sizes;
- Don't say that GetShortPathNameW() failed when it succeeds;
- Use standard capitalization for hardcoded environment variables.

svn path=/trunk/; revision=73440
2016-12-08 16:12:59 +00:00
Hermès Bélusca-Maïto b0107a6173 [USERENV]: Code formatting
svn path=/trunk/; revision=73439
2016-12-08 16:08:59 +00:00
Giannis Adamopoulos d6e721c82f [SHELL32] - CDefView: Remove some todo comments that are done.
svn path=/trunk/; revision=73438
2016-12-07 15:43:17 +00:00
Giannis Adamopoulos af810e862f [SHELL32] - Initialize the shell icon cache only when needed or when FileIconInit is called (and not in the DllMain of shell32)
svn path=/trunk/; revision=73436
2016-12-07 00:10:43 +00:00
Hermès Bélusca-Maïto 0b5c61d493 [SERVICES]: Addendum to r73433 for ScmStartUserModeService:
- Use the correct capitalization for the desktop name (to be consistent with all the rest of our code);
- Fix DPRINT1 order of arguments;
- Reorganize a bit the code to avoid the memory leak if ImpersonateLoggedOnUser fails and the environment block was already allocated (caught by Ged Murphy).
CORE-12414

svn path=/trunk/; revision=73435
2016-12-06 23:01:27 +00:00
Mark Jansen 54e99fcd1b [SHELL32] Don't call CoInitialize in DllMain, bad things happen when calling into dll's that are being loaded! CORE-12443 #comment Please retest!
svn path=/trunk/; revision=73434
2016-12-06 21:18:17 +00:00
Eric Kohl cce01fa95c [SERVICES]
Create a new environment block when a service process is started.
Patch by Hermès BÉLUSCA - MAÏTO.
CORE-12414

svn path=/trunk/; revision=73433
2016-12-06 17:29:30 +00:00
Hermès Bélusca-Maïto c5e734fdd8 Fix for source code file header, sorry for commit noise.
svn path=/trunk/; revision=73432
2016-12-05 16:38:11 +00:00
Hermès Bélusca-Maïto aadba539ce [ADVAPI32_APITEST]: Test for a (correctly initialized) service process environment block, that should contain both ALLUSERSPROFILE and USERPROFILE environment variables.
CORE-12414

svn path=/trunk/; revision=73431
2016-12-05 16:36:06 +00:00
Hermès Bélusca-Maïto 8e18f1fbd9 [ADVAPI32_APITEST]: Add a small helper lib 'svchlp' for common routines for test-services embedded in api tests. Taken & heavily adapted from Jacek Caban's services_service test and Thomas Faber's ServiceArgs.c (the latter will be able to use 'svchlp' when it'll be ready).
CORE-12414

svn path=/trunk/; revision=73430
2016-12-05 16:22:30 +00:00
Sylvain Petreolle ab777da1ae [BROWSEUI]
Fix CShellBrowser window class name,
shown by shell32:progman_dde and AHK_Diablo_1.0:1.install

svn path=/trunk/; revision=73429
2016-12-04 23:33:19 +00:00
Hermès Bélusca-Maïto 2299a44489 [NTDLL]: Export _wcstoui64 (as done in Win2k3). Prototype from msvcrt. CORE-12534
svn path=/trunk/; revision=73428
2016-12-04 22:52:03 +00:00
Hermès Bélusca-Maïto b193d7bdfb [NTDLL]: Add proper stubs for EtwpGetTraceBuffer and EtwpSetHWConfigFunction, needed for CORE-12534.
[NTDLL][ADVAPI32]: Improve the prototypes for EtwReceiveNotificationsA/WmiReceiveNotificationsA and EtwReceiveNotificationsW/WmiReceiveNotificationsW.

svn path=/trunk/; revision=73427
2016-12-04 22:44:37 +00:00
Hermès Bélusca-Maïto 23e508dc18 [ADVAPI32_APITEST]: Rename the 'LockDatabase' test to 'LockServiceDatabase' to better match the name of the API.
svn path=/trunk/; revision=73426
2016-12-04 18:41:46 +00:00
Hermès Bélusca-Maïto 8cd23c3dc0 [USERENV]: Use ARRAYSIZE instead of hardcoding the sizes of the static buffers.
svn path=/trunk/; revision=73425
2016-12-04 18:28:33 +00:00
Mark Jansen a55106da83 [DESK] Fix theme preview for Win7. Patch by Carlo Bramini. CORE-10076 #resolve #comment Thanks!
svn path=/trunk/; revision=73424
2016-12-04 16:52:22 +00:00
Eric Kohl 46bbe29d9e [INCLUDE]
Add  CreateUserProfileExA and  CreateUserProfileExW prototypes to userenv.h.

svn path=/trunk/; revision=73423
2016-12-04 15:56:44 +00:00
Mark Jansen f0d4850705 [APPSHIM_APITEST] Add tests for the DisableThemes shim. CORE-11927
svn path=/trunk/; revision=73422
2016-12-04 15:33:28 +00:00
Mark Jansen d39ff22033 [APPSHIM_APITEST] Add tests for display mode shims. CORE-11927
svn path=/trunk/; revision=73421
2016-12-03 21:24:47 +00:00
Eric Kohl 16093a084c [SERVICES]
- Code cleanup.
- ScmCreateOrReferenceServiceImage() and ScmDereferenceServiceImage(): Close the logon token and service process handles properly.
- ScmStartUserModeService(): Store the service process handle in the SERVICE_IMAGE struct.
Patch by Hermès BÉLUSCA - MAÏTO.

svn path=/trunk/; revision=73420
2016-12-03 14:33:07 +00:00
Eric Kohl 3e44ec76e4 [SERVICES]
Tiny fixes.
One fix found by Serge Gautherie.

svn path=/trunk/; revision=73419
2016-12-03 13:54:11 +00:00
Eric Kohl 3ee27dbe81 [SERVICES]
Add more parameter checks to RChangeServiceConfigW().

svn path=/trunk/; revision=73418
2016-12-03 12:55:29 +00:00
Eric Kohl ae1c49c382 [SERVICES]
Implement large parts of RI_ScGetCurrentGroupStateW.

svn path=/trunk/; revision=73417
2016-12-03 12:48:44 +00:00
Eric Kohl 974f97cce5 [SERVICES]
- Get rid of the obsolete USE_SERVICE_START_PENDING option.
- Services do not accept any command when they are in SERVICE_START_PENDING state.
Patch by Hermès BÉLUSCA - MAÏTO.

svn path=/trunk/; revision=73416
2016-12-03 09:33:03 +00:00
Robert Naumann 3d7ae255a1 [TIMEDATE] Update/Fix German and French resource files. Patch by Joachim Henze and Kyle Katarn. CORE-12369
svn path=/trunk/; revision=73415
2016-12-02 22:36:21 +00:00
Robert Naumann 327d464e0c [RAPPS][USERINIT][HIVECLS] Add/Update Italian translation. Patches by Carlo Bramini. Thanks. CORE-9725 #comment rapps_new and usrmgr were not appliable, please check your patches. The others were committed in r73414
svn path=/trunk/; revision=73414
2016-12-02 22:22:28 +00:00
Hermès Bélusca-Maïto 0d21c76ef1 [ROSTESTS]: advapi32_apitest: Add a test to extensively test services command-line arguments. By Thomas Faber.
[ADVAPI32]: Correctly set up both the ANSI and UNICODE service command-line arguments. Adapted from a patch by Thomas Faber. Thanks!

[SERVICES]
- Correctly pack the service command-line arguments in the control packet structure. In particular, the offsets stored in the vector are relative to the beginning of the vector (and not relative to the previous offset ^^). Improve comments...
- Fix the definition of the SCM_CONTROL_PACKET control packet structure to make it Win2k3-compatible, so that we can use Win2k3' advapi32.dll or services.exe on ReactOS and vice-versa.

CORE-9235 CORE-9838

svn path=/trunk/; revision=73413
2016-12-02 20:01:29 +00:00
Robert Naumann b687b6775f [NETSHELL]Add Japanese translation. Patch by Katayama Hirofumi MZ. Thanks. CORE-12514
svn path=/trunk/; revision=73412
2016-12-01 21:09:47 +00:00
Robert Naumann e5d67ba90e [RUNONCE] Add Italian translation. Patch by Carlo Bramini. Thanks. CORE-12488
svn path=/trunk/; revision=73411
2016-12-01 21:06:38 +00:00
Mark Jansen 7b0c55ea0c This does not belong here.
svn path=/trunk/; revision=73410
2016-11-30 20:39:06 +00:00
Mark Jansen 0744770ebe [NETSHELL] Implement NcIsValidConnectionName + tests. Patch by Jared Smudde, modified by me. CORE-11320 #resolve
svn path=/trunk/; revision=73409
2016-11-30 20:31:50 +00:00
Giannis Adamopoulos f9e5da10de Fix build.
svn path=/trunk/; revision=73408
2016-11-29 18:01:35 +00:00
Giannis Adamopoulos 4c9e684463 [SHELL32] - CDefViewBckgrndMenu: Shell_MergeMenus doesn't handle items added by shell extensions correctly so let the folder IContextMenu add its items directly in the menu. CORE-12508
svn path=/trunk/; revision=73407
2016-11-29 17:56:04 +00:00