Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-02-24 09:25:10 +00:00
Code Issues Projects Releases Packages Wiki Activity

[SERVICES]

Browse source 
Add more parameter checks to RChangeServiceConfigW().

svn path=/trunk/; revision=73418
This commit is contained in:
Eric Kohl 2016-12-03 12:55:29 +00:00
parent ae1c49c382
commit 3ee27dbe81
1 changed files with 34 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
reactos/base/system/services/rpcserver.c
View file

@ -1846,6 +1846,40 @@ DWORD RChangeServiceConfigW(
return ERROR_ACCESS_DENIED;
}
/* Check for invalid service type value */
if ((dwServiceType != SERVICE_NO_CHANGE) &&
(dwServiceType != SERVICE_KERNEL_DRIVER) &&
(dwServiceType != SERVICE_FILE_SYSTEM_DRIVER) &&
((dwServiceType & ~SERVICE_INTERACTIVE_PROCESS) != SERVICE_WIN32_OWN_PROCESS) &&
((dwServiceType & ~SERVICE_INTERACTIVE_PROCESS) != SERVICE_WIN32_SHARE_PROCESS))
return ERROR_INVALID_PARAMETER;
/* Check for invalid start type value */
if ((dwStartType != SERVICE_NO_CHANGE) &&
(dwStartType != SERVICE_BOOT_START) &&
(dwStartType != SERVICE_SYSTEM_START) &&
(dwStartType != SERVICE_AUTO_START) &&
(dwStartType != SERVICE_DEMAND_START) &&
(dwStartType != SERVICE_DISABLED))
return ERROR_INVALID_PARAMETER;
/* Only drivers can be boot start or system start services */
if ((dwStartType == SERVICE_BOOT_START) ||
(dwStartType == SERVICE_SYSTEM_START))
{
if ((dwServiceType != SERVICE_KERNEL_DRIVER) &&
(dwServiceType != SERVICE_FILE_SYSTEM_DRIVER))
return ERROR_INVALID_PARAMETER;
}
/* Check for invalid error control value */
if ((dwErrorControl != SERVICE_NO_CHANGE) &&
(dwErrorControl != SERVICE_ERROR_IGNORE) &&
(dwErrorControl != SERVICE_ERROR_NORMAL) &&
(dwErrorControl != SERVICE_ERROR_SEVERE) &&
(dwErrorControl != SERVICE_ERROR_CRITICAL))
return ERROR_INVALID_PARAMETER;
lpService = hSvc->ServiceEntry;
if (lpService == NULL)
{