Commit graph

77567 commits

Author SHA1 Message Date
Joachim Henze 0d1186afa3 [0.4.14][NETSHELL] Repair "Network Connection 'State' does nothing" CORE-18844
It regressed in this branch by 0.4.14-release-48-g e5c9a50c57
 ( in master it was by 0.4.15-dev-5613-g 7a17c7d9ad )

It was the only place within the ros sources where message WM_SHOWSTATUSDLG
was sent also from code. And therefore the only one that needed to be updated as well.

Fix picked from:
0.4.15-dev-5712-g a5cd42c1ea
2023-02-19 22:51:43 +01:00
Joachim Henze 05fccd02ce [0.4.14][SHELL32] Ignore unused flag SEE_MASK_UNICODE (#5033) & de-DE update
by porting back:

0.4.15-dev-5676-g 5c22ce3742 [SHELL32] Ignore unused flag SEE_MASK_UNICODE (#5033)
to mute logspam of the kind
fixme:(dll/win32/shell32/shlexec.cpp:1934) flags ignored: 0x00004000
e.g. when starting Rapps.
---------------
0.4.15-dev-2957-g c30b1fe893 de-DE.rc Update regarding IDC_BROWSE_FOR_FOLDER_NEW_FOLDER,
and pick other small tweaks in that file from master
---------------
Then delete an unused #ifndef __REACTOS__ block within brsfolder.c and strip all EOL-whitespace in that file.
This part is done as the file is part of a backport into even older branches. It is a partial pick of:
0.4.15-dev-3642-g 83be315abf
brsfolder.c will be 100% in sync between releases/0.4.7 - releases/0.4.14 afterwards.
2023-02-14 20:43:07 +01:00
Joachim Henze 1e4c5509f5 [0.4.14][SHELL32] Improve StartButton context menu (#5008) CORE-16544
It regressed by the introduction of the SendTo-menu in:
0.4.14-dev-238-g 5308a606dc
Since then we had some unintended verbs in the start buttons context menu.

Fix that by *partially* porting back:
0.4.15-dev-5611-g 8e036fe74d [SHELL32] Improve StartButton context menu (#5008)
0.4.15-dev-5614-g f156f9a137 [SHELL32] Follow-up

I picked only the parts that I needed to hide the CSendToMenu, because the older branches do not
have the CCopyToMenu, CMoveToMenu. And I do not intend to ever add the new source files implementing them.
2023-02-10 01:33:12 +01:00
Joachim Henze 38dd7d8094 [0.4.14][GDI32][BUTTERFLIES] Fix a BSOD caused by memory leak CORE-18498
The symptom was unhidden by (regression from users perspective):
0.4.12-dev-389-g 5f2bebf7a5

by porting back:
0.4.15-dev-5608-g afb953ae4d [BUTTERFLIES] Do not release the DC passed to OpenGL. CORE-18498
0.4.15-dev-5607-g 8b19b6ec5a [GDI32] Fix memory leak in case of public DC. CORE-18498

For now I will not port it back further than releases/0.4.12
although the code in both modules might be suboptimal even in earlier release-branches.
But we see no symptoms in those yet.
2023-02-09 16:33:06 +01:00
Joachim Henze c616bd2d91 [0.4.14][SYSSETUP] Fix *.rc combobox for the timezone is too small CORE-18587
by porting back:
0.4.15-dev-5542-g f9dfc45375
and pick a few places where translators decided to shorten their strings
2023-02-04 13:51:22 +01:00
Joachim Henze e5c9a50c57 [0.4.14][NETSHELL] Lan Status Dlg should show on LBUTTONUP in systray,
not on LBUTTONDOWN

by porting back:
0.4.15-dev-5613-g 7a17c7d9ad CORE-18813 LBUTTONUP
and strip EOL whitespace
2023-02-02 12:17:40 +01:00
Joachim Henze 497261a758 [0.4.14][NTGDI] Check if face->charmap is not zero before accessing its encoding (#4390)
Prevents a BSOD 0x1E upon dereference.
CORE-18091 CORE-18558

By partially porting back:
0.4.15-dev-5587-ga999c43 a999c43746
and take also some cosmetic changes from master head, like EOL-whitespace-removal.
2023-01-21 11:06:56 +01:00
Joachim Henze 69eb10692a [0.4.14][SHELL32] Improve Right-click copy/move/link menu
by porting back:
0.4.15-dev-5588-g e89675768b [SHELL32] Add 3 accelerators for IDM_DRAGFILE MENU de-DE.rc (#5001)
pick a single line only of 0.4.15-dev-984-g a5a30fc249 [SHELL32] CFSDropTarget.cpp ERR->TRACE to mute logspam

and strip some EOL-whitespaces in 3 related source-files thats contents I will port back into even older branches, like it was done in master.
2023-01-18 22:50:12 +01:00
Joachim Henze f56cc2310c [0.4.14][NTUSER][USER32] Scrollbar improvements
by porting back 2 fixes:

0.4.15-dev-5355-g 0484beb04b [NTUSER] Don't redraw scrollbar if it is hidden (#4849) CORE-18593
0.4.15-dev-3875-g 977c129f33 [USER32] SetScrollPos should not bypass UserApiHook (#4372) CORE-18048

Both regressions were caused/unhidden by 0.4.14-dev-1134-g 00adb1a3f9
2023-01-11 05:55:43 +01:00
Joachim Henze fe85357afe [0.4.14][SETUP][BOOTDATA][FONTS][INF][MEDIA][ROSTESTS] Monospaced fonts and substitution
Switches from "FreeMono" and "Dejavu Sans Mono" to "Courier New" and "Lucida Console"
and therefore brings us closer to 2k3sp2 stock fonts. Saves some RAM also.
Deletes some "Ubuntu" font left-overs in some Themes.

CORE-18605 (and partially CORE-16264)

By porting back the following commits:
0.4.15-dev-5362-g c47758b102 [SETUP][INF][MEDIA] Get rid of the last Ubuntu references CORE-18607 (#4871)
0.4.15-dev-5336-g bd40c13f6f [SETUP][BOOTDATA][FONTS][INF] Delete DejaVu Sans Mono and re-map (#4856)
0.4.15-dev-5335-g a4193ade03 [SETUP][FONTS][INF][GDI32_APITEST] Delete FreeMono and re-map (#4852)
0.4.15-dev-5324-g d035452148 [SETUP][INF][ROSTESTS] Delete font substitutions and tests for "DejaVu Sans" (#4829)
2023-01-06 09:38:59 +01:00
Joachim Henze 5dfa141eb6 [0.4.14][CMAKE] Update baseaddress_msvc.cmake
by hand!

Motivation is to fix the following warnings at configure-time for *MSVC x86 dbg* :
-- umandlg has no base address
-- hotplug has no base address
-- qcap has no base address
-- mydocs has no base address
-- fusion has no base address
-- fusion_1_1 has no base address
-- fusion_2_0 has no base address
-- storprop has no base address
-- localspl_apitest.dll has no base address

This fixes CORE-14831 for *MSVC dbg* for this release-branch at least.
Meaning: It hides the effect, without fixing the cause.
It is not a sustainable solution for master yet.
We'd need to improve the python script for that.

I tested afterwards the bootup of a build configured via:
-DENABLE_ROSTESTS=1 -DENABLE_ROSAPPS=1
and built with:
MSVC 2010SP1 (16.0.40219.1) x86 target in dbg configuration
and verified that we had no relocation happening until 3rd stage desktop VBox4.3.12.

MSVC 2010SP1 (16.0.40219.1) x86 target in *rls* configuration was not
tested yet, as that up to now did never reach the desktop yet for unrelated reasons.

I will not upload an iso to sourceforge after this commit,
because it will not have any impact for our primary GCC 4.7.2 toolchain.
2022-12-29 18:41:55 +01:00
Joachim Henze e1dd4e3e15 [0.4.14][NTUSER] Fix zombie window created by CTRL+ALT+DEL (#4935) CORE-18258
Based on patch by I_Kill_Bugs.
Fixes the regression which was introduced to master by 0.4.15-dev-1126-g 58b0558f94

fix picked from 0.4.15-dev-5532-g ca9ded7af8
2022-12-26 01:43:35 +01:00
Joachim Henze 875b9e7c4f [0.4.14][NTUSER][USER32][OSK] Initial support of WS_EX_NOACTIVATE flag (#4731)
WS_EX_NOACTIVATE flag forbids the window to be activated
fix picked from 0.4.15-dev-5137-g 826bd41d88 (1 of 3 commits for CORE-18417)
My reason for picking it is that it fixes CORE-13257 'Reboot leaving Evernote 5.9.8 in tray causes WIN32K BSOD 0x50'
I also had to pick together with it the
0.4.15-dev-5491-g 1fbed1710e to prevent it from introducing (+2 failures in user32:msg_focus) unittests.
----------------
The above patch allows/encourages us to pick then also:
0.4.15-dev-5492-g 47f3a4e144 [OSK] Delete WS_EX_NOACTIVATE workaround code
(which referenced CORE-18528, but is not fixing this minor GUI glitch yet, it just removes workaround-code that is no longer needed,
I just mention the ticket here, because the commit on master did that as well)
----------------
----------------
The following 2 things were small *unrelated* improvements nearby, and I decided to take them with me:
0.4.15-dev-4323-g 9f5cde9cbe [WIN32K:NTUSER] window.c Remove broken assert in NtUserCreateWindowEx. CORE-18123 fixed
and
a tiny part of 0.4.15-dev-3476-g 55a1c29341 [WIN32K] appswitch.c: delete unused func DWORD wtodw(const WCHAR *psz)
2022-12-24 02:05:12 +01:00
Joachim Henze 1be3db2baa [0.4.14][KEYBOARD] Fix problems in our keyboard layouts
- This fixes problems with "F17" or "F14" shortcut key in the menu items of some programs,
  e.g. SQLiteAdmin 0.8.3.2

CORE-17906 CORE-3903

fix picked from 0.4.15-dev-5145-g cdf907074d
--------------
[KEYBOARD] Switch to QWERTZ for Croatian keyboard layout (#4177)
fix picked from 0.4.15-dev-3503-g 2196a06fc1
--------------
Also ported back some EOL whitespace trimming
2022-12-21 18:12:36 +01:00
Joachim Henze 4e0ec3f03c [0.4.14][SYSSETUP] Trivial rc update
picked from 0.4.15-dev-5519-g e8e38b8301
picked from 0.4.15-dev-2937-g 1078340f5c
and ported back some trivial changes in some other languages as well.
2022-12-21 03:51:37 +01:00
Joachim Henze 863bbeee99 [0.4.14][INF] Backport String deduplication and minor fixes
Fixes a bug in msmouse.inf missing " at begin of last string in section [Strings.0416].
partial pick of 0.4.15-dev-1105-g d50cbb6eed (only the changes in msmouse.inf were picked) (#3173)
------------
Fixes a bug in nete1000.inf missing " at the end of a string in section [Strings.0415] (which affected releases/0.4.12 to releases/0.4.14).
------------
partial pick of 0.4.15-dev-4867-g bbccad0ed6 Deduplicate the "ReactOS =" strings,
they are non-localizable now CORE-18191. I intentionally left out the "ReactOS team"->"ReactOS project" part here.
------------
full pick of 0.4.15-dev-309-g 7c8d5635aa [PROCESSR][INF] Fix "Intel Intel" duplication typos
which was an addendum to 3509318521 == SVN r46465
------------
also ported back deduplication of some manufacturer strings.
------------
all changes to shortcuts.inf and syssetup.inf.tpl are exclusively stripping EOL-whitespace, no other changes in those files.
------------
the only part that was not picked from master is the stripped 's' in disk.inf, which is possible,
because the file has been replaced altogether in master by an MS file.
2022-12-18 15:08:10 +01:00
Joachim Henze ca0223e31d [0.4.14][DESK] Fix handle leaks in screensaver preview and other small fixes
- Fix leaking two handles to avoid creating zombie processes when closing the
screensaver preview

fix is *partial* pick of 0.4.15-dev-5495-g 71123b72fa which *partially* fixes CORE-18680 (#4921)
The other part of that fix is not safe, neither on master, nor when porting back due to yet unfixed Win32K bugs.
-------------------------
*partial* pick of 0.4.15-dev-3154-g 158a479a4e "\r\n"->"\n" in desk.cpl
-------------------------
furthermore port back some EOL-whitespace cleanup and some minor translation improvements
-------------------------
also *partial* pick of 0.4.15-dev-5521-g 5ecb9e8cb5 (#4943)
only the parts that are relevant for older releases
2022-12-16 20:51:18 +01:00
Joachim Henze 90505bc2e5 [0.4.14][NTUSER] Fix Toolbar re-painting when Rebar parent has been altered (#4380) CORE-12342
Fixes:
CORE-12342 '7zip is not drawing some of its controls until forcing a repaint'
CORE-8734 '[WIN32SS] dxdiag exposes a tabsheet redraw problem'
...
and many other duplicates in JIRA.

If a Rebar window is altered by calling either ShowWindow() or UpdateWindow()
then we were only updating the parent and omitting their children windows.

This is closer to the behavior of the very very old SVN r27394 == git f1a7f30887 .
And therefore intentionally excludes parts of SVN r27403 == git e2651a0dbc .

The bots have no complaints about it:
KVM https://reactos.org/testman/compare.php?ids=81266,81290
VBox https://reactos.org/testman/compare.php?ids=81267,81291

fix picked from 0.4.15-dev-3885-g ea7c14919e
2022-12-07 02:09:58 +01:00
Joachim Henze 9ffb1e5c21 [0.4.14][RPCRT4] Sync msvc.S with WINE's inline assembly,
as suggested by Thomas

It fixes
CORE-18505 '[MSVC only] VBox 2.0.0 is not able to open, but on GCC it can'

It regressed by:
0.4.12-dev-555-g b6fdb56b9a and
0.4.12-dev-544-g 5db885cae7

Fix picked from 0.4.15-dev-5461-g 062a8f20a9

The fix works also for MSVC2010SP1 dbg builds in the older branches.
I will not create a new GCC iso for that revision, because this commit does not
affect GCC at all.
2022-12-02 23:49:40 +01:00
Joachim Henze 72cd84dd02 [0.4.14][COMCTL32] Remove a rosdiff TOOLBAR_EraseBackground() (#4887)
This fixes the toolbar in FileZilla 3.8 being drawn wrong (grey)
It regressed by 0.4.14-RC-61-g 1d8e74d4aa ( == 0.4.15-dev-1603-g 232c45fcd7 on master)
No release branches older than releases/0.4.14 were ever affected.

And todays fix is a partial revert of that guilty rev.
The reverted part is not even necessarily needed for what we had in mind back then,
It was just a first tiny step with the aim to get rid of the comctl32.h changes of that commit.
But that goal was and even is far out of reach for many other reasons also.
Actually we should have reverted the toolbar.c change back then already,
before committing the "flipfix9".

CORE-18263

Fix picked from 0.4.15-dev-5396-g 9c5bb096bc
2022-11-22 15:41:54 +01:00
Joachim Henze a08cada31a [0.4.14][DEVMGR] Fix wrong menu item hint (#4854) CORE-18608
Item hint for "Resources by connection" was incorrectly set to the hint for "Resources by type".

fix picked from 0.4.15-dev-5334-g 075ec50298
and also port back stripping of some EOL-whitespace
2022-11-16 13:28:27 +01:00
Joachim Henze 385763882b [0.4.14][WDMAUD.DRV] Strip EOL whitespace in mmixer.c
Addendum to 0.4.14-RC-98-g c437ff6128
because I do intend to port the changed code back further
and don't want to poison the older branches with the malformatting.
2022-11-14 18:14:04 +01:00
Joachim Henze 984e256c2c [0.4.14][SETUP][INF] Delete obsolete font substitutions "DejaVu Serif" (#4827)
This is some cleanup addendum to 0.4.14-dev-20-g 2f4fb903b4

The commit is not super important for releases/0.4.14 but makes sense to port back for the sake
of sync, because it is inherent part of a much bigger backport for the older releases.

fix picked from 0.4.15-dev-5287-g 4615c824db

I will backport later more of similar left-over-removals but I will wait with that
until releases/0.4.15 will have been tested thoroughly and released.
2022-11-06 02:26:32 +01:00
Joachim Henze 527c858bce [0.4.14][DDRAW] Handle DDLOCK_WRITEONLY in wined3dmapflags_from_ddrawmapflags() CORE-18378 (#4713)
Mutes the logging:
fixme:(dll/directx/wine/ddraw/utils.c:584) Unhandled flags 0x20.
gets logged many times per second.

It does affect several applications, e.g. the game 'Anno 1602' from 1998, and the 'Diablo 2 demo' from rapps,
For both games it can be observed with both: our VBEMP driver and the VBox4.3.12 3D-accelerated-driver.

Muting may improve performance a bit in such apps.
It gets logged although no missing features can be perceived visually in the rendering.

The regression was introduced to master by 0.4.9-dev-155-g 9987f02917

Fix it by importing Wine-commit
b943c7910b
 ddraw: Handle DDLOCK_WRITEONLY in wined3dmapflags_from_ddrawmapflags().
 Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com>
 Signed-off-by: Alexandre Julliard <julliard@winehq.org>

fix picked from 0.4.15-dev-5070-g 305aae75f5
2022-10-27 00:02:26 +02:00
Joachim Henze 8a2dc46439 [0.4.14][BCRYPT] Add ECDSA P384 to known algorithms (#4236)
Today 2022-10-25 was the day, when I spotted the first URL in rapps that is not longer happy with just having
ECDSA_P256 but now needs even ECDSA_P384 to make the rapps download succeed. *eye-rolling*
It was https://bitbucket.org/Swyter/tld-downloads/downloads/diabloiidemo.exe
that failed the rapps download with

fixme:(dll/win32/bcrypt/bcrypt_main.c:359) algorithm L"ECDSA_P384" not supported
err:(win32ss/user/user32/windows/messagebox.c:1048) MessageBox: L"Paket konnte nicht geladen werden! Pr\00fcfen Sie Ihre Internetverbindung!"

So I have no choice but to follow the totally stupid crypto-rat-race and
add the missing structs and handlers in BCryptOpenAlgorithmProvider().

When will the world ever learn that the new cryptos do outdate faster than the new shit even can be implemented in time everywhere?
Each additional crypto algorithm effectively enlarges the attack surface of the end-points instead of making stuff more secure.
The world is rushing towards totally breaking backward compatibility to older systems. This is built-in obsolescence. For which gain?
This race can never be won. Each crypto-iteration just intensifies the existing chaos. Enough ranting...

fix picked from 0.4.15-dev-3662-g c3e0df0611

It is a cherry-pick a part of Michael Müller's commit from Wine
76b6c360fa

The commit doesn't fix CORE-14198 at all, same like on master, but since the original commit was linked
to that JIRA ticket as well, I decided to do the same with the backport.
2022-10-25 02:16:00 +02:00
Joachim Henze a32cda85be [0.4.14][REACTOS] Remove references to ReactOS Foundation (#4557)
See https://reactos.org/wiki/ReactOS_Foundation for more information.

the first part of CORE-18191

picked from 0.4.15-dev-4866-g 6881d8c624

Respect:
-Colins wish to leave out for now all the matches in kbdtool for legal uncertainty
-boot_images.cmake on master vs. boot/CMakeLists.txt in older branches
-treating cpu.inf special in this first commit for the sake of keeping sync to all other infs
-unlike master I decided to groom also cdmake, because I don't see any reason yet to dump that
 in the older branches
-all releases down to releases/0.4.7 were released for the first time after the "ReactOS foundation"
 dissolved already in 2015. So all are definitely fine to receive this commit.
-port back some EOL whitespace fixes as well in common.ver to sync the file to 100% to master head
2022-10-24 00:20:38 +02:00
Joachim Henze ffd100bfc9 [0.4.14][SHELL32] Delete old unused implementation of OLD_SHAppBarMessage() (#4800)
SHAppBarMessage() was reimplemented at a different place by
0.4.14-dev-1209-g 10d1afea18
That was a reimport from Wine.

Fix picked from 0.4.15-dev-5242-g e6fb0e0c25
2022-10-22 22:15:32 +02:00
Joachim Henze 744068d494 [0.4.14][NTFS] PrintAllVCNs(): Fix a typo in an ASSERT() (#4682), EOL-WS
First part with the typo in the assert was introduced by 5579428b4f
which was merged into ros by a merge-task during 0.4.8-dev'ing.
releases/0.4.7 didn't have that code yet.
fix picked from 0.4.15-dev-5035-g f308c6a2bc
----------
[NTFS] Do not print debug message for every function call by default
That 2nd part was picked from 0.4.13-dev-450-g 1552434940
This part is not relevant for the backport to releases/0.4.13 and 0.4.14, because it is
already inside them.
----------
And for all the files that I had to touch for the 2nd part in the older branches,
I ported back also some EOL-whitespace-fixes within like they were done during 0.4.15-dev'ing.
2022-10-16 23:24:49 +02:00
Joachim Henze 69b9233ee2 [0.4.14][NTOS:MM] Copy the WorkingSet page when initializing "hand-built" process CORE-16737
(and part of the duplicated ticket CORE-17642 which covers a bit more changes in master)

fix picked from 0.4.15-dev-3018-g 34662e2f6f
2022-10-13 03:28:16 +02:00
Joachim Henze 57efac32b1 [0.4.14][DBGHELP] Non-functional whitespace addendum in context of CORE-17073
I did not want to port back the fix further in unpolished form. (1st diff)
And found the whitespace to be offsync to older branches. (2nd diff)
2022-10-08 23:08:04 +02:00
Joachim Henze c1b15dbc86 [0.4.14][CMAKE] Update GCC dbg baseaddress.cmake
by hand!

Motivation is to fix the following warnings at configure-time for *GCC dbg* :
-- umandlg has no base address
-- hotplug has no base address
-- qcap has no base address
-- mydocs has no base address
-- fusion has no base address
-- fusion_1_1 has no base address
-- fusion_2_0 has no base address
-- storprop has no base address
-- localspl_apitest.dll has no base address

This fixes CORE-14831 for *GCC dbg* at least for this branch.
Meaning: It hides the effect, without fixing the cause.
It is neither a sufficient fix for other toolchains/configs,
nor a sustainable solution for master yet.
We'd need to improve the python script for that.
2022-10-02 03:39:35 +02:00
Joachim Henze c75b5da08a [0.4.14][DNSAPI] DNSRSLVR_HANDLE_bind(): Demote 1 DPRINT1() (#4733) CORE-18384
Addendum to 0.4.14-dev-174-g b79246c534

Fix picked from 0.4.15-dev-5116-g f0e13157c6
2022-09-29 19:11:39 +02:00
Joachim Henze 1302c1bc66 [0.4.14][SHELL32] Copy without FILE_ATTRIBUTE_READONLY from a CDROM CORE-18089 (#4386)
That problem in the shell was unhidden when we switched from our own to the MS-PL CDFS-driver
in 0.4.8-dev-164-g ec6b3ecbe4
because our own old CDFS driver erroneously never reported any CD file being read-only.

Fix picked from 0.4.15-dev-4348-g 513d0a6d2d

While backporting the fix, I decided to port back also some EOL-whitespace-stripping in that file.
2022-09-22 16:52:48 +02:00
Joachim Henze e289e869e0 [0.4.14][WINHTTP] Fix 1 MSVC2010SP1 x86 dbg warning LNK4199 (#4414) CORE-18104
which I could observe all the way from releases/0.4.7 up to releases/0.4.14
with MSVC 2010SP1 (16.0.40219.1) x86 target in dbg configuration

Creating library dll\win32\winhttp\winhttp.lib and object dll\win32\winhttp\winhttp.exp
LINK : warning LNK4199: /DELAYLOAD:ole32.dll ignored; no imports found from ole32.dll

Fix picked from 0.4.15-dev-4326-g 2f7dc168f2

And just for the record: Wine did the same with their:
f400f25c25
2022-09-19 02:38:53 +02:00
Joachim Henze a575acbea8 [0.4.14][CYLFRAC] Fix 3 MSVC2010SP1 x86 dbg warnings C4305 CORE-18104
can be observed with MSVC 2010SP1 (16.0.40219.1) x86 target in dbg configuration:
C:\047rls\reactos\modules\rosapps\applications\screensavers\cylfrac\cylfrac.c(109) : warning C4305: 'function' : truncation from 'double' to 'float'
C:\047rls\reactos\modules\rosapps\applications\screensavers\cylfrac\cylfrac.c(110) : warning C4305: 'function' : truncation from 'double' to 'float'
C:\047rls\reactos\modules\rosapps\applications\screensavers\cylfrac\cylfrac.c(137) : warning C4305: 'initializing' : truncation from 'double' to 'GLfloat'

partial pick of 0.4.15-dev-2951-g 5d8e834897
2022-03-31 06:12:11 +02:00
Joachim Henze a1b561e477 [0.4.14][ROSHTTPD] Fix 3 MSVC2010SP1 x86 dbg warnings C4373 CORE-18104
can be observed with MSVC 2010SP1 (16.0.40219.1) x86 target in dbg configuation:
[11438/11751] Building CXX object modules\rosapps\applications\net\roshttpd\CMakeFiles\roshttpd.dir\config.cpp.obj
C:\047rls\reactos\modules\rosapps\applications\net\roshttpd\include\httpd.h(70) : warning C4373: 'CHttpDaemon::OnAccept': virtual function overrides 'CServerSocket::OnAccept', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
        C:\047rls\reactos\modules\rosapps\applications\net\roshttpd\include\socket.h(132) : see declaration of 'CServerSocket::OnAccept'
[11441/11751] Building CXX object modules\rosapps\applications\net\roshttpd\CMakeFiles\roshttpd.dir\httpd.cpp.obj
C:\047rls\reactos\modules\rosapps\applications\net\roshttpd\include\httpd.h(70) : warning C4373: 'CHttpDaemon::OnAccept': virtual function overrides 'CServerSocket::OnAccept', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
        C:\047rls\reactos\modules\rosapps\applications\net\roshttpd\include\socket.h(132) : see declaration of 'CServerSocket::OnAccept'
[11442/11751] Building CXX object modules\rosapps\applications\net\roshttpd\CMakeFiles\roshttpd.dir\roshttpd.cpp.obj
C:\047rls\reactos\modules\rosapps\applications\net\roshttpd\include\httpd.h(70) : warning C4373: 'CHttpDaemon::OnAccept': virtual function overrides 'CServerSocket::OnAccept', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
        C:\047rls\reactos\modules\rosapps\applications\net\roshttpd\include\socket.h(132) : see declaration of 'CServerSocket::OnAccept'

partial pick of 0.4.15-dev-2951-g 5d8e834897
2022-03-29 19:32:47 +02:00
Joachim Henze 66405f2311 [0.4.14][NETREG] Fix 1 MSVC2010SP1 x86 dbg warning C4065 CORE-18104
the warning can be observed with MSVC 2010SP1 (16.0.40219.1) x86 target in dbg configuation:
[11432/11751] Building CXX object modules\rosapps\applications\net\netreg\CMakeFiles\netreg.dir\netreg.cpp.obj
C:\047rls\reactos\modules\rosapps\applications\net\netreg\netreg.cpp(188) : warning C4065: switch statement contains 'default' but no 'case' labels

partial pick of 0.4.15-dev-2951-g 5d8e834897
2022-03-29 18:19:18 +02:00
Joachim Henze 58c87f5404 [0.4.14][REACTOS] Fix ' \n' in *.rc (the most recent popups) CORE-18103
This covers a last handful of those glitches that were freshly introduced
during late 0.4.14-dev'ing after we had just recently killed
all of them via 0.4.14-dev-1142-g 92aabb07fb

Fix picked from 0.4.15-dev-4276-g a8107ee446
This does not need to be ported back further, the older branches are clean now.
2022-03-24 23:35:28 +01:00
Joachim Henze b6088a6adb [0.4.14][MSCONFIG_NEW] Exclude from the iso, for the time being CORE-18067
Since more than 10 years we do ship two binaries for the very same purpose in our isos:
msconfig and msconfig_new.

msconfig_new was an attempt to refactor the old tool, but it got stuck rather soon
and is bloating our isos since then, and consuming build-time.
My testing shows that the older version is superior in many ways
compared to that refactoring attempt: see CORE-18067 for examples of some bugs.

Personally I think focusing on the older tool exclusively would make more sense
than trying to improve that refactoring proposal.
But since one never knows what the future might bring and I did not want to step on anyones toes,
I decided to just disable the build and iso-integration of the unfinished one meanwhile,
instead of dumping it entirely. Although my feeling is that after 10years of waiting
it's not worth waiting another 10 years with that.

Fix picked from:
0.4.15-dev-3882-g e6de6098fb
2022-03-11 04:26:40 +01:00
Joachim Henze 210d6026f5 [0.4.14][USETUP] de-DE Update 2022-03-05 CORE-18075
ports back the fixes of:
0.4.15-dev-3886-gc791d4e c791d4ee4e CORE-18075
2022-03-05 18:34:09 +01:00
Joachim Henze a0db8399e4 [0.4.14][RASDLG] de-DE.rc Update CORE-18056
Fix the glitch
"Wenn nur eine nur einzige Leitung verbunden ist"
to
"Wenn nur eine einzige Leitung verbunden ist"
which was introduced by
SVN r67570 == git 8ad8574f4b

and a few other small glitches.

fix picked from:
0.4.15-dev-3878-g d9f156e9a8
2022-03-01 12:38:34 +01:00
Joachim Henze 313f9f72f6 [0.4.14][TASKMGR] Backport commits id-ID and 'Remove Debug Channels' CORE-18057
by picking the following commits:
0.4.15-dev-413-g ed7196d964 [TASKMGR] Remove 'Debug Channels' feature, which is Wine-specific
0.4.15-dev-2488-g fd4d8f550c [TASKMGR] id-ID.rc, just the single line in this module
2022-02-27 22:43:36 +01:00
Joachim Henze c9e07b2437 [0.4.14][SYSDM] uk-UA.rc Trivial whitespace addendum (in context of CORE-17827)
A resource compiler 'warning RC4206 : title string too long; truncated at 256'
had been fixed by
0.4.12-dev-920-g 8fb10879fc already
and I am porting this back into releases/0.4.7 till releases/0.4.11 right now.

Back then the trailing space before that comment
' //TOO LONG, MAX 256 CHARS ALLOWED' was forgotten to be removed.
That part was already done on master head since then though as part of 0.4.15-dev-3152-g bbabe2489e

I decided to port back 'the final thing' of that line instead of having several intermediate states.
Therefore the stupid-looking one-character-change in this branch.
2022-02-27 13:48:14 +01:00
Joachim Henze 1b0b8527eb [0.4.14][NTUSER][3DTEXT] Squashed backport CORE-17866, CORE-8217
The main part in [USER32] was already committed into 0.4.14-RC-123-g 75e9ac7727
but we do have two follow-ups that are worth picking as well:
---------------------
[NTUSER] Do not remove message from the Msg Queue if it is not for us. (#4129)

CORE-8217 This part of the fix keeps the buttons working (Cancel/Ok/top-Right-X) even under high CPU-load
Patch from 'I_Kill_Bugs' contributor.

Fix picked from 0.4.15-dev-3499-g 7d1b50394b
---------------------
[3DTEXT] Fix 3dtext.scr using near 100% CPU (#4125) CORE-17866, CORE-8217

Fix picked from 0.4.15-dev-3443-g 5c9fdcb1de
2022-02-08 12:23:20 +01:00
Joachim Henze 44b7f9f470 [0.4.14][RPCRT4] Fix implicit in attribute handling in write_param_fs() CORE-17884
Cherry-pick wine-5.0-rc1-50-g1aaf870 by Jacek Caban.
https://source.winehq.org/git/wine.git/?a=commit;h=1aaf870039dfb8419ae060d8c67240df1366b953
(OLEAUT32_WINETEST part shall be imported later.)

Fixes regression CORE-17884 AVR Studio 4: 'FrameWork Class: Unable to add process to ROT: -2147467261'
which regressed by 0.4.12-dev-555-g b6fdb56b9a

Fix picked from 0.4.15-dev-3624-g 1723c223e3
2022-02-07 21:36:38 +01:00
Joachim Henze 9f847bd3d4 [0.4.14][FREELDR] LogSpam before the Dash-separator already CORE-18033
Our default configuration started to spam before the dash separator for 2nd-/3rd-stage:

(boot/freeldr/freeldr/ntldr/winldr.c:628) fixme: LoadWindowsCore: SOS - TRUE (not implemented)
(ntoskrnl/kd64/kdinit.c:74) -----------------------------------------------------

since 0.4.14-dev-1347-g 305e856ef8

I left master untouched for now, because hbelusca has something in the making
for the actual implementation already. He expects to merge that "soon"(TM)
and does not have to merge anything then. I do not intend to wait that long
for the release though.
The other options are left in spam-mode, because they are not the default.
2022-02-05 06:15:07 +01:00
Joachim Henze e6038e0e7d [0.4.14][WIN32SS] Remove an ambiguous assert entirely CORE-16738
It popped up very reliably when performing git-clone of the ros sources
while having the taskmgr open in the processes-tab.
Or when building 'ninja bootcd -j1' while having the taskmgr open in the processes-tab.

It is always possible to ignore it and then continue using ros for days without
noticing any side effects.
James Tabor judged the assert to have a "questionable logic".
Giannis who once added it, was also ok with commenting it.

His words:
This assertion isn't something fatal,
the worst thing that can happen from continuing on it would be
to make the thread get awake more times than it should.

The assert was once added by SVN r63880 == git 9ad857369a

It was commented out already via 0.4.14-dev-1519-g 87f6c82d85 (2020-04-21)
Final Removal picked from 0.4.15-dev-3780-g bf16435303 (2022-02-05)
2022-02-05 01:54:48 +01:00
Joachim Henze 4b2f7bba05 [0.4.14][CRYPTUI] Fix all MSVC *.rc warnings RC4206 CORE-18017
warning RC4206 : title string too long; truncated at 256
by providing shorter translations.
We had 24 such warnings in this module

fix picked from:
0.4.15-dev-3739-g ff9301e9db
0.4.15-dev-3748-g 6a496c3991
2022-02-03 13:01:53 +01:00
Joachim Henze 5ef8e055a6 [0.4.14][BCRYPT] Add ECDSA P256 to known algorithms CORE-16741
Add missing structs and handler in BCryptOpenAlgorithmProvider().
Fixes CORE-16741 and similar problems.

The modern internet is not waiting for ReactOS, needed to keep the RAPPS URLs working.
fix picked from:
0.4.15-dev-3603-g e0a47b7b5f [BCRYPT] Add BCRYPT_ECDSA_P256_ALGORITHM
2022-02-02 22:04:21 +01:00
Joachim Henze 05964a44d2 [0.4.14][CMD] *.RC Shorten the string for the version header CORE-17420
We did strip that superfluous "Operating system"
during 0.4.15-dev'ing to prevent line-overflow when
we added the target platform to the version string.
picked from 0.4.15-dev-1605-g ab45955a5a
Recently I found out that the git hashes will also become
longer when there is hash collision. So the shortening adds to
safety also for the old branches.

While touching those RCs do also pick:

0.4.15-dev-2336-g d3fc345730 [CMD] de-DE: Fix 'Paramater' typo
and some EOL-whitespace stripping.
2022-01-31 18:53:28 +01:00