Commit graph

659 commits

Author SHA1 Message Date
Katayama Hirofumi MZ
49be08bc69
[FONTVIEW] Fix regression; opening files won't list files (#3045)
Based on Mark Jansen's patch in CORE-17001.
2020-08-15 07:08:40 +09:00
Serge Gautherie
b509658280
[CMAKE] Remove obsolete 'CMAKE_CXX_COMPILER_VERSION' checks (#2981)
Following upgrade to RosBE 2.2.0 support and GCC 8.4.
2020-07-18 15:37:29 +02:00
Arjav Garg
3b983e57b0
[OSK] Meta key modifier behaviour added (#2973)
Make the meta key in the OSK have modifier key behaviour.
Changed all the .rc files in the OSK so that the meta key doesn't release on it's own and needs a second click to release.
CORE-17161
2020-07-18 15:33:43 +02:00
Serge Gautherie
f91144364b [TASKMGR] CachedGetUserFromSid(): Fix user name length on cache hit 2020-07-11 01:37:53 +02:00
Colin Finck
5f37b687b0
[OSK] Fix some mistakes in the German translation I just spotted 2020-07-08 23:32:17 +02:00
FritzsHero
fbb612f41a
[OSK] Updated German On-Screen Keyboard translation (#2882) 2020-07-04 15:17:26 +02:00
Serge Gautherie
4292fdd8aa
[NET] cmdAccounts(): Set ProductType default value (#2365) 2020-07-04 15:16:22 +02:00
Serge Gautherie
ed7196d964 [TASKMGR] Remove 'Debug Channels' feature, which is Wine-specific 2020-06-25 22:08:03 +02:00
He Yang
393a2c42fe
[RAPPS] delete obsolete field 2020-06-14 20:34:43 +02:00
Charles Ambrye
99dd292553
[CHARMAP] Functionality Improvements and Bug Fixes (#2560)
- Resize the window slightly when compiled with REMOVE_ADVANCED to avoid deadspace at the bottom of the window.

- Skip over the non-printable characters by starting with character ' ' + 1.

- Instead of iterating over every cell, simply compute the cell x and y using the CellSize.

- Modify behaviour of charmap to allow large character render on mouse move, only hiding the larger character on double click.

- Simplify math for moving window to be on desktop.
Added FIXME to highlight this doesn't work well on multi-monitor setups.
Changed xPos and yPos to LONG since negative numbers are valid on multi-monitor setups.

- Do not draw invalid glyphs on the map (can happen when switching fonts or filtering existing font).
- Do not allow mouse-over of invalid glyphs.

- Fix bug that caused the Help button to remain enabled as it was being modified before it was even created.
- Do a better job at finding the correct glyph under the mouse.

- Ensure the active cell is cleared correctly.

- Invalidate the rect around the previously active cell to ensure it gets redrawn as inactive.

- Fix bug from CORE-10518 (initial active cell was not being invalidated on scroll).

- Do not try to copy a character to the output if there is no active cell selected.

- Populate the advanced portion of the screen with several built-in code pages (the list is hardcoded so that we don't enumerate everything).

- Add functionality to filter the character map by a code page (called a character set in this program).

- Some fonts list 0x0000 as drawable, even when it isn't, so ignore any valid glyphs that contain it.
2020-06-07 19:34:45 +02:00
Amine Khaldi
139a3d6661
[CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2020-06-06 21:58:41 +03:00
He Yang
e5886f862f
[RAPPS] Update Chinese (Taiwan) translation (#2873) 2020-06-01 14:30:53 +03:00
Serge Gautherie
701e6c6a2f
[SNDREC32] Use ShellAboutW(..., ..., NULL, ...) (#2827)
Addendum to 82e4efea77.
2020-06-01 12:17:29 +03:00
Serge Gautherie
9a614c82e1
[LABEL] wmain(): Initialize 'szBuffer' (#2867)
Detected by Cppcheck: uninitvar.
2020-05-27 17:05:33 +02:00
Serge Gautherie
11345aedd8
[FORMATTING] [CMAKE] Remove space in 'if (' (#2847) 2020-05-26 20:24:02 +02:00
Jose Carlos Jesus
9619dd4598
[RAPPS] Update Portuguese translation (#2820)
Update translation following PR #2792.
2020-05-23 15:17:52 +02:00
He Yang
e5336bd2af
[RAPPS] Rapps trivial fixes (#2819)
- Specify W explicitly for URL_COMPONENTS;
- Remove malloc/free for once used HostName in urlComponents;
- Use PathAppendW to operate on path string.
2020-05-21 00:21:26 +02:00
Kyle Katarn
637b1e8661
[RAPPS] French translation update following PR #2792 (#2815) 2020-05-20 16:05:12 +02:00
He Yang
a21d959e90
[RAPPS] Move database source URL to settings dialog (#2792)
- Add download source in settings dialog, and apply it when download .cab file
- Now user should specify full rappmgr.cab URL
- Check if URL is vaild in settings dialog
- Move source settings to the end of struct (will refactor settings to one value per option later)
2020-05-19 20:06:10 +03:00
Adam Stachowicz
cc662bfde8
[EVENTVWR] Update polish translation (#2804)
After commit 8756cec0.
2020-05-17 23:39:56 +02:00
Kyle Katarn
8756cec0e3
[EVENTVWR] Implementation of Properties page functionnal code. (#2744)
Implementation of functional code for log properties page in order to allow user to :
- Make modification and have them taken into account when properties page is closed / apply is used;
- Set defaults (including correction of default max size);
- Delete content of log;
- Make "Apply" button functional based on user inputs;
- Correct default value during installation (duration, size).

- Improve InitPropertiesDlg() error;
- Fix SavePropertiesDlg(): When the event log key does not exist, it is not recreated by the event log viewer.
- GetDisplayNameFileAndID(): Show the error also when opening the event log key fails.

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-05-17 18:54:39 +02:00
Hermès Bélusca-Maïto
591f7ff5d7
[CHARMAP_NEW] Remove non-existing entries. 2020-05-17 18:46:42 +02:00
Julen Urizar Compains
546862babc
[TRANSLATION] Update Spanish, and add Basque translation (#2667)
Add/update translation for:
charmap_new, logoff, mspaint, notepad, usetup, welcome,
hotplug.cpl, sysdm.cpl, aclui.dll, comctl32.dll, comdlg32.dll,
hhctrl.ocx, kernel32.dll, msi.dll, oledlg.dll, shell32.dll,
tapiui.dll, themeui.dll, wininet.dll, winmm.dll, wldap32.dll,
winsrv.dll.
2020-05-17 18:46:36 +02:00
Kyle Katarn
4d1cd72317
[REGEDIT] Fix and improvement in TreeView (Null handle check, incorrect display after edit, WM_NOTIFY refactor) (#2733)
* - Fix of missing invalid handle check
- Fix of Address & status bar incorrect display after rename
- Refactoring of Treeview WM_NOTIFY code, for better consistency with WM_NOTIFY management for ListView

* Fix following review (space in #define)

* Cleanup following review

* fix following review

* Fix of round 3 of review comments

* UpdateAdress kept in its original location

* fix

* fix (extern missing)

* both extern removed

* Review comments
Error message being added in order to support CORE-17048
2020-05-16 21:23:20 +09:00
Kyle Katarn
82e4efea77
[SNDREC32] Use the ShellAboutW API routine to display the about dialog (#2754) 2020-05-14 14:30:57 +02:00
Kyle Katarn
4b479d19e6
[SERVMAN] Use the ShellAboutW API routine to display the about dialog (#2752) 2020-05-14 14:30:35 +02:00
Kyle Katarn
a6084d7440
[RAPPS] Use ShellAbout() to display the about dialog (#2751)
As the dialog simply displays the copyright names and nothing particular it makes sense to use ShellAboutW() instead.
2020-05-14 15:28:57 +03:00
Katayama Hirofumi MZ
b1519f65a7
[MPLAY32] Don't hardcode C: drive (#2778)
CORE-13235
2020-05-13 22:36:44 +09:00
He Yang
2f56ccafe0
[RAPPS] Corrections for Chinese Simplified dialog UI translation (#2781) 2020-05-13 15:26:29 +03:00
Yaroslav Kibysh
a76c7ea9fc
[NOTEPAD] Update Ukrainian translation (#2775) 2020-05-13 15:12:22 +03:00
Katayama Hirofumi MZ
278f563e04
[FTP] Don't hardcode C: drive (#2767)
CORE-13235
2020-05-13 13:42:18 +09:00
Mark Jansen
909f50a857
[FONTVIEW] Ensure the extension filter is properly double-null terminated 2020-05-11 20:52:30 +02:00
Kyle Katarn
a2a24cadae
[SNDREC32] French translation update (#2761)
And add/fix colliding keyboard accelerators.

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-05-10 18:22:13 +02:00
Eric Kohl
592bafd60a [ARP] Print a message when there is no relevant entry to be shown 2020-05-10 09:05:52 +02:00
Eric Kohl
5ebde7139a [ARP] Coding style fixes only 2020-05-10 08:24:10 +02:00
Eric Kohl
e31069738f [ARP] Improvements to ARP
- Print message on failed memory allocations.
- Functions return error code instead of exit code.
- Convert error code to exit code in the main function only.
- Always free the allocated memory.
- Fix bug from previous commit: Use _tprintf instead _putts to print messages.
2020-05-10 00:46:42 +02:00
Kyle Katarn
d839e3d9b4
[SNDREC32] Fix incorrect opaque text rendering (#2760)
Remove "Opaque" parameter so that the transparency can be correctly used.
2020-05-09 21:09:58 +09:00
Eric Kohl
ac01e4cd72 [ARP] Replace some hard-coded strings by message resources 2020-05-09 12:30:11 +02:00
George Bișoc
2c80432268
[UTILMAN] Use the ShellAboutW API routine to display the about dialog (#2743)
In addition to that, add the missing function prototypes in the DLL dialog header of Utilman, add missing IN/OUT annotations and remove CheckUtilityState() prototype which is barely used (it's not implemented either).
2020-05-07 13:01:36 +02:00
He Yang
a7b111f550
[RAPPS] 64bit compatibility fix (#2748)
Change SetWindowLongW to SetWindowLongPtrW.

It's the same (because the value is 0) but I think it's better.
2020-05-07 18:08:08 +09:00
Kyle Katarn
0461de33c5
[REGEDIT] Fix HeapFree() on the wrong variable (#2736)
- When exporting registry keys (to .reg files) some variables from the heap are not free'd while the debug log indicates "HEAP: Trying to free an invalid address".
- This is due to the export_registry_key() function that calls
HeapFree() for reg_key_name. But this variable is an argument provided by the caller, which is always a statically defined array of WCHAR.
- Meanwhile reg_key_name_buf is never free'd and cause a memory leak each time the function gets called.
2020-05-05 11:44:45 +03:00
Mark Jansen
86572f1f69
[RAPPS] Fix the locale fix 2020-05-03 20:33:23 +02:00
Mark Jansen
cf9ba2b9ce
[RAPPS] Fix locale fallback code 2020-05-03 18:33:06 +02:00
Adam Stachowicz
d53ee9c69e [RAPPS] Polish translation
After fb1582d330
2020-05-02 13:22:48 +02:00
Kyle Katarn
bfd02fa107
[SNDVOL32] Fix GetDC/ReleaseDC error management (#2713)
GetDC() is called without properly calling ReleaseDC() as required in order to releases a device context. Similar to #2707
2020-05-02 18:43:30 +09:00
Kyle Katarn
fb1582d330
[RAPPS] Add error messages on all download failure cases
- Implement error message for all failure condition of RAPPS Download
- Implement logging for failure conditions not needing user complementary awareness (cancellation)
- Support for localization
CORE-16851
2020-05-01 23:52:57 +02:00
Kyle Katarn
b3947d5283
[SERVMAN] UI update and Error Management (#2653)
Purpose
=======
- Current design does not warn user nor logs DEBUG traces when Service Start/Stop command fails or reach timeout.
- Current Service Start/Stop progress window are WS_EX_TOOLWINDOW which reduce lisibility, is a ReactOS specificity without good reason.

Proposed changes
================
- DPRINT1 traces added on failure cases.
- Error Message box presented to user upon failure with explicit root cause identification.
- Change Dialog definition to standard window.
2020-05-01 19:01:59 +02:00
Eric Kohl
16d136a63e [NET][MC] Replace the last string resource by a message from netmsg.dll.
- Move translations to netmsg.dll.
- Keep italian translation as a comment because netmsg.dll does not have an italian translation yet.
- Remove obsolete resource files.
2020-05-01 10:27:26 +02:00
Katayama Hirofumi MZ
5765c5be26 [UTILMAN] Add Japanese translation 2020-05-01 10:34:36 +09:00
Katayama Hirofumi MZ
4fda2f9753 [CMDUTILS][LABEL] Improve Japanese translation 2020-05-01 10:31:11 +09:00