Also:
- Set ServiceName.MaximumLength.
- Fix MSVC warnings:
'...\load\load.c(19): warning C4267: '=': conversion from 'size_t' to 'USHORT', possible loss of data
'...\unload\unload.c(19): warning C4267: '=': conversion from 'size_t' to 'USHORT', possible loss of data'
'...\unload\unload.c(24): warning C4476: 'wprintf' : unknown type field character 'U' in format specifier'
'...\unload\unload.c(24): warning C4474: 'wprintf' : too many arguments passed for format string'
- Migrate all the IOCTL calls to NtDeviceIoControlFile() calls in
order to know the actual returned data and Status values.
- Add support for displaying information retrieved from:
* IOCTL_DISK_GET_DRIVE_GEOMETRY_EX ,
* IOCTL_DISK_GET_PARTITION_INFO and IOCTL_DISK_GET_PARTITION_INFO_EX
for "partition 0" (aka. the whole disk).
- Compactify the drive layouts after getting these from
IOCTL_DISK_GET_DRIVE_LAYOUT(_EX).
- Fix the HexDump() when displaying a buffer whose size is not a
multiple of 16.
Just to satisfy static code analysis. No change in behavior expected.
The same way as the external applications maintainers
fixed it in their latest version
https://sourceforge.net/projects/pice/files/pICE%20source/build_20/
By killing the whole function ScrollUp() with the disabled code.
Like the original authors I left the functions unused declaration
existing within hardware.h
Found by some static code analysis tool reporting 'Condition always false'.
The fix is a selective back-port from the more recent version of pICE hardware.c
Revision: 1.6, Date: 2004/02/17 23:07:36
The most recent source of pICE atm can be found at
https://sourceforge.net/projects/pice/files/pICE%20source/build_20/
Thanks to DougLyons and JIRA user 'maddin200'.
