Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-05-29 14:08:22 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ROSAPPS][PICE] Fix a glitch at two places where code intends to replace invalid chars with spaces ROSAPPS-353

Browse source 
Found by some static code analysis tool reporting 'Condition always false'.
The fix is a selective back-port from the more recent version of pICE hardware.c
Revision: 1.6, Date: 2004/02/17 23:07:36

The most recent source of pICE atm can be found at
https://sourceforge.net/projects/pice/files/pICE%20source/build_20/

Thanks to DougLyons and JIRA user 'maddin200'.
This commit is contained in:
Joachim Henze 2019-05-30 12:40:54 +02:00
parent fe3ae24369
commit 2d3b72a070
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
modules/rosapps/applications/sysutils/utils/pice/module/hardware.c
View file

@ -283,7 +283,7 @@ BOOLEAN AddToRingBuffer(LPSTR p)
}
else
{
if((UCHAR)p[i]<0x20 && (UCHAR)p[i]>0x7f)
if((UCHAR)p[i]<0x20 || (UCHAR)p[i]>0x7f)
p[i]=0x20;
aBuffers[ulInPos][j++] = p[i];
@ -873,7 +873,7 @@ void Print(USHORT Window,LPSTR p)
}
else
{
if((UCHAR)p[i]<0x20 && (UCHAR)p[i]>0x7f)
if((UCHAR)p[i]<0x20 || (UCHAR)p[i]>0x7f)
p[i]=0x20;
if(bOutput)