Commit graph

59299 commits

Author SHA1 Message Date
Jérôme Gardou f801abcacf [NTOS/SE]
- Allocate the new ACL for the token with the right pool.
Fixes google chrome BAD_POOL_CALLER bugcheck.

svn path=/trunk/; revision=65139
2014-10-31 11:03:56 +00:00
Amine Khaldi d4eaa22e1f [FTP]
* Plug a leak. CID 513875.
CORE-7975

svn path=/trunk/; revision=65138
2014-10-31 10:40:48 +00:00
Amine Khaldi 7de7c827be [LOGOFF]
* LocalFree should only be executed if AllocAndLoadString() succeeds. Spotted by Thomas Faber.

svn path=/trunk/; revision=65137
2014-10-31 10:24:48 +00:00
Amine Khaldi 55f7571996 [IPCONFIG]
* Plug some leaks. CIDs 716301 => 716305.
CORE-7975

svn path=/trunk/; revision=65136
2014-10-31 10:20:55 +00:00
Amine Khaldi 614ee71e6d [FINGER]
* Addendum to r37084.
* Really fixes CIDs 500624 and 500625 which were marked as fixed.
CORE-7975

svn path=/trunk/; revision=65135
2014-10-31 09:53:18 +00:00
Amine Khaldi c5095466a0 [FINGER]
* Plug a leak. CID 1102406.
CORE-7975

svn path=/trunk/; revision=65134
2014-10-31 09:43:48 +00:00
Amine Khaldi b1626fe71e [LOGOFF]
* Plug some leaks. CIDs 716284 and 716285.
CORE-7975

svn path=/trunk/; revision=65133
2014-10-31 09:22:59 +00:00
Amine Khaldi a7c09060d2 [SHELL32]
* Plug a leak. CID 716474.
CORE-7975

svn path=/trunk/; revision=65132
2014-10-31 09:08:43 +00:00
Kamil Hornicek 476cc79d1f [WIN32K]
- check for an attached surface a bit earlier in GreExtTextOutW
- fixes Foobar 2000
CORE-7425

svn path=/trunk/; revision=65131
2014-10-31 00:21:03 +00:00
Pierre Schweitzer b3fd4ef2f0 [VFATLIB]
When we're done with formatting, attempt to umount the volume, so that it can be remounted properly by FastFAT.

svn path=/trunk/; revision=65130
2014-10-30 21:12:38 +00:00
Pierre Schweitzer ab38eafc21 [FASTFAT]
On the road for getting rid of IopParseDevice() hack....

- Add support for FSCTL_LOCK_VOLUME, FSCTL_UNLOCK_VOLUME, FSCTL_DISMOUNT_VOLUME in VfatFileSystemControl()
- Implement VfatLockOrUnlockVolume(). This brings some kind of volume locking to FastFAT FSD. It's likely not fully accurate and welcome to race conditions. But, its main purpose is to be used in usetup. So, this is fine for now.
- Stubplement VfatDismountVolume(). This will be implemented later on, but should be relatively straightforward as it requires volume to be locked (so, we're the last ones on it :-)).

svn path=/trunk/; revision=65129
2014-10-30 20:56:40 +00:00
Sylvain Petreolle 00bc798da9 [APPWIZ][SYSSETUP]
Enforce focus of the Wine Gecko download prompt in second stage.
Patch by Ismael Ferreras Morezuelas (swyter)

svn path=/trunk/; revision=65128
2014-10-30 20:50:30 +00:00
Hervé Poussineau a293927d33 [FREELDR] Move down the requirement of highest usable address
This fixes PXE boot in QEMU, where highest usable address is 0x9c400.

svn path=/trunk/; revision=65127
2014-10-30 20:22:57 +00:00
Amine Khaldi d23ef58d9e [BOOTDATA]
* Romanian translation update by Ștefan Fulea.
CORE-8630 #resolve #comment Committed in r65123. Thanks!

svn path=/trunk/; revision=65123
2014-10-30 13:29:44 +00:00
Kamil Hornicek 535667ca32 [INTL]
- don't display garbage in the location combo box

svn path=/trunk/; revision=65122
2014-10-30 12:15:11 +00:00
Pierre Schweitzer 2fc51b27ef [NTOSKRNL]
Actually enable again the hack...
For whatever reason, it works with my WC but not with clean trunk...
Where are the you, magic and silent patch that fixes it? :-(

svn path=/trunk/; revision=65120
2014-10-30 08:39:03 +00:00
Pierre Schweitzer 1bc8e4320f [NTOSKRNL]
Finally, disable again the IopParseDevice hack.
Just for the record, opening a volume with FILE_READ_EA or FILE_READ_DATA is legal and works in Windows (NTFS Info for instance opens it with GENERIC_READ).

Let's hope we can rid of this hack forever now... It's been with us since 2006!

svn path=/trunk/; revision=65119
2014-10-30 07:49:37 +00:00
Pierre Schweitzer 2009765b6a [FASTFAT]
Don't over-reference our FCB in case of volume opening (vfatAttachFCBToFileObject() already references it).

This fixes 1st stage and beyond with IopParseDevice hack off

svn path=/trunk/; revision=65118
2014-10-30 07:46:25 +00:00
Pierre Schweitzer 9288b1ab76 [NTOSKRNL]
Reenable IopParseDevice hack for now.
Out of fixes for tonight.

svn path=/trunk/; revision=65117
2014-10-29 23:28:15 +00:00
Pierre Schweitzer bedd8fa9be [FASTFAT]
Now that we start to honor the storage stack (ie, without the IopParseDevice hack ;-)), we have to let FSDs forward device IOCTLs.
This allows back copying files on 1st stage

svn path=/trunk/; revision=65116
2014-10-29 23:10:31 +00:00
Pierre Schweitzer c9ec1555ad [FASTFAT]
Don't attempt to mount any partition just because we have a valid partition table...
Restrict this to them being marked as FAT or compatible.

svn path=/trunk/; revision=65115
2014-10-29 22:51:16 +00:00
Pierre Schweitzer d22dd7da46 [NTFS]
Addendum to r65112

svn path=/trunk/; revision=65113
2014-10-29 22:40:16 +00:00
Pierre Schweitzer 7f1c752c3a [NTFS]
Implement support for the FSCTL_GET_NTFS_VOLUME_DATA user request in NtfsUserFsRequest().

This makes NTFSInfo capable of working in ReactOS :-). A picture to show it: http://www.heisspiter.net/~Pierre/rostests/NTFS_info.png
Yes, NTFS Zone isn't computed yet. I'll have a look at it later on.

This doesn't fix nfi.exe though. If it can get its data, it cannot continue. It loops forever on a FSCTL we don't handle yet.

CORE-8725

svn path=/trunk/; revision=65112
2014-10-29 22:36:55 +00:00
Sylvain Petreolle d7565e93f7 [NTOSKRNL]
Reapply r65107.
We need fixes, not hacks.
Sorry for being popular^W pressure ;)


svn path=/trunk/; revision=65110
2014-10-29 22:22:24 +00:00
Eric Kohl b87393f170 [NETAPI32]
NetUserModalsGet:
- Return the proper maximum password age.
- Remove dead code.

svn path=/trunk/; revision=65109
2014-10-29 22:17:23 +00:00
Sylvain Petreolle a1baaa2225 [UNIATA]
Update to 0.45c1.

svn path=/trunk/; revision=65108
2014-10-29 21:34:01 +00:00
Pierre Schweitzer a65c5549f9 [NTOSKRNL]
Reenable hack due to popular pressure.
Still better than fixing it, it seems...
So, break again volume opening.

svn path=/trunk/; revision=65107
2014-10-29 21:22:36 +00:00
Pierre Schweitzer 0872193d40 [NTFS]
Finally, move old stuff back from disk.sys to ntfs.sys now it can be properly reached on volume opening:
- Halfplement NtfsUserFsRequest() and add support for IRP_MN_USER_FS_REQUEST in NtfsFsdFileSystemControl()
- Also, use the proper FSCTL code: FSCTL_GET_NTFS_VOLUME_DATA which exists and is documented instead of FSCTL_GET_NTFS_VOLUME_DATA. Spotted by Christoph.

CORE-8725

svn path=/trunk/; revision=65106
2014-10-29 18:42:05 +00:00
Pierre Schweitzer c009666393 [DISK]
Revert r65097 and r65090.
Thanks to r65104, now the FSCTLs go to the right place: the FSDs!

Thanks to Thomas for pointing out that NTFSinfo was really talking with the FSD on Windows and not to disk.sys

CORE-8725

svn path=/trunk/; revision=65105
2014-10-29 18:25:30 +00:00
Pierre Schweitzer 48cddc2fcc [NTOSKRNL]
Disable the IopParseDevice hack. It appears it was triggered on volume opening and thus was breaking volume opening which were then forwarded down to disk.sys.
Not sure how legit it is to have it anylonger.

At least, disabling it reenables volume opening in ReactOS and associated FSCTL!

Alex & Aleksey, can you review please?

CORE-8725

svn path=/trunk/; revision=65104
2014-10-29 18:20:43 +00:00
Kamil Hornicek 34147616fd [NLS]
- fix the code page value
- also fixes intl.cpl showing date format string in the code page list

svn path=/trunk/; revision=65103
2014-10-29 18:20:03 +00:00
Kamil Hornicek c1c1e05803 [KERNEL32]
- remove bunch of stray pragmas
- add a czech translation to stop debug spam reported in CORE-8720

svn path=/trunk/; revision=65102
2014-10-29 16:59:44 +00:00
Kamil Hornicek 08e9098294 [BOOTDATA]
- add metrics to classic themes (the flag 0xb0001 will result in a kinda esoteric value of type REG_QWORD)
- fixes switching from Lautus back to a classic theme
CORE-8718

svn path=/trunk/; revision=65100
2014-10-29 14:27:09 +00:00
Pierre Schweitzer 88ea664a82 [DISK]
Actually, sysinternals used to release the source code of NTFSInfo (thanks Christoph!), so we know a bit more about the interface of the user FS request.
So, implement a bit more of the interface to validate it properly works (and so far, it does!)

CORE-8725

svn path=/trunk/; revision=65097
2014-10-29 11:31:19 +00:00
Timo Kreuzer 54d0920f7e [GDI32]
Improve functions in coord.c:
- Use GdiGetDcAttr() where appropriate
- Fix SetLastError() usage
- Add annotations
- improve variable naming
- Add some comments

svn path=/trunk/; revision=65093
2014-10-28 22:16:24 +00:00
Pierre Schweitzer 7a204076f6 [DISK]
Get ready to enter into the 10th dimension... So:
- Implement support for IRP_MJ_FILE_SYSTEM_CONTROL. Yes... You read well! So, implemented a ScsiDiskFileSystemControl() function. The way it is added to the DriverObject is a big hack, class2 is not supposed to have such requests, so, we do it in its back. Fear!
- Stubplement the NtfsRussinovichism() function. This is the only function we're supposed to call with IRP MJ FSCTRL and with IRP MN USRFSRQST. Its purpose (when its implemented) is to reply back to the M. Russinovich tools (NFI & NTFSInfo) so that they can directly dump NTFS information without going into NTFS driver. They kind of bypass it.
We do all agree this is a ugly hack. But it exists in Windows, as these tools work in Windows. And it would be useful they actually work in ReactOS.
Soon, we'll be able to publish a book "ReactOS Internals" where we speak about undocumented FS controls to dump NTFS information to show how well our NTFS works ;-).

svn path=/trunk/; revision=65090
2014-10-28 21:59:57 +00:00
Eric Kohl 70cb67436c [NET]
Display more password information in the NET USER command.

svn path=/trunk/; revision=65089
2014-10-28 21:57:41 +00:00
Kamil Hornicek b71df11be9 [WIN32K]
- addendum to revision 64877 which slightly changed UserDrawCaption's logic
- fixes window title being drawn over the icon

svn path=/trunk/; revision=65087
2014-10-28 21:38:26 +00:00
Timo Kreuzer 6417d36a41 [GDI32]
- Move functions to the appropriate source files, zap hacks.c, stubs.c, stubsa.c and stubsw.c (sorry for the noise, but this mess had to be cleaned up)

svn path=/trunk/; revision=65086
2014-10-28 21:09:01 +00:00
Pierre Schweitzer aaebdbf9d3 [FASTFAT]
For now, disable the VfatSetRenameInformation() asserts in trunk.
They can be reenabled for testing by commenting "#define NASSERTS_RENAME" out.

CORE-8721 #resolve #comment Fixed with r65085

svn path=/trunk/; revision=65085
2014-10-28 20:39:42 +00:00
Pierre Schweitzer 135e926315 [NTFS]
Finally, implement NtfsGetFreeClusters() which will just read the $Data stream from $BITMAP file record to get the amount of free clusters to allow estimating the free space on a volume.
The implementation is likely under-optimized... But wwell, the rest of the FSD is not better. Who talked about caching?! ;-)

Because pictures are more relevant than words in such case: http://www.heisspiter.net/~Pierre/rostests/NTFS_disksize.png

svn path=/trunk/; revision=65082
2014-10-28 19:17:59 +00:00
Giannis Adamopoulos 2c3bb20acb Merge r65001 from shell-experiments branch:
[user32]
- Properly notify the theme engine that the caption needs to be repainted on WM_SETICON
- Fixes a classic frame appearing when themes are enabled and we navigate to a different folder

svn path=/trunk/; revision=65077
2014-10-28 17:32:01 +00:00
Ged Murphy f5ca079e13 [WINLOGON]
- Stop the log from being spammed when the session is idle and no screensaver is set
- Also checking if my login still works :)

svn path=/trunk/; revision=65076
2014-10-28 17:07:47 +00:00
Pierre Schweitzer d6fa9e7094 [NTFS]
ReleaseAttributeContext() is to be used out of mft.c
I believe that at some point, we're leaking memory...

svn path=/trunk/; revision=65068
2014-10-28 10:26:47 +00:00
Timo Kreuzer 1bc1ae75f3 [GDI32]
Implement separate functions for all SelectObject cases.

svn path=/trunk/; revision=65067
2014-10-28 09:06:33 +00:00
Christoph von Wittich 27b8f91dbd [DRIVERS]
don't use uninitialized variables

svn path=/trunk/; revision=65066
2014-10-28 08:15:49 +00:00
Timo Kreuzer c8e18b66a9 [GDI32]
- Use GdiGetDcAttr instead of GdiGetHandleUserData where appropriate
- Add a few missing SetLastError()
- Fix return failure return value of GetBkColor()
- Improve order of operations in SelectObject (needs more fixing)

svn path=/trunk/; revision=65063
2014-10-28 00:55:22 +00:00
Aleksandar Andrejevic 891d638347 [FAST486]
Fix a typo in r65061.


svn path=/trunk/; revision=65062
2014-10-28 00:53:02 +00:00
Aleksandar Andrejevic f1a3c93e07 [FAST486][NTVDM]
Get rid of Fast486Interrupt, since it's not used anywhere. Also we can now remove
workarounds for all of the bugs that it caused.
Implement the "single-instruction interrupt delay" for instructions that load the
stack segment only.


svn path=/trunk/; revision=65061
2014-10-28 00:33:03 +00:00
James Tabor 14c0c3cbce [NtUser]
- Revert 64363. See CORE-7797.

svn path=/trunk/; revision=65060
2014-10-28 00:26:22 +00:00