Commit graph

77172 commits

Author SHA1 Message Date
Vadim Galyant
7db342f8a1
[NTOS:PNP] Add set functions for debugging PNP and IO managers. (#2457)
Useful functions for debugging IO and PNP managers:

PipDumpDeviceNodes() - displays information about a node(s) in the device tree;
PipDumpResourceRequirementsList() - displays information about a Io List;
PipDumpCmResourceList() - displays information about a Cm List

The tree list of devices (DEVICE_NODE structures) is perhaps the main one in the PnP manager. They also store information about the hardware resources required and assigned to devices.
These functions can help with debugging. For example, you can call PipDumpDeviceNodes() before and after device enumeration and compare the resulting information.

For PipDumpDeviceNodes() it is possible to optionally output:
- allocated resources and boot configuration resources
- resources required
- translated resources
It is possible to displays both a single node and the entire tree.
Optionally, you can display child nodes.

The information output format for resource lists is maximally compressed, since often the only debugging port is a monitor.

The DebugLevel parameter allows dumping in two modes:
0 - unconditional;
1 - if NDEBUG is not defined in "debug.c".
2020-04-04 14:30:40 +02:00
Vadim Galyant
ac843d7b82
[NTOS:MM] Make the definitions and macros for x86 more human-readable. (#2487)
- Move also PDE_MAPPED_VA definition from common miarm.h to ..arch/mm.h.
- Add assert "PAE not yet implemented".
2020-04-04 14:26:15 +02:00
Julen Urizar Compains
58d2b1f3f6
[TRANSLATION][USETUP] Update Spanish translation of USetup. (#2497)
Correct the random names, fixing the denominations, translate of the English words, and fixing random and incorrect denominations like "Cabinet" or "distribuciones".
2020-04-04 13:10:34 +02:00
Colin Finck
3c02749f92
[ROSAUTOTEST] Use tlsv1.reactos.org for submitting test results now that reactos.org is TLS 1.2+
We still need to be able to submit test results from Windows Server 2003, which supports TLS 1.0 only.
2020-04-04 12:57:50 +02:00
Oleg Dubinskiy
56aa5137e7
[QCAP] Import qcap.dll from Wine Staging 3.3. CORE-16350 (#2421)
Fix also MSVC build.

[DOC] Add qcap entry in README.WINE

Co-Authored-By: Thomas Faber <18138474+ThFabba@users.noreply.github.com>
2020-04-03 23:59:12 +02:00
Oleg Dubinskiy
e9f5438eea
[DXSDK] Sync axextend.idl with Wine Staging 3.3 (#2421)
Required by Wine's qcap.dll CORE-16350

[DXSDK] Restore all deleted code in axextend.idl to propely fix compilation
Also regularize some parts of added code and replace IAMStreamControl interface
with Wine's one, because otherwise compilation fails.
2020-04-03 23:58:54 +02:00
Hermès Bélusca-Maïto
a5d599505d
[TASKKILL] Merge our updated terminate_processes() function with the one
from Wine, using __REACTOS__ defines to separate the changes.

We note that in effect it completely contains the functionality of
Wine's send_close_messages(), so we keep that latter disabled.
2020-04-03 18:40:00 +02:00
Bișoc George
e6f83a91b8
[UTILMAN] Implement the Registry management code skeleton (#2456)
The following SaveAppSettings(), QueryAppSettings() and InitAppRegKey() are helper functions.
This is merely a base Registry skeleton for Utility Manager as more work on it has to come later.
2020-04-03 17:46:30 +02:00
He Yang
5874c66e41
[TASKKILL] Improve taskkill utility (#2459)
Make the argument process of command utility "taskkill" behave same as what Windows does.

Now options are no longer detected as parameters when placed after options that accept one.
For example, `taskkill /im /f` will no longer regard `/f` as a process name.

If `/?` and `/f` options appear more than once, an error will be reported, telling they are not allowed more than once.
(e.g. `taskkill /f /pid 1000 /f`)

If only one option `/f` is given without `/pid` or `/im`, an eerror will be reported, telling that one must specify `/pid` or `/im`.
(e.g. `taskkill /f`)

Additional changes:
- Combine SendCloseMessages() and TerminateProcesses() functions.
- Protect new written code with `#ifdef __REACTOS__`
2020-04-03 17:37:53 +02:00
Serge Gautherie
ded98b846e
[WIN32K:NTUSER] ntuser.h: Rename NtUserWaitForInputIdle() 3rd parameter (#2499)
Addendum to 568b6d05.
2020-04-03 15:06:25 +02:00
Serge Gautherie
803b5e1371
[WINETESTS] Remove forced _WIN32_WINNT defines (#2463)
Only comctl32 is affected.

Import
be3cda6ec0
2020-04-03 14:01:22 +02:00
Serge Gautherie
8c986e17a0
[PSDK] guiddef.h: Remove unwanted '&& !defined(CINTERFACE)' (#2492)
Cherry-pick
4626db2bb2
Import
54f58769fe
34f3e7793b
2020-04-03 13:59:34 +02:00
Hermès Bélusca-Maïto
76ebd0d054
[RPCRT4] Handle ERROR_BAD_NETPATH failure if an RPC pipe connection is done on an non-existing UNC path.
Addendum to 5274857d (see originally commit 13f41d74). CORE-6561
2020-04-03 13:33:03 +02:00
James Tabor
568b6d0558 [NTUser] Fix Strings and Format to Hooks
Allocate heap instead of data segment to be used for callbacks on user side.
Move and correct initial hook call out setup. Use it in more than one hook call.

This fixes issues with strings out of alignment and use of kernel pointers.

See CORE-13907 and CORE-16769. KsStudio still needs retested.

Small wow update.
2020-04-03 03:58:29 -05:00
Stanislav Motylkov
61a54aef9e
[SYSDM] Cumulative update 2020-04-01 for SMBIOS parser (#2495) 2020-04-02 19:57:53 +02:00
Hermès Bélusca-Maïto
5274857da9
[RPCRT4] Addendum to support for remote pipes names in ncacn_pipe_name() (24cd7bbe).
CORE-6561 CORE-13442

- Call GetComputerNameA() only when a non-empty server name has been
  provided, thus slightly improving speed for the most common case when
  local calls (with an empty server name) are done.

- When a server name is passed, trim any leading UNC server prefix since
  the latter will be restored when building the pipe name string.
2020-04-02 18:35:39 +02:00
Jérôme Gardou
bf0dc6adb2 [README] Add "open in Gitpod" button 2020-04-02 18:03:18 +02:00
Jérôme Gardou
04d0d95b8a [GITPOD]Add gitpod config
this commit adds support for Gitpod.io, a free automated
dev environment that makes contributing and generally working on GitHub
projects much easier. It allows anyone to start a ready-to-code dev
environment for any branch, issue and pull request with a single click.
2020-04-02 18:03:18 +02:00
Joachim Henze
45b5ec8e7b [RDBSS] Avoid CORE-13938
Pierre recommended this workaround for 0.4.8rls before.
Avoids "GetVolumeInformation now fails on NFS volume"

This workaround was recurrently applied for all releases
0.4.8, 0.4.9, 0.4.10, 0.4.11, 0.4.12, 0.4.13.

I never got any reply in the regression-ticket and recurrently
applying this over and over again is a waste of time.
So I decided to commit to master today, but will leave
the ticket unresolved, so when a proper fix will arrive in the future,
the existing ticket will remind us to undo this workaround.

Please note that I replaced #if 0 with #if 1
as discussed with Pierre. That's different to the patch in ticket.
2020-04-02 15:09:46 +02:00
Vadim Galyant
b78cb36d91
[NTOS:MM] Using the macro MiIsPteOnPdeBoundary(). (#2496)
The SYSTEM_PD_SIZE constant should not be used to determine the page boundary for page tables. It is better to use the portable MiIsPteOnPdeBoundary() macro for this.
2020-04-02 12:15:33 +02:00
Jared Smudde
a5a725ae57
[STOBJECT] Change eject hardware dialog buttons from OK/Cancel to just OK. (#2493)
It's just an information dialog that needs one button, it's not actually doing different actions based on user input.
2020-04-01 11:42:24 +02:00
Mark Jansen
c1464a4030
[SPEC2DEF] Omit skipped exports from ordinal numbering.
CORE-16769
2020-03-31 22:49:44 +02:00
Eric Kohl
45e79efd06 [HOTPLUG] Display class icons for removable devices 2020-03-31 22:44:31 +02:00
Victor Perevertkin
d37799ea3e
[CONFIGURE] Simplify version detection for modern Visual Studio 2020-03-31 12:29:56 +03:00
Jared Smudde
8aa58c19a6
[HOTPLUG] Add 32 pixel icon. (#2486)
Add a 32 pixel icon to the main icon for hotplug.cpl so the Safely Remove Hardware dialog looks normal.
2020-03-30 23:54:17 +02:00
Eric Kohl
cbdf649f2c [HOTPLUG] Show removable devices and update the list on arrival and removal. 2020-03-30 23:11:44 +02:00
Joachim Henze
30dcc229f0 [ROSAPPS][PICE] Fix ROSAPPS-355 Unreachable code
Just to satisfy static code analysis. No change in behavior expected.

The same way as the external applications maintainers
fixed it in their latest version
https://sourceforge.net/projects/pice/files/pICE%20source/build_20/

By killing the whole function ScrollUp() with the disabled code.
Like the original authors I left the functions unused declaration
existing within hardware.h
2020-03-30 17:18:16 +02:00
Hervé Poussineau
76a41370d0 [NTOS:KD] Move dump of stack trace on crash to debugger
Release builds now show again the bugcheck screen, instead of freezing.
2020-03-30 15:23:34 +02:00
Hervé Poussineau
fd8cacae4c [NTOS:KE] Remove dead code 2020-03-30 15:23:25 +02:00
Hervé Poussineau
8b6e441a6e [NTOS:KD] Fix compilation with CMAKE_BUILD_TYPE=Release
This was broken by commit a890fc64d1
2020-03-30 15:23:25 +02:00
Hervé Poussineau
38e53eea4f [NTOS:KD] Fix compilation with CMAKE_BUILD_TYPE=Release
This was broken by commit f7ec84eea0
2020-03-30 15:23:25 +02:00
Serge Gautherie
30613b92ab
[ACLUI] Properly enumerate cache+queue entries (#1937) 2020-03-30 13:13:22 +02:00
Benjamin Aerni
66cf7b6028
[PORTCLS] Stub missing IoControlCode switches (#1756)
Stub missing switches: IOCTL_KS_HANDSHAKE and IOCTL_KS_METHOD.
2020-03-30 12:58:25 +02:00
Serge Gautherie
c6e854ce7b
[KERNEL32_APITEST][WS2_32_APITEST] Call SetLastError() before checking LastError (#2437)
Follow-up to cb5aa7be.
2020-03-30 12:52:37 +02:00
Bișoc George
f70e43c8f3 [APITEST][NTDLL] Initial implementation of NtSetInformationProcess() testcase
The following testcase only performs argument checks for ProcessForegroundInformation class for the moment. The testcase will be expanded with further tests when needed.
2020-03-30 13:52:15 +03:00
Serge Gautherie
724466597f [REACTOS] Remove forced _WIN32_IE defines
No impact, as already deactivated or superseded or superfluous.

Import
7770e26f2d
2020-03-30 13:47:09 +03:00
Serge Gautherie
5d393d73ad
[NTDLL_WINETEST] Remove forced 0x500 API versions (#2483)
No impact, as conditional.

Import
71d8103190
2020-03-30 12:38:47 +02:00
Serge Gautherie
07efa2ef53
[SHELL32] HCR_GetIconA(): Properly use icon_idx (#2482)
CORE-11713

Import
7cc2806e0e
2020-03-30 12:24:59 +02:00
Serge Gautherie
78d8705181
[WINMM] Add a WARN() when winejoystick.drv is missing (#2480)
Follow-up to 97150ce9.

Import
175a2a0276
2020-03-30 12:14:52 +02:00
Tibor Lajos Füzi
6020af2014
[GDI32] Allow BI_BITFIELDS compression in CreateDIBitmap (#2448)
CORE-16750, CORE-15960
2020-03-30 12:11:38 +02:00
Serge Gautherie
6e79e60883
[RPCRT4] Fix 'Routeines' typos (#2481)
Addendum to b6fdb56b9a.

Import
c73352047d

CORE-15682
2020-03-30 10:28:52 +02:00
Jérôme Gardou
5a8901130a [CMAKE] Fix symbol directory for non-MSVC builds 2020-03-30 07:54:21 +00:00
Jérôme Gardou
de369ce26b [KDGDB] Various fixes and improvements 2020-03-30 07:53:34 +00:00
Jérôme Gardou
0b5033e2ff [NTOSKRNL] Fix build 2020-03-30 07:36:30 +00:00
Eric Kohl
2125fec23a [HOTPLUG] Enable the hotplug.cpl and add the 'Safely Remove Hardware' dialog 2020-03-30 00:38:33 +02:00
Mark Jansen
177ae91bf6
[RTL] Introduce RtlpImageNtHeader,
which implements the required functionality.
ntdll and ntoskrnl now have a wrapper for this, with SEH.
This protects the function against malformed / bad images,
whilst still being able to use the code in freeldr et al.
Idea from Thomas.
CORE-14857
2020-03-29 21:27:38 +02:00
Mark Jansen
4b2665046d
[NDK] Ensure RTL_IMAGE_NT_HEADER_EX_FLAG_NO_RANGE_CHECK is available regardless of NTOS_MODE_USER being defined.
CORE-14857
2020-03-29 21:27:38 +02:00
Mark Jansen
2801a8272d
[LDR] Include source dll in static snap failure dprint 2020-03-29 21:02:31 +02:00
Andreas Maier
782ff23261
[MSV1_0] LsaApLogonUserEx2: use RtlRunDecodeUnicodeString to decode password 2020-03-28 23:27:34 +01:00
Serge Gautherie
72fa935128 [CMAKE] kernel32_winetest: Enable 'generated.c', at last
Follow-up to 20f4039666.

ROSTESTS-251
2020-03-28 20:57:16 +01:00