[RDBSS] Avoid CORE-13938

Pierre recommended this workaround for 0.4.8rls before.
Avoids "GetVolumeInformation now fails on NFS volume"

This workaround was recurrently applied for all releases
0.4.8, 0.4.9, 0.4.10, 0.4.11, 0.4.12, 0.4.13.

I never got any reply in the regression-ticket and recurrently
applying this over and over again is a waste of time.
So I decided to commit to master today, but will leave
the ticket unresolved, so when a proper fix will arrive in the future,
the existing ticket will remind us to undo this workaround.

Please note that I replaced #if 0 with #if 1
as discussed with Pierre. That's different to the patch in ticket.
This commit is contained in:
Joachim Henze 2018-02-17 20:28:15 +01:00
parent b78cb36d91
commit 45b5ec8e7b
1 changed files with 10 additions and 0 deletions

View File

@ -8319,6 +8319,16 @@ RxQueryNameInfo(
return STATUS_BUFFER_OVERFLOW;
}
#if 1 // CORE-13938, rfb: please note I replaced 0 with 1 here
if (NodeType(Fcb) == RDBSS_NTC_STORAGE_TYPE_DIRECTORY &&
RxContext->Info.LengthRemaining >= sizeof(WCHAR))
{
NameInfo->FileName[NameInfo->FileNameLength / sizeof(WCHAR)] = L'\\';
NameInfo->FileNameLength += sizeof(WCHAR);
RxContext->Info.LengthRemaining -= sizeof(WCHAR);
}
#endif
/* All correct */
return STATUS_SUCCESS;
}