Commit graph

360 commits

Author SHA1 Message Date
Giannis Adamopoulos fd209faa66 [SHELL32] CFSDropTarget: style fixes 2018-02-17 22:01:04 +02:00
Giannis Adamopoulos 4b19b1e49d [SHELL32] CDefView: remove a useless print 2018-02-17 21:40:16 +02:00
Giannis Adamopoulos 6f25b42a31 [SHELL32] CFSDropTarget: Use copy depending on the source drive
Show the default action as the default menu item in the right click menu.
2018-02-17 20:30:37 +02:00
Giannis Adamopoulos 6d91269eda [SHELL32] CFSDropTarget: Initial implementation of right click drag menu 2018-02-17 20:30:37 +02:00
Giannis Adamopoulos 8f8ab050db [SHELL32] CDefView: Implement several methods needed for drop targets
Set the view object as the site of the drop target.
Implement GetItemPosition, SelectAndPositionItems, IsDropOnSource, GetDragPoint.
Use DROPEFFECT_COPY only when the item supports it.
2018-02-17 20:30:37 +02:00
Giannis Adamopoulos 5bef945cc9 [SHELL32] Add menu resource which is used when dragging files with right click 2018-02-17 20:30:37 +02:00
Hermès Bélusca-Maïto 175e78e50f
[SHELL32] Fix COM registration of IShellFolder, IShellLinkA/W, IQueryContinue and IUserNotification classes. 2018-02-16 23:31:39 +01:00
Katayama Hirofumi MZ 338799bf8b improve SHGetFileInfo (#118)
This patch reduces failures of SHGetFileInfo function. CORE-7159
* improve WideByteToWideChar calls
* fix bugs related to file attributes and SHGFI_EXETYPE
* SHGFI_USEFILEATTRIBUTES and SHGFI_ICON fix
* s/sizeof(temppsfi)/0/
2018-02-16 11:00:08 +00:00
Serge Gautherie cd4db318d0 [D3D9][ARPING] Add missing va_start() and va_end() (#371) 2018-02-16 10:28:25 +01:00
Hermès Bélusca-Maïto fe4704fa64
[SHELL32] Implement the CUserNotification class, which implements the IUserNotification interface. CORE-13177 2018-02-15 22:38:22 +01:00
Giannis Adamopoulos 67f99833cd [SHELL32] CNewMenu: Don't use CWM_GETISHELLBROWSER.
CDefaultContextMenu: Set the site for context menu extensions
CNewMenu: Get SID_IFolderView service of the site to get the IShellView
2018-02-15 00:58:22 +02:00
Giannis Adamopoulos b97886ea9f [SHELL32] Fix the toolbar buttons in the file open dialog
CDefView: Make GetItemObject return an IContectMenu after setting itself as the site.
CDefViewBckgrndMenu: Make the inner context menu use the same site. Implement handling CMDSTR_VIEWLISTA and CMDSTR_VIEWDETAILSA.
CDefaultContextMenu: CMDSTR_VIEWLISTA and CMDSTR_VIEWDETAILSA shouldn't be handled in this class.
Fixes CORE-14327 and the two buttons that change the view mode
2018-02-15 00:23:18 +02:00
Joachim Henze e4aa45f63a [SHELL32] Fix glitch in de-DE.rc
checkbox captions are too long.
issue was introduced by 3624c5d6fd

fixes CORE-14329 for de-DE
2018-02-14 20:12:10 +01:00
Giannis Adamopoulos 111c40e012 [SHELL32] CDefViewBckgrndMenu: Fix handling string verbs.
It shouldn't be necessary for QueryContextMenu to be called before InvokeCommand.
Move retrieving the IContextMenu of the folder to the initialization of the class.
CORE-12866
2018-02-14 00:03:35 +02:00
Hermès Bélusca-Maïto eb3987e172
[SHLWAPI] Import wine commit 2c163225730e88 as addendum to the SHCreateWorkerWindowW/A fixes from commit 770bf93. 2018-02-13 22:30:59 +01:00
Mark Jansen fb7caa7452
[COMCTL32] Import wine commit 71cf0a31d99feb to fix the name column width in rapps. 2018-02-13 19:48:18 +01:00
Hermès Bélusca-Maïto 770bf93be3
[SHLWAPI] Improvements for SHCreateWorkerWindowW/A() prototypes + fix x64-bit compatibility. Sent upstream.
[SHLWAPI] Refactor the SHCreateWorkerWindowW() prototype to match its ANSI SHCreateWorkerWindowA() counterpart.

The last parameter is really to be understood as an extra window data, and not a "message result" (as it would be the case for dialog window procedure).
That is why I also remove the mention of "DWLP_MSGRESULT" in the SetWindowLongPtrW() call.
SHCreateWorkerWindowA() had it OK but SHCreateWorkerWindowW() did not.

------------------

[SHLWAPI] Make SHCreateWorkerWindowA() and SHCreateWorkerWindowW() x64-compatible.

The first parameter of these functions is a pointer to a window procedure, having a definite prototype, so employ a correct typedef WNDPROC,
which ensures both correct pointer size and parameter type enforcement.
This also ensures that we use instead a correct pointer size, since otherwise LONG remains 32-bits for Windows compatibility on x64 platforms.
The wndProc parameter is thus casted to LONG_PTR to comply with the SetWindowLongPtrA/W calls.

In SHCreateWorkerWindowW(), the last "wnd_extra" parameter should also be LONG_PTR to be able to pass 64-bit data pointer on x64 platforms.
Therefore fix also setting the wc.cbWndExtra size. One should note that the ANSI SHCreateWorkerWindowA() function had everything OK already.
2018-02-13 00:13:47 +01:00
Serge Gautherie 71ebfd8717
[OPENGLCFG] Fix a Clang-Cl warning about IDC_DEBUG_OUTPUT
"warning: use of logical '||' with constant operand [-Wconstant-logical-operand]"

CORE-14306
2018-02-10 18:04:03 +01:00
Thomas Faber c0a227d9a5
[SYSDM] Make the GPL text ASCII. CORE-14278
This is better than wasting space on null chars (and having Git mangle it).
Also ensure that it gets CRLF newlines since its contents go in the binary.
2018-02-08 00:52:41 +01:00
Luo Yufan 19737a2cb9 [TRANSLATION] Simplified Chinese translation update for NETID and PING. (#369) 2018-02-07 14:03:42 +01:00
Giannis Adamopoulos e05f08be4e [SYSSETUP] Hackfix CORE-14228
Wine's comctl32 somehow fails to load an 24bpp image with ImageList_LoadImageW
when crMask is CLR_NONE so use a color that doesn't exist in the bitmaps until
comctl32 gets fixed.

I prefer to add this silly hack in a non critical dll than make a hasty change in the
critical comctl32 until some proper tests are written for this absurd failure.
2018-02-07 02:26:28 +02:00
Giannis Adamopoulos 218b8eda92 [SYSSETUP] Don't load ISOLATIONAWARE_MANIFEST_RESOURCE_ID manually
Such a manifest is meant to be activated by the caller of the exports of the dll.
This means that the user of syssetup which is setup.exe is the one that should do the proper handling of the manifests.
Since setup.exe is the one that needs to do the right thing, add a CREATEPROCESS_MANIFEST_RESOURCE_ID to it and avoid
dealing with ISOLATIONAWARE_MANIFEST_RESOURCE_ID altogether (which is supposed to be used by activating the activation context
before calling the exports of the dll that has it). We don't really use ISOLATIONAWARE_MANIFEST_RESOURCE_ID correctly in any
place in the tree so let's rely on CREATEPROCESS_MANIFEST_RESOURCE_ID for now.

This fixes one part of CORE-14228 where no image was shown in the theme selector buttons. This happened because comctl32 was
statically linked and calling ImageList_LoadImage ended up creating an image list with comctl32 v5. Then we passed this image
list to a button created with comctl32 v6 and as a result the image list was unusable. This is yet another issue that needs
to be addressed in the future. Namely, it seems that in windows comctl32 v6 can use image lists created by comctl32 v5 whereas
we cannot.

This fix is not a hack but cleverly works around these two bugs that need to be addressed some time in the future.
CORE-14228
2018-02-07 01:15:49 +02:00
Bișoc George 7b71877676 [TRANSLATION] Romanian translation for FONTEXT and TIMEOUT (#363)
[FONTEXT]: At the moment there is a comment in the en-US.rc resource file that advises to not translate it. I only created this file as a basis for the future. The file will be updated later when there is the possibility for FONTEXT to be translated further.
2018-02-05 18:57:39 +01:00
Luo Yufan b97f0a8fed [TRANSLATION][BROWSEUI][MEDIA] Simplified Chinese translations update (#360) 2018-02-05 18:47:53 +01:00
Mark Jansen 058c2658a4 [SHELL32] CDefViewBckgrndMenu: Fix a crash when pasting on a new explorer window. 2018-02-05 17:39:32 +01:00
Thomas Faber f46b177e11
[LIBTIFF] Update to version 4.0.9. CORE-14291 2018-02-05 14:40:31 +01:00
Thomas Faber 5c0faa58cf
[LIBXSLT] Update to version 1.1.32. CORE-14291 2018-02-05 14:37:37 +01:00
Thomas Faber 5c72e50fd0
[LIBXSLT] Better highlight some ROS diffs. CORE-14291 2018-02-05 14:37:27 +01:00
Thomas Faber ef4f57579e
[LIBJPEG] Update to version 9c. CORE-14291 2018-02-05 11:51:02 +01:00
Thomas Faber df5a0b43e7
[LIBPNG] Update to version 1.6.34. CORE-14291 2018-02-05 11:51:00 +01:00
Eric Kohl e5870819a3 [SETUPAPI] Machine handles are pointers. 2018-02-04 22:03:17 +01:00
Eric Kohl 19fc20f222 [SETUPAPI] Add a proper (SEH protected) check for LOG_CONF handles 2018-02-04 20:23:51 +01:00
Eric Kohl 60a218948e [SETUPAPI] Fix the coding style, annotations and debug messages
* Fix the coding style.
* Add missing annotations.
* Add the function name to the debug messages.
* Treat all machine handles like pointers.
2018-02-04 20:16:46 +01:00
Thomas Faber b9f88d594d
[PSDK][XDK] Remove DECLSPEC_* from windef.h, protect against redefinition in winnt.h 2018-02-04 19:28:36 +01:00
Adam Słaboń 0d838f40a3 [TRANSLATION] Polish translation update (#357) 2018-02-04 18:45:20 +01:00
Hermès Bélusca-Maïto 131678a025
[SHELL32] Rewrite the wrapping code for shell taskbar notifications.
- Introduce the TRAYNOTIFYDATAW structure, as documented by Geoff
  Chappell in "WM_COPYDATA for Taskbar Interface", at
  http://www.geoffchappell.com/studies/windows/shell/shell32/api/shlnot/copydata.htm
  that is the data structure passed between shell32 and explorer for
  communicating shell notify icon information.

- In Shell_NotifyIcon(), correctly capture the (ANSI and) UNICODE
  structures provided by the caller, properly taking into account for
  the different NOTIFYICONDATA structure sizes existing out there.
  The different strings are now properly null-terminated (especially
  szTip if it needs to be truncated out), and the flags validated.

- Remove the now unneeded "SHELL_NotifyIcon()" helper function.

[EXPLORER] Use TRAYNOTIFYDATAW and adjust the callers.
2018-02-04 18:11:50 +01:00
Hermès Bélusca-Maïto 4207397963
[STOBJECT] Don't hardcode variable type in sizeof. 2018-02-04 18:11:49 +01:00
Hermès Bélusca-Maïto e2c6c3cfc7
[BROWSEUI] Shut a warning down ("windef.h(121) : warning RC4005: 'DECLSPEC_IMPORT' : redefinition" when compiling the resource). 2018-02-04 18:11:47 +01:00
Eric Kohl 65d3bf7482 [SETUPAPI] Fix the coding style, add annotations and fix the debug messages. 2018-02-04 15:41:13 +01:00
Thomas Faber 25bca520f5
[MBEDTLS] Don't link with zlib, we don't use it. CORE-14290 2018-02-04 12:54:44 +01:00
Eric Kohl c7fc2ef4d2 [SETUPAPI] Update some more functions to the current coding style, add annotations and add function names to the TRACE calls. 2018-02-04 11:17:30 +01:00
Hermès Bélusca-Maïto 5de33ab010
[STOBJECT] Revert b7c3398 because it was not the cause of the original problem I wanted to fix (notify structure not completely zeroed-out on the receiver side of the notification). 2018-02-04 02:23:28 +01:00
Hermès Bélusca-Maïto b7c3398f95
[STOBJECT] Fully zero-out the full NOTIFYICONDATA structure (it wasn't zeroed out correctly in MSVC build). 2018-02-04 01:57:02 +01:00
Hermès Bélusca-Maïto af4bdd4388
[NETSHELL] Don't use hardcoded values. 2018-02-04 01:56:59 +01:00
Hermès Bélusca-Maïto 5ecabcce59
[SHELL32] Fix copy-pasta. 2018-02-04 01:56:56 +01:00
Luo Yufan a13c998183 [TRANSLATION] Simplified Chinese translations updated. (#348) 2018-02-01 02:50:29 +01:00
Stanislav Motylkov 63ad8a71c0 [IPHLPAPI] Fix IcmpSendEcho output when host is not reachable
- Add missing error code to DDK/NDIS
- Fix error code in IP driver
- Patch MSAFD to reply correct WSA error code
- Fix IcmpSendEcho function
  - Fix returning error code in ICMP_ECHO_REPLY (see MSDN)
  - Fix returning host address (using GetBestInterface and GetIpAddrTable functions)
- Fix GetBestRoute function (it is used by GetBestInterface)

Relates to #318 and CORE-14241
2018-01-31 17:28:21 +00:00
Stanislav Motylkov 3624c5d6fd [SHELL32] Fix file and folder properties dialogs
CORE-12755
2018-01-31 18:25:14 +01:00
Doug Lyons 912434849f
[TIMEDATE] Correctly set the time when using the "Update now" button. CORE-14167 2018-01-31 11:51:08 +01:00
Thomas Faber 682735fb56
[SHELLMENU] Add missing psdk dependency. 2018-01-31 11:48:37 +01:00