Commit graph

54571 commits

Author SHA1 Message Date
Alex Ionescu a8e4859598 [NPFS-NEW]: Multiple code fixes to almost all code paths. Mainly a collection of small bugs, structural errors, logic flaws, off-by-ones, etc. But they were enough to make the driver essentially useless. Now Thomas's kmtests NpfsCreate and NpfsConnect return absolutely zero failures. On to NpfsReadWrite....
svn path=/trunk/; revision=60027
2013-09-11 02:04:17 +00:00
Amine Khaldi f2664a3227 [ADVPACK_WINETEST]
* Sync with Wine 1.7.1.

svn path=/trunk/; revision=60026
2013-09-11 00:08:28 +00:00
Amine Khaldi 8516d91fba [ADVPACK]
* Sync with Wine 1.7.1.

svn path=/trunk/; revision=60025
2013-09-11 00:07:58 +00:00
Amine Khaldi 2d51bcc269 [CREDUI]
* Move the resource files to the appropriate folders.

svn path=/trunk/; revision=60024
2013-09-10 23:38:33 +00:00
Amine Khaldi 2f66f47d0c [DDK]
* Annotate swenum.h.

svn path=/trunk/; revision=60023
2013-09-10 23:31:39 +00:00
Amine Khaldi 54f807af0c [WINE/TEST]
* Add winetest_{get,add}_failures().

svn path=/trunk/; revision=60022
2013-09-10 23:30:54 +00:00
Amine Khaldi 1abc05ae78 [NTOSKRNL]
* Fix the locking in MiQueryBasicInformation to cover ARM3 too, not just RosMm. This makes sure we don't change the address space while querying it (or vice-versa).
* Don't attempt to query information for a terminated process (fixes some kernel32 loader winetests, matches Windows behavior).
* Brought to you by Alex Ionescu.

svn path=/trunk/; revision=60021
2013-09-10 22:21:52 +00:00
Amine Khaldi a56630f977 [DDK]
* Annotate ntddpcm.h and apply some formatting consistency to it.

svn path=/trunk/; revision=60020
2013-09-10 22:20:09 +00:00
Amine Khaldi 074c447003 [AVIFIL32]
* Move the resource files to the lang folder.

svn path=/trunk/; revision=60019
2013-09-10 22:17:59 +00:00
Kamil Hornicek 0baa230380 [CALC]
Fix two more misaligned buttons in Czech resources.

svn path=/trunk/; revision=60018
2013-09-10 22:10:14 +00:00
Hermès Bélusca-Maïto ec9cdf3b8a [CSR]: Fix header information ;)
svn path=/trunk/; revision=60017
2013-09-10 22:06:25 +00:00
Amine Khaldi 0fdb692a1f [NTOSKRNL]
* Return the proper status when we attempt to illegally commit non-ARM3 section. We hit this assert with some kernel32 winetests (mainly loader and virtual). Brought to you by Alex Ionescu.

svn path=/trunk/; revision=60016
2013-09-10 21:57:52 +00:00
Hermès Bélusca-Maïto 961f5fcef6 [ADVAPI32]
Use a correct control pipe sharing policy.

svn path=/trunk/; revision=60015
2013-09-10 21:38:15 +00:00
Hermès Bélusca-Maïto e7603b96f7 [USERENV][USER32]
Use a correct return variable for RtlCreateUnicodeStringFromAsciiz. Advice: read the documentation before using functions...

svn path=/trunk/; revision=60014
2013-09-10 21:26:37 +00:00
Eric Kohl 13abedbf7a [LSASRV]
- Allocate buffers for account and domain names in the well-known sid list instead of using pointers to strings.
- Add a string load routine and convert all hard-coded SID names to resources.
A german translation will follow soon.

svn path=/trunk/; revision=60013
2013-09-10 21:20:22 +00:00
Hermès Bélusca-Maïto 179f3eb806 [BASESRV]
- Fix header formatting plus windows headers inclusion.
- RtlCreateUnicodeString returns booleans, not ntstatuses, so fix the code appropriately.

svn path=/trunk/; revision=60012
2013-09-10 20:45:53 +00:00
Thomas Faber f50a1754a6 [CMAKE]
- Correctly escape error message. Spotted & tested by David Quintana

svn path=/trunk/; revision=60010
2013-09-10 20:06:05 +00:00
Thomas Faber 3ae1db0c81 [KERNEL32]
- Improve a DPRINT in CreateProcessInternalW. Patch by Víctor Martínez Calvo
CORE-7452 #resolve

svn path=/trunk/; revision=60009
2013-09-10 17:12:21 +00:00
Daniel Reimer ecfb4a3bf3 Woops, modified the Description to be a bit more helpful.
svn path=/trunk/; revision=60008
2013-09-10 16:59:13 +00:00
Amine Khaldi ac467dd40b [NTDLL_WINETEST]
* Sync with Wine 1.7.1.

svn path=/trunk/; revision=60007
2013-09-10 16:49:44 +00:00
Daniel Reimer 515b54ee2a Commit some Rapps Database regarding patches.
CORE-7312 #resolve #comment Committed in r60006. Thank you.
CORE-7352 #resolve #comment Committed in r60006. Thank you.
ROSAPPS-284 #resolve #comment Committed in r60006. Thank you.
ROSAPPS-283 #resolve #comment Committed in r60006. Thank you.

svn path=/trunk/; revision=60006
2013-09-10 16:49:30 +00:00
Amine Khaldi 5301954920 [PSDK]
* Import Wine's (broken) winioctl.h.
* Remove FILE_FS_VOLUME_INFORMATION from winternl.h. It doesn't belong there.
[NTDLL_WINETEST]
* Be more specific about winioctl.h inclusion.

svn path=/trunk/; revision=60005
2013-09-10 16:39:37 +00:00
Amine Khaldi 5d8d612453 [USER32]
* Be more specific about the commctrl.h inclusion.
* We no longer need to add include/reactos/wine as a global inclusions folder.

svn path=/trunk/; revision=60004
2013-09-10 16:28:05 +00:00
Pierre Schweitzer bd3ccd4826 [NTOSKRNL]
Fix string size to store GPT GUIDs.
This was causing a buffer overflow (with ending null char) and thus a stack corruption.
The side effect of the stack corruption was that the debug code (display) was looping
forever while attempting to read partition table making ntoskrnl unable to boot with
a machine where there's a GPT disk.
Kernel is now able again to handle GPT disks (and they can be used again in user-land).

This was magically hidding before r59923 or by disabling NDEBUG. Lovely Heisenbugs :-).

svn path=/trunk/; revision=60003
2013-09-10 13:42:34 +00:00
Alex Ionescu 36f1e2f5d1 [NTOSKRNL]: Implement ExAllocatePoolWithQuotaTag. However PsChargeProcessPoolQuota is still unimplemented so nothing really gets charged (we do write the owner process, though).
svn path=/trunk/; revision=60002
2013-09-10 10:02:27 +00:00
Alex Ionescu 144100a4e2 [CSRSRV]: Update CSR_SERVER_DLL definition to Server 2003 instead of XP. Get rid of the whole initialization event stuff. This should make Windows CSRSS+CSRSRV work with our BASESRV. Thanks to Hermes for discovering there was a structure issue.
svn path=/trunk/; revision=60001
2013-09-10 08:55:09 +00:00
Alex Ionescu 5492bdcde2 For our 60000th commit, I bring you a complete rewrite of the Named Pipe File System. It is not yet "active", but I consider this to now be largely code complete and worthy of the prize (and I didn't want to delay other commiters any further). Once the code is reviewed, fixed, tested, and commented, it will replace our old and aging NPFS. This driver is cross-compatible with Windows Server 2003. It is expected to fix winetest incompatiblities, speed up performance, and reduce bizare RPC/SCM issues. This commit is dedicated to my best friend Rachel, who has not only always been there for me, but was also the motivating factor behind my return to my passion -- ReactOS :)
[NPFS-NEW]: Implement QueryVolume, QuerySecurity, SetSecurity. Everything but Directory Query, Fast I/O, and a few rare FSCTLs is implemented now. The former two will come in an upcoming commit.
[NPFS-NEW]: Major cleanup in the way some member variables were being addressed. Reference them as array members based on the correct FILE_PIPE defines from now on. Also fix a lot of formatting issues. Fix a bunch of bugs that were found. Use FILE_PIPE_SERVER_END and FILE_PIPE_CLIENT_END intead of a BOOLEAN. Use TRUE/FALSE/STATUS_SUCCESS/NULL/etc when needed intead of 0/1. The code formatting can/should still be improved, but this was a big help.

svn path=/trunk/; revision=60000
2013-09-10 08:36:25 +00:00
Alex Ionescu 3dfdce74d8 [NPFS-NEW]: Implement Close, Cleanup, Disconnect, Flush, Listen, Peek, SetInfo, Transceive, Wait, Write. Only QueryInfo remains as critical functionality to support the Kernel32 APIs. Code is WIP, untested, and ugly! But it is now 90% complete. r60000 should hopefully finalize the implementation. As long as I didn't forget a file :)
svn path=/trunk/; revision=59999
2013-09-10 02:23:32 +00:00
Alex Ionescu b5edd2ce20 [NPFS-NEW]: Add data queue management routines, and add read support. Implement NpFsdRead & NpfsCommonRead (Peek is inherently implemented too, just didn't write the FSCTL handlers yet). Next up will be Write/Peek/Close/Cleanup. Code is WIP.
svn path=/trunk/; revision=59998
2013-09-09 01:16:06 +00:00
Daniel Reimer 2976384615 Update Rapps Database to most recent versions.
svn path=/trunk/; revision=59997
2013-09-08 10:34:18 +00:00
Amine Khaldi 73ca298c46 [NPFS_NEW]
* Beginnings of windows-compatible NPFS driver. Still rough WIP, supports CreateNamedPipe and Create IRPs for now only. This is mainly to lay out all the structures (VCB, DCB, FCB and CCB). Work on read/write (and hence data queue management) is next. Brought to you by Alex Ionescu.

svn path=/trunk/; revision=59996
2013-09-07 15:32:29 +00:00
Thomas Faber 903ab584cf [KERNEL32]
- Fix LoaderLock assert in TerminateThread. Spotted by Amine

svn path=/trunk/; revision=59992
2013-09-04 19:53:59 +00:00
Amine Khaldi 37c514e37f [README.WINE]
* Update bcrypt and clusapi sync states.

svn path=/trunk/; revision=59989
2013-09-04 15:28:22 +00:00
Amine Khaldi 183255b1d4 [JSCRIPT]
* Move the resource files to the lang folder.

svn path=/trunk/; revision=59988
2013-09-04 12:27:18 +00:00
Alex Ionescu d32d9c72da [USER32]: Remove another stack check. Should fix ole32 marshall tests.
svn path=/trunk/; revision=59987
2013-09-04 11:08:43 +00:00
Amine Khaldi d336165578 [MSHTML]
* Move the resource files to the lang folder.

svn path=/trunk/; revision=59986
2013-09-04 10:01:30 +00:00
Alex Ionescu 02cb040946 This commit, in my opinion, marks an important milestone in ReactOS development. One is now able to boot to desktop, launch applications, download through the application manager, play solitaire, minesweeper, launch Task Manager, etc... by using an unmodified Windows 2003 kernel32.dll binary (and, until our NPFS driver is fixed, the unmodified Windows 2003 NPFS driver). Additionally, one is able to achieve the same by booting with an unmodified Windows 2003 ntdll.dll, including a combination of both. The capability to mix-and-match components such as kernel32 and ntdll, at the heart of the system, will allow to better understand apitest failures (just as Wine has long had the capability to use Windows DLLs instead). With these two building blocks, additional Windows 2003 DLLs can be dropped in/tested, etc, and where failures are seen, a likely component can now be blamed. Furthermore, debugging with public symbols for these DLLs is now possible with WinDBG (in fact, this is how many bugs were fixed in this attempt). Many issues already exist when running with this combination FYI, for example, I was not able to launch any installers (tested Firefox and MIRC). This already demonstrates either missing functionality or ReactOS-specific functionality in components which depend on kernel32. I suspect the next step is infrastructure work to get special patchbot/builders to try and report back winetest results, and for additional DLLs to be "ported"/made to work. On a final note, this mixing and matching has benefits on both ends -- it's now likely that ReactOS' ntdll can run on Server 2003, at least far enough to get to Explorer or Task Manager. Running apitests on Server 2003 with and without reactos DLLs should also easily identify if certain DLLs are directly to blame for certain regressions/failures. </end excited rant>
[BASESRV]: Allocate the INI mappings from the right heap.

svn path=/trunk/; revision=59985
2013-09-04 07:28:15 +00:00
Alex Ionescu 4edf5167a4 [BASESRV]: Add INIFILE_MAPPING structures, and set a valid IniFileMapping pointer in the shared static data. Windows' kernel32 needs this whenever an INI API is called, which is why UserInit was crashing on load (our pointer was set to NULL). Now userinit.exe loads/works, and explorer.exe is the one that fails to initialize. But one can CTRL-ALT-DEL and launch Task Manager (works!), Calc (but not Notepad).
svn path=/trunk/; revision=59984
2013-09-04 07:07:08 +00:00
Alex Ionescu fb738a2fab [BASESRV]: Fix inverted definition of BASE_CREATE_THREAD. Now Windows' kernel32.dll can create threads :) And so RPC now works, and services.exe + all the services now initailize and run correctly. userinit.exe now dies with 0xC0000005.
svn path=/trunk/; revision=59983
2013-09-04 05:06:19 +00:00
Alex Ionescu f5f5edbd4a [KERNEL32]: Enable guard pages for Win32 threads too, not just native threads (replicated the changes I made to RtlpCreateStack).
svn path=/trunk/; revision=59982
2013-09-04 04:47:02 +00:00
Amine Khaldi e371890058 [COMCTL32]
* Move the resource files to the lang folder.

svn path=/trunk/; revision=59980
2013-09-03 22:44:37 +00:00
Hermès Bélusca-Maïto 6848a97d66 Fix much more fonts (the reverse exclamation point and the block 0xb2 in particular, as well as the æ character).
svn path=/trunk/; revision=59979
2013-09-03 20:19:24 +00:00
Amine Khaldi 7a2b05f8d4 [TRANSLATIONS]
* Improve Russian localization. Patch by Alex Gorgurov based on the work of jperm (jaroslaff111 @at@ mail .dot. ru).
CORE-7381 #resolve #comment Committed in r59977. Thank you all.

svn path=/trunk/; revision=59978
2013-09-03 17:07:25 +00:00
Amine Khaldi 87691cdeae [PSDK]
* Annotate wincred.h.

svn path=/trunk/; revision=59977
2013-09-03 13:15:35 +00:00
Amine Khaldi 3c3723d278 [VGAFONTS]
* Correct AD and B2 characters of codepage 437. By Erdem Ersoy.
CORE-7432 #resolve #comment Committed in r59976. Thanks.

svn path=/trunk/; revision=59976
2013-09-03 12:56:00 +00:00
Amine Khaldi da6d22538a [KERNEL32]
* "Fix" the VS build when the default code page is a MBCS (Chinese version). For some reasons, the MSVC resource compiler ignores the #pragma code_page inside the included nls files. Brought to you by Yuntian Zhang.
CORE-7420 #resolve #comment Committed in r59975. Cheers.

svn path=/trunk/; revision=59975
2013-09-03 12:44:48 +00:00
Amine Khaldi 8bf355bf88 [SHELL32]
* Improve the German translation, fix the position of some new strings that are larger than English originals and fix some formatting. By Robert Naumann.
CORE-7440 #resolve #comment Committed in r59974. Thanks.

svn path=/trunk/; revision=59974
2013-09-03 12:32:48 +00:00
Amine Khaldi 962e2b35b9 [DDK]
* Annotate scsiwmi.h.

svn path=/trunk/; revision=59973
2013-09-03 12:04:47 +00:00
Amine Khaldi 62b8ac070f [SMSS]
* Fix some print specifiers.

svn path=/trunk/; revision=59972
2013-09-03 12:02:52 +00:00
Amine Khaldi 1a96516805 [PSDK]
* Fix a typo.

svn path=/trunk/; revision=59971
2013-09-03 11:59:51 +00:00