Comment that part too, because it was in KdPortInitialize and here, it reported an invalid port. KdPortInUse is initialized by KDBG.
svn path=/branches/kd++/; revision=58957
- Fix some function parameter types, so to avoid unuseful casts (from pointers to const strings to pointers to strings in particular).
- The big thing: make FreeLdr load personalized Kernel Debugger Transport DLLs by reading at the kernel command line and interpreting the /DEBUGPORT=xxx entry (--> loads KDxxx.DLL dll in \SystemRoot\System32\).
So now, we can not only load the "default" kdcom.dll, but also 3rd-party ones such as kdbazis.dll from VirtualKD.
Read http://www.nynaeve.net/?p=173 for a trick I used :
"[...] Another enhancement that could be done Microsoft-side would be a better interface for replacing KD transport modules. Right now, due to the fact that ntoskrnl is static linked to KDCOM.DLL, the OS loader has a hardcoded hack that interprets the KD type in the OS loader options, loads one of the (hardcoded filenames) "kdcom.dll", "kd1394.dll", or "kdusb2.dll" modules, and inserts them into the loaded module list under the name "kdcom.dll". [...]".
svn path=/branches/kd++/; revision=58902
The idea then would be to have the following behaviour (when specifying the following options in the kernel command line):
/DEBUGPORT=COMi --> load KDCOM.DLL and use COMi port (i == 1,2,3,4) if possible.
/DEBUGPORT=FOO --> load KDFOO.DLL (useful for KDUSB.DLL, KD1394.DLL, KDBAZIS.DLL for VirtualKD, etc...)
/DEBUGPORT=ROSDBG:[COMi|SCREEN|FILE|GDB|...] --> load KDROSDBG.DLL which contains the ROS kernel debugger, and use COMi or SCREEN or... as output port.
svn path=/branches/kd++/; revision=58883
- turkish translation update by Erdem Ersoy: CORE-7025,CORE-7032,CORE-7033,CORE-7034,CORE-7071;
- italian translation update by Paolo Devoti: CORE-7122;
- use the same notepad caption title as in Windows 2003 for AHK test compatibility, patch by Edijs Kolesnikovics: CORE-7023;
- added polish translation of samsrv and wlanconf, updated polish translation of rapps, msgina, consrv, console and desk;
- convert msgina to compile resources for a defined language;
svn path=/trunk/; revision=58882
- Use SHELL_LINK_HEADER instead of defining a local structure. Patch by Dominik Hornung (dominikhornung at gmx dot de).
CORE-7099
svn path=/trunk/; revision=58881
- Add tests for ZwAllocateVirtualMemory, ZwCreateSection, ZwMapViewOfSection. Patch by Nikolay Borisov (nib9 at aber dot ac dot uk).
- Some tests are currently skipped because they crash or assert on ROS: See ROSTESTS-107, ROSTESTS-108, ROSTESTS-109, ROSTESTS-110.
ROSTESTS-105 #resolve
svn path=/trunk/; revision=58874
- Implement a mechanism for kmtests to retrieve information from user-mode. Patch by Nikolay Borisov (nib9 at aber dot ac dot uk).
- Currently supported function: QueryVirtualMemory
ROSTESTS-96 #resolve
svn path=/trunk/; revision=58873
- Rework FsRtlExpression test to be more maintainable by using a table. Patch by Víctor Martínez Calvo, a few comments by me.
CORE-7108 #resolve
svn path=/trunk/; revision=58864
* Account for the asm source files in all the HAL flavors. Should fix compiling them with VS (which regressed recently).
svn path=/trunk/; revision=58862
- Apply changes from http://code.reactos.org/cru/CR-30
- If an event object already exists, CreateEvent returns a valid handle to it. So that, if the returned handle is NULL, then automatically we are sure that it doesn't exist. Therefore remove unneeded checks.
svn path=/trunk/; revision=58856
- Handle VME for the PUSHF and POPF instruction in virtual mode
- There is no reason to set interrupt flag when handling POPF
- Fix a typo in POPF case : mask out the right variable
See http://www.rcollins.org/articles/vme1/ for reference
svn path=/trunk/; revision=58852
* Make sure that BaseAddress is at 64-k boundary in NtMapViewOfSection(). Fixes a couple NtMapViewOfSection tests.
* Brought to you by Zhan Jianyu (aka larmbr) with review and improvement by Timo.
CORE-7118 #resolve #comment A slightly improved fix was committed in r58851. Thanks ;)
svn path=/trunk/; revision=58851
- Apply similar fixes as in 58848 to RtlGetElementGenericTable (no need to make too fancy predecrements if they work incorrectly in this case when do/while loops were unnecessary at all).
svn path=/trunk/; revision=58850
- Do not set result variable NodeOrParent in RtlpFindGenericTableNodeOrParent in case the generic table is empty, just returning TableEmptyTree is enough.
- Fix improper enumeration of generic tables nodes. The way they were done previously clearly shows that noone was actually testing these APIs and a simple mistake (do/while instead of while loop) led to a NULL pointer access. Thanks to Pierre for developing MCB tests which revealed this problem.
Rephrasing Vladimir Lenin: "Test, test and again test!"
svn path=/trunk/; revision=58848
Reimplement (yes, once more...) all the DOS wildcards in FsRtlIs*InExpression().
This time with a better understanding of MSDN (doc can be sometimes quite cryptic...).
Which means that now the functions are passing all the tests and are even simpler.
svn path=/trunk/; revision=58847