Hermès Bélusca-Maïto
be19fda765
[SHELL32] Remove some trailing spaces; use explicitly global namespace for some functions.
2019-12-29 16:14:33 +01:00
Hermès Bélusca-Maïto
d967b5aa25
[BROWSEUI] Remove useless RegenerateUserEnvironment() call.
...
[SHELL32] Call RegenerateUserEnvironment() in WM_SETTINGCHANGE handler **ONLY** when lParam points to the L"Environment" string.
CORE-15147
2019-12-29 16:14:26 +01:00
Hermès Bélusca-Maïto
1ee511a10c
[SHELL32] Fix MSVC warning warning C4390 by adding a bit more debug info.
2019-12-25 19:02:48 +01:00
Hermès Bélusca-Maïto
16f64a9533
[SHELL32] Improve the displayed error on file copy / displacement + simplify code.
...
Also update the corresponding french translations, see CORE-16572.
And fix a regression introduced in 257e7307
that allowed again copying
or moving a directory into its sub-tree...
I also personally think that these checks must also be done within the
copy_files() / move_files() helpers instead?
2019-12-24 18:30:54 +01:00
Bișoc George
8ec05f5fa1
[SHELL32] Do not return -1 if a file is not valid or not found - ExtractIconEx() ( #2113 )
...
ExtractIconEx() returns the number of successfully extracted icons from a file. The routine may return 0 in case no icons could be extracted but it could also return 0 if the file is not a valid PE image file or the file couldn't be found.
PrivateExtractIcons and the internal USER32 routine, ICO_ExtractIconExW(), return -1 in such scenarios. The behaviour is correct however we do not want that ExtractIconEx() returns -1 as well as it doesn't comply with the general documentation. In such cases, simply return 0 as no successful icons have been extracted due to related file failures.
CORE-16535
2019-12-12 08:24:20 +09:00
Katayama Hirofumi MZ
257e7307b4
[SHELL32] Fix hung-up of shell32:shlfileop ( #2136 )
...
#2085 caused some failures and hung-up in shell32:shlfileop testcase. This PR will fix it.
CORE-16546
2019-12-08 07:58:14 +09:00
Katayama Hirofumi MZ
2fad488a85
[SHELL32] Add 'm_' prefix to CFSFolder members ( #2129 )
...
CORE-7585
2019-12-05 05:35:25 +09:00
Katayama Hirofumi MZ
c082d08cf3
[SHELL32] Delete unused CNewMenu::m_wszPath
2019-12-03 13:46:35 +09:00
Katayama Hirofumi MZ
364e22fa14
[SHELL32] Improve Japanese translation
2019-12-02 07:03:18 +09:00
Katayama Hirofumi MZ
b582d6ff45
[SHELL32] Improve and fix SendTo ( #2122 )
...
Because of timing of SendTo folder initialization, SendTo My Documents didn't work well.
Now My Documents item is working well. CORE-12562
2019-12-02 04:06:20 +09:00
Shy Zedaka
b6743016f7
[TRANSLATION] Some Hebrew Translation for Shell32 ( #2121 )
2019-12-01 19:30:48 +01:00
Katayama Hirofumi MZ
f1bc04d7e6
[SHELL32][ZIPFLDR] Implement SendTo ZIP folder ( #2118 )
...
Follow-up of #2114 .
- s/Creater/Creator/
- Add an empty file in the SendTo folder.
- Trick.
CORE-16495
2019-12-02 02:26:34 +09:00
Jose Carlos Jesus
62a95e4943
[TRANSLATION] Update Portuguese translation ( #2115 )
2019-12-01 10:14:13 +01:00
Katayama Hirofumi MZ
79d21f7664
[SHELL32] Fix regression of DoCreateSendToFiles
...
CoInitializeEx/CoUninitialize added.
CORE-12562
2019-12-01 13:55:43 +09:00
Katayama Hirofumi MZ
0e2bb5b0b8
[SHELL32] Validate file operation ( #2085 )
...
- Support FOF_RENAMEONCOLLISION flag of SHFileOperationW.
- Add validate_operation function and use it in SHFileOperationW.
CORE-10225
2019-11-30 15:36:16 +09:00
Katayama Hirofumi MZ
5734570a15
[BOOT][SHELL32][INCLUDE] Support 'SuperHidden' files ( #2102 )
...
PR #2101 shows desktop.ini files on Desktop. I want to hide them.
- Add "ShowSuperHidden" setting to Explorer.
- Add SHCONTF_INCLUDESUPERHIDDEN flag.
- Support SHCONTF_INCLUDESUPERHIDDEN in Explorer.
CORE-10045
2019-11-29 15:14:18 +09:00
Katayama Hirofumi MZ
2c272a9017
[SHELL32] Add desktop.ini more to some folders ( #2101 )
...
Provides special icons for special folders by adding desktop.ini. CORE-10045
2019-11-29 14:40:04 +09:00
Katayama Hirofumi MZ
5538facfdd
[SHELL32] Add SendTo DeskLink (Retry) ( #2099 )
...
CORE-12562
2019-11-27 20:09:19 +09:00
Jared Smudde
30e0c2430d
[SHELL32] Disable all controls during format and re-enable after format is complete. ( #2098 )
2019-11-27 09:18:50 +01:00
Katayama Hirofumi MZ
cfdbccf937
[SHELL32] Follow-up of #2076 ( #2091 )
...
Fix EXE and SCR file icons. CORE-16533
2019-11-26 21:45:58 +09:00
Katayama Hirofumi MZ
bd25333e24
[SHELL32] Make SHFormatDrive multi-thread ( #2080 )
...
CORE-12756
2019-11-26 18:26:25 +09:00
Katayama Hirofumi MZ
cd75a87cfd
[SHELL32] Improve DragEnter of CFSDropTarget ( #2073 )
...
Reduce failures of DragDrop testcase. CORE-11238
2019-11-26 17:34:24 +09:00
Katayama Hirofumi MZ
399854ce31
[SHELL32] Set default exe icon ( #2076 )
...
The default icon of an exe file was empty if no icon available from exe.
CORE-10480
2019-11-24 19:26:32 +09:00
Katayama Hirofumi MZ
a2d5a5c301
[SHELL32] Add SVG files of 'Rename' icon ( #2084 )
...
@milawynsrealm has provided the source of 242.ico as svg files. CORE-11736
2019-11-23 14:18:20 +09:00
Katayama Hirofumi MZ
a4deb3f8f1
[SHELL32] Change icon of SendTo My Documents ( #2083 )
...
Follow-up of #2027 . CORE-16496
2019-11-23 14:10:13 +09:00
Katayama Hirofumi MZ
9e20604a5f
[SHELL32] Add Tango icons download URL ( #2079 )
...
Add a download URL for referencing source. CORE-11736
2019-11-22 23:52:35 +09:00
Serge Gautherie
0f92924a99
[REACTOS] Use explicit StringCb*W() ( #2069 )
2019-11-21 00:47:06 +01:00
Katayama Hirofumi MZ
79b030219f
[SHELL32] Improve icon selection upon right click ( #2063 )
...
If the Right-Clicked item is not being selected, then reset the selection and select the Right-Clicked item. CORE-16519
2019-11-20 20:37:57 +09:00
Katayama Hirofumi MZ
aedba8441a
[SHELL32] Improve UI of drive formatting ( #2048 )
...
- Add stub window (StubWindow32) to the drive formatting dialog to avoid locked.
- Separate the thread of drive formatting.
- Move CStubWindow32 codes.
CORE-12756
2019-11-20 10:00:26 +09:00
Joachim Henze
dc047f9630
[BROWSEUI][SHELL32] Fix scroll to selection CORE-16504
...
A patch by Katayama Hirofumi MZ
The bug was unhidden by
0.4.14-dev-312-g
b931f643e3
2019-11-17 02:04:27 +01:00
Katayama Hirofumi MZ
8f129932dd
[SHELL32] Simply return S_OK if *pdwEffect is none ( #2039 )
...
IDropTarget::DragEnter must simply return S_OK if *pdwEffect == DROPEFFECT_NONE. CORE-11238
2019-11-15 18:02:06 +09:00
Katayama Hirofumi MZ
90c63d12a1
[SHELL32][BOOTDATA] Implement Command Prompt here ( #2029 )
...
Add "Command Prompt here" menu item to the Right-click menu of normal folders and drives. Currently, this menu item doesn't work correctly because of the bug of pushd. CORE-12150
2019-11-14 23:25:21 +09:00
Katayama Hirofumi MZ
d037003511
[SHELL32] Add SendTo My Documents ( #2027 )
...
If SendTo folder is empty in SHGetFolderPathAndSubDirW function, then add a shortcut file linked to My Documents. CORE-16496
2019-11-12 16:54:28 +09:00
Katayama Hirofumi MZ
c0f340bca5
[SHELL32] Implement 'Open file location' of shortcut files ( #2028 )
...
"Open file location" is a feature to open the location of the target of a shortcut file.
Ideally we should probably use SHOpenFolderAndSelectItems here, but that is not 100% implemented in ros yet... CORE-12770
2019-11-12 16:47:36 +09:00
Katayama Hirofumi MZ
3b2ead064f
[SHELL32] Follow up of #2021 ( #2022 )
...
- Delete IObjectWithSite interface.
- Use PIDLIST_ABSOLUTE and PITEMID_CHILD rather than LPITEMIDLIST.
- Move CLSID_SendToMenu to shlguid_undoc.h.
- Delete unnecessary codes.
CORE-12562
2019-11-11 00:37:23 +09:00
Katayma Hirofumi MZ
4a1cd04501
[SHELL32] Improve Japanese translation
2019-11-09 19:57:51 +09:00
Pierre Schweitzer
15a703503e
[SHELL32] Update French translation
...
CORE-12562
2019-11-09 10:19:10 +01:00
Katayama Hirofumi MZ
5308a606dc
[SHELL32] Initial SendTo implementation ( #2021 )
...
This PR will realize SendTo feature. Initially, there is no file in SendTo folder (displayed as "(None)"). If you added some shortcut files, then SendTo shows some menu items.
- Copy, Move, and Link are working.
- Added icons.
CORE-12562
2019-11-09 08:08:40 +09:00
Mark Jansen
1f362c1a5a
[SHELL32] CDefaultContextMenu: Don't render a medium just to query if it is present
2019-10-20 17:10:12 +02:00
Mark Jansen
e45beb55f8
[SHELL32] CDefaultContextMenu: Always add the wanted operation to the IDataObject
2019-10-20 17:10:12 +02:00
Mark Jansen
c31327114b
[SDK][SHELL32] Augment the internally used IDataObject with some extra formats
...
This is needed because our code seems to use CF_HDROP a lot, instead of HIDA...
2019-10-20 17:10:12 +02:00
Mark Jansen
f9d3c2c608
[SHELL32] Mark an unexpected failure as unexpected
2019-10-20 17:10:11 +02:00
Mark Jansen
75cabb07be
[SHELL32] Properly release an StgMedium
2019-10-20 17:10:11 +02:00
Mark Jansen
730a99c860
[SHELL32] Update CDataObject,
...
allowing it to accept new formats and behave a bit more like windows
2019-10-19 18:42:15 +02:00
Mark Jansen
5d54b65ceb
[SHELL32] Add support for custom View objects defined with UICLSID
...
CORE-16271
2019-10-19 18:42:15 +02:00
Mark Jansen
5d7ae44059
[SHELL32] Demote an ERR to WARN
2019-10-19 18:41:52 +02:00
Mas4hmad
f84bd4f393
[TRANSLATION] Add/Update Indonesian translations ( #1904 )
...
Add/Update Indonesian translations for CHARMAP, CMDUTILS-HELP, SERVMAN, SETUPAPI, SHELL32, SUBST, SYSSETUP, TASKMGR, USERINIT.
2019-10-08 17:03:14 +02:00
Thomas Faber
a66bee2837
[SHELLFOLDERS] Gracefully handle NULL pidl in CDrivesFolder::BindToObject. CORE-16403
...
Fixes one of many crashes in shell32_winetest:shlfolder.
2019-09-29 12:42:26 +02:00
Thomas Faber
be1f95527a
[SHELL] IPersistIDList/IShellLink use P(C)IDLIST_ABSOLUTE. CORE-16385
2019-09-29 12:09:39 +02:00
Thomas Faber
b2992e7a5e
[SHELL] IShellExtInit::Initialize uses PCIDLIST_ABSOLUTE. CORE-16385
2019-09-29 12:09:02 +02:00