Commit graph

61 commits

Author SHA1 Message Date
Jose Carlos Jesus 23cd14d78b
[SHELL32] Move error message to rc files so can be translated (CORE-18786) (#4997)
CORE-18786
2023-02-23 09:43:53 +09:00
Stanislav Motylkov 43ecf7e4e4
[SHELL32] Add missing strings for desktop icons
Reuse existing translations where possible.

CORE-8427
2022-10-19 21:00:22 +03:00
Denis Malikov 8ef8e41cc9
[SHELL32] Show error message if move or copy operation failed (#4155)
This allows user to know when there is not enough space on the target media,
when there is no permissions for the operation, or some other error.

CORE-9239
2021-12-15 17:42:47 +03:00
William Kent 6ac25e6f7f
[SHELL32] Add missing SS_NOPREFIX to labels in About dialog (#3969)
Signed-off-by: William Kent <wjk011@gmail.com>
2021-10-10 21:50:18 +03:00
Joachim Henze cf6c191f69 [SHELL32] *.rc Whitespace fixes just, no functional change
Motivation to fix them in master is to avoid having to also port them back
when porting back nearby code.
2021-05-15 03:44:48 +02:00
George Bișoc 2ae526a039
[SHELL32] Do not format the partition if it's a system drive
Implement a sanity check helper which determines if the partition is a system drive or not based on the %SystemDrive% environment variable, preventing the user from nuking accidentally the partition with ReactOS system files installed. :P

NOTE: This code serves as a temporary measure to prevent accidental formatting of the system drive. In the future most of this code has to be totally rewritten (and stopping syncing with WINE altogether) as well as FMIFS library code so that we're on par in terms of compatibility with Windows.
2021-04-10 17:38:23 +02:00
Katayama Hirofumi MZ b66bdef370
[SHELL32] Enable auto-completion on SHBrowseForFolder (#3535)
This PR realizes auto-completion on SHBrowseForFolder. CORE-9281

- Call SHAutoComplete in WM_INITDIALOG message handling.
- Fix focus.
- Remove ES_NOHIDESEL style.
- Fix layout initialization.
2021-03-15 16:30:32 +09:00
Katayama Hirofumi MZ 2d066c93fe
[SHELL32] Fix SHBrowseForFolder new UI layout (#3533)
CORE-17507

- Change layout of resource dialogs IDD_BROWSE_FOR_FOLDER_NEW.
- Delete IDC_BROWSE_FOR_FOLDER_FOLDER control.
- Fix focus.
- Add ES_NOHIDESEL style to IDC_BROWSE_FOR_FOLDER_FOLDER_TEXT control.
- Add TVS_SHOWSELALWAYS style to IDC_BROWSE_FOR_FOLDER_TREEVIEW control.
- Fix assertion failure in LayoutUpdate function in <layout.h>.
2021-03-15 07:13:03 +09:00
Katayama Hirofumi MZ e1a5ba188e
[SHELL32] SHBrowseForFolder with BIF_EDITBOX should use new UI (#3532)
CORE-17506

- Convert some judgements against BIF_NEWDIALOGSTYLE to judgements against BIF_USENEWUI. Here BIF_USENEWUI == (BIF_NEWDIALOGSTYLE | BIF_EDITBOX).
- Remove WS_SIZEBOX window style from new UI dialog resource (IDD_BROWSE_FOR_FOLDER_NEW).
- Fix header layout.h for resizing without WS_SIZEBOX.
2021-03-14 18:35:40 +09:00
Arnav Bhatt fd39a292af
[MSGINA][SHELL32] Rework friendly UI shutdown dialog box and implement friendly UI log off dialog box (#3399)
Implement the re-worked shut down dialog box as well as implementing fancy log off dialog box.
- Fancy shut down dialog box has been redesigned to be more comparable to of XP.
- Implement features that were missing earlier.
- Implement the fancy log off dialog which is more comparable to of XP.
2021-02-28 20:03:35 +09:00
Riley Bell 3014417919 [SHELL32] Hide "This version of ReactOS is registered to:" text on condition (#3325)
When the system is not installed yet (e.g. LiveCD or 2nd installation stage)
there is no registered user and organization, so no need to show this text
label in the shell about dialog.

Co-authored-by: Stanislav Motylkov <x86corez@gmail.com>
2020-11-30 03:12:32 +03:00
Katayama Hirofumi MZ de8d156e2c
[SHELL32] Resizable for SHBrowseForFolder (#3299)
Make the dialog box of SHBrowseForFolder function resizable. CORE-17341
2020-10-21 22:25:16 +09:00
Kyle Katarn aad9bb8e8a
[TRANSLATION][SHELL32] Localization of "System Folder" in My Computer types (#3168)
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
Co-authored-by: JoseSanchezz <67137372+JoseSanchezz@users.noreply.github.com>
2020-09-13 23:16:19 +02:00
Katayama Hirofumi MZ ed445dd775
[SHELL32] Enable CopyTo/MoveTo textbox functionality (#3075)
- The user can enter the full path of a directory in "Copy To Folder" and "Move To Folder" features.
- Fix two bugs in SHBrowseForFolder function. One is disability of text box to enter a full path. Another one is disability to choose the root item in BFFM_SETSELECTION.
- Add ES_AUTOHSCROLL style to text box. This enables the user to enter a long text.
CORE-11132
2020-08-20 11:35:14 +09:00
Katayama Hirofumi MZ 46ff964e22
[SHELL32] Implement Move To Folder (#3056)
- Add context menu item "Mo&ve to folder..." and implement the action.
- Implement the "Mo&ve to folder..." menu item of "Edit" menu of Explorer.
CORE-11132
2020-08-18 05:30:54 +09:00
Katayama Hirofumi MZ 85fdcdf2cc
[SHELL32] Implement Copy To Folder (retrial) (#3044)
- Add context menu item "Copy to &folder..." and implement the action.
- Implement the "Copy to &folder..." menu item of "Edit" menu of Explorer.
CORE-11132
2020-08-16 08:04:07 +09:00
Katayama Hirofumi MZ a3ec01cc28
[SHELL32] Add IDD_LINK_PROBLEM and IDS_LINK_INVALID (#3037)
A resource dialog and a resource string for shortcut problem. CORE-16816
2020-08-12 14:16:25 +09:00
Katayama Hirofumi MZ 77b8505393
[SHELL32] Delete IDM_RECENTMENUHEAD resource menu (#2705)
Follow-up of #2648. Reduce translation cost and resource data.
CORE-3588, CORE-11483
2020-05-01 15:58:58 +09:00
Katayama Hirofumi MZ 8f3079c67f
[SHELL32][EXPLORER] Improve Recent Documents of Start Menu (#2648)
Improve Recent Documents of Start Menu. Add items of "My Documents" and "My Pictures" into Recent menu item.
CORE-3588, CORE-11483
2020-04-30 17:09:14 +09:00
Kyle Katarn e6e45b34cc
[SHELL32] Fix "Max size" Edit box position in Recycle Bin properties page (#2676)
CORE-16972
2020-04-27 12:48:26 +02:00
Katayama Hirofumi MZ a48aa21102
[SENDMAIL][ZIPFLDR][MYDOCS] Fix creation of SendTo files (#2616)
- Improve and move SendTo files creation code and timing.
- Delete IDS_DESKLINK of shell32.
- Add IDS_DESKLINK into sendmail.
CORE-16924
2020-04-23 04:19:20 +09:00
Charles Ambrye c82ba3485e [SHELL32] Modify context menu to include Align To Grid, and remove Line Up Icons
Implement support for using Align To Grid, which itself simply sets the LVS_EX_SNAPTOGRID extended style of the list view control
2020-04-20 23:13:09 +03:00
Joachim Henze 4af7888b29 [SHELL32] CORE-16895 RC IDD_OPEN_WITH All langs
-Avoid text truncations regarding the checkbox
 in a uniform way
-Reduce chance of text truncations for a button
 in a uniform way
-Fix es-ES dlg layout and harmonize its dlg Size
 with other languages
-de-DE fix double accelerator
2020-04-20 02:08:45 +02:00
Joachim Henze c0d5e4fd6b [SHELL32] CORE-16895 RC IDD_FOLDER_OPTIONS_FILETYPES All langs
-Some inspiration from de-DE which I improved years ago
-Avoid text truncations and control overlapping that
 happened in almost all other languages
-Increase the size of the listView for all except es-ES & pt-PT
-es-ES & pt-PT had different dlgs sizes, I only slightly tweaked
 those therefore
-In sum this brings the RCs much closer to each other

-Unrelated: fix a white-space-typo we had in some but not all RCs
2020-04-19 21:33:13 +02:00
Oleg Dubinskiy 7075bdacb2
[SHELL32] Don't hardcode My Documents path for My Music/Pictures/Videos folders in some translations (#2354)
Don't hardcode My Documents path in some translations of My Music, My Pictures and My Videos folders in Shell32. It fixes incorrect location of that folders when install ReactOS as Workstation.
Currently they are located in one more My Documents subfolder, which is, in its turn, in the correct My Documents directory. After this fix, they are directly in the 2nd one, as they should be.

CORE-16698
2020-02-15 20:06:16 +01:00
Bișoc George 6ce72ba172
[SHELL32] Better fix for the "Version" string in the About-dialog (#2349)
The version string kernel number and the localized "version" word were too near in translation files. The patch fixes the problem introduced by #2276.
Addendum to commit a57f7b50.
2020-02-14 22:17:48 +01:00
Bișoc George a57f7b50c0
[SHELL32] Display the ReactOS version to the About dialog programmatically (#2276)
The current control parameters don't fit well with the version string since ReactOS migrated from SVN to Git. However, modifying the resource parameters doesn't fix the problem as well because the string itself is dynamic (as it can change in words specially the build architecture if the version build is AMD64 or x86 for example).

CORE-16571
2020-02-01 22:47:32 +01:00
Katayama Hirofumi MZ aacb9f0ccd [SHELL32] Improve comments of shell folder paths 2020-01-24 21:32:25 +09:00
Hermès Bélusca-Maïto 16f64a9533
[SHELL32] Improve the displayed error on file copy / displacement + simplify code.
Also update the corresponding french translations, see CORE-16572.
And fix a regression introduced in 257e7307 that allowed again copying
or moving a directory into its sub-tree...

I also personally think that these checks must also be done within the
copy_files() / move_files() helpers instead?
2019-12-24 18:30:54 +01:00
Katayama Hirofumi MZ 0e2bb5b0b8
[SHELL32] Validate file operation (#2085)
- Support FOF_RENAMEONCOLLISION flag of SHFileOperationW.
- Add validate_operation function and use it in SHFileOperationW.

CORE-10225
2019-11-30 15:36:16 +09:00
Katayama Hirofumi MZ 2c272a9017
[SHELL32] Add desktop.ini more to some folders (#2101)
Provides special icons for special folders by adding desktop.ini. CORE-10045
2019-11-29 14:40:04 +09:00
Katayama Hirofumi MZ 5538facfdd
[SHELL32] Add SendTo DeskLink (Retry) (#2099)
CORE-12562
2019-11-27 20:09:19 +09:00
Katayama Hirofumi MZ 90c63d12a1
[SHELL32][BOOTDATA] Implement Command Prompt here (#2029)
Add "Command Prompt here" menu item to the Right-click menu of normal folders and drives. Currently, this menu item doesn't work correctly because of the bug of pushd. CORE-12150
2019-11-14 23:25:21 +09:00
Katayama Hirofumi MZ c0f340bca5
[SHELL32] Implement 'Open file location' of shortcut files (#2028)
"Open file location" is a feature to open the location of the target of a shortcut file.
Ideally we should probably use SHOpenFolderAndSelectItems here, but that is not 100% implemented in ros yet... CORE-12770
2019-11-12 16:47:36 +09:00
Katayama Hirofumi MZ 5308a606dc
[SHELL32] Initial SendTo implementation (#2021)
This PR will realize SendTo feature. Initially, there is no file in SendTo folder (displayed as "(None)"). If you added some shortcut files, then SendTo shows some menu items.
- Copy, Move, and Link are working.
- Added icons.
CORE-12562
2019-11-09 08:08:40 +09:00
Shy Zedaka a3944563c3 [SHELL32] Run Dialog Text Fix 2019-08-15 20:03:55 +02:00
Bișoc George 019e3ffe5f
[SHELL32] Recycle-Bin: Validate the MaxCapacity value with respect to the available disk space. (#1688)
CORE-12313

Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
2019-07-07 19:01:09 +02:00
Joachim Henze 1d7287288d [SHELL32] Update all languages RCs to fix possible text truncation CORE-15765
IDD_BROWSE_FOR_FOLDER displays text controlled by the calling applications in
IDC_BROWSE_FOR_FOLDER_TITLE. Its old height could lead to text truncation
for existing 3rd party apps.
The new height value for IDC_BROWSE_FOR_FOLDER_TITLE
was inspired by IDC with the same from dialog IDD_BROWSE_FOR_FOLDER_NEW.
I could change all languages to the same height,
as dimensions of the dialog and surrounding controls were same.
2019-03-03 02:23:34 +01:00
David Quintana 01e5cb0c04
Resource file strings cleanup (#581)
[CMDUTILS/AT] Fix missing translation strings in certain files.
[NOTEPAD] Fix SUBLANG code to brazillian.
[RAPPS] Fix missing translation strings in certain files.
[FDEBUG] Fix translation string ID.
[CPL/INPUT] Fix missing translation strings in certain files.
[ACPPAGE] Fix incorrect resource IDs.
[NETSHELL] Fix incorrect resource IDs.
[DEVMGR] Fix missing translation strings in certain files.
[LSASRV] Fix missing translation strings in certain files.
[RASDLG] Fix missing translation strings in certain files.
[SHELL32] Fix missing translation strings and incorrect resource IDs.
[TAPIUI] Fix missing translation strings in certain files.
[WINFILE] Fix incorrect resource IDs.
[NTVDM] Fix missing translation strings in certain files.
[USERSRV] Fix missing translation strings in certain files.
[BROWSEUI] One more missing string.
[FLTMC] Fix missing translation strings in certain files.

Detected using the TransDiffer tool (early alpha).
This doesn't include everything anymore, but I wanted to get the PR out of the way.
2019-01-05 15:44:16 +01:00
Jared Smudde 44bb99cc8e [SHELL32] Add a warning dialog before starting a dialog as well as a format complete dialog. (#1137)
Also fix the progress bar not working and the Allocation unit size combo box disappearing after a format completes.
2018-12-15 21:22:57 +01:00
Auron Hines 86c5cfd81a [TRANSLATION][SHELL32] Grammar fix: content -> contents (#1115) 2018-12-11 19:43:46 +01:00
Joachim Henze 432afb4161 [SHELL32] Improve CORE-15295 IDD_FILE_PROPERTIES
addendum to 0.4.11-dev-673-g
04e1263921

Actually this control must not statically consume width of 170.
There are two different versions of that dialog.
One has a "change"-button. In this case the edit must be only 100 wide.
In case we have the version without the change button, we resize it to have
170 width (same as its neighbor).

This commit is shared work of
Stanislav Motylkov, Giannis Adamopoulos and Joachim Henze.

Commit supersedes PR#1056.
2018-11-23 02:25:28 +01:00
Joachim Henze 04e1263921 [SHELL32] Fix CORE-15295, wrong edit width in IDD_FILE_PROPERTIES for all langs 2018-11-07 01:40:53 +01:00
Katayama Hirofumi MZ 39dc3cdaf6 [SHELL32] Adjust the IDC_PICKICON_LIST control's height in the IDD_PICK_ICON dialog resource. (#824)
CORE-14974
2018-08-27 12:21:51 +02:00
Stanislav Motylkov 707f2ed360 [SHELL32] Fix some elements positions and styles
Addendum to eb1912b. CORE-11407
2018-06-30 01:15:41 +02:00
Katayama Hirofumi MZ eb1912b15f [SHELL32] Initial implementation of Folder Customization (#642)
- Add property sheet;
- Implement changing the folder icon.
CORE-11407
2018-06-28 21:51:37 +02:00
Katayama Hirofumi MZ cb69443362 [SHELL32] Implement the 'General' tab of the "Folder Options" dialog (#604)
CORE-14678
2018-06-22 16:40:06 +02:00
Katayama Hirofumi MZ 698cbc6184 [SHELL32] Split dialogs/folder_options.cpp (#582)
The dialogs/folder_options.cpp source file in shell32 is too big to manage. We will split it to smaller files.
CORE-12906
2018-06-06 14:04:50 +02:00
Katayama Hirofumi MZ 222534a5a2 [SHELL32] Fix and improve the PickIconDlg function (#574)
CORE-10972
2018-05-31 15:33:07 +02:00
Katayama Hirofumi MZ 5187ec858f [SHELL32] Implement the 'Advanced' button of the 'File Types' dialog (#565)
This allows the user to edit the File Type / extension information by clicking 'Advanced' button in the 'File Types' property sheet of Folder Options.
CORE-12906, CORE-10972
2018-05-30 17:22:31 +02:00