Commit graph

68441 commits

Author SHA1 Message Date
Thomas Faber b206e0eb2a [EVENTVWR]
- Make user name caching actually work
CORE-12798

svn path=/trunk/; revision=74417
2017-04-27 00:17:08 +00:00
Hermès Bélusca-Maïto 01a6b1023f [CMD]: Improvements for the CHCP command.
- Display the informative CP-change message on stdout, using the *output* code page (and not the input CP);
- Correctly update the local codepage cache;
- Display the informative CP-change message when the CP change succeeded;
- Add source comments + informative TODO for what remains to be done.

svn path=/trunk/; revision=74416
2017-04-26 22:29:07 +00:00
Eric Kohl f25d0ce422 [BOOTDATA]
Make the timezone names translatable.
CORE-11855

svn path=/trunk/; revision=74415
2017-04-26 21:21:02 +00:00
Hermès Bélusca-Maïto 053db1af86 [KERNEL32]: Add/update localized codepage display names.
- Slightly update the description of CP 28599;
- Add descriptions for CPs 28600, 28603, 28604 and 28606;
- Add CP 856 "OEM - Hebrew PC" (which differs from OEM Hebrew CP 862).
Note that while we also have codepages 424, 878 and 1006, I don't add their description because:
- CP 424 is actually CP 20424 "IBM EBCDIC - Hebrew" on Windows (documented in the resource files);
- CP 878 is actually CP 20866 "Russian - KOI8" on Windows (documented in the resource files);
- CP 1006 seems to be "IBM Arabic" according to Wine, but I don't know its corresponding number on Windows.

svn path=/trunk/; revision=74414
2017-04-26 20:31:54 +00:00
Hermès Bélusca-Maïto 4f80d030e6 [KERNEL32]: Little improvements/fixes for GetCPInfoExW and GetGeoInfoW:
- Rework GetLocalisedText helper such that it looks more like LoadStringW. Also, if the string is not found (either because there is no associated string table, or because its resource length is zero), then return zero.
  Otherwise we return the correct number of characters copied into the user buffer, not counting the NULL terminator.
  This fixes the blank strings showing in the list of codepage user-friendly names in the console properties dialog.
- Simplify the code of NLS_GetGeoFriendlyName: we can directly use the user-provided buffer to retrieve the string.
Addendum to r65157.
CORE-13130 #resolve

svn path=/trunk/; revision=74413
2017-04-26 17:38:57 +00:00
Hermès Bélusca-Maïto 46f402da90 [KERNEL32]: Add the Brunei in the list of localized countries.
Translators, please localize the name!

svn path=/trunk/; revision=74412
2017-04-26 17:10:51 +00:00
Giannis Adamopoulos 79aeba8939 [UXTHEME] -Fix some resource leaks.
svn path=/trunk/; revision=74411
2017-04-26 13:55:19 +00:00
Hermès Bélusca-Maïto 403ef47169 [COMMAND]: Disable COMMAND.COM debugging messages by default.
Disable again this #define if you want to get the dbg messages back.
CORE-10710

svn path=/trunk/; revision=74410
2017-04-26 13:41:43 +00:00
Thomas Faber 701f62c3ac [USBOHCI]
- Not building before committing is also a hack
CORE-9224

svn path=/trunk/; revision=74409
2017-04-26 10:54:34 +00:00
Thomas Faber 1bb6977402 [USBEHCI][USBOHCI]
- Touch the virtual address of DMA buffers before calling MmGetPhysicalAddress on them. This ensures page directories are correctly set up for the current process context, and fixes random DMA operation failures ("MM:MmGetPhysicalAddressFailed"). This is not a hack -- using MmGetPhysicalAddress for DMA in the first place is.
CORE-9224 #resolve

svn path=/trunk/; revision=74408
2017-04-26 10:53:32 +00:00
Giannis Adamopoulos 43e13595cf [UXTHEME] -Implement the tab background texture. NOTE: A hack was used to go around the problem that SetBrushOrgEx doesn't really work. CORE-12978
svn path=/trunk/; revision=74407
2017-04-26 09:28:35 +00:00
Giannis Adamopoulos e9846d6f9c [COMCTL32]
- Button, Trakbar: Send WM_CTLCOLORBTN or WM_CTLCOLORSTATIC and use their return value to paint the control despite the fact that DrawThemeParentBackground was called as well.
Part of the fix for CORE-12978

svn path=/trunk/; revision=74406
2017-04-25 11:19:22 +00:00
Hermès Bélusca-Maïto 83e0dd0595 [CONSOLE.CPL]: Simplify some parts of font.c code.
- Use a helper function "AddFontToList" to add font names into the font list;
- Use string-safe functions where needed.

svn path=/trunk/; revision=74405
2017-04-24 17:01:07 +00:00
Thomas Faber 384affe098 [WIN32K:ENG]
- In PDEVOBJ_vRefreshModeList, restore the current mode pointer, ppdev->pdmwDev, to a valid value.
CORE-13097 #resolve

svn path=/trunk/; revision=74404
2017-04-24 16:28:04 +00:00
Thomas Faber e395d953b3 [USER32]
Fix heap corruption in EnumDisplaySettingsExA/W:
- Do not overwrite the user-provided buffer size in dmDriverExtra
- Fix broken pointer arithmetic
CORE-13097

svn path=/trunk/; revision=74403
2017-04-24 15:04:00 +00:00
Hermès Bélusca-Maïto b5171111fb [ACCESS]: Fix french el-typo, noticed by Kyle Katarn. Thanks!
CORE-12482

svn path=/trunk/; revision=74402
2017-04-24 11:17:10 +00:00
Thomas Faber 9b4e4d42ed [WININET]
- Silence Firefox/Safari debug spam
CORE-12853 CORE-12128 CORE-11135

svn path=/trunk/; revision=74401
2017-04-24 10:07:39 +00:00
Thomas Faber 6eec01d1f5 [NTOS:MM]
- In MiFlushTbAndCapture, only print a fixme if we actually need to do something.
CORE-12074 #resolve

svn path=/trunk/; revision=74400
2017-04-24 09:45:03 +00:00
Thomas Faber 8fde80eacd [CONSOLE]
- Fix build
CORE-12451

svn path=/trunk/; revision=74399
2017-04-24 07:19:41 +00:00
Hermès Bélusca-Maïto b6f13160b2 [CONSOLE.CPL]: Addendum to r74397: Fix a cast.
svn path=/trunk/; revision=74398
2017-04-24 00:32:10 +00:00
Hermès Bélusca-Maïto 34a71f27fc [CONSOLE.CPL]: Add a list of available code pages in the console properties dialog.
Display a list of available code pages, as done on Windows (NT/2k/2k3/Vista/7/8, when a CJK language is selected, and as always done on Windows 10 for all languages).
But contrary to Windows, do not limit this list to only CJK + CP-437 codepages, but list *all* the available CPs, retrieved from the registry. These CPs are also those available when using the "chcp" or "mode con cp" commands.
And contrary to Windows (where this is done only for the general console properties), always allow the user to view or change the code page even from the console properties dialog.

[CONSRV]: Support changing the current code page from the console properties dialog.

CORE-12451

svn path=/trunk/; revision=74397
2017-04-24 00:24:34 +00:00
Eric Kohl d1ad859a6e [SYSETUP]
Update the shown date and time on the Date and Time page until the user changes the date or time.
CORE-11896

svn path=/trunk/; revision=74396
2017-04-23 21:56:36 +00:00
Thomas Faber 20689dba23 [CRYPTNET]
- Fix ROS-Diff. Spotted by CRLF.
CORE-13117 #resolve

svn path=/trunk/; revision=74395
2017-04-23 17:59:25 +00:00
Eric Kohl f83d61cce0 [SERVMAN]
- Make a copy of the service list where service and display name strings are separately allocated. We need this to update the service names rather than reload the list when the display name is changed.
- Write the display name, description or binary path to the registry when the user changed them.
- Disable the Edit button after it has been clicked.
- Do not add the service name to the argument vector in the call to StartServiceW. Services.exe already add the service name to the vector.
CORE-12743

svn path=/trunk/; revision=74394
2017-04-23 17:39:26 +00:00
Colin Finck ceaed9f1ec [LOCALSPL]
Implement all corner cases of handling the Name parameter in EnumPrinters. This can be done in a common way for all levels.
Fixes more tests.

svn path=/trunk/; revision=74393
2017-04-23 15:00:26 +00:00
Giannis Adamopoulos 4414132a97 [NTOSKRNL] CcPurgeCacheSection: Check if SharedCacheMap is NULL. Change suggested by ThFabba. CORE-13115
svn path=/trunk/; revision=74392
2017-04-23 11:12:48 +00:00
Thomas Faber 1f03a83d50 [NTOS:MM]
- In NtMapViewOfSection, check for address alignment after validating the handles. This fixes the tests from the previous commit, but is also necessary because information about the section object is necessary to avoid the alignment checks for physical memory sections.
CORE-13113

svn path=/trunk/; revision=74391
2017-04-23 09:38:45 +00:00
Thomas Faber 6e74416198 [KMTESTS:MM]
- Show that NtMapViewOfSection validates section and process handles before checking base address alignment
CORE-13113

svn path=/trunk/; revision=74390
2017-04-23 08:10:46 +00:00
Thomas Faber e570b43842 [NTOS:MM]
- Check for ROS section object before accessing the AllocationAttributes member in NtMapViewOfSection, since ARM3 sections use a different structure.
CORE-13113

svn path=/trunk/; revision=74389
2017-04-23 07:24:44 +00:00
Mark Jansen 20756892b7 [ACPPAGE] Implement custom compatibility mode selection + Expand paths CORE-10375
svn path=/trunk/; revision=74388
2017-04-22 17:11:52 +00:00
Mark Jansen 7edfd6a3a9 [ACPPAGE] Update translations based on slayer. CORE-10375
Translators, please check your language, some text was changed!

svn path=/trunk/; revision=74387
2017-04-22 15:20:25 +00:00
Thomas Faber a8b7dd40e2 [KMTESTS:MM]
- Enable MEM_RESERVED test in SimpleErrorChecks() since it no longer asserts. Patch by Serge Gautherie.
ROSTESTS-109 #resolve

svn path=/trunk/; revision=74386
2017-04-21 08:08:57 +00:00
Hermès Bélusca-Maïto e21e3e4e03 [INPUT.CPL]
- Remove an unneeded header inclusion;
- Fix a sizeof invocation;
- RegEnumKeyExW and RegEnumValueW take their fourth parameter (size of key / value name, resp.) as a size in number of *characters* (and not in number of bytes);
- Add a missing RegCloseKey call in LocaleList_Create.

svn path=/trunk/; revision=74385
2017-04-21 00:22:39 +00:00
Thomas Faber 1836858f0a [NTOS:KE]
- Reset DebugDpcTime before calling timer DPC routines. Avoids spurious "DPC routine > 1 sec" break-ins.

svn path=/trunk/; revision=74384
2017-04-20 17:36:40 +00:00
Thomas Faber ec2dddf4cb [NTOS:MM]
- Avoid reference leaks in failure cases of MmCreateCacheSection
CORE-6931

svn path=/trunk/; revision=74383
2017-04-20 08:58:45 +00:00
Thomas Faber 599c80f8f2 [VGADDI]
- Fix buffer overflow in DIB_BltFromVGA. A byte fits two pixels.

svn path=/trunk/; revision=74382
2017-04-20 07:30:01 +00:00
Eric Kohl e9940a928b [TRANSLATION]
Romanian resources maintenance
Patch by Ștefan Fulea.
CORE-13099

svn path=/trunk/; revision=74381
2017-04-19 22:10:00 +00:00
Mark Jansen fd91fe3337 [SHELL32] Fix for BuildPathsList, this solves some problems showing while copying folders. Patch by 'Gleb'. CORE-8434
svn path=/trunk/; revision=74380
2017-04-19 18:45:33 +00:00
Giannis Adamopoulos 5db681f766 [SHELL32] -CDesktopBrowser: Clone the pidl passed to SHOpenNewFrame as it will later free it itself. This was masked by a hacky cast.
svn path=/trunk/; revision=74379
2017-04-19 16:24:59 +00:00
Thomas Faber ef27450876 [NTOS:MM]
- Never use special pool for prototype PTEs. Avoids "(PointerPte >= (PMMPTE)MmPagedPoolStart) && (PointerPte <= (PMMPTE)MmPagedPoolEnd)" assertion failure in MiDecrementShareCount.
CORE-11474

svn path=/trunk/; revision=74378
2017-04-19 14:40:53 +00:00
Thomas Faber a909a0807a [KERNEL32_WINETEST]
- Improve the test_GetVolumePathNamesForVolumeNameW hack to avoid a stack buffer underrun.
CORE-11474

svn path=/trunk/; revision=74377
2017-04-19 14:08:51 +00:00
Thomas Faber 85f31b899e [OPENGL32]
- Fix uninitialized variable use in IntGetIcdData
CORE-11474

svn path=/trunk/; revision=74376
2017-04-19 13:16:30 +00:00
Thomas Faber 424bbf064b [KMTESTS:OB]
- After ObCreateObject+ObInsertObject a handle close is enough to destroy the object, so do not dereference it in addition. Fixes use after free.
CORE-11474

svn path=/trunk/; revision=74375
2017-04-19 12:21:57 +00:00
Thomas Faber eff26a3a92 [KMTESTS:NPFS]
- Remove tests that cause pool buffer overflows. NtQueryVolumeInformationFile does not validate buffer length for kernel mode callers, so passing an invalid length is not a good test.
CORE-11474

svn path=/trunk/; revision=74374
2017-04-19 11:46:34 +00:00
Thomas Faber 497a20b8a0 [WS2_32][DNSAPI]
- Avoid stack buffer overflow in ParseV4Address
CORE-11474

svn path=/trunk/; revision=74373
2017-04-19 11:14:18 +00:00
Thomas Faber 77ec221feb [GDI32]
- Use the number of WCHARs, not the number of ANSI chars in GetCharABCWidthsA. Fixes stack corruption when running gdi32_winetest:font
CORE-11474

svn path=/trunk/; revision=74372
2017-04-19 10:33:58 +00:00
Eric Kohl ae3886b65f [VARIOUS]
Updating Turkish Translation
Patch by Erdem Ersoy.
CORE-12362

svn path=/trunk/; revision=74371
2017-04-18 17:47:08 +00:00
Thomas Faber 202ae322fb [USER32]
- In RealSystemParametersInfoA/SPI_GETDESKWALLPAPER, write the ansi wallpaper path directly into the user's buffer instead of using an allocation (and overrunning it). Fixes crash when running user32_winetest:sysparams with DPH.
Tangential to CORE-13097

svn path=/trunk/; revision=74370
2017-04-18 14:31:33 +00:00
Giannis Adamopoulos fc00a030f4 [USER32] -CallWindowProc: Call PreWndProc and PostWndProc hooks for dialog messages if the message is not hooked for PreDefDlgProc and PostDefDlgProc.
svn path=/trunk/; revision=74369
2017-04-18 12:35:57 +00:00
Hermès Bélusca-Maïto 3d8292ede6 [CONCFG]: Addendum for r74366: Initialize the console settings information codepage with the current OEM codepage, and read the optional console "CodePage" DWORD registry setting.
CORE-12451

svn path=/trunk/; revision=74368
2017-04-17 23:31:48 +00:00