Commit graph

4 commits

Author SHA1 Message Date
Joachim Henze
30dcc229f0 [ROSAPPS][PICE] Fix ROSAPPS-355 Unreachable code
Just to satisfy static code analysis. No change in behavior expected.

The same way as the external applications maintainers
fixed it in their latest version
https://sourceforge.net/projects/pice/files/pICE%20source/build_20/

By killing the whole function ScrollUp() with the disabled code.
Like the original authors I left the functions unused declaration
existing within hardware.h
2020-03-30 17:18:16 +02:00
Joachim Henze
2d3b72a070 [ROSAPPS][PICE] Fix a glitch at two places where code intends to replace invalid chars with spaces ROSAPPS-353
Found by some static code analysis tool reporting 'Condition always false'.
The fix is a selective back-port from the more recent version of pICE hardware.c
Revision: 1.6, Date: 2004/02/17 23:07:36

The most recent source of pICE atm can be found at
https://sourceforge.net/projects/pice/files/pICE%20source/build_20/

Thanks to DougLyons and JIRA user 'maddin200'.
2019-05-30 12:40:54 +02:00
Serge Gautherie
bcaa33e33b
[USETUP][ROSAPPS][EXT2LIB] NtReadFile() calls: Remove unused 'ByteOffset = 0', Use explicit NULL instead of ambiguous 0, Remove casts to same type. CORE-13910 2017-11-03 15:02:16 +01:00
Colin Finck
c2c66aff7d Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00