Commit graph

1374 commits

Author SHA1 Message Date
Brock Mammen 0eee3ed368 [SHELLFIND] Remove redundant check 2019-09-15 19:46:36 +03:00
Brock Mammen 2513c47452 [SHELLFIND] Fix unsafe cast 2019-09-15 19:46:36 +03:00
Brock Mammen fbdc08dceb [SHELLFIND] Use CoTaskMemAlloc instead of SHAlloc 2019-09-15 19:46:36 +03:00
Brock Mammen d0171027e0 [SHELLFIND] Fix IImageList leak 2019-09-15 19:46:36 +03:00
Brock Mammen a3ee648d8b [SHELLFIND] Simplify PIDLs to paths 2019-09-15 19:46:36 +03:00
Brock Mammen 0f995d77d1 [SHELLFIND] Remove search results folder from address edit box 2019-09-15 19:46:36 +03:00
Brock Mammen e6a5821e0c [SHELLFIND] Subscribe to folders that are already opened 2019-09-15 19:46:36 +03:00
Brock Mammen 07d37180a1 [SHELLFIND] Open search bar when search results folder is opened 2019-09-15 19:46:36 +03:00
Brock Mammen 312b628fe1 [SHELLFIND] Remove dependency on internal shell32 functions 2019-09-15 19:46:36 +03:00
Brock Mammen 6c6fd6d989 [SHELLFIND] Localize column names 2019-09-15 19:46:36 +03:00
Brock Mammen 641988a386 [SHELLFIND] Rename data members 2019-09-15 19:46:36 +03:00
Brock Mammen fe5c76a034 [SHELLFIND] Fix handle leak for stop event 2019-09-15 19:46:36 +03:00
Brock Mammen dce5ccec4e [SHELLFIND] Use DeferWindowPos for resizing child windows 2019-09-15 19:46:36 +03:00
Brock Mammen 8aa063b451 [SHELLFIND] Use assignment instead of memcpy 2019-09-15 19:46:36 +03:00
Brock Mammen 3b9508e98f [SHELLFIND] Fix copyright headers 2019-09-15 19:46:36 +03:00
Brock Mammen e15445e0c5 [SHELLFIND] Remove unused function 2019-09-15 19:46:36 +03:00
Brock Mammen ff7e9870ce [SHELLFIND] Remove unnecessary data member for focus 2019-09-15 19:46:36 +03:00
Brock Mammen a905699ac6 [SHELLFIND] Use case-insensitive string comparison 2019-09-15 19:46:36 +03:00
Brock Mammen 87c1f457eb [SHELLFIND] Improve search bar UI 2019-09-15 19:46:36 +03:00
Brock Mammen c46d60360a [SHELLFIND] Update status bar text 2019-09-15 19:46:36 +03:00
Brock Mammen 8246cd4e1b [SHELLFIND] Remove duplicate search code 2019-09-15 19:46:36 +03:00
Brock Mammen 41f9ad120d [SHELLFIND] Add stop search command 2019-09-15 19:46:36 +03:00
Brock Mammen 41d7b3700d [SHELLFIND] Add search command events 2019-09-15 19:46:36 +03:00
Brock Mammen 2f3db8d9a3 [SHELLFIND] Add search functionality 2019-09-15 19:46:36 +03:00
Brock Mammen 3583900b17 [SHELLFIND] Move window message constants to header file 2019-09-15 19:46:36 +03:00
Brock Mammen 6d6bc885cb [SHELLFIND] Use smart pointers for PIDLs 2019-09-15 19:46:36 +03:00
Brock Mammen 27ca55bce6 [SHELLFIND] Add edit box for search location 2019-09-15 19:46:36 +03:00
Brock Mammen 363ddf9c70 [SHELLFIND] Set status bar text after opening search results folder 2019-09-15 19:46:36 +03:00
Brock Mammen 04fcbe3202 [SHELLFIND] Message handler for updating status bar text 2019-09-15 19:46:36 +03:00
Brock Mammen 2fdaa386d2 [SHELLFIND] Add "Open Containing Folder" to right-click menu 2019-09-15 19:46:36 +03:00
Brock Mammen 7c937bd9ef [SHELLFIND] Add search bar click handler for testing search results 2019-09-15 19:46:36 +03:00
Brock Mammen 06fd04d7b0 [SHELLFIND] Message handler for adding search results 2019-09-15 19:46:36 +03:00
Brock Mammen 666bf34640 [SHELLFIND] Create PIDLs and add search results to folder 2019-09-15 19:46:36 +03:00
Brock Mammen 9c29004090 [SHELLFIND] Set default folder view mode to details 2019-09-15 19:46:36 +03:00
Brock Mammen c0799cd25b [SHELLFIND] Add default columns from CFSFolder 2019-09-15 19:46:36 +03:00
Brock Mammen ccf9ce324f [SHELLFIND] Add CFindFolder 2019-09-15 19:46:36 +03:00
Brock Mammen 7544656b85 [SHELLFIND] Open search results folder with search button 2019-09-15 19:46:36 +03:00
Brock Mammen 4212f4b175 [SHELLFIND] Add CSearchBar 2019-09-15 19:46:36 +03:00
Brock Mammen 957a604b36 [SHELL32] Implement CDefView::AddObject() 2019-09-15 19:46:36 +03:00
Brock Mammen e7e551afda [SHELL32] Make SHFindFiles open the search results folder 2019-09-15 19:46:36 +03:00
Timo Kreuzer 175abab7ad [IPHLPAPI] Simplify spec file
Also move the exports where they are on Windows. This was already handled correctly by MSVC and still doesn't fix the order on GCC builds, but that is a different story and shall be addressed at a different time.
2019-09-08 16:23:46 +02:00
Timo Kreuzer 76eed61813 [IPHLPAPI] Improve function stubs 2019-09-08 16:23:46 +02:00
Carlo Bramini 6b8d722bb2 Fix italian translation: "Cancella" -> "Annulla" (#1902) 2019-09-08 14:04:41 +02:00
Pierre Schweitzer 255ef2c332
[UBTRFS] Upgrade to 1.4
CORE-16354
2019-09-02 08:19:49 +02:00
Timo Kreuzer 99fe069ce6 [CRT][MSVCRT] Add __DestructExceptionObject from wine 2019-09-01 16:29:26 +02:00
Eric Kohl fa0eef085c [BOOTDATA][LSASRV] Add the security service(s)
- Add the service routines for the SamSs service.
- Start the SamSs service.
2019-08-31 18:17:14 +02:00
Eric Kohl 0625eb3746 [SERVICES][ADVAPI32] Support the security process aka lsass.exe
- Reserve the pipe NtControlPipe0 for the security process.
- Count regular service control pipes from 1.
- Use I_ScIsSecurityProcess to identify the security process.
- Services.exe uses the SECURITY_SERVICES_STARTED event to notify the security process that NtControlPipe0 is ready for use.
2019-08-31 17:24:47 +02:00
Eric Kohl 8571c26a71 [NETAPI32] Implement DsEnumerateDomainTrustsA 2019-08-31 12:45:30 +02:00
Eric Kohl 324afc252c [NETAPI32] Implement DsEnumerateDomainTrustsW 2019-08-25 18:23:38 +02:00
Eric Kohl abeb3324fb [NETAPI32] Implement DsAddressToSiteNamesA and DsAddressToSiteNamesExA 2019-08-25 11:39:53 +02:00
Ioannis Adamopoulos e419195d37 [HEADERS] Move some helpers from undocshell.h to shellutils.h as they didn't cover anything undocumented. Merge traycmd.h in undocshell.h as both contain just undocumented shell definitions. 2019-08-25 12:20:52 +03:00
Eric Kohl 121f0a5c50 [NETAPI32] Fix a typo in DsDeregisterDnsHostRecordsA
Thank you very much UserNT and Thomas for the hint!
2019-08-25 11:15:00 +02:00
Eric Kohl c9537b392b [NETAPI32] Implement DsDeregisterDnsHostRecordsA 2019-08-24 22:57:36 +02:00
Eric Kohl 47b749aa31 [NETAPI32] Implement DsGetDcNameWithAccountA 2019-08-24 21:40:11 +02:00
Eric Kohl 792d0f6b78 [NETAPI32] Implement DsGetDcSiteCoverageA 2019-08-24 19:44:37 +02:00
Eric Kohl 61ac4f1ee9 [NETAPI32] Add the NetpAllocStrFromWStr helper function 2019-08-24 14:00:33 +02:00
Eric Kohl 3d5c682cd8 [NETAPI32] Implement DsGetSiteNameA
Also add the NetpAllocAnsiStrFromWStr helper function.
2019-08-24 13:15:41 +02:00
Mark Jansen 4872912eb2
[SETUPAPI] Demote some noisy dprints 2019-08-23 13:03:36 +02:00
Shy Zedaka cbf47846e7 [TRANSLATION] Changes to Newdev and hdwwiz 2019-08-21 18:49:59 +02:00
Shy Zedaka cc8180fe63 [TRANSLATION] Change the recycle bin from 'Trash' to 'Recycle bin' 2019-08-21 18:49:59 +02:00
Mark Jansen ca4b001544
[NTDLL_VISTA] Fix the build for arm 2019-08-20 22:31:56 +02:00
Mark Jansen 6872cef0da
[FRAMEDYN[ARM] Fix some exports 2019-08-20 22:31:55 +02:00
Serge Gautherie 9f5f7a97f8 [IPHLPAPI] icmp.c: Restore sync after Wine Staging 1.7.55
Mark all our (new) differences.
2019-08-20 15:20:01 +02:00
Mark Jansen c2b9f94234
[COMCTL32] imagelist: Invalidate the cookie of a destroyed imagelist
CORE-16316
CORE-16275
2019-08-19 21:25:07 +02:00
Konstantin Motylkov ab2c90f1b9
[DNSAPI][DNSAPI_APITEST] Fix DnsQuery_UTF8 function and add tests
CORE-11634
2019-08-19 20:01:23 +02:00
Serge Gautherie cb77f1701f [SHELL32][STOBJECT] Enforce ShellExecuteW(..., file, parameters, ...)
CORE-16299
2019-08-19 13:01:08 +02:00
Eric Kohl f052817d84 [MSV1_0] Add SpLsaModeInitialize and SpUserModeInitialize.
SpLsaModeInitialize and SpUserModeInitialize will provide access to SSPI functions. LSASRV will soon access the LsaAp functions via SpLsaModeInialize.
2019-08-18 14:56:27 +02:00
Serge Gautherie 8ba4b11a33 [IPHLPAPI] icmp.c: Complete sync with Wine Staging 1.7.55
- Restore a missing brace.
- Mark all our differences (at that time). Please inspect them.

CORE-10536
2019-08-17 17:48:21 +02:00
Katayama Hirofumi MZ 344d559935
[COMCTL32] Unchange the property sheet page after WM_INITDIALOG (#1842)
In my testing on Win2k3, EN_CHANGE is generated in OnInitDialog, that is correct. The target is property sheet. The property sheet does unchange the page after WM_INITDIALOG generation. CORE-16280
2019-08-17 20:02:57 +09:00
Andreas Maier 2b5f38295b [COMCTL32] remove unused theme_*.c files. 2019-08-17 12:08:04 +02:00
Shy Zedaka fca051a1d1 [TRANSLATION][NEWDEV] Complete Hebrew Translations for New Device Prompt 2019-08-16 20:04:27 +02:00
Jose Carlos Jesus 0b4510301b
[SHELL][COMCTL32] pt_PT_Translation Improvements 2019-08-16 19:32:23 +02:00
Andrew Boyarshin 0a84597679
[COMCTL32] Export LoadIconMetric and LoadIconWithScaleDown
They are already implemented and there is little sense for them to be hidden.
Required for ProcessHacker 3.0+.
2019-08-16 18:31:07 +02:00
Andreas Maier 83dcae1e0f [JSCRIPT] import wine commits "stub + implement Enumerator()"
6630bc4096
a015c62643

CORE-13810
2019-08-16 16:37:32 +02:00
Waritnan Sookbuntherng 76dfa2b284 [COMCTL32] Checking size grip bounds in x-axis only 2019-08-16 16:22:24 +02:00
Waritnan Sookbuntherng b9ddad0bbb [COMCTL32] Hide size grip when the parent window is maximized 2019-08-16 16:22:24 +02:00
Andreas Maier 4093681ad0 [COMCTL32] Saturated images: Take mask-images in account.
This fixes CORE-14209 - Some icons not drawn in IDA Free
2019-08-15 21:11:45 +02:00
Andreas Maier 49a797543f [COMCTL32] Improve failure cases. 2019-08-15 21:11:45 +02:00
Adam Słaboń 65f42596ce [THEMES][LUNAR] Update
Improved Button and Combo Button bitmaps, fixed SYSSETUP Lunar resource.
2019-08-15 20:25:02 +02:00
Shy Zedaka a3944563c3 [SHELL32] Run Dialog Text Fix 2019-08-15 20:03:55 +02:00
Katayama Hirofumi MZ 944aba1fcc
[SHELL32] Fix Desktop Properties menu item action (#1833)
1. Right Click the Desktop.
2. Choose "Properties" menu item.
3. "Properties for Display" dialog must be shown.

The parameters of ShellExecuteW were wrong. The execution parameters must be separated from the file parameter.
CORE-16299
2019-08-15 23:10:06 +09:00
Denis Malikov 18a9993d69 [KERNEL32] implement CreateSemaphoreExW/A and adjust macroses for it 2019-08-15 15:50:59 +02:00
Serge Gautherie 40ab30d6a0 [KERNEL32] Partially fix dll/win32/kernel32/client/vista.c compilation as NT6
CORE-12596
2019-08-15 15:42:34 +02:00
Timo Kreuzer ad89837c0e [3RDPARTY] Suppress MSVC printf format warnings in 3rd-party code 2019-08-15 15:24:12 +02:00
Shy Zedaka 187c9fc33c [Translation] More Hebrew Translations
Co-authored-by: Baruch Rutman <peterooch@gmail.com>
2019-08-15 13:41:01 +02:00
Mark Jansen c96ba1aff2
[SHELL32] CDefView: Improve the context menu positioning
Previously we would always show a menu on the focused item, but
this should only be done when it is also selected.
2019-08-15 11:28:31 +02:00
Joachim Henze 0f16d44b66 [SHELL32] Improve ShellExecute
This fixes regression CORE-6412 and also fixes CORE-12927
by bringing us a bit closer to Wine implementation.

Thanks to patches author Doug Lyons.
The removed code looks like historic workaround code.

Automated tests do improve as well
VBox https://reactos.org/testman/compare.php?ids=68662,68696
KVM https://reactos.org/testman/compare.php?ids=68663,68697

I intend to merge this back into 0.4.12RC.
2019-08-06 20:24:55 +02:00
Katayama Hirofumi MZ 5972b1e284
[SYSSETUP] Caption of 2nd stage ReactOS Setup is too heavy (#1806)
The caption text of 2nd stage ReactOS Setup was too bold. CORE-16295
2019-08-06 11:09:56 +09:00
Katayama Hirofumi MZ 836e3107ba
[SYSSETUP] Fix bold font (#1799)
The font of radio buttons at ReactOS 2nd setup was wrong and too heavy. CORE-16291
2019-08-05 09:44:25 +09:00
Eric Kohl 7550e9efbf [DEVMGR] Add the code to uninstall a device from the property page 2019-08-04 11:20:04 +02:00
Eric Kohl 611989943e [DEVMGR] Change the menu id prefix from IDC_ to IDM_. 2019-08-03 21:52:00 +02:00
Eric Kohl 38d3c4d8da [DEVMGR] Fix the indentation of the menu resources. No code changes! 2019-08-03 16:37:54 +02:00
Eric Kohl d1a2983c00 [DEVMGR] Fix wonky action menu
Patch by Pi_User5.

CORE-10364
2019-08-03 14:54:18 +02:00
Hermès Bélusca-Maïto 44cddadba8
[KERNEL32] Minor enhancements for CreateRemoteThread(). (#804)
- Add some cleanup code in failure code paths, instead of asserting.
- Move BasepNotifyCsrOfThread() helper to the only file where it is used.
- Don't use ERROR_DBGBREAK in failure paths but just DPRINT the error
  message: we handle the failures properly.
- When creating the remote thread, sync its service tag with the parent
  thread's one.
2019-08-01 19:12:49 +02:00
Hermès Bélusca-Maïto effdb6f232
[KERNEL32][RTL] Diverse fixes/improvements for thread stack creation code. (#802)
- kernel32!BaseCreateStack() is compatible with ntdll!RtlpCreateUserStack().
- When checking whether a stack guard page can be added, its size has to
  be accounted for in the checking logic.
- We have to satisfy the PEB::MinimumStackCommit constraint.
- We cannot use PEB::GuaranteedStackBytes in BaseCreateStack() since it is
  nowhere initialized (default is 0). It gets initialized to a non-zero
  value when the user manually calls SetThreadStackGuarantee().
  https://www.installsetupconfig.com/win32programming/windowsthreadsprocessapis7_6.html

- RtlpCreateUserStack(): Fix memory leak in failure case.
- RtlpFreeUserStack() doesn't need to return anything.

See also commit 1bc59379 (r59868).

CORE-11319
2019-08-01 19:04:13 +02:00
Joachim Henze 8b67edd8fa [INPUT][INTL][SYSSETUP] Limit Combobox height CORE-16252
v6 comboboxes default to displaying up to 30entries and
give a bad user experience in 2nd stage
where we usually have low vertical screen resolution.
Therefore limit the height of the expanded boxes to
bring us close to how they were drawn before 0.4.12-dev-882-g
e3e173ffaa

Adding CBS_NOINTEGRALHEIGHT gives similar result for both:
comctl32 v5 and v6 comboboxes.
2019-07-30 23:14:31 +02:00
Eric Kohl 034c6fd0c5 [LSASRV] Improvements to LsapLogonUser()
- Token handle duplication must be the last step because we cannot close the duplicated token handle if something fails.
- Call LsaApLogonTerminated(), delete the logon session and free the profile buffer if something fails.
2019-07-30 23:10:33 +02:00
Eric Kohl 32861b84b9 [MSV1_0] Add debug messages to MsvpCheckWorkstations() and disable MsvpCheckLogonHours() for testing. 2019-07-29 01:22:37 +02:00
Jose Carlos Jesus f699cc96ac [NETSHELL][SYSSETUP] Minor improvements for pt_PT translation and object position adjustments (#1761) 2019-07-29 00:20:40 +02:00
Eric Kohl 12aba91abb [MSV1_0] LsaApCallPackage: The messages MsV1_0EnumerateUsers, MsV1_0GetUserInfo and MsV1_0ReLogonUsers are obsolete. 2019-07-28 14:57:46 +02:00