Commit graph

1083 commits

Author SHA1 Message Date
Giannis Adamopoulos a9d92a99c6 [NETSHELL] Add some notes about how it can be tested in windows 2018-11-18 14:01:54 +02:00
Giannis Adamopoulos f722ddac96 [NETSHELL] CNetConnectionPropertyUi: Add a comment about how windows write the settings 2018-11-18 14:01:54 +02:00
Giannis Adamopoulos 0654d60eef [NETSHELL] Move the implementation of the Disable button of the status dialog to CNetConnection::Disconnect 2018-11-18 14:01:54 +02:00
Giannis Adamopoulos 132463abf2 [NETSHELL] CNetConUiObject: Implement the Connect and Disconnect context menu items 2018-11-18 14:01:54 +02:00
Giannis Adamopoulos 7506198780 [NETSHELL] Optionally use the system's CLSID_ConnectionManager
Use a central compile option like we do in the rest of the shell so that when testing in windows we can switch using the one in the current dll or the one registered in the system.
Note that not only CLSID_ConnectionManager isn't implemented in netshell, it can't even be instantiated as CLSCTX_INPROC_SERVER because it is implemented by the netman service
2018-11-18 14:01:54 +02:00
Giannis Adamopoulos 21a5a559f2 [NETSHELL] Rewrite how pidls are created and accessed.
What we did before was completely wrong as we stored pointers in the pidl.
2018-11-18 14:01:54 +02:00
Giannis Adamopoulos 769b102e5f [NETSHELL] Use smart pointers and IID_PPV_ARG 2018-11-18 14:01:54 +02:00
Giannis Adamopoulos c73d8c64bb [NETSHELL] Use ATL 2018-11-18 14:01:54 +02:00
Giannis Adamopoulos 8d47872ea0 [NETSHELL] Add missing license headers
Since one of the first files in the module (shfldr_netconnect.c) used the LGPL2.1+ license, all the other files have the same license
2018-11-18 14:01:54 +02:00
Pierre Schweitzer 5e024bfeb6
[MPR] Drop a nasty ReactOS specific hack
That hack (cf. previous commit) was used to restore all
the saved connections. But, because it was implemented
in the wrong place, each time the MPR DLL was attached,
it was trying to restore connections.

With that commit and the previous one, now, ReactOS has
a correct behavior (it tries to bring back connections
only at session opening) and will reduce "workload" for
applications attaching MPR dll.

CORE-15310
2018-11-17 22:13:34 +01:00
Pierre Schweitzer 8b0a126445
[MPR] Implement remembered connection enumeration
Submitted upstream

CORE-15310
2018-11-17 22:13:25 +01:00
Bișoc George c00bafaad9 [SHELL32] Print out the error code (#973)
When SearchPathW, GetFullPathNameW and PathFileExistsW fail, output the error code.
2018-11-16 23:09:15 +01:00
Pierre Schweitzer 007cc5cd8a
[ACGENRAL] Don't leak memory on failure in InitIgnoreFreeLibrary()
CID 1441306
2018-11-16 22:07:09 +01:00
Pierre Schweitzer 52da844825
[COMCTL32] Don't leak memory in CB_ThemedPaint()
CID 1441313
2018-11-16 22:07:09 +01:00
Pierre Schweitzer 699af9f62a
[SETUPAPI] Allocate big enough buffer in CM_Query_Resource_Conflict_List().
CID 1441357
2018-11-16 22:07:08 +01:00
Pierre Schweitzer 3fddd3157c
[COMCTL32] Don't leak memory in PB_ThemedPaint()
CID 1441373
2018-11-16 22:07:08 +01:00
Pierre Schweitzer 402c983094
[SYSSETUP] Fix error message in ApplyRegistryValues()
CID 1441398
2018-11-16 22:07:07 +01:00
Giannis Adamopoulos 9baf05f164 [SHELL32] COpenWithMenu: Use ShellExecuteExW to open the file
CORE-15353
2018-11-15 21:26:17 +02:00
Luo Yufan d8a4e0a8e3 [TRANSLATION]Update Simplified Chinese translation. (#1032) 2018-11-14 21:42:21 +09:00
Baruch Rutman 97150ce9dd [WINMM] Sync wine commit ebae298 as a fix for CORE-15336 (#1031)
Reduce CPU usage by only attempting once to load the default joystick driver.
Fix for CORE-15336

Imported wine commit ebae298
ebae298aa4
https://www.winehq.org/pipermail/wine-devel/2018-November/134767.html
2018-11-14 12:32:55 +01:00
Giannis Adamopoulos 73b679e4a6 [NETSHELL] CNetConUiObject: Fix implementation of IContextMenu.
The id that InvokeCommand gets is the one used by QueryContextMenu after subtracting idCmdFirst.
2018-11-11 20:28:36 +02:00
Giannis Adamopoulos cd7a331749 [NETSHELL] CNetConUiObject: Implement handling the rename context menu item 2018-11-11 20:28:34 +02:00
Giannis Adamopoulos af3a1b1936 [NETSHELL] CNetConUiObject: Use a switch in InvokeCommand 2018-11-11 20:28:32 +02:00
Giannis Adamopoulos 41639e94c2 [NETSHELL] CNetworkConnections: Remove SFGAO_CANRENAME bit when renaming shouldn't be enabled.
This fixes the problem where renaming could take place by clicking on a name even when it is disabled in the context menu.
CORE-14116
2018-11-11 20:28:31 +02:00
Giannis Adamopoulos 91119080bc [NETSHELL] CNetworkConnections: SetNameOf should always return a new pidl on success.
CORE-14116
2018-11-11 20:28:29 +02:00
Giannis Adamopoulos bcd309cb7a [SHELL32] CDefView: Don't assume that SetNameOf always works properly so initialize pidlNew to NULL before
CORE-14116
2018-11-11 20:28:27 +02:00
Luo Yufan 5cdee1ab82 [TRANSLATION] Update Simplified Chinese translation. (#1028) 2018-11-11 17:57:12 +01:00
Adam Słaboń b8044d6783 [TRANSLATION] Polish translation update (#1029)
Translated missing strings and improved existing translations.
2018-11-11 17:55:01 +01:00
Luo Yufan 91e032f9b1 [TRANSLATION] Update Simplified Chinese translation. (#1025) 2018-11-09 15:31:53 +01:00
Luo Yufan 7fafe923cb [SYSDM] Update Simplified Chinese translation. (#1021) 2018-11-08 14:08:34 +01:00
Joann Mõndresku b63e2d5046 [TRANSLATIONS] Style fixes for Estonian 2018-11-07 22:10:27 +01:00
Zcooger 52eee8955c [APPWIZ] Update polish translation (#921) 2018-11-07 16:20:32 +01:00
Joachim Henze 04e1263921 [SHELL32] Fix CORE-15295, wrong edit width in IDD_FILE_PROPERTIES for all langs 2018-11-07 01:40:53 +01:00
Eric Kohl f26513f942 [NETSHELL] Add missing interface stubs to CNetworkConnections (aka CConnectionFolder). 2018-11-06 22:23:45 +01:00
Eric Kohl ee90e7f608 [LSASRV] Return STATUS_DIRECTORY_SERVICE_REQUIRED for all trusted domain functions that use a policy handle and a domain name or domain SID when the machine is not a domain controller. 2018-11-04 15:27:57 +01:00
Eric Kohl 91eaa5e2d4 [LSASRV] Coding style fixes 2018-11-04 12:50:21 +01:00
Pierre Schweitzer 497a9c8087
[SETUPAPI] Don't let LZClose() reset error code 2018-11-02 09:34:25 +01:00
Carlo Bramini 8236bb8f38
Avoid stray temp files in failure cases of do_file_copyW. CORE-12616 2018-11-02 09:22:34 +01:00
Joachim Henze ad34c91d1c [RICHED20] Revert ocr_reverse.cur to fix CORE-15190
Old cursor looks better.
We revert to SVN state r75865 and note the diff for Amine
so that the wrong version won't come back in the future.

Old file is just 326bytes while the one that we do not want is 33.134bytes
which means we will save some RAM as well.
2018-10-30 19:06:50 +01:00
Bișoc George 0c88f79480 [USRMGR] Fix a truncated text on French resource
CORE-15267
2018-10-28 19:30:17 +01:00
Mark Jansen 4bfac27ce6
[SHELL32] Fix broken control definition 2018-10-28 13:06:27 +01:00
Mark Jansen 95682e5406
[SETUPAPI] Fix broken control definition. 2018-10-28 13:06:08 +01:00
Mark Jansen 824e5dba51
[KERNEL32] Directly use UnhandledExceptionFilter in BaseProcessStartup 2018-10-28 13:01:38 +01:00
Mark Jansen 40549483f6
[KERNEL32] Use the default UnhandledExceptionFilter in BaseThreadStartup.
This should allow unhandled exceptions in a thread to trigger our crash reporter,
instead of killing the process directly.
2018-10-28 13:01:38 +01:00
Hermès Bélusca-Maïto e405ad257c
[SETUPLIB][USETUP][INPUT.CPL] MUI integration with setuplib.
[SETUPLIB] Copy the mui* files from usetup into the setuplib for later usage, and add mui.c to build.

svn path=/branches/setup_improvements/; revision=75711

[SETUPLIB][USETUP] Start massaging the MUI files and split up what concerns only the usetup "resources",
and what concerns general language parameters (in the setuplib).

It may be interesting to retrieve the language parameters
from INF file (e.g. intl.inf) (suggested by Giannis).

svn path=/branches/setup_improvements/; revision=75715

[SETUPLIB] Add the necessary headers to mui.c to be able to compile.
[USETUP] Comment out the languages that don't have any resources.

svn path=/branches/setup_improvements/; revision=75716

[SETUPLIB][USETUP] Adjust MUI and settings code.

- Re-enable settings code concerning language, keyboards & layout
  in the setuplib, and remove the old code in usetup.

- Remove useless code in setuplib's mui.c.

- Rename usetup's MUI "LanguageList" into "ResourceList" so as to
  avoid colliding with the "LanguageList" of setuplib.

- Add the magic CMakeLists line "add_definitions(${I18N_DEFS})" that
  I forgot previously, that caused the "LanguageList" of setuplib to be empty!

The code compiles and works during my tests.

svn path=/branches/setup_improvements/; revision=75717

[SETUPLIB] Change some string pointer types & function prototypes so that the usetup-specific
"SelectedLanguageId" variable is not used in the library.

svn path=/branches/setup_improvements/; revision=75719

[SETUPLIB] Change some function prototypes so that the usetup-specific "SelectedLanguageId" variable is not used in the library.
Also, make AddEntriesFromInfSection(), DefaultProcessEntry() and the typedef PPROCESS_ENTRY_ROUTINE private again.

svn path=/branches/setup_improvements/; revision=75720
svn path=/branches/setup_improvements/; revision=75724

[USETUP] Code adaptations.

- Transform some do{}while() loops into while(){} ones, since the lists on which we work may only contain one single {NULL} element.
- Modify MUIGetOEMCodePage() call after r75719.
- Use PCWSTR where needed.

svn path=/branches/setup_improvements/; revision=75722

[USETUP] Adjust some MUI & settings calls, following the commits r75719, r75720 and r75721.

svn path=/branches/setup_improvements/; revision=75723

[INPUT.CPL] Adjust inclusion of "muifonts.h" (commit 3dbd44f) due to changes introduced in r75711 and r75715.
2018-10-28 00:13:07 +02:00
Eric Kohl 0ce15a8faa [LSASRV][IDL] The first parameter of the Credr* functions is a PLSAPR_SERVER_NAME. 2018-10-27 18:17:35 +02:00
Hermès Bélusca-Maïto c8d37c1a0d
[SYSSETUP] Use a $winnt$.inf file to retrieve setup information for the 2nd-stage setup.
Following r75518, we use the $winnt$.inf file (created in System32
by the 1st-stage installer) as the setup information file for the
2nd-stage setup for:

- retrieving the installation source media path;
- retrieving the unattended information that was copied from the
  unattend.inf file from the installation source media.

The installation source media path is converted from NT format to
Win32 format for usage with Win32 functions and storage in the registry:
this is done by GetInstallSourceWin32(), which replaces the hackish
GetRosInstallCD() function.

The $winnt$.inf file is also updated, and the registry values "SourcePath"
and "ServicePackSourcePath" are created / updated in:
HKLM\Software\Microsoft\Windows\CurrentVersion\Setup .

svn path=/branches/setup_improvements/; revision=75524
2018-10-27 18:13:38 +02:00
Giannis Adamopoulos e69213448d [BROWSEUI] CInternetToolbar: fix whitespace 2018-10-27 15:08:31 +03:00
Giannis Adamopoulos a2bd9b44a9 [BROWSEUI] Simplify toggling the search band
In windows the toolbar itself creates the search shell extension. In ros we send a command to the CShellBrowser to let it handle it itself. Use the same command for showing and hiding it.
2018-10-27 15:08:28 +03:00
Giannis Adamopoulos a0c5cafce5 [BROWSEUI] Implement toggling the folders and search band with the toolbar and make their buttons appear pressed when they are shown.
CBaseBarSite: Ask the CBaseBar to close itself when the x button is pressed.
CBaseBar: Hide the bar and inform its site that it is closing when it gets the close command.
CShellBrowser: Cache the guid of the current vertical bar and use it to report correct command status to the toolbar.
Also implement toggling the Folders, Favorites, History and search commands.
CInternetToolbar: Query the Folders and Search command status from the site so that they can be properly be shown as pressed.
2018-10-27 15:08:24 +03:00