Commit graph

50917 commits

Author SHA1 Message Date
Timo Kreuzer a77220cc37 Remove confusing comments
svn path=/trunk/; revision=56348
2012-04-14 21:19:12 +00:00
Timo Kreuzer 49a81a2b04 [CMD]
Fix several bugs in the copy command:
- "x:" is not a valid source path (see bug #5709)
- when appending files using "+", cmd must distinguish between + as operator and + as part of the source file, when being put in "". For that reason the tokenizer was modified to make + a seperate token, which is replaced with | when creating the string of multiple files (since + is a valid file character)
- ? was not correctly handled when passed in the output file name
- factor out the code to create the file name from wildcards and make it readable (no, p, q, r are NOT reasonable variable names!)
- Move code out of the loop that doesn't belong there
- Make sure the file names are printed when multiple files are copied or appended
- write the count of written files (which is 1 when appending), not source files after the copy process is done
- Remove an excessive newline when writing strings with ConPuts()
- Improve readability a bit

svn path=/trunk/; revision=56346
2012-04-14 20:57:38 +00:00
Timo Kreuzer 847a74660e [SHELL32]
Fix a trace message, noticed by Edijus

svn path=/trunk/; revision=56345
2012-04-14 12:10:02 +00:00
Timo Kreuzer c001d46f1c [SHELL32]
Remove trailing backslash in shellink working dir
Patch by Edijs Kolesnikovics (terminedijs at yahoo dot com)

See issue #7000 for more details.

svn path=/trunk/; revision=56344
2012-04-14 10:40:21 +00:00
Amine Khaldi b4d5aaed08 [NTKRNLMP]
* Properly set the exports to refer to ntkrnlmp.exe instead of ntoskrnl.exe.

svn path=/trunk/; revision=56343
2012-04-13 21:35:00 +00:00
Timo Kreuzer 4ef8986a9a [WIN32K]
Fix path reference leaks in PATH_add_outline
Should fix failed assertion when closing google earth.
thanks to r3ddr4g0n for providing the neccessary debug info.

svn path=/trunk/; revision=56342
2012-04-13 18:33:56 +00:00
Timo Kreuzer dee532ddce [WIN32K]
Fix indentation and the name of the programmer who dared to use GNU style indentation.

svn path=/trunk/; revision=56341
2012-04-13 16:27:14 +00:00
Amine Khaldi ecea399f4b [NTKRNLMP]
* Add to build. Dedicated to Stefan.

svn path=/trunk/; revision=56340
2012-04-13 16:16:39 +00:00
Sylvain Petreolle 84efd179fc [MSI]
Workaround crash for installers that require image binding.
Suggested by Amine.

svn path=/trunk/; revision=56339
2012-04-12 17:08:38 +00:00
Eric Kohl c22ce87532 [SERVICES]
Log failed service starts and stops.

svn path=/trunk/; revision=56338
2012-04-08 22:27:44 +00:00
Eric Kohl 9024e05e55 [SERVICES]
- Make the handle to the shutdown event a global handle and set it when the service manager is being shut down.
- Close the start event properly.

svn path=/trunk/; revision=56337
2012-04-08 21:06:32 +00:00
Stefan Ginsberg e15e4f0c7e - There is no need for the i8042 driver to use a hacked KdSystemDebugControl call to breakpoint or crash on TAB+k/TAB+b. Just call DbgBreakPoint or KeBugCheck directly.
svn path=/trunk/; revision=56336
2012-04-08 15:57:04 +00:00
Stefan Ginsberg 51de801d45 - It seems the remaining page fault issue was fixed as well in 56333, so it should now be safe to enable this check. Finally, it is now illegal to page fault in ReactOS with interrupts disabled, as it should be. Previous attempts to fix this were likely hindered by the old memory manager, but ARM3 seems to do its job and doesn't fault on non-paged memory that I believe the old Mm was doing.
- Hacks--;

svn path=/trunk/; revision=56335
2012-04-07 01:18:36 +00:00
Stefan Ginsberg e1c86ddb2d - Add missing newline to debug print.
svn path=/trunk/; revision=56334
2012-04-06 21:01:17 +00:00
Stefan Ginsberg 3d119713b4 - Even while I love having the trap/fpu/context code in C, the bugs this switch introduced continue to amaze me. This time, fix a bug from 45156 when KiFlushNPXState was rewritten in C. The C version could miss to restore the interrupt state, which would lead to interrupts being disabled when it was not expected. This "interrupt leak" was seen in the page fault handler if a page fault occurred after interrupts had been disabled (which had sometimes been observed to occur on the test server during exception handling and thread creation when KiFlushNPXState had been called). This didn't completely hang the system because during thread creation (and other system calls where this may have happened) interrupts would be re-enabled when returning to user mode when restoring eflags, and the exception handling would result in a system call which would enable interrupts again (it appears exception handler would have run with interrupts disabled, though!). This is now fixed, as well as any other issues this might have caused. The hack in the page fault handler remains until another issue has been fixed.
svn path=/trunk/; revision=56333
2012-04-06 20:13:33 +00:00
Eric Kohl 4f80488ca3 [RTL]
Implement RtlCreateBootStatusDataFile, RtlGetSetBootStatusData, RtlLockBootStatusData and RtlUnlockBootStatusData.

[SYSSETUP]
Call RtlCreateBootStatusDataFile as part of the install process.

svn path=/trunk/; revision=56332
2012-04-06 18:25:18 +00:00
Cameron Gutman 4c6cc26667 [TCPIP]
- Fix a crash when a NIC driver indicates the media state before we're expecting it
- Fixes bug 6895

svn path=/trunk/; revision=56331
2012-04-06 16:08:20 +00:00
Timo Kreuzer be57977549 [CSRSRV/CSRSRV2]
Hard error parameters are ULONG_PTR, no need to truncate them

svn path=/trunk/; revision=56330
2012-04-03 15:02:51 +00:00
Timo Kreuzer 9630a8bd29 {PORTCLS]
forgot this one

svn path=/trunk/; revision=56329
2012-04-03 14:56:58 +00:00
Timo Kreuzer 21f3574c5d {PORTCLS]
Fix more PtrToUlong fun

svn path=/trunk/; revision=56328
2012-04-03 14:54:51 +00:00
Cameron Gutman 0056538299 [LIBUSB]
- Fix broken pointer arithmetic

svn path=/trunk/; revision=56327
2012-04-03 14:52:18 +00:00
Timo Kreuzer 819033bac0 [PORTCLS]
Fix broken "pointer arithmetics"

svn path=/trunk/; revision=56326
2012-04-03 14:43:52 +00:00
Timo Kreuzer 06314bbad2 [KS]
Fix misuse of UlongToPtr

svn path=/trunk/; revision=56325
2012-04-03 14:31:15 +00:00
Timo Kreuzer de8f033910 [NTOSKRNL]
Don't truncate pointers to 32 bits in pushlock code

svn path=/trunk/; revision=56324
2012-04-03 13:27:45 +00:00
Amine Khaldi f0ae11b629 [WIN32SS]
* Compile diblib only when we use it.

svn path=/trunk/; revision=56323
2012-04-02 18:44:48 +00:00
Amine Khaldi 4a7200a793 [W32KNAPI]
* Adapt to the new subsystem layout.

svn path=/trunk/; revision=56322
2012-04-02 18:43:35 +00:00
Amine Khaldi 38209482a4 [CMAKE]
* CMake automatically handles def files when they're added to the source list, so we don't need to mark it as an external object here.

svn path=/trunk/; revision=56321
2012-04-02 15:27:35 +00:00
Amine Khaldi b5e6b0441c [GDI32_APITEST]
* Addendum to r56319.

svn path=/trunk/; revision=56320
2012-04-02 10:52:54 +00:00
Amine Khaldi a8e7e00b21 [WIN32SS]
* Move win32k headers to win32ss/include.

svn path=/trunk/; revision=56319
2012-04-02 10:52:36 +00:00
Timo Kreuzer 925c587c81 [PSDK/NDK]
- Don't include NDK from winnt.h, instead duplicate NtCurrentTeb inline definition between psfuncs.h and winnt.h as it used to be
- remove duplicated _GENERAL_LOOKASIDE_POOL
- Add missing NTKERNELAPI to ObDereferenceObjectDeferDelete

svn path=/trunk/; revision=56318
2012-04-02 08:28:17 +00:00
Sir Richard 9f28638f51 [NTOS]: Add support for unmapping ARM3 sections. Trunk should now be ready for switching to ARM3 shared-memory, pagefile-backed sections, instead of Ros Mm.
svn path=/trunk/; revision=56317
2012-04-02 07:23:49 +00:00
Sir Richard d7f63e4986 [NTOS]: Correctly handle transition vs free PTEs in MiDecrementShareCount.
svn path=/trunk/; revision=56316
2012-04-02 06:54:41 +00:00
Timo Kreuzer e5c9bc2f70 [XDK/DDK]
Some fixes for Vista/Win7

svn path=/trunk/; revision=56315
2012-04-01 22:30:00 +00:00
Timo Kreuzer 372271d5bf [NDK]
A number of fixes for Vista/Win7, now all C_ASSERTs pass

svn path=/trunk/; revision=56314
2012-04-01 22:25:05 +00:00
Timo Kreuzer dc1ac7bfa3 [NDK]
Add structure layout tests for KTHREAD

svn path=/trunk/; revision=56313
2012-04-01 22:19:32 +00:00
Amine Khaldi b2f0e3cbda [USERINIT]
* Remove an unneeded include.
* Improve the cmake file a bit.

svn path=/trunk/; revision=56312
2012-04-01 22:03:14 +00:00
Amine Khaldi e19d519f52 * Reorganize the whole ReactOS codebase into a new layout. Discussing it will only waste time, so we better have it then talk about it after.
* Put ntoskrnl and ntdll in the same folder, because they both start with nt.
* Place hal next to acpi, they both deal with hardware stuff.
* Move mountmgr next to usb drivers.
* Put the rtl next to the crt, and share as much as possible between the two.
* I'm just kidding, you know, April's fool and all ;)

Here's the real deal:

[WIN32SS]
* And finally, integrate win32k itself into the new file layout. Now the subsystem modules are located close to each other (like gdi32 and ntgdi, or user32 and ntuser).
* Thanks go to the subsystem team for coming up with this nice layout, hopefully this will scale to the whole codebase layout soon.
* Special thanks to Smiley for coming up with this cool idea :)

svn path=/trunk/; revision=56311
2012-04-01 20:42:43 +00:00
Amine Khaldi 85434c6c85 [WIN32SS]
* Move winsrv into win32ss/user/winsrv.

svn path=/trunk/; revision=56310
2012-04-01 18:37:49 +00:00
Amine Khaldi 8ae399c767 [WIN32SS]
* Move win32csr into win32ss/user/win32csr.

svn path=/trunk/; revision=56309
2012-04-01 18:36:08 +00:00
Amine Khaldi 295d782d2c [WIN32SS]
* Move ReactX modules into win32ss/reactx.

svn path=/trunk/; revision=56308
2012-04-01 18:17:07 +00:00
Amine Khaldi dc1326136d [WIN32SS]
* Move the drivers into win32ss/drivers.

svn path=/trunk/; revision=56307
2012-04-01 17:57:24 +00:00
Amine Khaldi bfef8930e0 [USER32_WSPRINTF]
* Add a missing dependency on psdk, revealed by the previous commit.

svn path=/trunk/; revision=56306
2012-04-01 17:32:55 +00:00
Amine Khaldi 7e0cd3140c [WIN32SS]
* Initialize the subsystem restructure. Start by bringing-in gdi32 and user32. Brought to you by the awesome Subsystem Team.

svn path=/trunk/; revision=56305
2012-04-01 17:27:38 +00:00
Timo Kreuzer ee6f35722f [NTOSKRNL]
Use MiFillSystemPageDirectory on amd64, too

svn path=/trunk/; revision=56304
2012-04-01 15:23:08 +00:00
Timo Kreuzer 446c972571 [NDK]
Make KTHREAD structure compatible to WS2003, Vista and Win7 for both x86 and amd64

svn path=/trunk/; revision=56303
2012-04-01 14:29:15 +00:00
Timo Kreuzer a298f67306 [NTOSKRNL]
Sort the C_ASSERTs and add some more.

svn path=/trunk/; revision=56302
2012-04-01 14:15:00 +00:00
Timo Kreuzer d84707fd22 [NTOSKRNL]
- Add a few more C_ASSERTs related to the KTHREAD structure layout

svn path=/trunk/; revision=56301
2012-04-01 13:37:20 +00:00
Timo Kreuzer d188878e4e [NTOSKRNL]
- If neccessary unlock the working set in MiMakeSystemAddressValid before calling MmAccessFault, fixes a failed ASSERT, when coming from NtFreeVirtualMemory
- Remove duplicated ASSERT

svn path=/trunk/; revision=56300
2012-04-01 13:34:18 +00:00
Amine Khaldi ccc0959e61 [CMAKE]
* Implement the _clean targets for the ninja generator.

svn path=/trunk/; revision=56299
2012-04-01 11:43:24 +00:00
Olaf Siejka a2a6c99792 [TRANSLATION]
- turkish translation of dxdiag by Arda Tanrýkulu (bug no. 6986);
- italian translation of browseui by Paolo Devoti (bug no. 6980);


svn path=/trunk/; revision=56298
2012-04-01 10:55:23 +00:00