Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-08-01 18:13:48 +00:00
Code Issues Projects Releases Packages Wiki Activity

- It seems the remaining page fault issue was fixed as well in 56333, so it should now be safe to enable this check. Finally, it is now illegal to page fault in ReactOS with interrupts disabled, as it should be. Previous attempts to fix this were likely hindered by the old memory manager, but ARM3 seems to do its job and doesn't fault on non-paged memory that I believe the old Mm was doing.

Browse source 
- Hacks--;

svn path=/trunk/; revision=56335
This commit is contained in:
Stefan Ginsberg 2012-04-07 01:18:36 +00:00
parent e1c86ddb2d
commit 51de801d45
1 changed files with 1 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

11
reactos/ntoskrnl/ke/i386/traphdlr.c
View file

@ -1190,8 +1190,7 @@ KiTrap0EHandler(IN PKTRAP_FRAME TrapFrame)
/* Enable interupts */
_enable();
#if 0
/* Check if we faulted with interrupts disabled */
/* Check if we came in with interrupts disabled */
if (!(TrapFrame->EFlags & EFLAGS_INTERRUPT_MASK))
{
/* This is completely illegal, bugcheck the system */
@ -1202,14 +1201,6 @@ KiTrap0EHandler(IN PKTRAP_FRAME TrapFrame)
TrapFrame->Eip,
TrapFrame);
}
#else
if (!(TrapFrame->EFlags & EFLAGS_INTERRUPT_MASK))
{
/* Warn and dump stack */
DPRINT1("Page fault with interrupts disabled!\n");
KeRosDumpStackFrames(NULL, 0);
}
#endif
/* Check for S-LIST fault in kernel mode */
if (TrapFrame->Eip == (ULONG_PTR)ExpInterlockedPopEntrySListFault)