"Scrolling by pressing the scrollbar arrows does not draw the arrows as pressed"
Fixed by a patch of JIRA-user 'I_kill_bugs'. Thank you very much!
The regression was introduced by 0.4.11-dev-586-g
929a2c6637
(which itself aimed to fix CORE-13986,
but not CORE-13918 as erroneously stated in commit comment)
cherry-picked from 0.4.14-dev-1167-g
8bb9434d3e
and CORE-15557 "disabled scrollbars being clickable"
gets fixed as well due to squash of 0.4.14-dev-243-g
19fbdda95c
The DbgBreakPoint() was reported to be continuable without
obvious side-effects by Doug Lyons.
Thank you for your tests Doug.
To prevent what end-users may otherwise perceive as a
freeze-regression caused by enabling the new driver in
0.4.13-dev-1048-g
6392c5a78c
not cherry-picked
(as in master USBHUB_NEW has been moved to USBHUB since 0.4.13RC)
but fixed 100% equal to a squash of
0.4.14-dev-881-g
f32e1acd3c
(thanks to author Thomas Faber)
and
0.4.14-dev-1164-g
23f6b36174
CP_UTF8 validation was not strict. 5- or 6-byte length sequences are invalid in RFC 3629 UTF-8. CORE-16468
- Fix MultiByteToWideChar(CP_UTF8, ...) by making check strict.
This will definitely fix regression CORE-16678 which was introduced or unhidden by
0.4.13-dev-927-g
e85664a3d8
and was also reported to bring ros a bit closer towards displaying japanese in ros Notepad with MS Gothic,
but I am not sure, whether it is enough for that already when backported on its own.
cherry picked from commit 0.4.14-dev-193-g
a63678c9a9
Many thanks to the patches author JIRA-user "blueghost"
tibor.fuzi@gmail.com
The patch fixes regression CORE-16703, which was unhidden by explorer commit
8ad0eae687 == SVN r74968
although the root-cause was missing functionality in WIN32SS.
The patch also fixes CORE-16705 and CORE-16706.
Only a few applications still show issues with the taskbar panes,
we have strong indications that other patches in master during
0.4.14-dev'ing already improved the situation further.
This patch (#2396) to date has not been committed to master yet,
but I guess that will happen soon.
TestBot results on 0.4.13-RC-48-g818e5bc:
VBox https://reactos.org/testman/compare.php?ids=71645,71670 LGTM
KVM https://reactos.org/testman/compare.php?ids=71646,71671 LGTM
A very nice set of patches done by Doug Lyons!, Jim Tabor, Colin Finck
to fix:
- a crash on the testbots for comdlg32:printdlg
- erroneous behavior of PrintDlg in _A()-application "Kompozer", namely
- prevents exceptions from being thrown when opening the print dlg
- prevents heap allocations of 0 byte size when opening the print dlg
- prevents a help-button that should be invisible from overlapping other controls
- allows Kompozer to extend the print-dialog with additional controls
- allows combobox to show the printers name, instead of memory garbage
[PRINTING] Improve Stubs for GetPrinterA and GetPrinterDeviceA (#2274)
cherry picked from commit 0.4.14-dev-849-g
acec69a1d7
[WINSPOOL] Add Implementation of EnumPrintersA (#2273)
cherry picked from commit 0.4.14-dev-878-g
e8b177825b
[FORMATTING] Fix indentation of winspool/printers.c
No code changes
cherry picked from commit 0.4.14-dev-879-g
45f39ffc25
[PRINTING] Part of GDI Support
Fix ups and added support to prevent GDI from crashing. These functions
will be required for GDI.
Part 1 of print support.
cherry picked from commit 0.4.14-dev-880-g
adffa8ea75
[WINSPOOL] printers.c: Demote 3 ERR() to TRACE(), Fix 1 copypasta (#2311)
cherry picked from commit 0.4.14-dev-889-g
06f8f80181
[WINSPOOL] Implement GetPrinterDriverA and a helper function UnicodeToAnsiInPlace (#2317)
cherry picked from commit 0.4.14-dev-957-g
d90beaeed2
[WINSPOOL] Fix build
cherry picked from commit 0.4.14-dev-958-g
8da7fbc704
[GDI32] GdiConvertToDevmodeW:
Import WINE commit 32393796bb534e9cf11dd988dce88722c67f7906
("gdi32: GdiConvertToDevmodeW should not refer to unintialized name bytes.")
This makes our GdiConvertToDevmodeW equivalent to the WINE counterpart again.
cherry picked from commit 0.4.14-dev-1031-g
5d8c39753e
[WINSPOOL] Implement DocumentPropertiesA including DEVMODE conversions (#2339)
Co-authored-by: Doug Lyons <douglyons@douglyons.com>
Co-authored-by: Colin Finck <colin@reactos.org>
cherry picked from commit 0.4.14-dev-1035-g
3077c0e43e
By using the capabilities created in CORE-16631.
This will fix many crash-regressions in apps that have "Vista+ready"-manifests.
A good default setting for releases to protect "average Joe".
We think that's a tolerable balance.
E.g: This will fix CORE-16700 and CORE-16707 for releases.
The reason for those crashes is that we have far too many gaps in our apisets still.
Adventurous users have two options in releases if they want to expose more apisets
(and additional crashes when apisets are not implemented yet):
1.) change registry setting "HKLM\SOFTWARE\Policies\Microsoft\Windows\AppCompat" "DisableCompatGuidDetection" back to 0
to switch the global behavior to act like master-state (== opt-out)
or
2.) Select the "Windows 7" shim for example individually per app for more apiset exposure.
(more safe)
Contrary master will remain affected by such crashes and users will
have to manually apply shim "IgnoreManifestCompatVersion" on each affected app for opt-out,
as we intend to abuse master as a testing platform to spot gaps in apisets and problematic apps more quickly.
Thanks to Mark Jansen for having implemented that flexibility.
Fixes symptom "mouse pointer vanishes when closing
applications via x in title-bar"
The bug in WIN32SS was unhidden by SVN r65496 == git
5c1a8109c8
, when we introduced explorer_new. The old explorer
had a workaround built within.
Many thanks to patches author James Tabor.
cherry picked from commit 0.4.14-dev-1012-g
820dbfccd0
By Reverting beginnings of raster-fonts-works (*.fnt and *.fon)
Thanks Katayama Hirofumi MZ for helping with this revert.
The regression was introduced by 0.4.13-dev-681-g
ae99df1675
The fix is a slightly adopted backport of 0.4.14-dev-1009-g
99ba7ea95f
Fixes offset in combo texts and menu highlights.
Fixes CORE-16656 and regression CORE-16644,
which appeared by 0.4.13-dev-209-g
dc7f4f682f
No official release ever was affected fortunately.
cherry picked from commit 0.4.14-dev-966-g
c89e111c6a
Fixes a regression on drawing Wnd background in Solitaire
with VBOX Guest Additions GPU driver with enabled acceleration
Rolling back to Vis, wine throwback. See CORE-16680.
Regression was introduced by 0.4.13-RC-40-g
63f46f3fde
Fix was cherry picked from commit 0.4.14-dev-935-g
2903022199
This will fix symptom "MPC HC 1.7.13 does not draw
part of its GUI anymore"
Fix clip region merging.
Use a new region while merging from the original.
The regression has been introduced by 0.4.13-dev-208-g
94b4b5c127
Fixing it today for RC means, we had not a single affected
official ros release.
cherry picked from commit 0.4.14-dev-830-g
4927905eeb
Fixes symptom "MSVCPP2017 setup crash due to missing export"
The issue very likely got introduced by
0.4.13-dev-986-g
029b8f2cf9
because our loader exports stuff from neweer Windows versions
since then in case an executables manifest states compatibility.
Original commit message from patches author William Kent:
Stub GetCurrentPackageId() (#1942)
* [KERNEL32] Add stub implementation for GetCurrentPackageId() function
This Windows 8+ function is called by WiX bundles (EXE-based installers) upon exit, if the export is present. If it is a stub in the spec, they will crash, even if they are coded to be compatible with Windows XP/ReactOS.
Also add GetCurrentPackageId() forwarder to apiset.
cherry picked from commit 0.4.14-dev-482-g
192926ee02
Fixes symptom
"Adobe Flash player online setup fails downloading itself"
by porting back
0.4.14-dev-560-g
5bd6580fc6
and 0.4.14-dev-716-g
4bf76a659e
and additionally updating README.WINE
Testbots LGTM:
https://reactos.org/testman/compare.php?ids=70898,71103 VBox
https://reactos.org/testman/compare.php?ids=70899,71104 KVM
Thanks to Matthias Basler, Amine Khaldi, Victor Perevertkin.
recent ros releases that were affected by this bug:
0.4.7, 0.4.8, 0.4.12
recent ros releases that were NOT affected by this bug:
- 0.4.6, 0.4.9, 0.4.10, 0.4.11 (thanks to revert)
- 0.4.13, and presumably 0.4.14 (thanks to the proper fix)
Symptom "Far Manager 3.0 Build 5200 can not load NetBox.dll"
due to uncaught exception when accessing GetSystemTimePreciseAsFileTime().
The symptom started to show with 0.4.13-dev-986-g
029b8f2cf9
as LDR exposes more Vista+ stuff since then.
The fix is a selective backmerge of master PR-1963
Symptom: "Far Manager main app unhandled exception when exiting"
The issue started to show with 0.4.13-dev-986-g
029b8f2cf9
Thanks to Mark Jansen for providing this 2nd patch.
cherry picked from commit 0.4.14-dev-654-g
6f93f2cf10
Symptom: "Far Manager main app does not longer start up"
The issue started to show with 0.4.13-dev-986-g
029b8f2cf9
Thanks to Mark Jansen for providing this first patch.
cherry picked from commit 0.4.14-dev-653-g
cabf120833
Both most likely was introduced by activating feature
MiWriteProtectSystemImage() once.
Imho this feature is not stable yet, therefore I disable
it for releases.
Confirmation of reporters will have to be collected after
the commit.
Both problems most likely got visible by 0.4.12-dev-386-g
65dbfc2868
Master remains affected for now.
If no fix will appear during 0.4.14-dev'ing, then I will
commit this to master as well in 3months.
This fixes CORE-16498, which got considerably more severe by
0.4.13-dev-209-g
dc7f4f682f
Thanks to the patches author Jim Tabor.
I merged manually analog 0.4.14-dev-594-g
5214a38fd0
since support for secure screensaver desktop is not
completely implemented in Winlogon.
This fixes a regression introduced between
0.4.10-dev-579-gc697f19 and 0.4.10-dev-582-g3270979
fix cherry picked from commit 0.4.14-dev-581-g
40db385716
This prevents ReactOS asserting when 'My computer'
is opened, while it tries to send commands to floppy drive.
Many thanks to patches author Doug Lyons.
The regression was introduced by 0.4.13-dev-1081-g
eeff926ede
patch was not committed to master yet,
hbelusca continues investigation
Make "shutdown.bmp" (IDB_SHUTDOWN_MSG: 213x11px) horizontally centered.
This fixes a regression of 0.4.13-dev-961-g
238ea69ca0
Fix cherry picked from commit 0.4.14-dev-546-g
55aed4f8fa
This version (after .rsrc) works different than the
proper version I used for 0.4.12 (after .reloc).
Inserting after .rsrc as actually not correct, but Thomas believes it can
be used as a temporary trick to avoid random memory corruption upon
relocations of the kernel, caused by ROSBE-154.
I follow his advice, although when judging from practical tests only:
as long as we limit this script to NTOSKRNL like I do for releases
there have no negative consequences been observed in real life yet
even with the proper version of 0.4.12.
Up to now those problems have only been observed when used for drivers
MODULE TYPE sdk/cmake/gcc.cmake as well, like
it was tried for a moment in master 0.4.13-dev-609-g
c4d8e2a6e9
Using for drivers immediately did lead to BSODs like CORE-16183 and therefore was
mitigated in master by total disabling of the scripts for both,
kernel and drivers in
0.4.13-dev-621-g
36e9a6f8dd
To allow installing DVDWritenow without BSOD,
we need the script at least for ntoskrnl!
Master remains affected by the BSOD until Thomas allows to commit there as well.
I doubt it helps for CORE-5007 (as it was stated in master),
that ticket most likely got fixed beforehand already.
But I already tested: Delay-loading fixes CORE-15795,
which was unhidden by 0.4.12-dev-632-g
d93e516747
The fix by delay loading was cherry picked from commit
0.4.14-dev-475-g
82b758974f
It's not just a workaround, Windows delay-loads like that as well.
Thomas believes this specific delay-load will not trigger
the LD bug CORE-6504 within our gcc toolchain.
Thanks for help of Mark Jansen, Thomas Faber and Fabian Maurer.
Many Thanks to patches author JIRA user 'I_Kill_Bugs',
but also to Doug Lyons and Fabian Maurer.
Unhidden by SVN r75735 == git 0.4.7-dev-168-g
6af37fd54e
cherry-picked from 0.4.14-dev-312-g
b931f643e3
To fix regression CORE-16497 "Chromium BSU setup using wrong font"
It is a good idea to add micross.ttf, but we should not use
"Liberation Sans" as template but instead either create it from scratch
or at least use something with the same metrics as the MS font.
Maybe "Tahoma" would have been a better starting point?
In Windows 2k3sp2 "Tahoma" and "MS Sans Serif" are not the same binary,
but they look almost identical to the human eye.
This reverts commit 0.4.13-dev-796-g
eefc544202
Symptom: stacklog via 'bt' command in gcc+kdbg regressed in certain cases.
This reverts the guilty commit 0.4.13-dev-514-g
3c8f19eb21.
But also reverts 2 tightly related follow-up commits
0.4.13-dev-515-g
04906f2abb
and
0.4.13-dev-516-g
4d5a2dd0f3
We revert only in RC, but master remains affected for now,
the developers aim to fix master by WIP PR#2003 later.
I considered following the bleeding-edge-development being
too risky here. Many unrelated changes in master since then.
To fix regression CORE-16467 which was caused
by adding encoding-heuristic in 0.4.13-dev-927-g
e85664a3d8
fix cherry picked from commit 0.4.14-dev-184-g
142d16c8a0
which caused images to be loaded up to MmHighestUserAddress,
thus overwriting the shared user page.
This is now fixed by using MM_HIGHEST_VAD_ADDRESS as the margin instead.
This commit allows again to load WIN32K.sys of Win2K3SP2
which regressed by SVN 67793 == git
3565260212
cherry picked from commit 0.4.14-dev-143-g
56da95671c
When Themesvc was disabled, some Window titlebar
frames were drawn too thin until the window
was actively resized in y by the user.
That and similar symptoms started to show up after SVN r68904 ==
6dfa71c487
Many thanks to patches author Doug Lyons.
We leave the ticket unresolved still due to explicit request of
James Tabor, who wants to continue working in that context.
cherry picked from commit 0.4.14-dev-121-g
9e14a762d5
Many 3D applications crashed with 'WineD3D fake window' msgbox
if they were used in VirtualBox with graphics driver
'VBoxDisp.sys from VM guest additions + installed 3D acceleration'
That was a regression of SVN r75847 == git
3d13ed394e
Contrary we had no such issues with the SW emulation.
The reason for the bug is that
VBoxDisp only supports OpenGL 2.1 (GLSL 120) and WineD3D
tried to use shaders for OpenGL 3.2 (GLSL 150).
This workaround disables the usage in a hard-coded way for
all graphics adapters. Should be ok for now, as ros does not
really support any modern GPU drivers yet.
Proper working runtime detection would be better ofc.
Thx to Doug Lyons & Fabian Maurer
cherry picked from commit 0.4.14-dev-113-g
082f230ac7
CORE-16375 #1914
Thanks to patches author ThFabba.
According to JIRA user 'Zero3k' this allows to format a
BTRFS drive again without INVALID_KERNEL_HANDLE BSOD.
Master remains affected,
our devs wait for upstream integration
of a search result again.
The feature regressed by 0.4.13-dev-1133-g
a3ee648d8b
I chose the shorter solution of Brock Mammen instead
of the patch of Doug Lyons from PR1960.
Still many thanks to Doug Lyons for his encouragement
in creating a fix as well and performing
regression-testing.
cherry picked from commit 0.4.14-dev-39-g
cd2a274ef7
Shell Find Improvement to make Search Item general by adding asterisks
before and after before search and show sub-directories in find listing. CORE-16152
cherry picked from commit 0.4.14-dev-9-g
b6b7bda443
Symptom:
The menu popup position for language selection in UltraIso regressed
It regressed by 0.4.13-dev-791-g
a59df3858c
Many thanks to the author Mark Jansen.
The fix has not been committed to master yet, but I hope
the PR will be merged during the next days as well.
JIRA-user "Illen" reported booting from his Z170 controller worked up to
0.4.12-dev-936-g89aaf0e
and would refuse booting - beginning with uniata commit
0.4.12-dev-937-g
b546130731
For sure this workaround is just a temporary and no proper solution,
but was confirmed to be working by "Illen".
We have no clear understanding of the real bug yet.
Can be replaced by something better at any time.
It was just committed into the RC, master remains affected.
cherry picked from previous release
commit a57363f363
In order to avoid a regression with Cyrillic text in Inno Setup 5.6.1
and Magma visual style
The regression was introduced by 0.4.13-dev-1009-g
ca967db5ca
- Replace "Verdana", "Verdana Bold", "Verdana Bold Italic" and
"Verdana Italic" fonts by duplicating "DejaVu Sans" fonts and renaming them.
- Replace LICENSE file.
I made these font files by using FontForge. Their family name is "Verdana".
Their display names are "Verdana", "Verdana Bold", "Verdana Bold Italic"
and "Verdana Italic". Their font filenames are verdana.ttf, verdanab.ttf,
verdanaz.ttf and verdanai.ttf.
The Underline Positions are hacked by adding
an integer value for workaround of FontForge's bug.
cherry picked from commit 0.4.14-dev-6-g
f45dd65773
Fixes the icons on some buttons being flipped vertically.
Known affected apps: Lazarus IDE, Double Commander, Peazip.
Beside that it also fixes transparency regressions in DVDStyler 3.0.4 (CORE-14701).
Thanks to patches author Doug Lyons.
The patch has not been committed to master yet and has the known side-effect
of introducing flipped icons in the options-listview of Double-Commander
that are drawn correctly without the hackfix.
Like in last releases.
Pierre recommended this hack-fix for 0.4.8rls before.
Avoids "GetVolumeInformation now fails on NFS volume"
I will not retest any RDBSS functionality myself in my tests,
maybe some other tester would be kind enough to retest this?
Please note that I replaced #if 0 with #if 1
as discussed with Pierre. That's different to the patch in ticket.
like in last release
(cherry picked from commit 26080d0c64)
GCC Linux build had no issues with the last commit in D3DCOMPILER_43 but
MSVC x86 & x64 v18.0.31101.0 choked on it with
error C4133: 'function' : incompatible types - from 'D3D_PRIMITIVE *' to 'DWORD *'
and similar.
MSVC v18.0.31101.0, target x86 and x64, flagged C4133 as error
MSVC v16.0.40219.1, target x86, flagged C4133 as warning
cherry picked from commit 0.4.14-dev-8-g
36d9e80add
