Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-04-05 21:21:33 +00:00
Code Issues Projects Releases Packages Wiki Activity

[0.4.13][USBHUB_NEW] Demote a DbgBreakPoint CORE-16394

Browse source 
The DbgBreakPoint() was reported to be continuable without
obvious side-effects by Doug Lyons.
Thank you for your tests Doug.

To prevent what end-users may otherwise perceive as a
freeze-regression caused by enabling the new driver in
0.4.13-dev-1048-g
6392c5a78c

not cherry-picked
(as in master USBHUB_NEW has been moved to USBHUB since 0.4.13RC)
but fixed 100% equal to a squash of
0.4.14-dev-881-g
f32e1acd3c
(thanks to author Thomas Faber)
and
0.4.14-dev-1164-g
23f6b36174
This commit is contained in:
Joachim Henze 2020-03-11 01:58:39 +01:00
parent e22ac0c2b9
commit 6a5e1328a4
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
drivers/usb/usbhub_new/ioctl.c
View file

@ -25,6 +25,7 @@ USBH_SelectConfigOrInterfaceComplete(IN PDEVICE_OBJECT DeviceObject,
PUSBHUB_PORT_DATA PortData = NULL;
NTSTATUS Status;
KIRQL OldIrql;
PURB Urb;
DPRINT("USBH_SelectConfigOrInterfaceComplete ... \n");
@ -69,8 +70,13 @@ USBH_SelectConfigOrInterfaceComplete(IN PDEVICE_OBJECT DeviceObject,
}
else
{
DPRINT1("USBH_SelectConfigOrInterfaceComplete: Status != STATUS_SUCCESS. FIXME\n");
DbgBreakPoint();
Urb = URB_FROM_IRP(Irp);
DPRINT1("USBH_SelectConfigOrInterfaceComplete: Status = 0x%lx, UsbdStatus = 0x%lx\n", Status, Urb->UrbHeader.Status);
if (Urb->UrbHeader.Status == USBD_STATUS_NO_BANDWIDTH)
{
DPRINT1("USBH_SelectConfigOrInterfaceComplete: USBD_STATUS_NO_BANDWIDTH. FIXME\n");
/*DbgBreakPoint();*/ /* disabled due to CORE-16384, seems to be continuable */
}
}
return Status;