Commit graph

1125 commits

Author SHA1 Message Date
Giannis Adamopoulos 3419e8ae60 [WIN32K] -MENU_TrackMouseMenuBar: Use IntGetSystemMenu instead of get_win_sys_menu because the system menu have not been initialized yet (it is delay initialized). CORE-12801
svn path=/trunk/; revision=74276
2017-04-05 09:09:50 +00:00
Giannis Adamopoulos 837f2ae4cb [WIN32K] -Correct one parameter in NtUserPaintMenuBar and make it return the height of the menu bar.
[UXTHEME] -Pass the correct parameter to PaintMenuBar. Draw the edge of WS_EX_CLIENTEDGE even if the window has a themed frame.

svn path=/trunk/; revision=74260
2017-04-01 10:18:40 +00:00
James Tabor 667ce623d5 [Win32SS]
- Patch by Alex Henrie : Translate WM_(NC)XBUTTONUP to WM_APPCOMMAND in DefWindowProc.
- Modified for ReactOS.

svn path=/trunk/; revision=74258
2017-04-01 02:01:59 +00:00
Giannis Adamopoulos bf3b8cd273 [WIN32K] -Store the flat menus setting and the drop shadow setting in the UserPreferencesMask registry value.
svn path=/trunk/; revision=74256
2017-03-31 22:27:13 +00:00
James Tabor 0258ba9082 [NtUser]
- Add additional information from CORE-9667 thememenu.patch so it does not get lost.

svn path=/trunk/; revision=74255
2017-03-31 21:57:20 +00:00
Giannis Adamopoulos c788005b8c [WIN32K] -Get the new value of SPI_SETFLATMENU from pvParam.
svn path=/trunk/; revision=74253
2017-03-31 19:04:31 +00:00
Giannis Adamopoulos 4daf6ffcbc [WIN32K] -Stub NtUserPaintMenuBar. I'm still not sure about the last parameter and its return value.
svn path=/trunk/; revision=74251
2017-03-31 18:05:27 +00:00
Giannis Adamopoulos 2a507824c6 [WIN32K] -Update the prototype of NtUserPaintMenuBar here as well.
svn path=/trunk/; revision=74250
2017-03-31 17:17:35 +00:00
Sebastian Gasiorek c6af963e8d [NTUSER] Lock before getting DesktopDC. Fixes crash during loading DirectX CORE-7733
svn path=/trunk/; revision=74142
2017-03-10 16:33:45 +00:00
James Tabor e0eab0e64c [NtUser]
- Remove scroll bar search that sends another WM_NCCALCSIZE message. Use wine as an example. See CORE-12827.

svn path=/trunk/; revision=74116
2017-03-06 18:28:03 +00:00
Hermès Bélusca-Maïto 71c5ed5c2f [USER32]: Use RtlInitEmptyUnicodeString where needed. Fix CID 1401230 and CID 701428 in the process.
svn path=/trunk/; revision=74071
2017-03-05 01:20:40 +00:00
Hermès Bélusca-Maïto 254b1fbb03 [USER32]: Trim trailing whitespace + few code style changes only.
svn path=/trunk/; revision=74070
2017-03-05 01:19:07 +00:00
Thomas Faber fd343d21dd [USER32]
- Fix overflow check in SetScrollRange. CID 731535
CORE-12763 #resolve

svn path=/trunk/; revision=74059
2017-03-04 19:02:30 +00:00
Hermès Bélusca-Maïto 41733bc328 [USER32]: Now for the real fix: Initialize lpLibFileName and pCtx in User32CreateWindowEx prior to calling ClassNameToVersion.
This avoid passing invalid parameters to VersionRegisterClass (and subsequent functions) afterwards.
Fix suggested by Mark Jansen, thanks!
CORE-12855

svn path=/trunk/; revision=74018
2017-03-01 19:36:51 +00:00
Hermès Bélusca-Maïto 0366c75f60 [USER32]: Fix formatting in User32CreateWindowEx, no code changes.
svn path=/trunk/; revision=74017
2017-03-01 19:23:27 +00:00
James Tabor 3238412b08 [NtUser]
- Move functions around.

svn path=/trunk/; revision=74015
2017-03-01 16:51:13 +00:00
Hermès Bélusca-Maïto d2f5096281 [NTUSER]: NtUserGetObjectInformation, nIndex == UOI_FLAGS case:
- Capture the ObjectFlags to be set in a local variable,
- Then copy its contents in the mem area pointed by pvInformation *under the SEH block*! This allows:
  * protection if pvInformation is an invalid pointer;
  * avoid to run the "RtlCopyMemory(pvInformation, pvData, nDataSize);" afterwards with pvData == NULL.

svn path=/trunk/; revision=74005
2017-02-28 20:49:37 +00:00
James Tabor 69dba98f6b [NtUser]
- Patch to level up scroll bar code, based on mudhead patch. See CORE-12827.

svn path=/trunk/; revision=74003
2017-02-28 17:11:08 +00:00
Kamil Hornicek f36d39ae3a [WIN32K]
- Clean up after myself. Thanks, Giannis and Thomas.

svn path=/trunk/; revision=73890
2017-02-22 21:18:18 +00:00
Hermès Bélusca-Maïto 08315aa914 [WIN32K]: Replace some checks against UserGetDesktopWindow() and UserGetMessageWindow() by checks against FNID_xxx flags.
Fixes some FIXMEs in the code encountered while investigating the origin of "err: NtUserSetWindowPos bad window handle!" messages.
Reviewed by James Tabor.
CORE-12819

svn path=/trunk/; revision=73889
2017-02-22 20:19:50 +00:00
James Tabor 81652fd827 [Win32SS]
- Implement Exclude Update Region, for testing. See CORE-12649.

svn path=/trunk/; revision=73888
2017-02-22 17:50:38 +00:00
James Tabor 482d43b875 [Win32SS]
- Implement Fill Window, for testing.

svn path=/trunk/; revision=73887
2017-02-22 17:45:19 +00:00
Giannis Adamopoulos ae875ccc88 [WIN32k] -Remove overzealous assertion that prevents boot.
svn path=/trunk/; revision=73882
2017-02-22 11:59:42 +00:00
Kamil Hornicek 4f72307675 [NTUSER]
- Prevent a null to be passed to UserDereferenceObject in UserSetCursorIconData. CID 1321971
- Make the status check in co_IntCallSentMessageCallback less useless. CID 1322014
- Prevent a null pointer dereference in a trace in IntCreateClass. CID 514617

svn path=/trunk/; revision=73879
2017-02-22 10:29:03 +00:00
James Tabor c87e532dcb [NtUser]
- If an appication hangs other than suspended use Hung test to prevent locking the whole system. Quick fix for CORE-10078.

svn path=/trunk/; revision=73876
2017-02-22 00:25:13 +00:00
James Tabor 9accb03ac7 [NtUser]
- Fix : Allow controls to receive non-client messages. See CORE-12771.
- See also https://bugs.winehq.org/show_bug.cgi?id=42503 .

svn path=/trunk/; revision=73875
2017-02-22 00:01:13 +00:00
Thomas Faber ea43e3d3dc [USER32][UXTHEME]
- Make API hooks type-safe. Fixes stack pointer corruption when calling ThemeGetScrollInfo. Powered by /RTC1

svn path=/trunk/; revision=73862
2017-02-20 17:31:50 +00:00
Kamil Hornicek ca4c2640e7 [WIN32K]
- Don't try to delete the pattern bitmap in UserInitialize.
- Set the correct owner before deleting the update region in co_UserFreeWindow.
- Fixes some "Trying to delete global object" debug prints.

svn path=/trunk/; revision=73855
2017-02-20 10:10:37 +00:00
Giannis Adamopoulos c607de714c [WIN32k]
-Fix a couple of cases where we use the versioned class atom instead of the non versioned one.

[USER32]
- Add support for versioned classes in RegisterClassExWOWW, GetClassInfoExW, GetClassInfoExA, UnregisterClassA, UnregisterClassW, and User32CreateWindowEx
- Make ClassNameToVersion return the name of the versioned class and the library name that implements it while preserving a hack that lets user32 know which classes are registered by comctl32 (this is needed because the default activation context doesn't contain the non versioned classes yet).
- Make VersionRegisterClass to load the specified library and make it register its classes which is used when the class is not registered yet but its manifest is active.

svn path=/trunk/; revision=73806
2017-02-17 11:07:14 +00:00
Thomas Faber 25d242883a [WIN32K:NTUSER]
- Kill a noisy debug print

svn path=/trunk/; revision=73785
2017-02-12 23:09:35 +00:00
Giannis Adamopoulos f349496e1d [USER32] -class.c: Try to use 4 space indentation. Convert tabs to spaces.
svn path=/trunk/; revision=73773
2017-02-11 12:18:06 +00:00
James Tabor ebc1f941e0 [User32]
- Patch by Dmitry Timoshkov : Fix groupbox rectangle calculation in the button's WM_SETTEXT handler. BUTTON_CalcLabelRect should use the button font. Otherwise WM_SETTEXT handler gets wrong rectangle to erase an old text.
- Fixes CORE-12464.

svn path=/trunk/; revision=73768
2017-02-10 16:05:15 +00:00
Eric Kohl bcb2480c3c [VARIOUS]
- Complete and updated translation for: runonce, winlogon, deskadp, deskmon, slayer, user32 and winsrv.
- Added right-to-left extended style for all dialogs.
Patch by Baruch Rutman.
CORE-6904 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=73717
2017-02-05 21:52:49 +00:00
Kamil Hornicek 73bb103c3c [KBSWITCH]
- Don't fall through to the default label. CID 515166

[NTUSER]
- Fix a copypasta.

[USER32]
- Fix computing of HKL for layouts with Layout id.
- Don't call NtUserLoadKeyboardLayoutEx with bogus keyboard layout id.
- Ideally LoadKeyboardLayout should return the default system layout on failure - to be continued.

svn path=/trunk/; revision=73708
2017-02-05 15:42:23 +00:00
Kamil Hornicek 5fd3611831 [TRANSLATIONS]
- fix, update and add some czech translations + two tiny "improvements" in english ones

In case anyone wants to continue - these modules lack czech resources completely:
(and I suggest doing getuname first)
clip comp doskey eventcreate mode taskkill tree whoami wmic xcopy ipconfig net clb diskpart acppage fontext browseui getuname iernonce lsasrv modemui msports rasdlg samsrv tapiui localmon

svn path=/trunk/; revision=73662
2017-02-01 14:45:59 +00:00
James Tabor bfd112dafa - Fix leak.
svn path=/trunk/; revision=73543
2017-01-13 19:35:36 +00:00
James Tabor 6d7fcc4bab [NtUser]
- Fix menu surfing while using MS Office 2003. See CORE-12085 and CORE-12071.

svn path=/trunk/; revision=73532
2017-01-13 04:06:24 +00:00
Mark Jansen e8801e23b6 [WIN32SS] Don't trigger ProbeForWrite when retrieving caret size from co_IntDrawCaret, fix unlocking in failure path. CORE-10308
svn path=/trunk/; revision=73517
2017-01-09 21:12:00 +00:00
James Tabor 527c11cf4d [Win32SS|RTL]
- Fix clipping for Draw Text. Inspired by Katayama Hirofumi MZ patch and ComCtl32/RichEd20/UxThmems. See CORE-2201.

svn path=/trunk/; revision=73475
2016-12-22 16:39:33 +00:00
James Tabor 7761bf28ba [User32|RTL]
- Move TEXT_TabbedTextOut back into User32.

svn path=/trunk/; revision=73474
2016-12-22 06:51:32 +00:00
James Tabor 8f83c019d3 [User32]
- Patch by Katayama Hirofumi MZ : DrawFrameControl draws bad, correct centering while drawing radio buttons. See CORE-12573.

svn path=/trunk/; revision=73471
2016-12-19 16:41:32 +00:00
James Tabor 30ff1f1032 [User32]
- Patch by Roman Pi?l : Fix buffer overflow in EDIT_EM_ReplaceSel().

svn path=/trunk/; revision=73470
2016-12-19 16:37:44 +00:00
James Tabor 1140838644 [User32]
- Patch by Andrey Gusev : Add support for WS_EX_RIGHT style.

svn path=/trunk/; revision=73469
2016-12-19 16:36:12 +00:00
James Tabor c88489858d [User32]
- Patch by Katayama Hirofumi MZ : DrawFrameControl draws bad. See CORE-12573.

svn path=/trunk/; revision=73451
2016-12-13 17:49:34 +00:00
James Tabor d41da9f33b [User32]
- Sync/Port wine UI code for drawing.

svn path=/trunk/; revision=73450
2016-12-13 17:27:37 +00:00
James Tabor 8fc6f71e55 [Win32SS]
- Revert HAX : Fix validating region with null. See CORE-12169 and related issues.

svn path=/trunk/; revision=73403
2016-11-28 16:48:39 +00:00
James Tabor 03c1491725 [Win32SS]
- HAX : Fix paint message spam. See CORE-12169 and related issues.

svn path=/trunk/; revision=73372
2016-11-24 18:18:28 +00:00
James Tabor 6f403240d9 [User32]
- Fix dialog pop up flicker. Regression from 73333.

svn path=/trunk/; revision=73359
2016-11-23 15:42:05 +00:00
James Tabor b45fe0d55c [Win32SS]
- Patch by Katayama Hirofumi MZ : Improves NC_IconForWindow function. See CORE-12129.

svn path=/trunk/; revision=73334
2016-11-22 04:46:58 +00:00
James Tabor 20637bd50c [User32]
- Fix dialog pop up crash due to loop.
- Sync/Port from wine head, not sure about Staging.

svn path=/trunk/; revision=73333
2016-11-22 03:57:48 +00:00