Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-07-02 02:34:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

[NTUSER]: NtUserGetObjectInformation, nIndex == UOI_FLAGS case:

Browse source 
- Capture the ObjectFlags to be set in a local variable,
- Then copy its contents in the mem area pointed by pvInformation *under the SEH block*! This allows:
  * protection if pvInformation is an invalid pointer;
  * avoid to run the "RtlCopyMemory(pvInformation, pvData, nDataSize);" afterwards with pvData == NULL.

svn path=/trunk/; revision=74005
This commit is contained in:
Hermès Bélusca-Maïto 2017-02-28 20:49:37 +00:00
parent eeb2923366
commit d2f5096281
1 changed files with 28 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

52
reactos/win32ss/user/ntuser/winsta.c
View file

@ -671,9 +671,10 @@ NtUserGetObjectInformation(
DWORD nLength,
PDWORD nLengthNeeded)
{
PWINSTATION_OBJECT WinStaObject;
PDESKTOP DesktopObject = NULL;
NTSTATUS Status;
PWINSTATION_OBJECT WinStaObject = NULL;
PDESKTOP DesktopObject = NULL;
USEROBJECTFLAGS ObjectFlags;
PVOID pvData = NULL;
DWORD nDataSize = 0;
@ -690,7 +691,7 @@ NtUserGetObjectInformation(
}
_SEH2_END;
/* try windowstation */
/* Try window station */
TRACE("Trying to open window station %p\n", hObject);
Status = ObReferenceObjectByHandle(hObject,
0,
@ -701,7 +702,7 @@ NtUserGetObjectInformation(
if (Status == STATUS_OBJECT_TYPE_MISMATCH)
{
/* try desktop */
/* Try desktop */
TRACE("Trying to open desktop %p\n", hObject);
WinStaObject = NULL;
Status = IntValidateDesktopHandle(hObject,
@ -718,29 +719,25 @@ NtUserGetObjectInformation(
TRACE("WinSta or Desktop opened!!\n");
/* get data */
/* Get data */
switch (nIndex)
{
case UOI_FLAGS:
nDataSize = sizeof(USEROBJECTFLAGS);
if (nLength >= nDataSize)
{
PUSEROBJECTFLAGS ObjectFlags = pvInformation;
{
/* This is a default implementation that does almost nothing */
ObjectFlags.fInherit = FALSE;
ObjectFlags.fReserved = FALSE;
ObjectFlags.dwFlags = 0;
ObjectFlags->fInherit = 0;
ObjectFlags->fReserved = 0;
ObjectFlags->dwFlags = 0;
Status = STATUS_SUCCESS;
}
else
{
Status = STATUS_BUFFER_TOO_SMALL;
}
pvData = &ObjectFlags;
nDataSize = sizeof(ObjectFlags);
Status = STATUS_SUCCESS;
ERR("UOI_FLAGS unimplemented!\n");
break;
}
case UOI_NAME:
{
if (WinStaObject != NULL)
{
pvData = WinStaObject->Name.Buffer;
@ -754,10 +751,14 @@ NtUserGetObjectInformation(
Status = STATUS_SUCCESS;
}
else
{
Status = STATUS_INVALID_PARAMETER;
}
break;
}
case UOI_TYPE:
{
if (WinStaObject != NULL)
{
pvData = L"WindowStation";
@ -771,8 +772,11 @@ NtUserGetObjectInformation(
Status = STATUS_SUCCESS;
}
else
{
Status = STATUS_INVALID_PARAMETER;
}
break;
}
case UOI_USER_SID:
Status = STATUS_NOT_IMPLEMENTED;
@ -785,7 +789,7 @@ NtUserGetObjectInformation(
}
Exit:
if (Status == STATUS_SUCCESS && nLength < nDataSize)
if ((Status == STATUS_SUCCESS) && (nLength < nDataSize))
Status = STATUS_BUFFER_TOO_SMALL;
_SEH2_TRY
@ -793,7 +797,7 @@ Exit:
if (nLengthNeeded)
*nLengthNeeded = nDataSize;
/* try to copy data to caller */
/* Try to copy data to caller */
if (Status == STATUS_SUCCESS)
{
TRACE("Trying to copy data to caller (len = %lu, len needed = %lu)\n", nLength, nDataSize);
@ -806,11 +810,11 @@ Exit:
}
_SEH2_END;
/* release objects */
if (WinStaObject != NULL)
ObDereferenceObject(WinStaObject);
/* Release objects */
if (DesktopObject != NULL)
ObDereferenceObject(DesktopObject);
if (WinStaObject != NULL)
ObDereferenceObject(WinStaObject);
if (!NT_SUCCESS(Status))
{