Commit graph

32688 commits

Author SHA1 Message Date
Cameron Gutman 8ffee924f5 - Fix build
svn path=/trunk/; revision=36498
2008-09-24 23:48:28 +00:00
Cameron Gutman 564e5b5a2c Merge aicom-network-fixes up to r36496
- We now call the MiniportCheckForHang handler every two seconds
 - We reset the miniport if it has detected a hang
 - Added some IRQL checks

svn path=/trunk/; revision=36497
2008-09-24 23:39:17 +00:00
Stefan Ginsberg ef2bb65235 - MiQueryVirtualMemory shouldn't be called for kernel memory, so remove the special case code for a kernel address space. Also fixes a case where we would dereference an uninitialized pointer.
- Fix for Coverity Error CID: 773

svn path=/trunk/; revision=36494
2008-09-24 19:13:08 +00:00
Stefan Ginsberg a9d6e4341e - Remove deprecated macro
svn path=/trunk/; revision=36493
2008-09-24 18:47:24 +00:00
Stefan Ginsberg c1a36080a7 - Add ObpValidateAccessMask stub (only returns success for now) and call it from ObInsertObject
- Fix for Coverity Error CID: 9

svn path=/trunk/; revision=36491
2008-09-24 17:32:14 +00:00
Stefan Ginsberg c2ca8fb596 - HalpXboxReadSector: Fail if we are out of memory instead of dereferencing null
- Fix for Coverity error CID: 464

svn path=/trunk/; revision=36490
2008-09-24 17:16:25 +00:00
Stefan Ginsberg ba22ca771d - IoFlushAdapterBuffers: "AdapterObject" is not an optional parameter, it is vital to identify the DMA adapter. Remove the check which confused Coverity and ASSERTify this instead.
- Fix for Coverity error CID: 155

svn path=/trunk/; revision=36489
2008-09-24 17:11:35 +00:00
Christoph von Wittich e724baacde more correct fix
svn path=/trunk/; revision=36488
2008-09-24 16:57:29 +00:00
Stefan Ginsberg d91564734d - IopGetDiskInformation: Fail if we are out of memory instead of dereferencing null
- Fix for Coverity error CID: 469
- Also fix a (potential) memory leak

svn path=/trunk/; revision=36487
2008-09-24 16:37:35 +00:00
Stefan Ginsberg e57cfa2826 - Only dereference the KCB if we know it exists
- Fix for Coverity error CID: 279

svn path=/trunk/; revision=36486
2008-09-24 16:19:52 +00:00
Christoph von Wittich d82ca9895d check for value > 0 before using it as array index
Fix for Coverity error CID: 438

svn path=/trunk/; revision=36485
2008-09-24 15:42:33 +00:00
Stefan Ginsberg 649b40cd13 - 64 bit fixes for Mm routines: Use SIZE_T and ULONG_PTR where appropriate
- Note: MSDN is wrong about Nt/ZwAllocateVirtualMemory's ZeroBits. It really is a ULONG_PTR.

svn path=/trunk/; revision=36484
2008-09-24 15:27:54 +00:00
Stefan Ginsberg 9bbb8ab1a3 - FsRtlBalanceReads: Fail if we are out of memory instead of dereferencing null
- Fix for Coverity error CID: 465

svn path=/trunk/; revision=36483
2008-09-24 15:04:59 +00:00
Stefan Ginsberg 85033039ab - RawQueryFsSizeInfo: Fail if we are out of memory instead of dereferencing null
svn path=/trunk/; revision=36482
2008-09-24 14:53:28 +00:00
Stefan Ginsberg 74897bfee4 - Fix some non-x86 FLOATOBJ_*
svn path=/trunk/; revision=36481
2008-09-24 14:01:43 +00:00
Art Yerkes c261b9dbe8 Fix leaks reported by coverity 612-615. In each case, it'd be safe to free
NULL, and failure to allocate isn't the only dropthrough case, leading to
conversion buffer leaks.

svn path=/trunk/; revision=36480
2008-09-24 13:35:37 +00:00
Art Yerkes 4046f15afe Fix my copypasta spotted by (coverity 1294)
svn path=/trunk/; revision=36479
2008-09-24 12:56:30 +00:00
Daniel Reimer c96b189f38 Bug 3726: Translate file: netshell by Lars Martin Hambro
Bug 3729: Italian translation update by Paolo Devoti
Bug 3738: slovak translations and fixes by Mario Kacmar
Bug 3741: Korean translation of Taskmgr by Sengyu Kim

svn path=/trunk/; revision=36472
2008-09-24 11:22:08 +00:00
Timo Kreuzer c00f4a266c - remove old test code
svn path=/trunk/; revision=36471
2008-09-24 11:17:33 +00:00
Aleksey Bragin f05e50b409 - Create a VdmpInitialize function for NtVdmControl's initialize command.
- Remove NtEarlyVdmInitialize hack and csrss IVT/BDA copying hack, instead, copy the first page of physical memory to the beginning of process's virtual address space like NT does.

svn path=/trunk/; revision=36459
2008-09-24 10:06:08 +00:00
Aleksey Bragin 200665fb89 Juriy Sidorov <jura@cp-lab.com>
- Fix existing font substitutions.
- Add FreeMono as substitution for Courier and Courier New.
- Optimize font substitution tables and make them easy to maintain.
See issue #3483 for more details.

svn path=/trunk/; revision=36451
2008-09-24 08:17:15 +00:00
Aleksey Bragin b20633a1f0 - Make SmCreateUserProcess accept two flags: the old "wait for" one, and a new "reserve 1Mb" one. NT reserves lower 1MB of address space when starting a subsystem process. ReactOS should too, however right now this change is disabled (leads to boot problems).
svn path=/trunk/; revision=36450
2008-09-24 08:12:41 +00:00
Andrew Munger 68b1f10bef Remove a overzealous check. MSDN says to avoid calling with NumberOfBytes == 0, but it is valid.
Addresses bug 3715.

svn path=/trunk/; revision=36449
2008-09-24 07:52:19 +00:00
Aleksey Bragin 9185bead4e - Fix ~4.4 million handle limit bug due to memory corruption. ReactOS can now create 16 million handles as expected (thanks Alex).
svn path=/trunk/; revision=36439
2008-09-23 20:44:31 +00:00
Stefan Ginsberg c3320e0a31 - Attempt satisfy Alex
svn path=/trunk/; revision=36436
2008-09-23 19:54:13 +00:00
Ged Murphy 504c3f3278 Don't risk a negative array subscript. Fixes our one and only REVERSE_NEGATIVE error
Fix for Coverity error CID: 766

svn path=/trunk/; revision=36435
2008-09-23 19:02:32 +00:00
Christoph von Wittich b13cfee486 return correct value in SETUPAPI_GetCurrentHwProfile
Fix for Coverity error CID: 782

svn path=/trunk/; revision=36434
2008-09-23 18:44:58 +00:00
Gregor Brunmar 931c14a8ea D3D9:
* More init values when creating a texture

svn path=/trunk/; revision=36429
2008-09-23 17:01:40 +00:00
Stefan Ginsberg ad277c0c6b - Add basic tracing to CmpReferenceKeyControlBlock, CmpDereferenceKeyControlBlock and CmpDereferenceKeyControlBlockWithLock
svn path=/trunk/; revision=36428
2008-09-23 14:15:56 +00:00
Aleksey Bragin 22c7de15e6 - In success cases of NtAllocateVirtualMemory, return the real (page rounded!) base address and region size, not the possibly unaligned pointer and length which were passed to the function. These cases were hit when a region of memory was previously reserved, then a commit request came with unaligned base address and length, which match that previously reserved region after aligning.
svn path=/trunk/; revision=36427
2008-09-23 12:41:02 +00:00
Aleksey Bragin 55ea8c5583 [FORMATTING]
- Reformat to the kernel coding style.

svn path=/trunk/; revision=36426
2008-09-23 11:45:40 +00:00
Aleksey Bragin 7a0cd51dea [FORMATTING]
- Apply standard header.

svn path=/trunk/; revision=36425
2008-09-23 10:47:10 +00:00
Art Yerkes 1c65b2ed57 Didn't notice that bufferSize is used by RegQueryValueEx. Now we count in
bytes with bufferSize and count in chars just in the subscript.

Noticed by Christoph_Vw

svn path=/trunk/; revision=36424
2008-09-23 10:17:27 +00:00
Art Yerkes 99f3a239d7 Initialize DbgLoadOptions from the start. It would be unitialized if a bootcd
was made without having the right section in txtsetup.sif.

svn path=/trunk/; revision=36423
2008-09-23 09:36:23 +00:00
Art Yerkes 5a637c03db Count the end of the szApplicationName in the right units. (coverity 551).
svn path=/trunk/; revision=36422
2008-09-23 09:28:44 +00:00
Art Yerkes a6b7e20ad4 Fix a legitimate overrun in _widths (coverity 575), and try not to be as
clever.

svn path=/trunk/; revision=36421
2008-09-23 09:09:16 +00:00
Art Yerkes 91ae271e19 This bug could've caused mayhem in the icon cache. (coverity 790).
svn path=/trunk/; revision=36420
2008-09-23 08:58:19 +00:00
Art Yerkes 6276f8ea51 Fix possible overrun of the last byte of dbuf (coverity 552).
svn path=/trunk/; revision=36419
2008-09-23 08:43:49 +00:00
Christoph von Wittich 87b74aaeed overrun of static array
Fix for Coverity error CID: 529

svn path=/trunk/; revision=36418
2008-09-23 08:04:57 +00:00
Aleksey Bragin 77b6062570 - The check for SystemHive being non-NULL is meaningless, because CmpInitializeHive is already checked for failure earlier, and in success case it returns a valid Hive.
- Fix for Coverity error CID: 280

svn path=/trunk/; revision=36417
2008-09-23 08:04:23 +00:00
Christoph von Wittich 112e87a86c overrun of static array
Fix for Coverity error CID: 532

svn path=/trunk/; revision=36416
2008-09-23 07:50:59 +00:00
Christoph von Wittich 1285642dcd overrun of static array
Fix for Coverity error CID: 552

svn path=/trunk/; revision=36415
2008-09-23 07:44:15 +00:00
Aleksey Bragin 118679eda4 - Preinitialize ValueData with NULL.
- Fix for Coverity error CID: 772.

svn path=/trunk/; revision=36414
2008-09-23 07:40:40 +00:00
Christoph von Wittich db712aaf9b overrun of static array
Fix for Coverity error CID: 546 + 547.

svn path=/trunk/; revision=36413
2008-09-23 07:38:00 +00:00
Christoph von Wittich eb68ba4328 overrun of static array
Fix for Coverity error CID: 548.

svn path=/trunk/; revision=36412
2008-09-23 07:33:44 +00:00
Christoph von Wittich cb7fa454fa don't free memory which is not allocated yet
Fix for Coverity error CID: 789.

svn path=/trunk/; revision=36411
2008-09-23 07:05:18 +00:00
Christoph von Wittich 2aabf8b66d fix heap corruption when lpStringToFind is NULL
Fix for Coverity error CID: 775.

svn path=/trunk/; revision=36410
2008-09-23 06:55:05 +00:00
Art Yerkes 9b1a7c47bd some detritus exposed by coverity.
svn path=/trunk/; revision=36409
2008-09-23 05:58:51 +00:00
James Tabor 9c5dbd4ca2 Add UpdateLayeredWindowIndirect to def and cleanup and add a new type in dce.h.
svn path=/trunk/; revision=36405
2008-09-22 15:49:38 +00:00
Christoph von Wittich 86186976c5 sync riched20 with wine 1.1.5
svn path=/trunk/; revision=36404
2008-09-22 14:29:28 +00:00