Commit graph

5671 commits

Author SHA1 Message Date
Hermès Bélusca-Maïto cfbf8660bc [WHOAMI]: Use the conutils (stream) library for console output (see also r65894).
CORE-8965 CORE-10504

svn path=/trunk/; revision=73111
2016-11-03 16:30:48 +00:00
Hermès Bélusca-Maïto 79c7b07668 [CONUTILS]: Remove that overengineered splitted library stuff, and just rely on the splitting of the source code files instead. This is simpler and does the same job as I wanted to do initially (thanks Amine and Thomas for the feedback).
CORE-10504 #resolve
[APPS]: Use again just the conutils library.
The effect of these two modifications above is to partly revert r73024 (the code splitting remains on the contrary).
[CMAKE]: Remove the "evil workaround" (revert r73027). See CORE-12206 for more details.

svn path=/trunk/; revision=73110
2016-11-03 15:47:45 +00:00
Thomas Faber bdcecff0be [USETUP]
- A fatal error when creating the install directory is worth a DPRINT1
CORE-11819

svn path=/trunk/; revision=73108
2016-11-03 14:14:19 +00:00
Amine Khaldi e9a079b458 [CHARMAP_NEW] Fix a copy pasta.
svn path=/trunk/; revision=73099
2016-11-02 19:19:17 +00:00
Amine Khaldi 968516f86d [SERVMAN] Sort out header inclusions.
svn path=/trunk/; revision=73098
2016-11-02 18:55:51 +00:00
Mark Jansen 082463978d [REGSVR32] Disable error message boxes while loading a dll. CORE-12209
svn path=/trunk/; revision=73077
2016-10-30 11:50:10 +00:00
Benedikt Freisen 3d592530f4 [MSPAINT] refactor RegistrySettings::SetWallpaper, also changing its signature to make it more usable
svn path=/trunk/; revision=73055
2016-10-28 19:48:25 +00:00
Thomas Faber f642128e8f [PROGMAN]
- Fix MSVC warnings
- Use strsafe printf

svn path=/trunk/; revision=73050
2016-10-27 10:21:13 +00:00
Hermès Bélusca-Maïto 682cc491e7 [EVENTVWR]
- Fix FormatMessage flags sanitization.
- Use "LANG_USER_DEFAULT" instead of MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT) (these are the same, but one is shorter than the other).
- In case LookupAccountSidW fails to retrieve the user name of an associated SID, use ConvertSidToStringSidW to get the SID string directly and display it, instead of claiming there is no associated user for a given event.
- In addition to display (in the status bar) the number of events in the selected log, display the number of events actually listed. This can be useful when events filtering will be completely implemented, and it can be also useful for detecting possible corrupted logs where the number of enumerable events is different (less) than the total number of events in the log...
==> To translators: please update the translations!
CORE-11637

svn path=/trunk/; revision=73043
2016-10-26 20:32:11 +00:00
Colin Finck fcaeb4d6a4 [PRINTING]
Finally merge my branch "colins-printing-for-freedom", giving us an initial implementation of a Win32-compatible Printing Stack (localmon, localspl, spoolss, spoolsv, winspool)
You can now send raw data to parallel port printers using documented Win32 API. An example application is in my "winspool_print" commandline tool merged to rosapps.
ReactOS folks, thanks for your support during the development of this, making my bachelor's thesis a reality! :)

Documentation/Thesis: https://svn.reactos.org/reactos/trunk/documentation/articles/Printing%20Stack%20Thesis/thesis.pdf
Video: https://www.youtube.com/watch?v=cNzePucTOLY

CORE-10489

svn path=/trunk/; revision=73039
2016-10-26 12:37:27 +00:00
Hermès Bélusca-Maïto 1f9c38b3b9 [EVTLIB]: Create a EvtLib library for manipulating the event log file format from anywhere.
[EVENTLOG]: Make usage of this library.
CORE-11868 #resolve #comment Committed in r73035.

[EVENTLOG]: Protect the global handle table with a lock as it seems to me that this needs serialization. Please notify me if you think this is not actually necessary (and I'll revert that in case).

svn path=/trunk/; revision=73035
2016-10-25 23:50:31 +00:00
Hermès Bélusca-Maïto 34a06851d3 [EVENTLOG]
- Update code source files headers.
- Use explicit unicode functions for RegOpen/Query/SetXXX and safe-string APIs.
- Use GetSystemWindowsDirectoryW where needed instead of GetWindowsDirectoryW (TS-safe).
- Fix some variable names & types.
- Improve some DPRINTs.

svn path=/trunk/; revision=73034
2016-10-25 23:32:20 +00:00
Hermès Bélusca-Maïto 00a8b0a3c8 [WLANCONF]: Addendum to r73024.
svn path=/trunk/; revision=73026
2016-10-22 22:15:10 +00:00
Hermès Bélusca-Maïto 6f5d03b414 [MORE]: Rewrite almost completely the MORE command, taking advantage of the console pager functionality of the ConUtils library (see CORE-10504 and commit r73024).
- When displaying files, display the percentage of file read so far in the "Continue" prompt. Otherwise (when being piped or feeded from StdIn), just display the "Continue" prompt without percentage.
- Try to detect the text file encoding (ANSI, UTF16-BE/BE w/ or w/o BOM; UTF-8 to do!!) before displaying it. See the code for more details.

NOTE that the other functionalities of more (being able to scroll one line at a time, other command-line switches, etc...) are still not implemented yet.

svn path=/trunk/; revision=73025
2016-10-22 22:07:28 +00:00
Hermès Bélusca-Maïto eb198b854d [CONUTILS]
- Introduce new functionalities related to console streams, a console screen management api (almost stubbed), a console pager api (adapted from code from CMD). This new functionality will be used in the future. See CORE-10504 for more details.
- As this library is therefore growing up, split it in small parts (sublibraries) that can be used, with the following dependency scheme: base utils (standalone); streams depending on base; screen depending on streams; pager depending on screen.

[APPS]: As a result, modify the CMakeLists of the different apps that use conutils to make them depend on the correct sublibrary.

svn path=/trunk/; revision=73024
2016-10-22 21:54:29 +00:00
Hermès Bélusca-Maïto 26cf82fa5b [MODE]: Forgot this change too (related to kbd rate before delay).
svn path=/trunk/; revision=73023
2016-10-22 21:46:58 +00:00
Hermès Bélusca-Maïto 0c5fc9b3b5 [CLIP]: Check read status before number of bytes read. Update main resource file.
[COMP]: Code style fix; remove an unused define.
[EVENTCREATE]: Remove an unused define.

[HELP]
- Remove unneeded headers; minor code formatting.
- Remove an unused define.
- Add placeholder Czech resource translation.

[MODE]: Update translation (part 2/x); show the keyboard rate before the delay.

svn path=/trunk/; revision=73022
2016-10-22 21:42:13 +00:00
Hermès Bélusca-Maïto 6672ea6af0 [MODE]: Adjust german resources.
svn path=/trunk/; revision=73013
2016-10-21 20:48:26 +00:00
Robert Naumann dbf62b106c [MODE] add initial German translation. needs completition!!!
svn path=/trunk/; revision=73012
2016-10-21 20:44:38 +00:00
Hermès Bélusca-Maïto 38933ca790 [CMD]: Documentation improvement: we actually support two types of filename completions, windows-cmd like (the default one), and "bash-style" one (that is available through a compile switch). I prefer calling it "bash-style" over "unix-style" because this style of completion looks like the one from the GNU ReadLine library, that is used by Bash, which is not exclusive to unix per se...
svn path=/trunk/; revision=72998
2016-10-20 16:51:07 +00:00
Hermès Bélusca-Maïto 7f59e9a13c [MODE]
- Localization of output based on a patch by Lee Schroeder, but where I haven't modified yet the output localization of errors.
- Dynamically underline the headers of the device status reports (by me).
CORE-12178

svn path=/trunk/; revision=72996
2016-10-19 17:04:29 +00:00
Hermès Bélusca-Maïto d259d035bc [MODE]
- Rearrange ResizeTextConsole so that it correctly computes the Top & Bottom parts of the window size rectangle;
- Fix its return type;
- Display an error if we failed resizing the console;
- Clear the screen before resizing the console, as the real MODE.COM does.
- Fix a parsing error in SetConsoleStateOld and in SetConsoleCPState.

svn path=/trunk/; revision=72995
2016-10-19 15:04:42 +00:00
Hermès Bélusca-Maïto 4c38c9a07e [MODE]: Code style changes + remove unused parameter for ResizeTextConsole.
svn path=/trunk/; revision=72994
2016-10-19 15:00:32 +00:00
Hermès Bélusca-Maïto 533d9d5f59 [MODE]: Numerous fixes for the MODE utility:
- Parse the command line the same peculiar way as Windows' mode.com tool. This is certainly done such as to be backwards-compatible with MS-DOS' tool.
- Fix serial port string parsing, based on Wine's dll/win32/kernel32/wine/comm.c code. Note that the BuildCommDCB kernel32 API has the same syntax :)
- Implement support for MODE CON codepage, as well as screen size and typematic settings. Screen size code is based on NTVDM's one and will be subject to fixes later on.

MISSING stuff:
- LPT/COM port redirection.
- Localization :)

CORE-12176 #resolve
CORE-7998 CORE-8001

svn path=/trunk/; revision=72980
2016-10-17 22:19:22 +00:00
Benedikt Freisen 38d01b32ac [MSPAINT]
- fix an odd quirk that resulted from Paint setting wallpaper and wallpaper style in the wrong order
- add the flag SPIF_SENDWININICHANGE

Setting wallpapers now works, whenever the OS natively supports the respective file format for wallpapers.

svn path=/trunk/; revision=72972
2016-10-15 11:44:15 +00:00
Amine Khaldi e3d7748688 [EVENTVWR][EXPLORER][SHELL32] Russian translation update by Sergey Stopkin. CORE-12153
svn path=/trunk/; revision=72967
2016-10-13 21:39:37 +00:00
Thomas Faber 4b9d31d916 [PSDK]
- ksmedia.h requires ks.h to be included first. Based on a patch by Lee Schroeder.
CORE-6783

svn path=/trunk/; revision=72963
2016-10-13 09:21:57 +00:00
Hermès Bélusca-Maïto 5bcbde18ec [CMD]: Fix the "TYPE" command so that it doesn't interpret the optional /P switch as a filename.
svn path=/trunk/; revision=72956
2016-10-10 19:17:03 +00:00
Hermès Bélusca-Maïto b408826a0b [CMD]
- Improve the screen pager so that it looks a bit more like MORE's one: display full screen pages, where only the last line contains the "press any key..." prompt, and erase this prompt when a key is pressed and before displaying the other screen page.
- GetScreenSize parameters are pointers (so use NULL instead of 0);
- Use ARRAYSIZE instead of hardcoding buffer number of elements;
- Simplify PrintInfoLine() (use read-only resource string buffer returned by LoadString instead of a temporary buffer, since we are just interested in the counted string).

svn path=/trunk/; revision=72955
2016-10-10 19:15:07 +00:00
Hermès Bélusca-Maïto 8fbd67bc4a [CMD]
- Fix typo in STRING_MEMMORY_xxx symbols (memmory -> memory);
- Remove the trailing newline for the STRING_MISC_HELP1 page prompt, as part of reworking it a bit (see next commit);
- Code formatting in type.c as I'll touch it after.

svn path=/trunk/; revision=72954
2016-10-10 19:11:15 +00:00
Mark Jansen aef3f9c467 RegQueryValueExW and RegQueryValueExA calls accept bytes. Patch by Victor Martinez Calvo. CORE-9665 #comment Thanks!
svn path=/trunk/; revision=72947
2016-10-09 20:58:08 +00:00
Mark Jansen fc0c290789 [MSCONFIG_NEW|SETUP/WELCOME] Capitalize "os" in "ReactOS" part 4 by Adam Stachowicz CORE-9558 #resolve #comment Last patch applied, thanks!
svn path=/trunk/; revision=72946
2016-10-09 20:20:10 +00:00
Benedikt Freisen 2a5f64604f [MSPAINT] get rid of all _stprintf occurrences and the respective magic number sized TCHAR arrays
svn path=/trunk/; revision=72945
2016-10-09 11:42:37 +00:00
Hermès Bélusca-Maïto 84a2080689 [EVENTCREATE]: Update turkish translation, by Erdem Ersoy.
CORE-12120 #resolve #comment Committed, thanks!

svn path=/trunk/; revision=72944
2016-10-08 19:43:16 +00:00
Hermès Bélusca-Maïto 8dd8a9d989 [PING]
- Use a dynamic-allocated buffer with FormatMessageW, fixes messages disappearance (eg. ping help in russian). CORE-12108 #comment Fixed in r72943.
- Remove the unneeded 1-line function "Usage" and instead just directly call the corresponding PrintString function.

svn path=/trunk/; revision=72943
2016-10-08 14:48:18 +00:00
Hermès Bélusca-Maïto 8b0c046e3c [FLTMC]: Resource strings do not need to be explicitely NULL-terminated, as ATL helpers know how to deal with them.
svn path=/trunk/; revision=72941
2016-10-08 14:05:06 +00:00
Hermès Bélusca-Maïto 2bc77973f5 [FORMAT]: Fix ukrainian translation by Vort.
svn path=/trunk/; revision=72940
2016-10-08 13:55:30 +00:00
Hermès Bélusca-Maïto 3d9c96162e Fix commit synchronization issue (that's what happens when you work on a patch that somebody else worked on in parallel!!)
svn path=/trunk/; revision=72939
2016-10-08 13:13:38 +00:00
Hermès Bélusca-Maïto 8b14a4a88a [TRANSLATIONS]: Russian translation update by Sergey Stopkin.
CORE-12108 #comment Спасибо!

svn path=/trunk/; revision=72938
2016-10-08 13:12:35 +00:00
Amine Khaldi aec4ce26d4 [TRANSLATIONS] Russian translation update by Sergey Stopkin. CORE-12108
svn path=/trunk/; revision=72937
2016-10-08 12:57:53 +00:00
Amine Khaldi d550219e4c [PING] German translation by Joachim Henze. CORE-12117
svn path=/trunk/; revision=72936
2016-10-08 12:50:15 +00:00
Hermès Bélusca-Maïto 330db984fe [DISKPART][NET][WLANCONF]
Make those command tools use the console uilities library, aka. solve all those problems of wrong characters on the console...
CORE-10584 #resolve

[CONUTILS]: Remove the now unneeded compatibility defines.
CORE-10504

svn path=/trunk/; revision=72933
2016-10-07 22:50:32 +00:00
Hermès Bélusca-Maïto 4c4b769ef2 [LOGOFF]: Code formatting fixes, including tabs vs. spaces.
svn path=/trunk/; revision=72932
2016-10-07 22:08:20 +00:00
Hermès Bélusca-Maïto cc5ded3854 [CACLS][CLIP][COMP][EVENTCREATE][HELP][LOGOFF][SHUTDOWN][CHKDSK][FORMAT][SUBST]
- Use Puts functions where needed;
- Fix a __stdcall that needs to be read __cdecl for a variadic function.

[CACLS]
Fix some resources so that the strings can hold on the width of a standard console screen (80 chars).

svn path=/trunk/; revision=72930
2016-10-07 21:57:12 +00:00
Hermès Bélusca-Maïto bf2828383e Fix build.
svn path=/trunk/; revision=72929
2016-10-07 20:44:15 +00:00
Hermès Bélusca-Maïto bc065fb271 [CACLS][CLIP][COMP][HELP][LOGOFF][SHUTDOWN][CHKDSK][FORMAT][SUBST]
Make those command tools use the console uilities library, aka. solve all those problems of wrong characters on the console...
Nitpickers may notice that at some places, the usage of a "Puts"-like function would be better than Printf. Don't worry, I'm on it, it's for another commit.
CORE-10504
CORE-11909 #resolve

svn path=/trunk/; revision=72928
2016-10-07 20:37:36 +00:00
Thomas Faber d47e800182 [DWNL]
- Handle arbitrary console buffer width in write_status
CORE-10228 #resolve

svn path=/trunk/; revision=72923
2016-10-07 15:25:20 +00:00
Hermès Bélusca-Maïto fe98303465 [RAPPS(_NEW)][SETUP]: Last russian translation fixes, by Kudratov Olimjon, amber, and Sergey Stopkin.
CORE-11510 CORE-11636 #resolve #comment Fixed in r72920, thanks to you all!

svn path=/trunk/; revision=72920
2016-10-06 12:51:05 +00:00
Hermès Bélusca-Maïto baf0c710d8 [RAPPS_NEW]: Whitespace fix in taiwan chinese language.
svn path=/trunk/; revision=72919
2016-10-06 12:48:37 +00:00
Hermès Bélusca-Maïto 5f68ab2401 [RAPPS][RAPPS_NEW]: Try to not hardcode types of variables in sizeofs, and use _countof where possible.
svn path=/trunk/; revision=72918
2016-10-06 12:22:32 +00:00