Commit graph

69455 commits

Author SHA1 Message Date
Mark Jansen 87ad6ca5ef [SERVICES] Allow CreateService to create an interactive service under the LocalSystem account.
MSDN stated that this is allowed, and this fixes VMWare Horizon setup not working.
CORE-13434

svn path=/trunk/; revision=75730
2017-09-01 18:27:40 +00:00
Hermès Bélusca-Maïto bf14a6ac69 [NET]: Whitespace fixes only.
svn path=/trunk/; revision=75729
2017-09-01 18:00:06 +00:00
Hermès Bélusca-Maïto 89e4e6102e [ACPPAGE]: "Sync fail" with Mark Jansen's translation work in CORE-13693, sorry :(
svn path=/trunk/; revision=75726
2017-08-31 20:49:02 +00:00
Hermès Bélusca-Maïto c65f4c81cf [ACPPAGE]: Improve the compatibility tab:
- Use the tab title from the corresponding dialog resource caption string.
- Fix some translations, and complete the french one.
- Use DialogBoxParamW and MAKEINTRESOURCEW (with W).

svn path=/trunk/; revision=75725
2017-08-31 20:38:38 +00:00
Giannis Adamopoulos 08585bba00 [BROWSEUI] -Demote a fixme print to a mere comment.
svn path=/trunk/; revision=75714
2017-08-30 12:59:05 +00:00
Giannis Adamopoulos f89672624d [SHELL32] -SHChangeNotifyRegister: Don't call CreateFileW with something that is not a filesystem path as this will obviously fail like when we are browsing My Computer.
svn path=/trunk/; revision=75713
2017-08-30 12:49:59 +00:00
Giannis Adamopoulos a051cd5754 [SHELL32][BROWSEUI] -Demote some uselass error prints and promote some others that make sense to have. Avoid a case that would logically hit an error as initialization of the shell browser is still under way,
svn path=/trunk/; revision=75712
2017-08-30 12:29:43 +00:00
Giannis Adamopoulos 7396067b2a [EXPLORER] -Fix a comment typo. CORE-13566
svn path=/trunk/; revision=75706
2017-08-29 09:11:57 +00:00
Hermès Bélusca-Maïto 7a73afbbc0 [CMD]: Russian translation for the START command, adapted from amber CORE-13248, jperm CORE-13560 and reviewed by Alexander Shaposhnikov (sanchaez). Thank you all :)
Addendum to r75369.

svn path=/trunk/; revision=75705
2017-08-28 20:31:34 +00:00
Thomas Faber 62ae004747 [INF]
- Properly set svn:eol-style. These files are text, so they shouldn't be marked as binary, and they need to have CRLF line endings since they go on the iso.

svn path=/trunk/; revision=75704
2017-08-28 19:42:35 +00:00
Giannis Adamopoulos f6de9ccb3d [UXTHEME] -When calculating the size of caption buttons assume that they have the same size. Hacks in the theme files that change the way the buttons are drawn actually make them appear to have a different size. CORE-13512
svn path=/trunk/; revision=75696
2017-08-28 13:41:16 +00:00
Sylvain Petreolle 8fe63e68c5 [RAPPS] Add a SHA1 sum to uTorrent.
CORE-13666

svn path=/trunk/; revision=75691
2017-08-27 12:00:55 +00:00
Giannis Adamopoulos 6f1a2f7dc9 [UXTHEME] -Ignore the alpha channel so that TrasnparentBlt will be used when a bitmap has an alpha channel but no pixel has alpha transparency. CORE-13464
svn path=/trunk/; revision=75688
2017-08-27 10:55:30 +00:00
Giannis Adamopoulos 3ee6628aa5 [BROWSEUI] -CExplorerBand: Calling ILGetDisplayNameEx with a full pidl was a bit hacky after all because it doesn't work always in win10. Just get the name manually as no helper is good enough.
svn path=/trunk/; revision=75687
2017-08-27 09:35:03 +00:00
James Tabor 93751aff42 [GDI32|Metafile]
- Andrew Eikum : Update metafile world transform immediately in winnt mode.
- More information at https://www.winehq.org/pipermail/wine-cvs/2017-August/122607.html .

svn path=/trunk/; revision=75685
2017-08-26 22:49:13 +00:00
Kamil Hornicek 2cee3c23f7 [TRANSLATIONS]
- Fix missing shortcuts on desktop for Ukrainian localization.

svn path=/trunk/; revision=75682
2017-08-26 21:19:44 +00:00
Giannis Adamopoulos c311042950 [BROWSEUI][SHELL32] -Move bitmap resources used by browseui from shell32 to browseui. Browseui alongside filebrowser.exe can already be used in windows so it makes sense to let it have toolbar icons even in latest windows versions. (It works from xp to win10).
svn path=/trunk/; revision=75677
2017-08-26 14:38:32 +00:00
Hermès Bélusca-Maïto 0054982013 [BOOTDATA]: Move an inf comment where it belongs.
svn path=/trunk/; revision=75675
2017-08-26 12:52:28 +00:00
Thomas Faber d8a59d7716 [WIN32K:NTUSER]
- Remove unnecessary thread reference in IsThreadSuspended.

svn path=/trunk/; revision=75672
2017-08-26 07:31:38 +00:00
Giannis Adamopoulos 9cf9a89aa0 [BROWSEUI] -CAddressEditBox: Populate address bar combobox. Patch by Barrett Karish with improvements by me to fix leaks and add error checks. CORE-10988
svn path=/trunk/; revision=75670
2017-08-25 15:03:25 +00:00
Giannis Adamopoulos 58ef11fbed [SHELL32] -Silence two unneeded prints.
svn path=/trunk/; revision=75666
2017-08-25 08:59:10 +00:00
Giannis Adamopoulos 19c1694e55 [SHELL32] -CRecycleBin: Call GetDriveTypeW with correct parameters. Now files can be deleted to the recycle bin again. Patch by Serge Gautherie. CORE-12340
svn path=/trunk/; revision=75665
2017-08-25 08:44:13 +00:00
Giannis Adamopoulos a28235c709 [USER32_APITEST] -Add a monster of a test to check if WM_DESTROYCLIPBOARD is blocking or not. Use a critical section while recording as we use a single message cache in two threads. After 50154, 50816, 50846 and 75616 changing back and forth, this test shows that 75616 is correct and making sure that it won't be changed again in the future, somehting that would break the ole clipboard.
svn path=/trunk/; revision=75663
2017-08-24 23:08:09 +00:00
James Tabor ddaeb9ccac [User32]
- Patch by mudhead : If the index is out of range, no error should be set, see CORE-13716.

svn path=/trunk/; revision=75661
2017-08-24 22:03:01 +00:00
Aleksandar Andrejevic 699a97f3e2 [NTVDM]: Fix linear 4-bpp mode. Return the status of the AC palette when the index register is read.
svn path=/trunk/; revision=75643
2017-08-23 04:44:55 +00:00
Giannis Adamopoulos 524ce41fa2 [SHELL32] -CRecycleBin: Factor out a new class called CRecyclerDropTarget, which will take the data object and call SHFileOperation for its contents. Add a noisy print to show the parameters passed in SHFileOperation and make it to always use DROPEFFECT_MOVE. Make CDefaultContextMenu use the new drop target in order to delete a file.
svn path=/trunk/; revision=75640
2017-08-22 13:50:25 +00:00
Colin Finck 78c1aeecb9 [FS_REC]
Always register CDFS as a low-priority filesystem. This inserts it at the tail of the filesystem queue instead of the head, meaning UDF always takes precedence and UDF/CDFS hybrid media is properly detected as UDF.
Thanks to Pierre for the hint!

Should fix what's reported in https://jira.reactos.org/browse/CORE-9816?focusedCommentId=78820&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-78820

svn path=/trunk/; revision=75638
2017-08-22 09:09:19 +00:00
Giannis Adamopoulos 8da0a3a46d [OLE32] -Recreate the clipboard window if it isn't a valid window handle. Can happen if the thread that first used the ole clipboard exists which also leads to the clipboard window being destroyed.
svn path=/trunk/; revision=75637
2017-08-22 08:02:30 +00:00
Giannis Adamopoulos 6bb9ea74e5 [SHELL32] Misc fixes for CFSFolder
- GetCLSIDForFileType: Check if the shell extension is blocked by the Blocked key like wine does.
- CFSFolder::BindToObject: Remove a redundant check as _ILGetFileStructW already does the same check.
- CFSFolder::GetUIObjectOf: Do not try to load an IconHandler or an arbitrary extension for directories.
- CFSFolder::SetNameOf: Simplify and make secure by using great helpers like wcscmp and PathCombineW

svn path=/trunk/; revision=75634
2017-08-21 12:18:46 +00:00
Giannis Adamopoulos af33a37eb4 [SHELL32] -CFSFolder: Fix a couple of handle leaks.
svn path=/trunk/; revision=75633
2017-08-21 09:07:41 +00:00
Colin Finck 4f8ba0560c [FS_REC]
- Add a detection routine for CDFS (ISO-9660) volumes that verifies the Primary Volume Descriptor.
- Use this to also detect CDFS on disks and load the CDFS driver if it has not been loaded yet (e.g. when a bootcd/livecd flashed USB drive is inserted at boot of an installed ReactOS).
- Fix a comment in udfs.c.

svn path=/trunk/; revision=75630
2017-08-20 15:30:59 +00:00
Thomas Faber ecc55a34f2 [HDAUDBUS]
- Correctly disable interrupts for status change events. Fixes infinite "HDA_InterruptService c0000000" debug spam (interrupt storm) on VMware with HDAudio sound enabled.
CORE-13704 #resolve

svn path=/trunk/; revision=75629
2017-08-20 15:02:53 +00:00
Hermès Bélusca-Maïto 0aa863c9ed [BROWSEUI]: Improve the rendering of the toolbar pin buttons. By dsp8195. Sorry for the delay!
CORE-10838

svn path=/trunk/; revision=75628
2017-08-20 12:05:25 +00:00
Eric Kohl 80b20b10c3 [SHELL32]
Folder Options: Japanese TreeView translation.
Patch by Katajama Hirofumi MZ.
CORE-13690

svn path=/trunk/; revision=75627
2017-08-20 08:47:23 +00:00
Eric Kohl b53f16528b [SYSSETUP]
Japanese translation of Theme dialog.
Patch by Katajama Hirofumi MZ.
CORE-13691

svn path=/trunk/; revision=75626
2017-08-20 08:27:16 +00:00
Giannis Adamopoulos b5af5aa749 [SHELL32] -CFSDropTarger: Improve the debug message that shows the first thing that is copied or moved and where. This way we sort of know what parameters we pass to SHFileOperationW.
svn path=/trunk/; revision=75625
2017-08-19 15:48:47 +00:00
Colin Finck 75cb0454f7 [USETUP]
Add type 0x96 as "CDFS/ISO-9660" to our list of partition types now that our ISOs flashed to USB use it.

svn path=/trunk/; revision=75624
2017-08-19 14:53:54 +00:00
Giannis Adamopoulos 9fee94b692 [SHELL32] -CFSDropTarget: Simplyfy the code path that handles the CFSTR_SHELLIDLIST format. Don't use FOF_MULTIDESTFILES to keep things simple. CORE-13176
svn path=/trunk/; revision=75623
2017-08-19 11:19:06 +00:00
Giannis Adamopoulos 3c6b222f15 [SHELL32] -Simplify the drop target of CRecycleBin to let the data object generate the list of names that can be passed to SHFileOperationW.
svn path=/trunk/; revision=75622
2017-08-19 11:09:28 +00:00
Mark Jansen fe4d4aa690 [WINED3D] Dereference context slightly later, as seen in wine. This prevents some crashes while applications are starting up. (f.e. ANNO1602)
svn path=/trunk/; revision=75621
2017-08-19 09:51:17 +00:00
Christoph von Wittich f5aed8f8c1 [WLANAPI] map rpc to win error codes
svn path=/trunk/; revision=75620
2017-08-19 06:04:08 +00:00
Giannis Adamopoulos 08b350c0dc [SHELL32] -CDefaultContextMenu: Correctly differentiate the copy and the cut commands.
svn path=/trunk/; revision=75619
2017-08-18 17:39:34 +00:00
Giannis Adamopoulos 1980176e15 [SHELL32] -CDefViewBckgrndMenu: Fix pasting in the background of a folder.
svn path=/trunk/; revision=75618
2017-08-18 17:32:20 +00:00
Mark Jansen e6008ea636 [OLE32] Do not crash on an invalid / empty clipboard.
CORE-12302

svn path=/trunk/; revision=75617
2017-08-18 17:18:46 +00:00
Giannis Adamopoulos 8998ffaca2 [WIN32K] -NtUserEmptyClipboard: Change its behaviour to wait for WM_DESTROYCLIPBOARD to return so it behaves like windows and our ole32 doesn't trip on its assumptions that everything works fine. A test will be written soon to prove that this is correct. CORE-12302
svn path=/trunk/; revision=75616
2017-08-18 17:18:17 +00:00
Benedikt Freisen 44fc547ffa [MSPAINT] Use Gdiplus::Bitmap in place of ATL::CImage to load pictures -- this un-breaks loading a picture's resolution from file
svn path=/trunk/; revision=75615
2017-08-18 17:01:01 +00:00
Timo Kreuzer 369ad20c7b [FTFD] Ignore NULL objects in free() wrapper
svn path=/trunk/; revision=75613
2017-08-18 15:02:05 +00:00
Timo Kreuzer 45720ed145 [FTFD] Fix indentation
svn path=/trunk/; revision=75612
2017-08-18 15:02:01 +00:00
Eric Kohl 7a47c14c8f [STOBJECT]
- Add support for the hotplug icon.
- Set default menu items in the context menus.
- Use a timer to properly distinguish between a single and a double click on an icon.
- Some code cleanup.

svn path=/trunk/; revision=75611
2017-08-18 14:49:11 +00:00
Timo Kreuzer 6c364c895d [NTOSKRNL] Fix 64 bit warnings about conversion in PsExitSpecialApc and PspTerminateThreadByPointer
svn path=/trunk/; revision=75610
2017-08-18 12:31:19 +00:00