Most likely not correct, as it breaks comctl32:buttonv6 tests
https://reactos.org/testman/compare.php?ids=68146,68147
But greatly eliminates perceived flickering when hovering
with the mouse over buttons in unthemed mode.
We suffered from these regressions for years and nobody did
find a proper solution, therefore it's time to at least workaround them.
The patch did not expose any new real-world-issues after I retested
the whole rapps suite against it in 0.4.12RCs.
CORE-13278 was once introduced/unhidden by SVN 73806 ==
c607de7
CORE-16093 was once introduced/unhidden by SVN 74149 ==
301c476
The comctl32 part of the fix was picked from 0.4.13-dev-1194-g
a40331b0f4
Many 3D applications crashed with 'WineD3D fake window' msgbox
if they were used in VirtualBox with graphics driver
'VBoxDisp.sys from VM guest additions + installed 3D acceleration'
That was a regression of SVN r75847 == git 0.4.7-dev-319-g
3d13ed394e
Contrary we had no such issues with the SW emulation.
The reason for the bug is that
VBoxDisp only supports OpenGL 2.1 (GLSL 120) and WineD3D
tried to use shaders for OpenGL 3.2 (GLSL 150).
This workaround disables the usage in a hard-coded way for
all graphics adapters. Should be ok for now, as ros does not
really support any modern GPU drivers yet.
Proper working runtime detection would be better ofc.
Thx to Doug Lyons & Fabian Maurer
Fix cherry picked from 0.4.14-dev-113-g
082f230ac7
patch is import of Wine commit 0937186f7d15fed60f77fa2014d650f4d0b6b20b
by Nikolay Sivov
regression was introduced by SVN r75872 == git 0.4.7-dev-344-g
c6f32e4a5f
fix cherry picked from 0.4.12-dev-360-g
daadcc6141
Old cursor looks better.
We revert to SVN state r75865 and note the diff for Amine
so that the wrong version won't come back in the future.
Old file is just 326bytes while the one that we do not want is 33.134bytes
which means we will save some RAM as well.
cherry picked from commit 0.4.11-dev-634-g
ad34c91d1c
This allows the code to give a last chance for expanding the string.
And if it still fails, we bail out as expected and the caller will
take appropriate actions.
As a by-product, this commit (together with the previous one e2960914)
fixes the regression CORE-14981 (Quick-Launch bar couldn't be opened
in LiveCD).
cherry picked from commit 0.4.11-dev-208-g
7ee298bbfc
and bail out if it failed. That way we won't use and cache in the registry an invalid-expanded string.
CORE-14981
cherry picked from commit 0.4.11-dev-207-g
e29609147b
The Logoff-Handler might try to notify the scheduler service which might already
have been shut down. We need to fix the shutdown sequence,
so that the service manager stops all running services.
Might fix CORE-14521 according to patches author ekohl.
I tested myself, it properly works around regression CORE-14999 aka
"Long time to shutdown after installing .NET Framework"
cherry picked from commit 0.4.11-dev-189-g
5e2fe08918
Adjust the IDC_PICKICON_LIST control's height in the IDD_PICK_ICON dialog resource. (#824)
It changed the number of rows from 4 to 3 unintentionally by
0.4.10-dev-466-g
35f62fc5ba
The fix was cherry-picked from
0.4.11-dev-30-g
39dc3cdaf6
This patch has not been committed to master yet.
It fixes the vertical position of button text,
which was shifted one pixel to the bottom since guilty commit
0.4.10-dev-466-g
35f62fc5ba
by reverting "[ADVAPI32] Additions for CreateProcessAsUserA/W()."
This reverts commit 0.4.10-dev-260-g
d4b4da5385
Afterwards I could install Java 7u80 again
and the Java-dependent app "pdfSam 2.2.4" did install and run.
This reverts commit 0.4.10-dev-55-g
7af3969e9f
and therefore downgrades D3D8,D3D9,DDRAW,WINED3D from 3.9 to 3.3 for this rls.
This is still newer than last release where we had to go back to 3.0 even.
Purpose of this revert is to fix crashes when Ddraw apps switch
into fullscreen with VBEMP and inbuilt Mesa.
I tested, before:
DxDiag crashed when switching to fullscreen,
Diablo II crashed immediately,
Monster-Truck-Madness 2 demo crashed after main menu
Afterwards all of these apps do run.
DXTN does still work after that, even with VBEMP and inbuilt Mesa.
This will be the interim fix, which I will keep for rls at least
until someone manages to fix CORE-14955 properly in master with Wine 3.9.
Our RCs were still affected by that regression.
The revert allows to run the current Online! setup
of Flash-Player 30.0.0.154 to download.
(I was able to watch a flash video in Opera 12.18 afterwards.)
like in last release
Fixes the icons on some buttons being flipped vertically.
Known affected apps: Lazarus IDE, Double Commander, Peazip.
Beside that it also fixes transparency regressions in DVDStyler 3.0.4 (CORE-14701).
Thanks to patches author Doug Lyons.
The patch has not been committed to master yet.
like in last release
(cherry picked from commit 9d758ae1cd)
This reverts commit 0.4.8-dev-502-g
7000fe2340.
This reverts commit 0.4.8-dev-503-g
f318a25e10.
The two changes were done once to work towards better
shim-supporting APIs of newer Windows versions on demand
in the future. Luckily we do not depend on them yet.
Giannis already fixed most regressions of the 2 commits
before branching 0.4.8RC (e.g. 2nd stage theme-selector).
Unfortunately we still have issues atm with the existing mixture
of Wine comctl32 v5 vs v6.
The image-lists of both are not compatible as Giannis told us.
We revert both commits for this release to fix CORE-14433
(missing icons due to incompatible image-lists). We can not
simply add a manifest here, because 3rd party apps are affected.
I double-checked, all of those (formerly affected) apps
are working fine and show the icons after the revert:
2nd-stage-theme-selection, MS Excel Viewer 2007 open-dlg,
MSVCPP 6 installer open-dlg, FaxViewer save-dlg,
MS Word Viewer 2003 open-dlg
This revert also obsoletes works/fixes like
2f11904000.
like in last release
(cherry picked from commit 11bf8fa047)
This commit was *not* committed to master yet.
I'll leave the ticket unresolved until it'll be.
This fixes a regression introduced in SVN r73442:
Our setup created undesired temporary files and left them
in the temp folder. Also we saw a slight one-time-increase
in memory consumption.
This patch was the work of Carlo Bramini
He proposed the fix on 2016-12-30 already.
There are ongoing discussions about an alternative approach
to the initial problem that SVN r73442 tried to address.
Serge Gautherie can and shall evaluate that alternative later in dev.
For now many thanks to Carlo Bramini for this fix.
like in last release
(cherry picked from commit dba2f743c5)
Thomas linked the patch in Wine Bug 44410
I tested it for some weeks without noticing any side-effects.
It avoids text rendering regressions in some setups like UltraISO
like in last release
(cherry picked from commit 937c2615e6)
This fixes a race condition, where the message thread was still running when InstallReactOS returned and syssetup.dll was unloaded by the caller (setup.exe).
Spinning here is supposed to improve performance by avoiding scheduling
overhead, but because ReactOS's Win32 subsystem does not deal with this well,
it causes the system to freeze on ROS.
As a workaround, we disable spinning and jump directly to the wait.
It should become obvious when this starts actually causing performance issues
again and it's time to undo.
The PROCESS_DEVICEMAP_INFORMATION union has 2 fields, one is a handle, the other one is a structure of 36 bytes (independent of architecture). The handle forces 64 bit alignment on 64 bit builds, making the structure 4 bytes bigger than on 32 bit builds. The site is checked in NtQueryInformationProcess (case ProcessDeviceMap). The expected size on x64 is the size of the Query structure without alignment. autocheck correctly passes the site of the Query union member, while smss passes the full size of PROCESS_DEVICEMAP_INFORMATION. Packing the structure is not an option, since it is defined in public headers without packing. Using the original headers sizeof(PROCESS_DEVICEMAP_INFORMATION) is 0x28, sizeof(PROCESS_DEVICEMAP_INFORMATION::Query) is 0x24.
fix control overlapping in IDD_FOLDER_OPTIONS_FILETYPES
(broke in 0.4.10-dev-24-ed1c6bb0060d06f4c0167d9c2d732f4dc2b4cce4)
and translate IDD_NEWEXTENSION, IDD_EDITTYPE, IDD_ACTION, IDD_FOLDER_CUSTOMIZE
