Commit graph

76307 commits

Author SHA1 Message Date
Katayama Hirofumi MZ
6bf099a662 [ATTRIB] Delete unused variable 'szText' 2019-11-29 20:08:46 +09:00
Katayama Hirofumi MZ
189f648584
[CMDUTILS][ATTRIB] Support folder attributes (#2103)
CORE-16538
2019-11-29 20:03:19 +09:00
Oleg Dubinskiy
c6b64448ce [KERNEL32] Stub GetSystemTimePreciseAsFileTime 2019-11-29 09:03:09 +01:00
William Kent
192926ee02 Stub GetCurrentPackageId() (#1942)
* [KERNEL32] Add stub implementation for GetCurrentPackageId() function

This Windows 8+ function is called by WiX bundles (EXE-based installers) upon exit, if the export is present. If it is a stub in the spec, they will crash, even if they are coded to be compatible with Windows XP/ReactOS.
Also add GetCurrentPackageId() forwarder to apiset.
2019-11-29 08:56:02 +01:00
Serge Gautherie
3d84e25ac0 [CHARMAP] LoadSettings(): Properly use RegQueryValueEx() 2019-11-29 10:45:02 +03:00
Serge Gautherie
2c8f2a099b [OPENGLCFG] general.c: Fix overruns and warnings, improve code consistency (#1923)
* [OPENGLCFG] dwNumDrivers: Fix related pOglDrivers[] overruns

Follow-up to e7b8f27309.

* [OPENGLCFG] dwNumDrivers: Sync related iKey to DWORD type

* [OPENGLCFG] Fix 2 MSVC-x64 'C4267' warnings about RegSetValueExW()
2019-11-29 08:43:15 +01:00
Serge Gautherie
1fa2780796 [NETSTAT] Fix output formats and more (#1709)
* [NETSTAT] Restore expected output formats

"Revert" parts of bd3c852012.

CORE-16119

* [NETSTAT] Improve default and ICMPv4 output formats

* [NETSTAT] Fix a few typos, in output strings

* [NETSTAT] Output usage to StdErr

* [NETSTAT] Be more explicit about unimplemented -b/-t/-v options
2019-11-29 08:26:19 +01:00
Katayama Hirofumi MZ
5734570a15
[BOOT][SHELL32][INCLUDE] Support 'SuperHidden' files (#2102)
PR #2101 shows desktop.ini files on Desktop. I want to hide them.
- Add "ShowSuperHidden" setting to Explorer.
- Add SHCONTF_INCLUDESUPERHIDDEN flag.
- Support SHCONTF_INCLUDESUPERHIDDEN in Explorer.
CORE-10045
2019-11-29 15:14:18 +09:00
Katayama Hirofumi MZ
2c272a9017
[SHELL32] Add desktop.ini more to some folders (#2101)
Provides special icons for special folders by adding desktop.ini. CORE-10045
2019-11-29 14:40:04 +09:00
Katayama Hirofumi MZ
f7ef99fcc8
[CMD_APITEST] Add attrib testcase (#2104)
CORE-16284
2019-11-29 11:13:17 +09:00
Mark Jansen
82b758974f
[URLMON] Delay-load advpack
CORE-5007
2019-11-28 21:40:20 +01:00
Katayama Hirofumi MZ
5d7c5cf459 [USERENV] Improve Japanese translation (again) 2019-11-28 18:50:45 +09:00
Katayama Hirofumi MZ
f06516bc66 [USERENV] Improve Japanese translation 2019-11-28 13:44:50 +09:00
Katayama Hirofumi MZ
5538facfdd
[SHELL32] Add SendTo DeskLink (Retry) (#2099)
CORE-12562
2019-11-27 20:09:19 +09:00
Katayama Hirofumi MZ
004e08383a
[SENDMAIL][INCLUDE][INF] Add sendmail.dll for DeskLink (#2092)
*.DeskLink file realizes SendTo Desktop (Create shortcut) in Windows. DeskLink is implemented in the sendmail.dll module. CORE-12562
2019-11-27 19:26:49 +09:00
Jared Smudde
30e0c2430d [SHELL32] Disable all controls during format and re-enable after format is complete. (#2098) 2019-11-27 09:18:50 +01:00
Katayama Hirofumi MZ
0b938a35bd [MEDIA][FONTS] Improve tahomabd.ttf (Latin and Punctuation) No.33
Tahoma Bold.
Version 0.019 khmz.
13px COMMERCIAL AT.
13px LATIN CAPITAL LETTER V.
13px LATIN CAPITAL LETTER W.
13px LATIN CAPITAL LETTER W WITH CIRCUMFLEX.
13px LATIN SMALL LETTER V.
13px LATIN SMALL LETTER W.
13px LATIN SMALL LETTER W WITH CIRCUMFLEX.
13px LATIN SMALL LETTER ETH.
CORE-8408
2019-11-27 16:53:05 +09:00
Serge Gautherie
9c82d16b14 [DEVMGR] m_DisplayName: Some functions need bytes, not chars
Also:
Always use explicit _countof() and sizeof().
Add a missing 'Size' re-init.
2019-11-27 10:22:46 +03:00
Katayama Hirofumi MZ
c3da027012 [MEDIA][FONTS] Improve tahomabd.ttf (Punctuations) No.32
Tahoma Bold.
Version 0.018 khmz.
NUMBER SIGN.
CORE-8408
2019-11-27 16:15:09 +09:00
Serge Gautherie
f5b10b4d0d [CABMAN] Fix 2 handle leaks, in case of error (#2044)
CORE-11090
2019-11-27 01:49:08 +01:00
Serge Gautherie
c741b1c185 [SETUPAPI] profile_items_callback(): Check LinkName (#2049)
CORE-11612
2019-11-27 01:48:32 +01:00
Mas4hmad
9d1ce7c35c [TRANSLATION] Update Indonesian translation (#2037)
Update Indonesian translation for AVIFILE, CLIPBRD and USERENV.
2019-11-27 01:40:51 +01:00
Hermès Bélusca-Maïto
f986527d49
[BOOTLIB] Remove a useless 'FontDirectory' check as it becomes always valid (!= NULL) through the function.
CORE-11590

Adapted from Victor Martinez patch & Serge Gautherie PR #2062
2019-11-27 01:30:56 +01:00
Katayama Hirofumi MZ
591b2b807c [MEDIA][FONTS] Improve tahomabd.ttf (Punctuations) No.31
Tahoma Bold.
Version 0.017 khmz.
GRAVE ACCENT.
CORE-8408
2019-11-27 09:06:21 +09:00
Serge Gautherie
27502f5c51 [COMCTL32] Minimize Wine diff (#2035)
Addendum to b931f643e3.

CORE-16466
2019-11-27 07:27:21 +09:00
Serge Gautherie
3bc93e9353 [MMC] DoSaveFileAs(): Respect szPath size (#2068)
CORE-11688
2019-11-27 07:24:51 +09:00
Katayama Hirofumi MZ
cfdbccf937
[SHELL32] Follow-up of #2076 (#2091)
Fix EXE and SCR file icons. CORE-16533
2019-11-26 21:45:58 +09:00
Katayama Hirofumi MZ
bd25333e24
[SHELL32] Make SHFormatDrive multi-thread (#2080)
CORE-12756
2019-11-26 18:26:25 +09:00
Katayama Hirofumi MZ
cd75a87cfd
[SHELL32] Improve DragEnter of CFSDropTarget (#2073)
Reduce failures of DragDrop testcase. CORE-11238
2019-11-26 17:34:24 +09:00
Katayama Hirofumi MZ
d8187d33be [MEDIA][FONTS] Improve tahomabd.ttf (Punctuations) No.30
Tahoma Bold.
Version 0.016 khmz.
PUNCTUATIONS.
CORE-8408
2019-11-26 09:41:46 +09:00
Timo Kreuzer
21647e2c4e [NTOS] Revert pool debugging code
Revert "[NTOS] On DBG builds, fill pool allocations with 0xCD and freed pool with 0xDD"
This reverts commit 24f240be8a.

Revert "[NTOS] Add compile time option to trace callers of pool allocations"
This reverts commit 8b20755040.

Revert "WIP"
This reverts commit 8cfd5c601f.
2019-11-25 19:32:06 +01:00
Serge Gautherie
1f8dcf3c0e [SYSDM] IMGINFO: Fix 'iPLanes' typo (#2059) 2019-11-25 18:50:03 +01:00
Serge Gautherie
fdc787c11d [HALX86] Remove a now useless ASSERT() (#2089)
By construction now the assertion will always be verified.
Addendum to 5887b170.
2019-11-25 18:29:03 +01:00
Hermès Bélusca-Maïto
28b77a40ca
[NDK][NTOS:INBV] Remove non-exported INBV functions from NDK; do some cleanup in INBV headers; label both InbvSetProgressBarSubset() and InbvSetProgressBarCoordinates() as INIT_FUNCTION since they are used only for the boot splash. And fix MSVC build. 2019-11-25 15:54:45 +01:00
Hermès Bélusca-Maïto
04c8ed493d
[NDK] Addendum to 592f01a5, fix build. 2019-11-25 02:28:08 +01:00
Hermès Bélusca-Maïto
5887b17005
[HALX86] Fix the "ASSERT(j < 32);" problem in HalpStoreAndClearIopm() encountered from time to time.
CORE-11921 CORE-13715

(Regression introduced by commit 2e1b82cf, r44841.)

In some cases the number of valid (!= 0xFFFF) entries in the IOPM can be
larger than the assumed size (32) of the entries cache. The maximum
possible number of entries is equal to IOPM_SIZE / sizeof(USHORT).

A way to reproduce the problem is as follows: start ReactOS in debugging
mode using '/DEBUG /DEBUGPORT=SCREEN' . Then manage to break into the
debugger exactly during the execution of Ke386CallBios() triggered by
display initialization (for example in my case, while a video driver was
being initialized via the HwInitialize() call done by videoport inside
IntVideoPortDispatchOpen() ).

When this happens, a "concurrent" execution between Ke386CallBios() and
the HAL function HalpStoreAndClearIopm() takes place. This is due to the
fact that when entering the debugger in SCREEN mode, the following
call-chain holds:
InbvResetDisplay() -> VidResetDisplay() -> HalResetDisplay() ->
HalpBiosDisplayReset() -> HalpSetupRealModeIoPermissionsAndTask() ->
HalpStoreAndClearIopm().

However, the code of Ke386CallBios() has reset the IOPM contents with
all zeroes instead of 0xFFFF, and this triggers the caching of all the
entries of the IOPM by HalpStoreAndClearIopm(), whose number is greater
than the wrongly assumed number of '32'.

As Thomas explained to me, "Windows supports [the maximum number of IOPM entries],
it just makes a full copy of the table instead of this indexed partial copy."

And I agree that this overengineered so-called "optimization" committed
in 2e1b82cf contributed in introducing an unnecessary bug and making the
code less clear. Also it makes the IOPM cache larger than the necessary
size by twice as much. Finally, Ke386CallBios() also caches IOPM entries
before doing a 16-bit call, and obviously uses the more straightforward
way of doing a direct copy of the IOPM table (using RtlCopyMemory()).

I wonder what kind of "optimization" this tried to achieve, knowing that
we are not doing like thousands of 32->16bit BIOS interrupt calls per second
in ReactOS...
2019-11-25 00:41:55 +01:00
Hermès Bélusca-Maïto
00cb464d9d
[HALX86] Trailing whitespace fixes only. 2019-11-25 00:41:55 +01:00
Hermès Bélusca-Maïto
03a9ccce65
[NTOS:KE] Explicitly use IOPM_SIZE for initializing the IO map, that is indeed also equal to PAGE_SIZE * 2 but is self-documented. 2019-11-25 00:41:54 +01:00
Hermès Bélusca-Maïto
b2ca7d3ed9
[NTOS:KE] Minor formatting fixes. 2019-11-25 00:41:54 +01:00
Hermès Bélusca-Maïto
592f01a594
[NTOS:INBV] InbvEnableBootDriver() is an export, thus can be called at any time, therefore it must NOT be an INIT_FUNCTION. 2019-11-25 00:41:54 +01:00
Hermès Bélusca-Maïto
66909fa9d5
[VIDEOPRT] Implement VideoPortReadStateEvent(). 2019-11-25 00:41:53 +01:00
Hermès Bélusca-Maïto
bf74f101c2
[VIDEOPRT] Use ExFreePoolWithTag() + Add some ASSERTs. 2019-11-25 00:41:53 +01:00
Hermès Bélusca-Maïto
e930b868a0
[VIDEOPRT] Code formatting only. 2019-11-25 00:41:52 +01:00
Hermès Bélusca-Maïto
148e137b42
[WIN32K] Add some validity checks in PDEVOBJ_vReference() and use it instead of explicitly manipulating ppdev->cPdevRefs. 2019-11-25 00:41:51 +01:00
Hermès Bélusca-Maïto
acf689a973
[WIN32K] Use RtlString* routines. 2019-11-25 00:41:49 +01:00
Hermès Bélusca-Maïto
0ad90f83d3
[WIN32K] Code formatting. 2019-11-25 00:41:49 +01:00
Hermès Bélusca-Maïto
75f188c200
[PCIX][BLUE] Don't hardcode values in KeDelayExecutionThread() call. Remove deprecated code. 2019-11-25 00:41:48 +01:00
Eric Kohl
8813a0dff8 [INF] Add the docking station device 2019-11-24 19:27:03 +01:00
Timo Kreuzer
8cfd5c601f WIP 2019-11-24 18:26:19 +01:00
Timo Kreuzer
8b20755040 [NTOS] Add compile time option to trace callers of pool allocations 2019-11-24 18:26:19 +01:00