A free Windows-compatible Operating System - mirrored from GitHub
Go to file
Hermès Bélusca-Maïto 5887b17005
[HALX86] Fix the "ASSERT(j < 32);" problem in HalpStoreAndClearIopm() encountered from time to time.
CORE-11921 CORE-13715

(Regression introduced by commit 2e1b82cf, r44841.)

In some cases the number of valid (!= 0xFFFF) entries in the IOPM can be
larger than the assumed size (32) of the entries cache. The maximum
possible number of entries is equal to IOPM_SIZE / sizeof(USHORT).

A way to reproduce the problem is as follows: start ReactOS in debugging
mode using '/DEBUG /DEBUGPORT=SCREEN' . Then manage to break into the
debugger exactly during the execution of Ke386CallBios() triggered by
display initialization (for example in my case, while a video driver was
being initialized via the HwInitialize() call done by videoport inside
IntVideoPortDispatchOpen() ).

When this happens, a "concurrent" execution between Ke386CallBios() and
the HAL function HalpStoreAndClearIopm() takes place. This is due to the
fact that when entering the debugger in SCREEN mode, the following
call-chain holds:
InbvResetDisplay() -> VidResetDisplay() -> HalResetDisplay() ->
HalpBiosDisplayReset() -> HalpSetupRealModeIoPermissionsAndTask() ->
HalpStoreAndClearIopm().

However, the code of Ke386CallBios() has reset the IOPM contents with
all zeroes instead of 0xFFFF, and this triggers the caching of all the
entries of the IOPM by HalpStoreAndClearIopm(), whose number is greater
than the wrongly assumed number of '32'.

As Thomas explained to me, "Windows supports [the maximum number of IOPM entries],
it just makes a full copy of the table instead of this indexed partial copy."

And I agree that this overengineered so-called "optimization" committed
in 2e1b82cf contributed in introducing an unnecessary bug and making the
code less clear. Also it makes the IOPM cache larger than the necessary
size by twice as much. Finally, Ke386CallBios() also caches IOPM entries
before doing a 16-bit call, and obviously uses the more straightforward
way of doing a direct copy of the IOPM table (using RtlCopyMemory()).

I wonder what kind of "optimization" this tried to achieve, knowing that
we are not doing like thousands of 32->16bit BIOS interrupt calls per second
in ReactOS...
2019-11-25 00:41:55 +01:00
.github Fix FUNDING.yml syntax. 2019-07-04 09:12:50 +02:00
base [DNSAPI][DNSRSLVR] Parse the hosts file when the resolver is initializing 2019-11-23 17:13:51 +01:00
boot [SHELL32] Shift-Right-Click patch: Plan B (#2082) 2019-11-24 19:22:23 +09:00
dll [HNETCFG] CORE-16372 Jansen's hack 2019-11-24 22:36:49 +09:00
drivers [PCIX][BLUE] Don't hardcode values in KeDelayExecutionThread() call. Remove deprecated code. 2019-11-25 00:41:48 +01:00
hal [HALX86] Fix the "ASSERT(j < 32);" problem in HalpStoreAndClearIopm() encountered from time to time. 2019-11-25 00:41:55 +01:00
media [INF] Add the docking station device 2019-11-24 19:27:03 +01:00
modules [SHELL32_APITEST] DragDrop: Add NULL check of pDropTarget 2019-11-24 22:48:15 +09:00
ntoskrnl [NTOS:KE] Explicitly use IOPM_SIZE for initializing the IO map, that is indeed also equal to PAGE_SIZE * 2 but is self-documented. 2019-11-25 00:41:54 +01:00
sdk [CMAKE] Turn printf format warnings (C4313 and C4477) into errors 2019-11-24 09:28:00 +01:00
subsystems [REACTOS] Fix warning C4146: unary minus operator applied to unsigned type, result still unsigned 2019-07-27 11:21:28 +02:00
win32ss [VIDEOPRT] Implement VideoPortReadStateEvent(). 2019-11-25 00:41:53 +01:00
.gitattributes Fix remaining text file line endings in the tree. (#18) 2017-10-06 15:00:36 +02:00
.gitignore also add modules/AHK_Tests to .gitignore 2019-04-06 12:05:15 +09:00
.gitmessage [CONTRIBUTING] Update .gitmessage 2018-02-25 16:14:41 +02:00
.travis.yml [CONFIGURE] Do not create another "reactos" directory in build directory. This makes configure.sh consistent with configure.cmd 2019-02-11 09:55:17 +01:00
apistatus.lst Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00
appveyor.yml [APPVEYOR] Disable the clang-cl 2019-05-13 08:35:23 +02:00
CMakeLists.txt [CMAKE] Fix host tools build on x86-64 mingw 2019-11-15 16:22:06 +01:00
CODE_OF_CONDUCT.md Add a document on the rules we should follow while managing/reviewing PRs, 2018-06-24 17:00:00 +02:00
CODEOWNERS [CODEOWNERS] Add /drivers/filters/*/ entries 2019-10-17 20:04:48 +02:00
configure.cmd [CONFIGURE] Add support for latest MSVC toolchain (#1940) 2019-09-26 23:49:52 +02:00
configure.sh Rework host tools 2019-08-17 17:39:31 +02:00
CONTRIBUTING.md [CONTRIBUTING] Add a notice for how to set your real name/mail (#1197) 2018-12-31 21:31:32 +01:00
COPYING Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00
COPYING.ARM Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00
COPYING.LIB Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00
COPYING3 Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00
COPYING3.LIB Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00
CREDITS [CREDITS] Update the credits list 2018-06-03 20:32:39 +02:00
Doxyfile [DOXYGEN] Update Doxyfile for our build of Doxygen 1.8.15. 2019-01-15 09:37:54 +01:00
INSTALL Add a quick statement about BtrFS :-) 2018-08-20 20:26:16 +02:00
overrides-gcc.cmake [CMAKE] Clear CMAKE_<LANGUAGE>_IMPLICIT_LINK_LIBRARIES and 2019-04-06 17:43:38 +02:00
overrides-msvc.cmake CORE-14513 [CMAKE] Remove modules that are shipped with cmake (#575) 2018-08-19 22:01:31 +02:00
PreLoad.cmake Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00
PULL_REQUEST_MANAGEMENT.md Add a document on the rules we should follow while managing/reviewing PRs, 2018-06-24 17:00:00 +02:00
README.md Updated release version on readme 2019-10-02 12:09:43 +02:00
toolchain-clang.cmake [CMAKE] Use modules instead of shared libraries 2019-04-06 17:43:38 +02:00
toolchain-gcc.cmake [CMAKE] Use modules instead of shared libraries 2019-04-06 17:43:38 +02:00
toolchain-msvc.cmake Update toolchain-msvc.cmake (#1593) 2019-06-02 00:38:56 +02:00

ReactOS


ReactOS 0.4.12 Release Download ReactOS SourceForge Download License Donate Follow on Twitter

WebsiteOfficial chatWikiForumJIRA Bug TrackerReactOS Git mirrorTestman

What is ReactOS?

ReactOS™ is an Open Source effort to develop a quality operating system that is compatible with applications and drivers written for the Microsoft® Windows™ NT family of operating systems (NT4, 2000, XP, 2003, Vista, Seven).

The ReactOS project, although currently focused on Windows Server 2003 compatibility, is always keeping an eye toward compatibility with Windows Vista and future Windows NT releases.

The code of ReactOS is licensed under GNU GPL 2.0.

ReactOS is currently an Alpha quality operating system. This means that ReactOS is under heavy development, things may not work well and it can corrupt the data present on your hard disk. It is recommended to test ReactOS on a virtual machine or on a computer with no sensitive or critical data!

Building

appveyor.badge travis.badge rosbewin.badge rosbeunix.badge coverity.badge

To build the system it is strongly advised to use the ReactOS Build Environment (RosBE). Up-to-date versions for Windows and for Unix/GNU-Linux are available from our download page at: "Build Environment".

Alternatively one can use Microsoft Visual C++ (MSVC) version 2010+. Building with MSVC is covered here: "Visual Studio or Microsoft Visual C++".

Binaries

To build ReactOS you must run the configure script in the directory you want to have your build files. Choose configure.cmd or configure.sh depending on your system. Then run ninja <modulename> to build a module you want or just ninja to build all modules.

Bootable images

To build a bootable CD image run ninja bootcd from the build directory. This will create a CD image with a filename bootcd.iso.

See "Building ReactOS" for more details.

You can always download fresh binary builds of bootable images from the "Daily builds" page.

Installing

By default, ReactOS currently can only be installed on a machine that has a FAT16 or FAT32 partition as the active (bootable) partition. The partition on which ReactOS is to be installed (which may or may not be the bootable partition) must also be formatted as FAT16 or FAT32. ReactOS Setup can format the partitions if needed.

Starting 0.4.10, ReactOS can be installed using the BtrFS file system. But consider this as an experimental feature and thus regressions not triggered on FAT setup may be observed.

To install ReactOS from the bootable CD distribution, extract the archive contents. Then burn the CD image, boot from it, and follow the instructions.

See "Installing ReactOS" Wiki page or INSTALL for more details.

Testing

If you discover a bug in ReactOS search on JIRA first - it might be reported already. If not report the bug providing logs and as much information as possible.

See "File Bugs" for a guide.

NOTE: The bug tracker is not for discussions. Please use #reactos Freenode IRC channel or our forum.

Contributing prwelcome.badge

We are always looking for developers! Check how to contribute if you are willing to participate.

You can also support ReactOS by donating! We rely on our backers to maintain our servers and accelerate development by hiring full-time devs.

More information

ReactOS is a Free and Open Source operating system based on the Windows architecture, providing support for existing applications and drivers, and an alternative to the current dominant consumer operating system.

It is not another wrapper built on Linux, like WINE. It does not attempt or plan to compete with WINE; in fact, the user-mode part of ReactOS is almost entirely WINE-based and our two teams have cooperated closely in the past.

ReactOS is also not "yet another OS". It does not attempt to be a third player like any other alternative OS out there. People are not meant to uninstall Linux and use ReactOS instead; ReactOS is a replacement for Windows users who want a Windows replacement that behaves just like Windows.

More information is available at: reactos.org.

Also see the media/doc subdirectory for some sparse notes.

Who is responsible

Active devs are listed as members of GitHub organization. See also the CREDITS file for others.

Code mirrors

The main development is done on GitHub. We have an alternative mirror in case GitHub is down.

There is also an obsolete SVN archive repository that is kept for historical purposes.