Victor Perevertkin
68490c1613
[WINHTTP_WINETEST] Restore test_persistent_connection execution
...
This reverts commit a22031d
ROSTESTS-295
2019-12-30 14:57:58 +02:00
Victor Perevertkin
4bf76a659e
[WINHTTP] Initialize winsock upon WinHttpOpen
...
As it was done before syncing with wine-staging 4.18 (5bd6580
)
ROSTESTS-348
2019-12-30 14:57:58 +02:00
Katayama Hirofumi MZ
8b5dc3bf5f
[SDK][INCLUDE] Improve gdiplusheader.h ( #2197 )
...
CORE-16585
2019-12-30 19:59:09 +09:00
Katayama Hirofumi MZ
5eaea74d46
[SDK][INCLUDE] Improve gdipluseffects.h ( #2196 )
...
CORE-16585
2019-12-30 19:57:55 +09:00
Katayama Hirofumi MZ
1674307fd1
[SDK][INCLUDE] Improve gdipluscolor.h ( #2195 )
...
CORE-16585
2019-12-30 18:07:13 +09:00
Katayama Hirofumi MZ
d24acc9779
[SDK][INCLUDE] Rename Gdiplus::Image::image as nativeImage (Retry) ( #2189 )
...
CORE-16585
2019-12-30 14:45:26 +09:00
Victor Perevertkin
b6e33426bf
[NTOS:KD] Fix wrong debug level checking logic in KdpPrint.
...
Use NtQueryDebugFilterState in that function for consistency.
Thanks Hermès Bélusca-Maïto for help
2019-12-30 05:57:49 +02:00
Thomas Faber
ef103d7d69
[WIN32K:NTUSER] Avoid user memory access outside of SEH in NtUserEnumDisplaySettings.
2019-12-29 20:08:51 +01:00
Thomas Faber
3d81dc48a7
[WIN32K:NTUSER] Correctly capture UNICODE_STRING in NtUserEnumDisplaySettings.
2019-12-29 20:08:44 +01:00
Thomas Faber
be92be2e37
[WIN32K:NTUSER] Add missing probe in NtUserGetClassName.
2019-12-29 20:08:30 +01:00
Hermès Bélusca-Maïto
771b87dc8f
[CMD] If the prompt displays the information line on top of the screen, ensure that the prompt won't be hidden below it.
...
CORE-16193
2019-12-29 19:14:03 +01:00
Hermès Bélusca-Maïto
0bede0062a
[CMD] Code formatting; don't hardcode the string buffer sizes in function calls.
2019-12-29 19:13:59 +01:00
Eric Kohl
4bc5d44f06
[SAMSRV] SamrEnumerate...: Return STATUS_NO_MORE_ENTRIES if there is nothing to enumerate.
2019-12-29 17:29:43 +01:00
Hermès Bélusca-Maïto
a946146efc
[BROWSEUI] Remove unneeded header, addendum to d967b5aa
.
2019-12-29 16:23:37 +01:00
Hermès Bélusca-Maïto
da7cd27018
[NETAPI32] Improve some error traces.
2019-12-29 16:14:34 +01:00
Hermès Bélusca-Maïto
be19fda765
[SHELL32] Remove some trailing spaces; use explicitly global namespace for some functions.
2019-12-29 16:14:33 +01:00
Hermès Bélusca-Maïto
d967b5aa25
[BROWSEUI] Remove useless RegenerateUserEnvironment() call.
...
[SHELL32] Call RegenerateUserEnvironment() in WM_SETTINGCHANGE handler **ONLY** when lParam points to the L"Environment" string.
CORE-15147
2019-12-29 16:14:26 +01:00
Hermès Bélusca-Maïto
a8e7defb01
[WIN32SS:USER] Some minimal work and fixes concerning message queues timeouts.
...
CORE-15147
- Rename CLIENTTHREADINFO::tickLastMsgChecked into timeLastRead as
documented in https://reactos.org/wiki/Techwiki:Win32k/CLIENTTHREADINFO .
This is the last time the message queue was read.
- This is the structure member one must compare against the current tick
count timestamp in order to heuristically determine whether a message
queue thread is hung!! Fix MsqIsHung() in accordance, add extra debug
logging in order to help us determining which of our code present
regular GUI hangs, and add as well an extra "TimeOut" parameter so as
not to hardcode a fixed value within that function but instead
allowing its caller to specify possible different values.
- THREADINFO::timeLast is on the contrary the last message time stamp,
and will definitively differ from CLIENTTHREADINFO::timeLastRead .
It should only be used for information purposes!
- Accordingly, in NtUserGetThreadState()::THREADSTATE_UPTIMELASTREAD
and in InitThreadCallback(), only (re-)initialize the timeLastRead
member of the CLIENTTHREADINFO structure of the THREADINFO of interest.
- In co_IntPeekMessage(), update more often the timeLastRead timestamp
whenever the current message queue has been read (but NOT timeLast!!
That one will be updated ONLY WHEN a message is found!).
- In co_IntSendMessageTimeoutSingle() first check whether the window to
which we send the message is being destroyed, before checking for
queue hangs etc. Collapse the logic checks for queue hang and increase
the hang timeout check to 4 times MSQ_HUNG (== 4 * 5 seconds) and
display a debug trace.
2019-12-29 16:14:15 +01:00
Thomas Faber
0d26bbf4b5
[INCLUDE] Safely handle odd & large lengths in ProbeAndCaptureUnicodeString.
2019-12-29 15:22:10 +01:00
Thomas Faber
975e117780
[WIN32K:NTUSER] Add missing parameter probe in NtUserGetClassInfo.
2019-12-29 15:22:03 +01:00
Katayama Hirofumi MZ
e7814f19fb
[SDK][INCLUDE] Formatting gdiplus headers ( #2190 )
...
Just code formatting. CORE-16585
$ clang-format -style=file -i sdk/include/psdk/gdiplus[a-z]*
2019-12-29 23:21:05 +09:00
Eric Kohl
8faf38ed22
[NTOS:IO] Fix indentation. No code changes!
2019-12-29 14:37:13 +01:00
Thomas Faber
b6df3c622e
[NTOS:CM] Probe for write in NtLockProductActivationKeys.
...
This doesn't technically make a difference, but it's good practice.
2019-12-29 10:41:47 +01:00
Thomas Faber
91cc1c3e4f
[NTOS:CM] Protect user memory access with SEH in NtQueryOpenSubKeys.
2019-12-29 10:41:44 +01:00
Eric Kohl
eb7be70007
[SYSSETUP] Start the dnscache service after the network support has been installed
...
CORE-16558
2019-12-29 10:10:43 +01:00
Katayama Hirofumi MZ
07e1f6ed47
[KERNEL32_APITEST] More power to ConsoleCP testcase ( #2187 )
...
Strengthen kernel32_apitest ConsoleCP testcase for COMMON_LVB_LEADING_BYTE and COMMON_LVB_TRAILING_BYTE attributes. CORE-12451
2019-12-29 13:12:39 +09:00
Katayama Hirofumi MZ
be40a0e296
[MSPAINT] Revert LoadDIBFromFile for workaround ( #2186 )
...
CORE-16566
2019-12-28 22:30:21 +09:00
Victor Perevertkin
e92ab76d0d
[REACTOS] Exclude some modules from clang-format
2019-12-28 01:23:49 +02:00
Victor Perevertkin
0c64aed86a
[REACTOS] Introduce .clang-format file
...
And set up a Travis job for checking formatting on PRs
2019-12-28 01:23:49 +02:00
Mark Jansen
5b4dbec140
[CMAKE] Update baseaddresses with gcc 8.3
2019-12-27 19:52:21 +01:00
Mark Jansen
9f6a1c9164
[SDK] Add usage / help to gen_baseaddress.py
2019-12-27 19:51:20 +01:00
Mark Jansen
67d10c5b17
Change whitespace so gcc 8.3 wont falsely complain about misleading indentation
2019-12-27 19:50:23 +01:00
Thomas Faber
8d3f52a2ca
[NTDLL:LDR] Add a print on illegal DLL relocation.
2019-12-27 17:02:26 +01:00
Hermès Bélusca-Maïto
d32e96d602
This was not meant to be committed!
...
This reverts commit 5e14dbd648
.
2019-12-26 17:19:11 +01:00
Hermès Bélusca-Maïto
51cb3cc6b2
[SETUPLIB] Register the \DosDevices\?: drive letter from installation time in the correct SYSTEM\MountedDevices registry key, i.e. the one of the ReactOS being currently installed.
...
CORE-15575
However I now hit a separate bug (see the report) that still prevent the
drive letter to be correctly assigned at reboot.
2019-12-26 17:16:14 +01:00
Hermès Bélusca-Maïto
5e14dbd648
WIP kdbg work.
2019-12-26 13:53:50 +01:00
Katayama Hirofumi MZ
22f883278b
[NTUSER] Fix caret display mistake ( #2180 )
...
Take care of caret visibility. co_IntSetCaretPos function wrongly drawn the caret upon invisible caret. @Doug-Lyons did test this patch. CORE-15661
2019-12-26 19:08:01 +09:00
Katayama Hirofumi MZ
3f9e695061
[SDK][INCLUDE] Add Gdiplus::Image::~Image ( #2174 )
...
Gdiplus::Image had no dtor. CORE-16566
2019-12-26 11:25:48 +09:00
Hermès Bélusca-Maïto
1ee511a10c
[SHELL32] Fix MSVC warning warning C4390 by adding a bit more debug info.
2019-12-25 19:02:48 +01:00
Katayama Hirofumi MZ
dfa3065e19
[CONSRV] Preparation for Asian console support ( #2171 )
...
Make preparation for console support of Chinese, Japanese and Korean (CJK) codepages. CORE-12451
- Add consrv/frontends/wcwidth.c.
- Add GuiPaintTextModeBufferCJK function.
2019-12-25 23:35:01 +09:00
Katayama Hirofumi MZ
fb7ac93dd1
[WIN32SS][NTGDI][FREETYPE] Add ASSERT(pOS2); to FillTM ( #2170 )
...
I had used a static analyzer cppcheck to improve the code. This analyzer suggested NULL check for this code.
2019-12-25 18:27:44 +09:00
Katayama Hirofumi MZ
9ce12f0b4c
[BOOTDATA][NTUSER] Fix some system parameters ( #2162 )
...
CORE-16547
- Add IconTitleWrap registry value.
- Modify gspv.dwMenuShowDelay initial value.
- Initialize gspv.bFastTaskSwitch as TRUE.
2019-12-25 18:12:43 +09:00
Doug Lyons
76aaded77d
[SHELL32_APITEST] Add Regression Test for ShellExecuteW(). ( #2166 )
...
Add a testcase for ShellExecuteW regression. This test also shows the results of ShellExecuteW's return value. Addendum to PR#1854. CORE-12266
2019-12-25 17:15:39 +09:00
Katayama Hirofumi MZ
3fa95ab912
[MSPAINT] Fix memory leak of SelectionModel ( #2169 )
...
- Initialize all members in SelectionModel's ctor.
- Add SelectionModel's dtor.
2019-12-25 15:46:29 +09:00
Hermès Bélusca-Maïto
1d14463947
[ACPPAGE] Enlarge the "Edit the Compatibility Modes" button for some languages. CORE-16573
2019-12-24 21:22:04 +01:00
Hermès Bélusca-Maïto
0fe71544d2
[VIDEOPRT] Complete dispatch IOCTL with IO_VIDEO_INCREMENT priority boost.
2019-12-24 18:34:19 +01:00
Hermès Bélusca-Maïto
16f64a9533
[SHELL32] Improve the displayed error on file copy / displacement + simplify code.
...
Also update the corresponding french translations, see CORE-16572.
And fix a regression introduced in 257e7307
that allowed again copying
or moving a directory into its sub-tree...
I also personally think that these checks must also be done within the
copy_files() / move_files() helpers instead?
2019-12-24 18:30:54 +01:00
Hermès Bélusca-Maïto
2828ea2e06
[SDK] Complete the list of DE_*** error codes for SHFileOperationA/W().
...
Documentation from https://docs.microsoft.com/en-us/windows/win32/api/shellapi/nf-shellapi-shfileoperationa
2019-12-24 18:05:09 +01:00
Hermès Bélusca-Maïto
1928e170f2
[BLUE] Fix a visual regression introduced in bfd8a848: Don't touch INBV when resetting internal screen state during driver loading.
2019-12-24 16:13:10 +01:00
Hermès Bélusca-Maïto
18a51dc7f5
[VIDEOPRT][WIN32K] Use a Windows-compatible way of communicating the 'BaseVideo' state from VIDEOPRT to WIN32K.
...
This is done by creating the volatile key
\Registry\Machine\System\CurrentControlSet\Control\GraphicsDrivers\BaseVideo .
Also cache during first initialization of VIDEOPRT the state of the boot
options BASEVIDEO and NOVESA, so that they can be readily retrieved later
(for example, in VideoPortIsNoVesa()).
2019-12-24 13:51:20 +01:00