Commit graph

69225 commits

Author SHA1 Message Date
Pierre Schweitzer 51e9c7f51a [RDBSS]
- Misc fixes with DPRINTS

[RXCE]
- In RxFinalizeSrvOpen, always dereference the FCB, it's always referenced on SRV_OPEN creation
- Misc fixes with DPRINTS

With that revision and r75419, I'm now able to mount a NFS share, browse it, read a file from it, and unmount it.
We're OK regarding references counting!

CORE-8204
CORE-11327
CORE-13581

svn path=/trunk/; revision=75420
2017-07-27 09:37:10 +00:00
Pierre Schweitzer 4a4f6e5d9f [SHELL32]
Revert r75348.
Because of r75349, this revision was made useless, and even worse, it was leaking a handle to the directory where the FSD doesn't support notifications.
Also made some debug traces more useful

svn path=/trunk/; revision=75419
2017-07-27 09:33:11 +00:00
Benedikt Freisen b36097ee50 [MSPAINT]
- Enable drag cancellation -- patch by Katayama Hirofumi MZ

CORE-13395 #resolve

svn path=/trunk/; revision=75418
2017-07-27 09:29:42 +00:00
Pierre Schweitzer 564e7818da [NFS]
Huge "hack" for ReactOS.
In case we're asked to unmount a NFS share, and there are still active FCBs, browse the prefix table for active NET_ROOT, and then, dump their associated FCBs (prefix + refcount).
It seems we only leak the root FCB.

CORE-8204
CORE-11327
CORE-13581

svn path=/trunk/; revision=75415
2017-07-26 20:00:30 +00:00
Pierre Schweitzer bf93adc414 [DDK]
Define RxIsFcbTableLockAcquired

CORE-8204
CORE-11327
CORE-13581

svn path=/trunk/; revision=75414
2017-07-26 19:57:50 +00:00
Thomas Faber 2d5ebe0ac1 [ACPICA]
- Update to version 20170629
CORE-13538 #resolve

svn path=/trunk/; revision=75412
2017-07-26 14:49:35 +00:00
Pierre Schweitzer 23e5c53ced [COPYSUP]
Remove leftovers from some attempted ugly things.
Should fix MSVC build

svn path=/trunk/; revision=75410
2017-07-26 09:55:30 +00:00
Pierre Schweitzer 85470b1b8e [RDBSS]
- Implement RxFastIoWrite()
- Finish implementation of RxFastIoCheckIfPossible()

[COPYSUP]
- Implement FsRtlCopyWrite2()

This brings (in link with r75398 fast IO writes to RDBSS, and thus NFS!

CORE-8204
CORE-11327

svn path=/trunk/; revision=75409
2017-07-26 09:28:41 +00:00
James Tabor 09ab5ea7ed [NtUser]
- Broadcast the appropriate messages to notify a change in display parameters and color. This should fix rollback issues from setting display modes. See CORE-12571 and CORE-13212.

svn path=/trunk/; revision=75407
2017-07-26 02:52:00 +00:00
Giannis Adamopoulos 27783c2956 [COMCTL32] -Implement taking into account the contents margins from the theme when calculating the size of the toolbar button. Using it while painting the button will be implemented in a later commit as it caused me some problems.
svn path=/trunk/; revision=75406
2017-07-25 22:41:26 +00:00
David Quintana 536fd901af [FREELDR]
Fix compilation on ARM.

svn path=/trunk/; revision=75404
2017-07-25 18:12:33 +00:00
David Quintana ed2b3728b6 [BOOTLIB]
[BOOTMGR]
Disabled x86-specific code when building ARM.

[LIBSUPP]
Use a hack to replace inline asm which is not supported by MSVC ARM.

[DBGHELP]
Fix ARM register access from context struct.

[MSVCRT]
Fix typo in spec file.

[NTOSKRNL]
[WIN32SS]
Add asm dependency to *sys modules.

[CPPRT]
Add one of the missing constructor aliases. There's more, but my brain is fried at this point.

[BTRFS]
Define-away an include for x86-specific intrinsics.

This is the first batch of fixes for building reactos using the MSVC ARM toolchain. A lot more work is needed to get a full build including rostests and rosapps.

svn path=/trunk/; revision=75403
2017-07-25 17:30:21 +00:00
Pierre Schweitzer 294ab75756 [RDBSS]
- Implement RxCommonSetInformation(), RxpSetInfoMiniRdr(), RxSetBasicInfo()
- Stub RxSetAllocationInfo(), RxSetDispositionInfo(), RxSetEndOfFileInfo(), RxSetPipeInfo(), RxSetPositionInfo(), RxSetRenameInfo(), RxSetSimpleInfo()

CORE-8204
CORE-11327

svn path=/trunk/; revision=75402
2017-07-25 12:09:11 +00:00
Pierre Schweitzer 83bcd980a2 [XDK]
Define FILE_ATTRIBUTE_INTEGRITY_STREAM

svn path=/trunk/; revision=75401
2017-07-25 11:34:36 +00:00
James Tabor 65e31a0c41 [NtUser]
- Initialize rectangle to all zero's. See CORE-13582.

svn path=/trunk/; revision=75400
2017-07-24 23:48:08 +00:00
David Quintana b0469b9227 [CABMAN]
Fix pointer math ('unsigned long' will truncate the pointer).

[MKISOFS/SCHILY TOOLS]
Fix the invalid assumption that a 'long' variable can hold pointers. Will be sent upstream.

With this the whole of reactos and rostests builds on x64. Rosapps still has issues.

svn path=/trunk/; revision=75399
2017-07-24 18:37:25 +00:00
Pierre Schweitzer f8e1661549 [RDBSS]
- Implement __RxWriteReleaseResources(), RxCommonWrite(), RxCompleteMdl(), RxGetTopIrpIfRdbssIrp(), RxLowIoWriteShell(), RxLowIoWriteShellCompletion()
- Finish implementation of RxCommonCleanup() so that it handles setting EOF on a file
- Finish implementation of RxCommonCreate() so that it handles sharing violations and attempts to scavenge open files

[RXCE]
- Implement RxpScavengeFobxs(), RxpTrackDereference(), RxpTrackReference(), RxPurgeFobx(), RxPurgeRelatedFobxs(), RxReinitializeContext(), RxSetFileSizeWithLock(), RxScavengeFobxsForNetRoot()
- Fix a bug in RxPrefixTableLookupName() where it was badly handling nodes in scavenger

This commits brings several improvments to the NFS driver.
First of all, now, the driver handles creating, extending and writing to files!
It also handles purging dormant opened files when a file opening fails because of a sharing violation
Finally, it also brings something to look at our references issues in RDBSS to help finding out why our FCB are never (or nearly) dereferenced

CORE-8204
CORE-11327
CORE-13581

svn path=/trunk/; revision=75398
2017-07-24 17:05:05 +00:00
David Quintana 30a8a02f54 [APITESTS]
MSVCRT_CRT_APITEST: Remove getmainargs tests from X64 build.
DELAYIMP: Fix callback prototype.
CComHeapPtr: Fix implementation of IMallocSpy to match the actual interface.

[WINETESTS]
ntdll: Disable 'generated' tests when not i386 platform, since they were generated for x86 and not x64 or ARM.


Fixes x64 compilation for tests.

svn path=/trunk/; revision=75397
2017-07-24 15:09:22 +00:00
David Quintana 86c98bfda7 [BOOTLIB]
Stub out some arch-specific functions (fixes x64 build).

[USBPORT]
Actually fix x64 build. The old code was not working at all, but the bootlib errors cancelled the build earlier than I thought.

The X64 compilation now succeeds, but cabman crashes trying to generate the bootcd.

svn path=/trunk/; revision=75396
2017-07-24 15:08:16 +00:00
David Quintana a822da7802 [EXPLORER]
[RSHELL]
[NTOBJSHEX]
[BROWSEUI]
[SHELL32]
Get rid of the unused "placement new" operators.

svn path=/trunk/; revision=75394
2017-07-24 10:40:55 +00:00
David Quintana e0280ef3ab [USBPORT]
Oops, brainfart (Fixes 32bit build).

svn path=/trunk/; revision=75393
2017-07-24 10:37:53 +00:00
David Quintana cdf1fc5784 [MSPAINT]
Correct callback return type (Fixes X64 build).

[USETUP]
Correct definition of the struct (fixes X64 build).

[USBPORT]
Improve struct size checks so they are X64-compatible (fixes X64 build).

The build as a whole still fails due to bootlib, but implementing those is beyond my expertise.

svn path=/trunk/; revision=75392
2017-07-24 10:34:06 +00:00
Mark Jansen dbcb280e05 [SHORTCUTS.INF] Move the shortcut creation for screenshot.exe to the new rosapps_shortcuts.inf. Patch by Joachim Henze (reactosfanboy)
CORE-13426 #resolve #comment Thanks!

svn path=/trunk/; revision=75391
2017-07-22 20:23:33 +00:00
Mark Jansen 808c1d2aac [WIN32SS][SHELL32] Fix the location and repaint of the version info shown on the desktop. Patch by Katayama Hirofumi MZ.
CORE-13567 #resolve #comment Thanks!

svn path=/trunk/; revision=75390
2017-07-22 18:27:32 +00:00
Giannis Adamopoulos 6e74f9217a [EXPLORER] -Restore a call to RegLoadSettings while handling WM_DISPLAYCHANGE which was removed in r74221. This is not really correct since it resets the size and position of the taskbar but I add it back since it updates the cached rects for all four positions.
svn path=/trunk/; revision=75389
2017-07-22 17:13:06 +00:00
Mark Jansen 68a311b64d [SYSSETUP][SHORTCUTS.INF] Add FontSub program shortcut to Start Menu. Patch by Katayama Hirofumi MZ.
CORE-13428 #resolve #comment Thanks!

svn path=/trunk/; revision=75388
2017-07-22 16:55:08 +00:00
Hermès Bélusca-Maïto 2152b66c27 [UNATTEND]: Move a comment sign ';' to a better place.
svn path=/trunk/; revision=75387
2017-07-22 15:54:40 +00:00
Giannis Adamopoulos 74348be606 [EXPLORER] -Implement the minimum taskbar size for the vertical position.
svn path=/trunk/; revision=75386
2017-07-22 09:13:33 +00:00
Giannis Adamopoulos 0c41ef8fb6 [BROWSEUI]
-CBandSite: Remove CCS_NORESIZE style. This is a hack probably needed because our rebar control is buggy.

[EXPLORER]
-CTaskBand::GetBandInfo: Use the toolbar button size as the minimum and integral size for the band.
-CTaskSwitchWnd: Use the system small icon size for the size of the icon. Recreate the image list if this size changes. This together with the size of the font are the only factors for the size of the toolbar and consequently for the size of the band and if it is the only band, the size of the taskbar. Don't use TB_SETBUTTONSIZE. Now the size of the image list and the font dictate the size.
-CTrayWindow: In the classic theme make the start button have the same height with the tasks toolbar button height. Improve the calculation of the size of the taskbar in FitToRebar.

These changes should make the taskbar and the toolbar have a proper size. On top of that the taskbar is finally resizable (however our rebar is too buggy and still fills only the first line in the taskbar). While testing this I noticed that moving the taskbar in the sides of the screen is buggy now. I'm not sure if this was uncovered by these changes, if this was broken before or this was caused by these changes (looks unlikely to me) but will be fixed in subsequent commits).

svn path=/trunk/; revision=75385
2017-07-21 14:32:15 +00:00
Sylvain Petreolle ce979b05e3 Revert r70669, it was a change in an unused 3rd party file.
CORE-10629

svn path=/trunk/; revision=75383
2017-07-20 21:32:16 +00:00
James Tabor 2b90a87358 [NtUser]
- Patch by Huw Davies : Explicitly set last error to ERROR_SUCCESS.
- Remove hack and added a note.

svn path=/trunk/; revision=75382
2017-07-20 20:26:14 +00:00
James Tabor f11f599e16 [NtUser]
- Patch by Fabian Maurer : Don't send WM_CHAR when a menu gets VK_ESCAPE and add tests.

svn path=/trunk/; revision=75381
2017-07-20 19:57:25 +00:00
James Tabor f6da80a67e [NtUser]
- Patch by Alex Henrie : Tell MENU_SuspendPopup which message to remove.

svn path=/trunk/; revision=75380
2017-07-20 19:46:17 +00:00
James Tabor ab58eda781 [NtUser]
- Remove unused code and reintegrate wine code.

svn path=/trunk/; revision=75379
2017-07-20 19:40:17 +00:00
Sylvain Petreolle 6157c78fb8 Patch by Mike Swanson :
This adds support for Esperanto as a language and a keyboard layout based on the one from X.Org.

CORE-11021


svn path=/trunk/; revision=75378
2017-07-19 20:33:58 +00:00
Daniel Reimer 9d8a8c4366 [CAROOT]
Updates root CAs to recent ones.

svn path=/trunk/; revision=75377
2017-07-19 19:23:47 +00:00
Hervé Poussineau 86d4e580c0 [SETUPAPI] Do not crash when encountering a device with HardwareIDs
svn path=/trunk/; revision=75374
2017-07-19 09:19:11 +00:00
Sylvain Petreolle 06b5ec800a [BDASUP]
Add digital TV tuning device driver to build.

svn path=/trunk/; revision=75372
2017-07-18 22:48:18 +00:00
Hermès Bélusca-Maïto 6721692a02 [REACTOS]: Russian translation update part 2/2 by amber: time-zones.
svn path=/trunk/; revision=75370
2017-07-17 21:30:20 +00:00
Hermès Bélusca-Maïto dbdfdc99f7 [REACTOS]: Russian translation update part 1/2 by amber.
CORE-13248

svn path=/trunk/; revision=75369
2017-07-17 21:26:25 +00:00
Hermès Bélusca-Maïto e3397b9bdc [CRT]: Add a missing _munlock call, caught by Serge Gautherie.
CORE-11568

svn path=/trunk/; revision=75368
2017-07-17 20:55:34 +00:00
Hermès Bélusca-Maïto f87f8bea7d [CMD]: Update the description of the START command, with the commutators that are known to work.
Translators, please update the translations based on en-US!

svn path=/trunk/; revision=75366
2017-07-17 17:17:22 +00:00
Hermès Bélusca-Maïto 1345a5a8a7 [MSVCRT][CRT]: Improvements/fixes over popen(), from Wine code and ported by Andreas Maier: the popen_handles array, which is used in _pclose, was never filled. _popen correctly fills it now.
Should fix returned codes by popen() and pclose(), which are functions that are called by windres, and this latter expects them to succeed. This was not the case before, in ROS, and therefore
trying to e.g. compile ROS within ROS failed from time to time with windres throwing the error that "preprocessing failed".
CORE-11568 #resolve

svn path=/trunk/; revision=75365
2017-07-17 16:11:18 +00:00
Hermès Bélusca-Maïto 73375485df [MSVCRT_APITEST]: Commit a simple test for popen(), by Andreas Maier.
CORE-11568

svn path=/trunk/; revision=75364
2017-07-17 15:27:40 +00:00
Hermès Bélusca-Maïto 2a5ed24776 [RXCE]: Fix bug, thanks MSVC! (warning C4553)
svn path=/trunk/; revision=75363
2017-07-17 12:47:18 +00:00
Eric Kohl f5dcc15bd4 [NETAPI32]
DsAddressToSiteNamesExW: Remove dead code.
This bug was found by Christian Bosch. Thanks a lot!

svn path=/trunk/; revision=75362
2017-07-16 21:48:30 +00:00
Giannis Adamopoulos 689777616b [SHELL32]
-CRegFolder: Implement CRegFolder::EnumObjects. Change its constructor to receive an extra parameter for the name of the key that should be enumerated.
-CEnumIDListBase: Add a new method called AppendItemsFromEnumerator to facilitate merging the contents from one IEnumIDList to another.
-Use the above in the enumerators of CControlPanelFolder, CDesktopFolder and CDrivesFolder to make them significantly simpler.

svn path=/trunk/; revision=75360
2017-07-16 15:13:02 +00:00
Mark Jansen 347ea70d19 [SHIMENG] Pass shim commandline to shims. CORE-11329
svn path=/trunk/; revision=75359
2017-07-16 13:56:08 +00:00
Mark Jansen 116dfc5bd7 [SHIMLIB] Add debug print functionality for shims. CORE-11329
svn path=/trunk/; revision=75358
2017-07-16 13:50:23 +00:00
Mark Jansen 9215c5efc4 [ACPPAGE] Usability: Convert the edit box to a combobox, ask the user if they want to add the layer when closing the dialog.
svn path=/trunk/; revision=75357
2017-07-16 13:47:16 +00:00