Commit graph

1449 commits

Author SHA1 Message Date
Hermès Bélusca-Maïto ad5dceff98 [NTOS][USERSRV]: Both hard-error message box options "OptionOkNoWait" and "OptionCancelTryContinue" are valid!
svn path=/trunk/; revision=71338
2016-05-15 22:32:17 +00:00
Hermès Bélusca-Maïto 497e74bc43 [USERSRV]: Code formatting.
svn path=/trunk/; revision=71337
2016-05-15 22:29:23 +00:00
Hermès Bélusca-Maïto c93051dff0 [CONSRV]: Use cmd's terminal icon that doesn't include crazy sizes.
svn path=/trunk/; revision=71277
2016-05-07 23:17:09 +00:00
Thomas Faber aa8f87d6c8 [WIN32K:NTUSER]
- Desktops should keep a reference to their parent window station
CORE-11124

svn path=/trunk/; revision=71240
2016-05-03 12:50:35 +00:00
Thomas Faber 16beeefbbb [WIN32K:NTUSER]
- In IntDesktopObjectDelete, correctly handle the case where pDeskInfo could not be allocated
CORE-11124

svn path=/trunk/; revision=71239
2016-05-03 12:38:41 +00:00
Thomas Faber 090738b6dd [WIN32K:NTUSER]
- Fix indentation. No functional changes.

svn path=/trunk/; revision=71238
2016-05-03 12:24:28 +00:00
Pierre Schweitzer 9756d84f6c [USER32]
Import Wine commit:
- bfb7e167cb399dbba0a889b797bc11ece8b9e687, Check bounds before dereferencing.

svn path=/trunk/; revision=71235
2016-05-02 17:45:42 +00:00
James Tabor 8357726420 [User32]
- Patch by Herschel Ralston : Fix scroll bar glitch. See CORE-3923 and CORE-11155.

svn path=/trunk/; revision=71231
2016-05-02 02:46:03 +00:00
Amine Khaldi 08a0346e9f [SDK] One step further towards ReactOS source code tree restructure: the sdk folder that groups includes, libraries and tools. CORE-9111
svn path=/trunk/; revision=71184
2016-04-20 12:36:25 +00:00
Thomas Faber 05c5e89e5d [NTOS][WIN32K]
- Disable some noisy DPRINTs

svn path=/trunk/; revision=71168
2016-04-16 10:38:58 +00:00
Thomas Faber 17e18bc653 [WIN32K:NTUSER]
- Don't leak desktop reference in failure case of NtUserSwitchDesktop

svn path=/trunk/; revision=71167
2016-04-16 10:22:35 +00:00
Thomas Faber 270998174c [WIN32K:NTUSER]
- Don't access WindowStationName after free
- Handle RtlCreateAtomTable failure

svn path=/trunk/; revision=71165
2016-04-15 20:43:25 +00:00
Thomas Faber 8ab4a127ba [WIN32K:NTUSER]
- Initialize the window station object before calling ObInsertObject, since the object will be deleted in case of failure.
CORE-11124

svn path=/trunk/; revision=71164
2016-04-15 20:24:44 +00:00
Thomas Faber 741f025e65 [WIN32K:NTUSER]
- Fix indentation. No code changes.

svn path=/trunk/; revision=71163
2016-04-15 19:49:33 +00:00
Thomas Faber 677a03e5af [USER32]
- Fix is_dib_monochrome for bitmaps using BITMAPCOREINFO. Patch by Mark Jansen.
CORE-10889

svn path=/trunk/; revision=71063
2016-03-28 14:58:20 +00:00
Thomas Faber d7dacbad47 [CMAKE]
- Delay imports belong before regular imports because delayimp may pull in functions from kernel32
CORE-10935

svn path=/trunk/; revision=71061
2016-03-27 15:14:32 +00:00
James Tabor bc08222791 [User32]
- Fix crash by use of MDI container rules.
- Patch by Michael Müller: Preserve beginning of extra data for MDI windows.
- Patch by Jacek Caban : Ignore WM_CHILDACTIVATE on disabled windows in DefMDIChildProc.
- CORE-10912 Wine Staging 1.9.4

svn path=/trunk/; revision=71059
2016-03-26 23:12:01 +00:00
James Tabor b0c749c4ea [User32]
- Patch by Piotr Caban : Select text control content while setting dialog focus.
- CORE-10912 Wine Staging 1.9.4
- Added comments.

svn path=/trunk/; revision=71058
2016-03-26 21:20:55 +00:00
Thomas Faber aa172ad912 [USER32]
- Use the correct, previously calculated width and height in BITMAP_LoadImageW instead of assuming pbmi is an actual BITMAPINFO. Fixes loading bitmaps using BITMAPCOREINFO format. Patch by Mark Jansen.
CORE-10889

svn path=/trunk/; revision=71056
2016-03-26 15:35:21 +00:00
Amine Khaldi 3a9620d0b4 [TRANSLATIONS] Spanish translation update by Ismael Ferreras Morezuelas. CORE-10922
svn path=/trunk/; revision=70980
2016-03-09 16:33:41 +00:00
James Tabor 3e20700354 - Fix build.
svn path=/trunk/; revision=70814
2016-02-29 00:32:08 +00:00
James Tabor 96ab54cc90 [Win32SS]
- Based on patch : Jacek Caban : Don't use window' s parent as an owner if WS_CHILD style is not set.
- https://www.winehq.org/pipermail/wine-cvs/2016-February/111835.html
- Pass all win:test_parent_owner.
- Add window last view to Desktop Information structure.

svn path=/trunk/; revision=70813
2016-02-29 00:29:52 +00:00
James Tabor 1a71a5dae6 [Win32SS]
- Fix hang, CORE-10785 and ROSTESTS-208.

svn path=/trunk/; revision=70784
2016-02-24 10:20:06 +00:00
James Tabor 1673380d6e - Fix build, this is used later.
svn path=/trunk/; revision=70783
2016-02-24 08:45:36 +00:00
James Tabor c8fff05661 [Win32SS]
- Fix all wine win:test_GetMessagePos tests.
- See CORE-10867, please verify this is a fix.

svn path=/trunk/; revision=70782
2016-02-24 08:41:26 +00:00
Hermès Bélusca-Maïto 26495e949a [LOL]
Starting NT 5.1 a mysterious "VideoPortCheckForDeviceExistance" (with a 'a') export made its apparition, and is the same as the already existing "VideoPortCheckForDeviceExistence" (with a 'e') ^^
I add it only to be compatible with Win2k3 SP2 videoprt.sys exports.

svn path=/trunk/; revision=70770
2016-02-22 19:11:34 +00:00
Hermès Bélusca-Maïto 92e0fb44ca [VIDEOPRT]
- Complete the table of exported VideoPort functions (compatible Win2k3 SP2), some functions were missing in it: see for example the last picture of http://www.reactos.org/forum/viewtopic.php?f=4&t=14727#p120344 .
- Don't redirect the VideoPortInterlockedIncrement/Decrement/Exchange functions directly to NTOS, because otherwise they cannot be included in the exports table.

svn path=/trunk/; revision=70769
2016-02-22 19:07:44 +00:00
James Tabor cf5302e3de [User32]
- Update usage comments related to CORE-10855.

svn path=/trunk/; revision=70753
2016-02-15 17:38:23 +00:00
James Tabor fbc10d8ca8 [User32]
- Update usage comments related to CORE-10855.

svn path=/trunk/; revision=70752
2016-02-15 17:34:17 +00:00
Hermès Bélusca-Maïto 22becce7e3 [USER32][NTUSER]
Remove some dead code; fix comments; mention that some code is redundant. This is added to help future people in cleaning up that mess called "win32k/user32".

svn path=/trunk/; revision=70751
2016-02-15 01:20:54 +00:00
Hermès Bélusca-Maïto c95d274bf6 [WIN32K:NTUSER]
- Cleanup window clipboard data while the window still exists and is not dereferenced.
- When a window is about to be destroyed (just before we send the WM_DESTROY message), if it is the current clipboard owner, make it release the clipboard. The WM_RENDERALLFORMATS message is then sent, and if needed, one WM_DRAWCLIPBOARD message.
- Send a WM_DRAWCLIPBOARD message when SetClipboardViewer is called.
WM_DRAWCLIPBOARD messages are sent as notifications to the corresponding windows.

svn path=/trunk/; revision=70744
2016-02-14 18:41:49 +00:00
Hermès Bélusca-Maïto 81c6aeb2dd [WIN32K]: Some whitespace fixes.
svn path=/trunk/; revision=70743
2016-02-14 18:26:23 +00:00
Hermès Bélusca-Maïto 1022f13973 [CLIPBRD]
- Avoid calling OpenClipboard with a NULL window handle.
- Display the clipboard erasing confirmation message before actually opening and resetting its contents.

[WIN32K]
- Improve few comments.
- In UserOpenClipboard, return success early in case the clipboard was already opened by the clipboard owner.

svn path=/trunk/; revision=70738
2016-02-14 01:52:58 +00:00
Hermès Bélusca-Maïto b4741c36f4 [WIN32K]: Since r7146 (12 years ago) we correctly set a small Close button for tool windows. WARNING: Please do NOT sync this piece of code with Wine! Ours behave better when one changes the values of SM_CXSMSIZE / SM_CYSMSIZE.
svn path=/trunk/; revision=70720
2016-02-12 23:10:59 +00:00
Hermès Bélusca-Maïto e02c739f6d [WIN32K][USER32]
- Both functions UserGetInsideRectNC and NC_GetInsideRect are the same: remove the redundant code and keep only NC_GetInsideRect.
- Move default WM_NCHITTEST into kernel side, getting rid of half-broken DefWndNCHitTest in user32. Note that we use a DefWndNCHitTest version almost unmodified in uxtheme.dll.
  I did this move also because otherwise, we didn't correctly checked for the presence of the window system menu icon. On the contrary the function GetNCHitEx (obviously taken from Wine's NC_HandleNCHitTest) correctly checks for this.

James, please review!

svn path=/trunk/; revision=70718
2016-02-12 22:10:29 +00:00
Hermès Bélusca-Maïto 492e14a055 This stuff should not have been committed.
svn path=/trunk/; revision=70716
2016-02-12 17:37:41 +00:00
Hermès Bélusca-Maïto c98d80baf0 [WIN32K]: Fix display of window title icon for dialogs having the WS_EX_DLGMODALFRAME style.
CORE-10850 #resolve
CORE-10437 #comment The real fix was committed in r70715.

svn path=/trunk/; revision=70715
2016-02-12 17:31:19 +00:00
Hermès Bélusca-Maïto 3a3ddebe62 [WIN32SS]
- Fix orthograph
- Mention in the code that some stuff are hacks & need to be fixed.
- Add parentheses around bit checks.

svn path=/trunk/; revision=70713
2016-02-12 16:40:36 +00:00
Hermès Bélusca-Maïto 10bff42ab6 Remove redundant extra terminating ';' in all of our C code.
svn path=/trunk/; revision=70690
2016-02-04 20:42:07 +00:00
James Tabor 201e5c881a [User32]
- Patch by Manuel : Explorer not draw (16 bits) icons. See CORE-10789.

svn path=/trunk/; revision=70685
2016-02-03 16:39:28 +00:00
Timo Kreuzer 7c033fc64b [WIN32K]
This ASSERT was actually supposed to be removed and only accidentally brought back.

svn path=/trunk/; revision=70487
2016-01-03 19:58:33 +00:00
Timo Kreuzer 7ba08f4ebf [WIN32K]
Fix the fix from r70482: Our DIBs are actually 32 bit aligned, so pass even uncompressed bits to GreCreateBitmapEx instead of copying them later with wrong alignment.

svn path=/trunk/; revision=70486
2016-01-03 19:46:57 +00:00
Timo Kreuzer 4b6f43dcfa [WIN32K]
Disable broken code to update a device palette. Should fix testbot crashes.

svn path=/trunk/; revision=70485
2016-01-03 18:10:31 +00:00
Timo Kreuzer de7d65388d [WIN32K]
NtGdiCreateDIBitmapInternal: clear CBM_INIT flag, if no bits are given.
IntSetDIBits: Always calculate the bitmap size for uncompressed bitmaps, do not pass uncompressed bits to GreCreateBitmapEx, since they don't have the required alignment (the width in bytes for DIB is 16 bit aligned, bitmaps 32).
Remove a broken ASSERT.

svn path=/trunk/; revision=70482
2016-01-03 16:16:04 +00:00
Timo Kreuzer 89cb03b072 [WIN32K]
Properly check the bitmap size in IntSetDIBits, taking into account that it might be set to 0, then we have to calculate it ourselves. Fixes a crash when invalid data is passed to NtGdiCreateDIBitmapInternal.
[GDI32]
Convert COREINFOHEADER to BITMAPINFOHEADER before passing it to NtGdiCreateDIBitmapInternal, which doesn't support it.
CORE-10583 #resolve

svn path=/trunk/; revision=70464
2015-12-29 20:28:23 +00:00
Timo Kreuzer 88d5b185b0 [WIN32K]
Pass cjMaxBits parameter from GreCreateDIBitmapInternal to IntCreateDIBitmap and check the image size before creating the bitmap.
Should fix crash when hitting about tab in Office2000 WinWord.
CORE-10583 #comment please retest

svn path=/trunk/; revision=70412
2015-12-23 14:55:34 +00:00
Timo Kreuzer fd01add9cf [WIN32K]
Fix bugs in pen implementation:
- Do not use the x coordinate to adjust styles, instead they start where the lines start
- Don't leak allocated styles
- Make sure the PEN fields are initialized correctly, even for BRUSHES, so that the destructor can do it's cleanup work
- Fix numerous parameter checks
gdi32_apitest:pen now shows 0 failures!

svn path=/trunk/; revision=70388
2015-12-17 22:05:06 +00:00
Timo Kreuzer 0f8f2f51ce [WIN32K]
Implement support for styled lines.
CORE-9984 #resolve

svn path=/trunk/; revision=70387
2015-12-17 17:44:42 +00:00
Amine Khaldi 71b6bf7814 [TRANSLATIONS] Romanian translation update by Ștefan Fulea. CORE-10676
svn path=/trunk/; revision=70357
2015-12-16 10:22:00 +00:00
Hermès Bélusca-Maïto 67e52a6862 [WIN32K:CLIPBOARD]
- When cleaning the clipboard, cancel any pending delayed rendering and increment all the sequence&serial numbers.
- Fix the clipboard access check when performing a delay rendering. This fixes VBox host <-> guest copy/paste amongst others...
CORE-5512 CORE-9620
CORE-8367 CORE-8627 #comment Please retest with revision >= 70355.

svn path=/trunk/; revision=70355
2015-12-16 00:26:27 +00:00