Hermès Bélusca-Maïto
4750cbe55b
[SDK:INCLUDE] bugcodes.mc: Add missing UP_DRIVER_ON_MP_SYSTEM bugcheck code ( #7744 )
2025-04-04 13:04:51 +02:00
Hermès Bélusca-Maïto
3022d74beb
[NTOS:EX/KE][HALX86] Add support for NUMPROC, BOOTPROC, MAXPROC, ONECPU boot switches ( #6024 )
...
These SMP-specific switches allow to test and control configurations
with various number of CPUs on multiprocessor systems.
- NUMPROC: maximum number of logical processors that can be started
(including dynamically, not currently supported by ReactOS) at run-time.
- BOOTPROC: maximum number of logical processors that can be started at
boot-time.
- MAXPROC: forces the OS to report the maximum possible number of CPUs
as existing on the system.
- ONECPU (MP HAL-only boot switch): causes the HAL to only use one
(the boot) CPU on a multiprocessor system. Attempting to start other
processors will fail.
For more information, see:
https://www.geoffchappell.com/notes/windows/boot/bcd/osloader/numproc.htm
https://www.geoffchappell.com/notes/windows/license/processors.htm
https://rmscrypt.wordpress.com/2011/02/
https://codeinsecurity.wordpress.com/2022/04/07/cpu-socket-and-core-count-limits-in-windows-10-and-how-to-remove-them/
Generic references about BOOT.INI switches:
https://learn.microsoft.com/en-us/windows-hardware/drivers/devtest/boot-options-in-a-boot-ini-file
https://www.itprotoday.com/cloud-computing/what-switches-can-be-used-bootini
http://franck.kiechel.free.fr/dbr_eng/BootIni.htm
References about BCD options:
https://learn.microsoft.com/en-us/windows-hardware/drivers/devtest/bcdedit--set
http://www.mistyprojects.co.uk/documents/BCDEdit/files/commands.6.1.7601.htm#TYPES%20OSLOADER
2025-04-04 12:51:49 +02:00
Hermès Bélusca-Maïto
7093412f4e
[NTOS] Build mproc.c _only_ for MP ntoskrnl, not for single-processor
...
The usage of the BUILD_MP cmake variable was inadequate.
2025-04-04 12:51:29 +02:00
Hermès Bélusca-Maïto
b0dd4ba09c
[HALX86][HALARM] Minor formatting to HalInitSystem
...
Add CODE_SEG("INIT"), SAL2 annotations, remove extra-parenthesis...
2025-04-04 12:51:28 +02:00
Katayama Hirofumi MZ
1890ad20f8
[NTGDI][GDI32] AddFontResource: Support multiple files ( #7833 )
...
JIRA issue: CORE-17684
- Add HEAP_strdupA2W_buf and HEAP_strdupA2W_buf_free
helper functions for quick string conversion.
- Optimize HEAP_... functions.
- Add IntConvertFontPaths helper function.
- Support multiple files in AddFontResource function.
- Add cFiles parameter to some internal font addition/
removal functions.
- Half-implement NtGdiRemoveFontResourceW and
RemoveFontResourceExW functions.
2025-04-04 19:30:18 +09:00
Whindmar Saksit
72bd9ef29a
[BROWSEUI] Don't pass the internal PIDL to the shell for processing ( #7859 )
...
CORE-20063
2025-04-03 20:52:53 +02:00
Timo Kreuzer
98b26cc24a
[NTDLL_APITEST] Fix NtCreateProfile tests for x64
2025-04-03 16:22:42 +00:00
Timo Kreuzer
0679260073
[HAL/APIC] Set the profiling interrupt handler
...
Fixes hang when running mtdll_apitest NtStartProfile.
2025-04-03 16:22:42 +00:00
Timo Kreuzer
dca5194279
[FTFD] Fix malloc/realloc/free wrappers
...
On x64 malloc needs to return a 16 byte aligned buffer, the previous code used an 8 byte header, making the allocations unaligned. This is now fixed with an improved header structure.
Also simplify realloc a bit and make it handle Object == NULL.
2025-04-03 16:22:09 +00:00
George Bișoc
91fadeb6c3
[STOBJECT] Explicitly tell the user the battery is fully charged
...
Short answer: our UI sucks bolas rojas.
Long answer: when the NT kernel informs the user-mode part of the system that the battery is no longer charging, the machine is directly powered up by the AC adapter.
This is understood by determining the presence of AC_LINE_ONLINE status bit in ACLineStatus member field, which is a Windows API construct.
In the NT world this is understood by checking the power state returned by the BATTERY_STATUS structure.
What's happening right now is that when the battery is fully charged, ROS UI simply displays "100% remaining" implying the battery is about to discharge, which is not the case.
This is extremely confusing to the user. AND WORST PART IS THAT IT'S XP/2003 DESIGN, AND I HATE IT UGGGHHH.
With this patch we're leaning towards Windows 10/11 way of informing the user the battery is fully charged. VIVA LA NT6!
CORE-18969
CORE-19452
2025-04-02 23:16:47 +02:00
Whindmar Saksit
5dbf87e2c1
[BROWSEUI] Handle resolution change when fullscreen ( #7852 )
...
CORE-20072
2025-04-02 18:18:23 +02:00
Whindmar Saksit
32fad87a08
[ROSAUTOTEST][SDK] ROS detection for apitests ( #7613 )
2025-04-02 15:17:18 +02:00
Whindmar Saksit
4965d6a8ac
[USER32_APITEST] Add more PrivateExtractIcons tests ( #7831 )
2025-04-02 15:16:04 +02:00
Katayama Hirofumi MZ
3660920b7f
[GDI32][NTGDI][SDK] ExtTextOut: Fix some type problems ( #7856 )
...
JIRA issue: CORE-19898
- Modify NtGdiExtTextOutW prototype.
- Add const to some paramters.
- Make Count parameter unsigned.
- Delete needless type casts.
2025-04-02 20:30:47 +09:00
Doug Lyons
7afcd2a8b7
[ROSAUTOTEST] Allow rosautotest to be in the same directory as its files and show its duration at the end. ( #7823 )
...
Example output:
[ROSAUTOTEST] System uptime 7.41 seconds
... Testing here...
[ROSAUTOTEST] System uptime at start was 7.41 seconds
[ROSAUTOTEST] System uptime at end was 1546.20 seconds
[ROSAUTOTEST] Duration was 25.65 minutes
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2025-04-01 21:21:10 -05:00
Adam Słaboń
d66ad21ee0
[FREELDR][INSTALL] Update the FreeLoader installation message ( #7853 )
...
Update the installfreeldr message in accordance with the changes in 3d516e71d3
.
2025-04-02 00:06:12 +03:00
Katayama Hirofumi MZ
87cd66a577
[NTGDI:FREETYPE] IntExtTextOutW: Renaming variables ( #7851 )
...
JIRA issue: CORE-19898
This PR is simply trivial renaming.
In IntExtTextOutW function:
s/SurfObj/psoDest/
s/SourceGlyphSurf/psoGlyph/
s/HSourceGlyph/hbmGlyph/
s/bitSize/glyphSize/
2025-04-02 03:54:42 +09:00
Whindmar Saksit
769462faaa
[IEFRAME] Implement URL PIDL ( #7850 )
2025-04-01 16:09:25 +02:00
Doug Lyons
13657fdb5b
[USER32][LIBPNG] Support PNG/Vista icons (Retry) ( #7709 )
...
CORE-18385
Retry of PR #7704
In USER32 change CMakeLists.txt to include libpng.
Improve libpng.spec to include additional needed defines.
Add code into mostly cursoricon.c to support PNG icons.
Co-authored-by: Katayama Hirofumi MZ <katayama.hirofumi.mz@gmail.com>
2025-03-31 12:55:53 -05:00
Whindmar Saksit
190782c3e0
[SHELL32] Fix some clang warnings ( #7845 )
2025-03-31 18:59:04 +02:00
Whindmar Saksit
aa4fac61c8
[BROWSEUI] Implement ShellBrowser F11 fullscreen mode ( #7844 )
2025-03-31 18:09:54 +02:00
Whindmar Saksit
cc8ec38a87
[SHELL32] Use SHGDN_FOREDITING when renaming in BrowseForFolder ( #7840 )
...
- Use SHGDN_FOREDITING when renaming.
- Handle rename change notification without full refresh.
- Don't use FS path when deleting.
CORE-20064
2025-03-30 23:11:27 +02:00
Eric Kohl
c5325f5016
[UMPNPMGR] Implement first part of PNP_AddEmptyLogConf
...
TODO: Adding a new configuration to an already existing configuration of the same type.
2025-03-30 17:16:00 +02:00
Katayama Hirofumi MZ
81d845fb2c
[SHELL32] Implement PathProcessCommandW ( #7818 )
...
Follow-up of #7815 . This function
affects ShellExec_RunDLLA/W
implementation.
JIRA issue: CORE-17659
- Implement PathProcessCommandW
in shlexec.cpp.
- Adapt utils.h to non-C++.
2025-03-30 20:28:31 +09:00
Whindmar Saksit
467dec4d16
[CLEANMGR] Only allow one instance per drive ( #7832 )
...
CORE-18941
2025-03-29 16:58:18 +01:00
Whindmar Saksit
21b3382f31
[SHELL32] Allow shell to format blank partitions ( #7810 )
...
- Don't corrupt static (global) data when formatting more than one disk at the same time.
- Guess partition size to enable formatting blank partitions.
- Added info tip.
- Calls SetVolumeLabel.
CORE-17273
2025-03-29 16:35:03 +01:00
Whindmar Saksit
090d563488
[SHELL32] CFolderOptions Reset can call DefView directly if there is no browser ( #7806 )
...
CORE-20029
2025-03-28 23:15:01 +01:00
Hervé Poussineau
cfde03ec9b
[VIDEOPRT] Write monitor EDID to registry
...
This will be used later by win32k to give only valid display modes
to user mode.
2025-03-28 23:10:42 +01:00
Justin Miller
177cbd81af
Revert "[FREELDR] Pass the correct ACPI table for Windows ( #7486 )"
...
Sorry this is something I had to do, I should have investigated deeper
before approving it and that's on me so ill take this over and get this
done. and credit you once again. Thank you @ILauncherDev
This reverts commit 185225a5fc
.
2025-03-28 07:20:45 +01:00
Whindmar Saksit
b6562a664b
[SHELL32] DefView statusbar item file size fix in recycler and UNC ( #7732 )
...
- Display item sizes inside \\ UNC paths.
- Don't display anything in the location pane inside the Recycle Bin (CORE-20005).
- Don't display the size and location panes in My Computer
- Don't update the location pane on simple item selection changes.
CORE-20005
2025-03-27 18:29:44 +01:00
Timo Kreuzer
c7eba0c5c7
[SDK] Improve definition of (RTL_)CRITICAL_SECTION_DEBUG
2025-03-27 12:50:40 +00:00
Whindmar Saksit
a444572c3e
[SHIMGVW] Display error message on delete failure ( #7776 )
...
CORE-20019
2025-03-27 13:43:58 +01:00
Mark Jansen
70422cda51
[SHELL32] Fix starting disk cleanup from drive properties
...
CORE-12314
2025-03-27 10:55:41 +01:00
Nguyen Trung Khanh
97e7efc020
[TASKKILL] Implement /t (tree) parameter ( #2403 )
...
CORE-15998
2025-03-26 17:04:49 +01:00
Mark Jansen
49c40a2941
[PROGMAN][MSPORTS][VFDLIB][CONSRV] Update resource encoding to be utf8
2025-03-26 16:39:43 +01:00
Mark Jansen
2e8f4e2c24
[SHELL32] Implement Recycle bin cleanup handler
...
CORE-18942
2025-03-26 13:58:40 +01:00
Mark Jansen
f9bedd5ca5
[CLEANMGR] Add basic cleanmgr implementation
...
CORE-18941
2025-03-26 13:58:40 +01:00
Mark Jansen
0cd7e2cfb0
[PSDK] Add missing parameter names
2025-03-26 13:58:40 +01:00
Mark Jansen
db9768f25d
[PSDK] Add EmptyVC.idl
2025-03-26 13:58:40 +01:00
Serge Gautherie
c302dbcc96
[FORMAT] wmain(): Call GetLastError() immediately
...
and adapt STRING_ERROR_DRIVE_TYPE strings.
2025-03-26 13:37:53 +01:00
Serge Gautherie
421dd31d49
[FORMAT] wmain(): Clean GetDiskFreeSpaceExW() calls up
2025-03-26 13:37:53 +01:00
Serge Gautherie
982cf2be5e
[FORMAT] wmain(): Clean GetVolumeInformationW() calls up
...
and immediately print file system out
2025-03-26 13:37:53 +01:00
Katayama Hirofumi MZ
d69a80fad7
[SHDOCVW] Follow-up of #7804 : Improve AddUrlToFavorites ( #7820 )
...
JIRA issue: CORE-19824
JIRA issue: CORE-19867
JIRA issue: CORE-14172
- Use <strsafe.h>.
- Don't use CSIDL_COMMON_FAVORITES.
2025-03-26 20:13:36 +09:00
Katayama Hirofumi MZ
457642cc4a
[FONTEXT] Refactor ( #7821 )
...
Improve code flexibility.
JIRA issue: CORE-12861
- Delete excessive virtual keywords
and add overload keywords.
- Add InstallFontFiles helper function.
- Add strMsg parameter to
DoInstallFontFile function.
- Move DoInstallFontFile and
DoGetFontTitle functions outside
the class.
- Delete needless fontext.h.
2025-03-26 18:58:12 +09:00
Marcin Jabłoński
be7d79768e
[COMCTL32] Fix a heap corruption in EDIT_EM_ReplaceSel ( #7598 )
...
https://jira.reactos.org/browse/CORE-19743
2025-03-26 10:32:17 +01:00
Serge Gautherie
35ca454cab
[NTOSKRNL] Add missing \n to DPRINT() calls ( #6012 )
...
Improve debug logs.
- Add missing \n to DPRINT() calls
- And demote/promote some DPRINT()/DPRINT1().
2025-03-26 10:23:15 +01:00
Whindmar Saksit
c1b8c4f96f
[SHELL32] Correctly implement common desktop items PIDL ( #7730 )
...
The current implementation is broken, if a file/folder exists in both places, you always get the user item.
CORE-19861
2025-03-25 21:26:55 +01:00
Katayama Hirofumi MZ
151ba9ee8f
[BROWSEUI][SHDOCVW][SDK] Fix 'Add Favorite' command ( #7804 )
...
JIRA issue: CORE-19824
JIRA issue: CORE-19867
- Add shdocvw import to browseui.
- Half-implement shdocvw!
AddUrlToFavorites function.
- Add AddUrlToFavorites prototype
to <shdocvw_undoc.h>.
- Fix browseui!CShellBrowser::
OnAddToFavorites and
shdocvw!CNSCBand::_AddFavorite
by using AddUrlToFavorites.
2025-03-26 04:35:22 +09:00
Doug Lyons
0c6423da8d
[RICHED20] txthost.c: Partial Wine Sync of RichEditWndProc_common ( #7817 )
...
Add extra parameters to 'struct host' to handle 'defer_release' and 'notify_level' and use these.
Fixes crash when using 'Enter' key in DevCpp installer license edit box.
Update and retrial of #7733 . CORE-19991
Cherry pick of wine commit: 8138159f20
2025-03-25 13:15:59 -05:00
Hermès Bélusca-Maïto
48beb0433e
[SETUPAPI] Add missing NULL parameter checks in SetupOpenInfFileW and SetupDiGetINFClassW ( #7573 )
...
Based on PR #5673 , ROSTESTS-388
Co-authored-by: Katayama Hirofumi MZ <katayama.hirofumi.mz@gmail.com>
2025-03-25 17:41:23 +01:00