Remove a temporary DPRINT1.
[CSRSRV]
- Shut down debug output.
- Fix some misspellings.
- Fix a bug in CsrMoveSatisfiedWaits ("satisfied" waits are waits where WaitFunction was put to NULL during a previous call to CsrNotifyWait, but still not dereferenced, and which can be dereferenced by a call to CsrDereferenceWait).
svn path=/branches/ros-csrss/; revision=58103
- Fix console apps initialization.
- Add some debug output (NOTE TO MYSELF: remove them when all things work).
- Rewrite ConsoleNewProcess.
- Reorganize SrvAllocConsole and create ConsoleConnect based on SrvAllocConsole.
- Create ConsoleDisconnect which undoes what ConsoleConnect and ConsoleNewProcess did.
- Rework a little bit CsrInitConsole.
Now the console app. initialization algorithm is the following:
1- A process is created, its type (GUI or CUI) is determined (kernel32 and basesrv).
2- ConsoleNewProcess is called (consrv) and makes this new process inherit the console handles table from its parent
(NOTE: this is done for all CUI processes, because at this point, we still don't know whether we must inherit
the handles from the parent or not).
3- (back in kernel32) In BasepInitConsole, we determine whether or not we must create a new console window or use
the parent's one or not using one at all. We (as a client) connect to the console server (consrv) (via CsrClientConnectToServer)
which in turn (via CSRSS mechanism) calls ConsoleConnect. For GUI processes we do nothing. For CUI processes, we initialize
a new console based on properties set in BasepInitConsole.
4- When a process dies, ConsoleDisconnect is called and whether it is a GUI or CUI process, we revert the actions done previously.
Part 2/2
TODO: - Debug the CSR waits.
- Work on the console properties property-sheet.
- See what can be done on http://jira.reactos.org/browse/CORE-122
svn path=/branches/ros-csrss/; revision=58098
- Fix console apps initialization.
- Introduce a helper function InitConsoleCtrlHandling for initializing console control handling.
- We now initialize the new created console when connecting the client (kernel32) to the server (consrv) by calling CsrClientConnectToServer with real parameters (not dummy ones).
- Add/activate some debug prints (will be removed when all things work).
Part 1/2
svn path=/branches/ros-csrss/; revision=58096
- Be sure that we reply to the dying client when he dies.
- "Improve" a debug output (display the client process).
- Use existing helper functions for incrementing reference counts for threads and processes.
svn path=/branches/ros-csrss/; revision=58075
Do NOT confuse a handle and a pointer to a handle !! In this case we need a handle.
Caught in the following situation :
1- Launch a process A which initializes a console A (say, cmd.exe).
2- Launch a process B which also initializes a console B (for instance, in the first cmd.exe, do: start cmd.exe)
3- Click on the "Close" button (the "Cross" button in the right upper side) of the windows of the console A.
4- Notice that the console B closes but the process B remains alive, whereas the console A remains open but the process A is killed...
(contrary to what you expected, closing the console A and the process A)
(when clicking on the "Close" button, the Console Server launches a remote thread in the context of the target process, and it appeared in the described situation
that it was the wrong process, because of bad parameter passing to the sub-function CsrLockProcessByClientId called when creating the remote thread).
svn path=/branches/ros-csrss/; revision=58073
I replaced by error the mask 0x10000003 by 0x3, which had as an effect to match handles of value 0xffffffff (invalid_handle_value). Fichtre !
svn path=/branches/ros-csrss/; revision=58064
- Code reorganization.
- In particular, move IsConsoleHandle macro to a place which it can be used by both kernel32 and consrv.
svn path=/branches/ros-csrss/; revision=58063
* HANDLE_TYPE --> CONSOLE_HANDLE_TYPE because it hits "previous" definition of this enumeration (a totally different one from win32ss/include/ntuser.h)
* Temporarily add a dummy member to the CONSOLE_CONNECTION_INFO structure, to make MSVC happy.
svn path=/branches/ros-csrss/; revision=58055
- Start implementing a library which is used to parse USB configuration descriptors and construct KSFILTER_DESCRIPTOR structure, which is used with the kernel streaming driver (ks.sys)
- The library will be used in USBAUDIO driver
svn path=/trunk/; revision=58033
* Correct a typo that led to incorrect Capacity value (shown in the disk properties).
* Correct some colors inversion in the Free/Used disk space chart.
* Brought to you by Victor Martinez Calvo.
CORE-6838 #resolve #comment Committed in r58030. Gracias ;)
svn path=/trunk/; revision=58030
- Do not close Notepad when 'Save As' dialog is canceled (behaviour correction, makes it as under Windows). Patch by Peter Hater.
- Temporarily fix saving with invalid file name --> now return an error, don't save the file, reset the internal file name to "" (untitled) and keep Notepad opened.
This is due to the lack of file name validation when calling Save-As file box (should be done by default, but it is not under ROS).
CORE-6836 #resolve #comment Committed in r58024. Thanks :)
svn path=/trunk/; revision=58024
* memcpy should behave exactly like memmove for Windows compatibility.
CORE-6833 #resolve #comment Committed in r58021.
svn path=/trunk/; revision=58021
- Move PcBeep function declaration to a better header.
- Resuscitate OptionMenuCustomBootReactOS() from revision r52491, update it to match recent changes in freeldr as well as making it using new boot method, and reuse ConstructArcPath.
Why I'm doing this ? Because it can be useful to enter personalized boot options by hand at boot time rather than being obliged to edit freeldr.ini. This needs care, not brutal deletion.
svn path=/trunk/; revision=58020
* Fix allocating the required bytes in SetupGetFileCompressionInfoW. Brought to you by Peter Hater (7element {at} mail [dot] bg)
CORE-6815 #resolve #comment Committed in r58018. Cheers ;)
svn path=/trunk/; revision=58018
- Include a netapi32.h in most files and move the other includes into netapi32.h.
- Add functions to open account and builtin domains directly and use these functions.
svn path=/trunk/; revision=58017
Export __crtLCMapStringW and correct __crtLCMapStringA: their prototypes are :
int CDECL __crtLCMapStringW(LCID lcid, DWORD mapflags, const wchar_t *src,
int srclen, wchar_t *dst, int dstlen, unsigned int codepage, int xflag)
and
int CDECL __crtLCMapStringA(LCID lcid, DWORD mapflags, const char* src,
int srclen, char* dst, int dstlen, unsigned int codepage, int xflag)
Needed by SVN.
svn path=/trunk/; revision=58016
- Add Advanced tab in task bar properties to support ReactOS-specific options (currently: show seconds in tray clock). Patch by Edijs Kolesnikovics.
CORE-5410 #comment Patch committed, thanks! Awaiting the updated save-to-registry functionality.
svn path=/trunk/; revision=58011
Improve the way we are doing the timing: When the timeout is > 0, we refresh its display. When it becomes == 0, we exit the waiting-loop and do the right action (start the default OS, ...). However, when we press a key, it is set to -1 by convention, that means, no timeout. The timeout display is then cleared ONLY ONCE since there is no need to refresh it each time we do a waiting-loop-turn when the timeout is == -1.
svn path=/trunk/; revision=58010
- Show the selected boot options as NTLDR does (in light blue under the "For troubleshooting... press F8" message).- The different safe modes are now mutually exclusive, as they must be.
- They can be coupled to the "boot logging", "vga mode" and "debugging" modes, enlarging possibilities (contrary to NTLDR. However you'll remark that these combinations are allowed when set with msconfig...).
- Since the safe modes come by default with boot logging, don't show "Boot Logging" when one of the safe modes is selected, but instead show the corresponding safe mode name.
- Modify the needed functions.
svn path=/trunk/; revision=58008
- Lee Schroeder: Replaces the current fontview icon with the icon found in the tango icon set (apps/preferences-desktop-font.png). This creates better consistency since that is where the majority of the icons come from.
CORE-6827 #resolve
svn path=/trunk/; revision=58007
Allow VideoMode to be set via decimal, hexadecimal, ... number representation in bootcd/livecd/freeldr.ini (see the Brian Palmer's FREELDR.INI example).
svn path=/trunk/; revision=58005
- Menu titles --> Menu headers (see r57842).
- In the same way we introduced menu headers, introduce menu footers, therefore we add the possibility, in mini-tui,
of showing or hiding the "For troubleshooting and advanced startup options for ReactOS, press F8." message, only
useful for the main menu (the one which shows the list of available OSes installed on the system).
svn path=/trunk/; revision=58001
Add some spacing (not too much) between the screen borders and the "Safe Mode" and the ReactOS version string labels, in Safe Mode.
svn path=/trunk/; revision=58000
Add a suitable 'Fixedsys' TTF Unicode font, called 'Fixedsys Excelsior v3.01'.
Released into the Public Domain.
By Darien Gavin Valentine,
http://www.fixedsysexcelsior.com/
svn path=/trunk/; revision=57998
- Implement NetUserGetInfo.
- Implement level 10 in BuildUserInfoBuffer.
- Zero-initialize the user info buffer after allocation.
svn path=/trunk/; revision=57997
