Commit graph

54 commits

Author SHA1 Message Date
Joachim Henze
b71429059a [COMCTL32] Improve status bar margin for unthemed and themed CORE-15834
Improve further what was recently committed in
0.4.12-dev-361-g
da9accfba6
2019-04-07 15:15:25 +02:00
Jérôme Gardou
23373acbb9 [CMAKE] Use modules instead of shared libraries
There is no need to compile our DLLs as shared libraries since we are
managing symbols exports and imports through spec files.

On my system, this reduces the configure-time by a factor of two.
2019-04-06 17:43:38 +02:00
Stanislav Motylkov
cd7011388e [COMCTL32] Edit: Fix caret and scroll position
Based on patch by JIRA contributor 'I_Kill_Bugs'. CORE-15780
2019-03-24 23:26:20 +01:00
Hermès Bélusca-Maïto
780f2ba215
[USER32][COMCTL32] Move the auto radio button group logic from BM_SETCHECK to WM_LBUTTONUP handler.
CORE-8526

Import Wine commit:
96d0af52eb

"user32: Move the auto radio button group logic from BM_SETCHECK to WM_LBUTTONUP handler.
This patch also changes the logic to get the control style with WM_GETDLGCODE
instead of GetWindowLong to make the message test pass.
"
by Dmitry Timoshkov.
See bug report https://bugs.winehq.org/show_bug.cgi?id=42010

- (ReactOS-only) Fix also the corresponding logic in COMCTL32.
2019-03-24 17:23:24 +01:00
Stanislav Motylkov
56ccf8d832 [COMCTL32] Edit: Fix rectangle overflow when inserting characters
Based on patch by JIRA contributor 'I_Kill_Bugs'. CORE-11475
2019-03-23 15:52:43 +01:00
Joachim Henze
e3e173ffaa [COMCTL32] Combobox Implement logic for set and get dropdown height CORE-15833
by import of Wine commit
313c63e194
merged from current Wine head.

Thanks to patches author Fabian Maurer
and also Doug Lyons for tests and adding initial the merge-patch.
2019-03-16 02:11:00 +01:00
Thomas Faber
8dcdf82e71
[COMCTL32] Check for NULL pointer when handling BCM_GETIDEALSIZE.
Fixes crash in comctl32_winetest:button.
2019-02-17 09:51:18 +01:00
Thomas Faber
3445129dd3
[COMCTL32] Add NULL checks to SetWindowSubclass.
Imports Wine commit 04847e68f87 by Sven Baars.

Fixes crash in comctl32_winetest:subclass.
2019-02-17 09:51:16 +01:00
Joachim Henze
1e05f9cc32 [COMCTL32] Revert "button: Don't erase the area of the checkbox or the text."
This reverts commit 0.4.12-dev-347-g
75a80ec823
by explcit request of Giannis Adamopoulos.

I double-checked and confirm, that
this revert fixes both regressions CORE-15595 & CORE-15696.
On the downside the revert will intensify again the regression CORE-13278
(will make the text flash again as well).

Giannis Adamopoulos mentioned earlier, that using double-buffering
eventually could be a valid way out of CORE-13278 instead.
2019-01-29 19:25:57 +01:00
Denis Malikov
da9accfba6 [COMCTL32] add padding for status bar text 2019-01-13 18:21:36 +02:00
Giannis Adamopoulos
75a80ec823 [COMCTL32] button: Don't erase the area of the checkbox or the text.
Attempt to fix the menace of the world, CORE-13278.
Note that this can also cause visual glitches for classic check boxes or radio buttons.
2019-01-10 23:38:02 +02:00
Arnav Bhatt
8ab3652c01 [TRANSLATION] Hindi translation of browseui, comctl32 and shell32 (#1209) 2019-01-01 19:43:42 +01:00
Luo Yufan
0a3f6f3b47 [TRANSLATION] Update Chinese translation. (#1187)
[REG][REACTOS][EXPLORER][APPWIZ][CONSOLE][INETCPL][INPUT]
[INTL][OPENGLCFG][TIMEDATE][DEVCPUX][COMCTL32][COMDLG32]
[MSGINA][NETCFGX][NETID][SETUPAPI][SHELL32][SYSSETUP]
Update Simplified and Traditional Chinese translations.
2018-12-25 17:28:36 +09:00
Luo Yufan
098c69679f [COMCTL32] Update Simplified Chinese translation. 2018-12-24 12:00:29 +01:00
Pierre Schweitzer
52da844825
[COMCTL32] Don't leak memory in CB_ThemedPaint()
CID 1441313
2018-11-16 22:07:09 +01:00
Pierre Schweitzer
3fddd3157c
[COMCTL32] Don't leak memory in PB_ThemedPaint()
CID 1441373
2018-11-16 22:07:08 +01:00
Amine Khaldi
82faa151e5 [XDK][PSDK][WINE] Unify ARRAY_SIZE definition for Wine modules. CORE-15127 2018-09-30 23:57:08 +01:00
Katayama Hirofumi MZ
a244e4f6dd [WIN32SS][COMCTL32] Fix button text Y positioning (#766)
Fixes the vertical position of button text.
CORE-14906
2018-09-09 17:37:37 +02:00
Mark Jansen
ffae49deaf
[COMCTL32] Unregister some classes that were registered.
This should help fix some crashes.
2018-08-27 19:49:57 +02:00
Joachim Henze
1c151c9977 [COMCTL32] Simplify some ifdefs CORE-14649
Addendum to 16d6c9b5e0
Giannis suggested and Thomas explained:

Before the Wine sync, comctl32/button.c was based on ROS's
user32/button.c, so _USER32_ would highlight changes between
user32 (originally based on Wine) and comctl32. Now our
comctl32/button.c is based on Wine's comctl32/button.c, so
__REACTOS__ is enough.
2018-06-03 14:27:34 +02:00
Joachim Henze
16d6c9b5e0 [COMCTL32] Fix regression CORE-14649
Fixes a regression that was introduced by Wine Staging 3.3 Sync.
Symptom was missing button text and icons for specific buttons
in Delphi applications, e.g. Double-Commander, Lazarus, Peazip.
The patch restores and ifdef-guards previous changes of Giannis.
2018-06-02 12:28:47 +02:00
Bișoc George
96c3d8d9eb [COMCTL32] Update Romanian translation (#538) 2018-05-08 23:06:33 +02:00
Giannis Adamopoulos
b3fb8555bf [COMCTL32] Sync with Wine Staging 3.3. CORE-14434 2018-04-20 16:27:17 +02:00
Kláben Szabolcs Bence (Tudi20)
b39df3259b [TRANSLATION][COMCTL32][COMDLG32] Hungarian fix + translation (#437) 2018-03-21 23:10:38 +01:00
Robert Naumann
69acbe905a
Update German translation (#438)
* [BROWSEUI] Update German translation

* [SHELL32] Update German translation

* [COMCTL32] Update German translation

* [COMDLG32] Update German Translation

* [SETUPAPI] Update German translation

* [EXPLORER] Update German translation
2018-03-17 22:48:16 +01:00
Mark Jansen
b02d78586c
[COMCTL32] Export GetWindowSubclass by name.
CORE-14346
2018-02-18 23:04:45 +01:00
Mark Jansen
fb7caa7452
[COMCTL32] Import wine commit 71cf0a31d99feb to fix the name column width in rapps. 2018-02-13 19:48:18 +01:00
Joann Mõndresku
d80ef2c90a [TRANSLATION] Various translations to Estonian (#329)
Estonian translations for shell + explorer, cpl files (access, appwiz, desk, timedate), devmgr, browseui, comctl32, aclui, avifil32, comdlg32 and credui.
2018-01-29 17:03:27 +01:00
Giannis Adamopoulos
8c4b7b0747 [COMCTL32] toolbar: Use szBarPadding.cy as the default top margin 2018-01-29 17:51:06 +02:00
Thomas Faber
73e6bc960a
[COMCTL32] Unset the toolbar's hot item when deleting a button. CORE-14222
This fixes occasional crashes when hovering over disappearing tray icons.
2018-01-20 02:24:01 +01:00
Amine Khaldi
edd99e8ccc [COMCTL32] Sync with Wine 3.0. CORE-14225 2018-01-18 23:49:20 +01:00
Giannis Adamopoulos
b8062bde5d [COMCTL32] rebar: Remove some hacks and fix checking for transparent background 2018-01-15 12:57:06 +02:00
Giannis Adamopoulos
5966a18e66 [COMCTL32] toolbar: Use the theme text color for the dropdown arrows. CORE-13855 2018-01-13 16:19:27 +02:00
Giannis Adamopoulos
f463ebe9e7 [COMCTL32] -toolbar: Improve drawing diabled text with themes. CORE-13855 2018-01-10 23:30:26 +02:00
Giannis Adamopoulos
789881672a [COMCTL32] status: Use DrawThemeText when drawing text with themes. CORE-13855 2018-01-10 15:52:42 +02:00
Giannis Adamopoulos
92732f1bcf [COMCTL32] rebar: Use DrawThemeText when drawing text with themes. CORE-13855 2018-01-10 13:44:32 +02:00
Erdem Ersoy
ba3f074320 [TRANSLATIONS] Update the email address and add a note in the Turkish translation document (#271) 2018-01-07 22:09:42 +01:00
Giannis Adamopoulos
695147eaac [COMCTL32] tab: Use DrawThemeText when drawing text with themes. CORE-13855 2018-01-04 23:27:48 +02:00
Giannis Adamopoulos
522601d050 [COMCTL32] toolbar: Draw checked and not hot buttons as checked, not hot. CORE-13592
Should be sent to wine.
2018-01-04 14:30:47 +02:00
Joachim Henze
5e5e5cde68 [COMCTL32] use previous version of cursor files CORE-14144,
idc_divider.cur & idc_divideropen.cur,
justify their diff in comctl32/comctl32_ros.diff
2017-12-28 00:04:53 +01:00
Katayama Hirofumi MZ
81d6232aa3
[TRANSLATION] Use correct font name in Chinese resources, Part 1/3, CORE-9566 (#221).
Localized resources should use the correct Chinese font names compatible with Windows.
2017-12-27 16:10:56 +01:00
Giannis Adamopoulos
435b0b19d2 [COMCTL32] Install comctl32 v6 and its manifest in first stage 2017-12-24 21:19:03 +02:00
Amine Khaldi
ccd5377851 [COMCTL32][FLTLIB][NETAPI32][SNDVOL32][STOBJECT][WBEMPROX] Remove unused debug channels and comment out unused variables. Silences some clang-cl warnings. 2017-12-08 00:06:13 +01:00
Giannis Adamopoulos
4a843c4e85 [COMCTL32] syslink: Don't free the return value of WM_CTLCOLORSTATIC. CORE-13605
-This is a bug in wine and should be sent upstream
2017-11-24 00:15:57 +02:00
Giannis Adamopoulos
1bfbdb6123 [COMCTL32] Button: Use double buffering when themes are enabled. 2017-11-20 18:51:03 +02:00
Giannis Adamopoulos
a4ea17218f [COMCTL32] Implement using different image list images depending on the button state 2017-11-17 14:44:52 +02:00
Giannis Adamopoulos
34c563fa2a [COMCTL32] Button: Don't use a class brush. CORE-13445 2017-11-17 01:26:37 +02:00
Giannis Adamopoulos
18dee7a392 [COMCTL32] Button: Implement sending CDDS_PREERASE, CDDS_POSTERASE, CDDS_PREPAINT and CDDS_POSTPAINT according to the apitest and the visual tests.
Remove some #ifdef __REACTOS__ from theme_button.c as this file has been forked for good and there is not real plan to keep syncing it with wine.
2017-11-11 13:56:28 +02:00
Giannis Adamopoulos
a98ff4d77c [COMCTL32] Button: Draw the image list even when the button has the BS_ICON or the BS_BITMAP style. CORE-13170 2017-11-11 01:31:32 +02:00
Giannis Adamopoulos
dea602cd70 [COMCTL32] -Button: Implement drawing the image list with the BUTTON_IMAGELIST_ALIGN_CENTER parameter. This is enough to fix buttons with images created by Lazarus but only with themes. The non themed branch of the code is slightly more complex and will be fixed next. CORE-13170 2017-11-10 20:59:25 +02:00