Commit graph

70230 commits

Author SHA1 Message Date
Joachim Henze 688875e411 [0.4.7][CDFS_NEW/NTOSKRNL/NDK] Switch from our old CDFS to MS-PL CDFS_NEW
The main motivation to switch to that newer driver is, that our old one
simply can not read all isos. Especially complex ones made trouble and were
only shown as empty in explorer.
It is still possible to build and use the old driver when needed, only thing
that needs to be done for that is to revert 0.4.8-dev-164-g ec6b3ecbe4

Porting back the state up to 0.4.8-release-100-g8f947b5 implies:

Fixing the following JIRA-IDs (or avoid introducing them):
CORE-18029 "Mute noisy DPRINT 'SectionObject has ImageSection'"
CORE-17405 "Fix a macro-copy-paste and shrink the binary size"
CORE-15659 "Unable to build the gcc Release version in Windows using RosBE 2.1.6 (module cdfs fails)"
CORE-14315 "CDFS_NEW assertion during first stage setup due to new CcPerformReadAhead"
CORE-14128 "Avast! Free Antivirus 7.0 hangs the system when trying to detect a newly created virus"
CORE-14067 "CDFS_NEW assertions and exceptions"
CORE-14003 "Shutting down LiveCD asserts since introduction of MS PL CDFS_NEW"
CORE-13184 "Restore ability to install from disk-image"

by picking the following commits:
0.4.8-release-100-g 8f947b5322 [NTOSKRNL] Mute noisy DPRINT 'SectionObject has ImageSection' CORE-18029
0.4.8-release-80-g eb1ea19588 [CDFS_NEW] == 0.4.15-dev-1456-g 889eab7 CORE-17405
0.4.8-release-62-g 8c07aad4a8 [CDFS_NEW/XDK] == 0.4.11-dev-39-g a2f9762 + 0.4.11-dev-40-g 6d7ec8c CORE-14067
0.4.8-release-3-g 5d976d04e8 [CDFS_NEW] == 0.4.12-dev-431-g bccad87f3c + 0.4.12-dev-432-g 3463b2db9f CORE-15659
0.4.8-RC-3-g 51f9494d48 [CDFS_NEW] superseded later by the proper fix 0.4.8-release-62-g 8c07aad4a8 CORE-14067
0.4.8-dev-1069-g a5e89014dc [CDFS_NEW] CORE-14315
0.4.8-dev-475-g a59d4674de [NTOSKRNL] io/iomgr/device.c (forgotten assert) CORE-14128
0.4.8-dev-221-g 9d67a24799 [CDFS_NEW]
0.4.8-dev-220-g 67a7e45e35 [CDFS_NEW/DOC]
0.4.8-dev-219-g 6a3bbf24e0 [CDFS_NEW]
0.4.8-dev-218-g ec26cde4a1 [CDFS_NEW]
0.4.8-dev-217-g bc2378a356 [CDFS_NEW]
0.4.8-dev-216-g 5429771b99 [CDFS_NEW]
0.4.8-dev-215-g fd34548263 [CDFS_NEW] Sync with MS-PL driver
0.4.8-dev-164-g ec6b3ecbe4 [FILESYSTEMS] switch from CDFS to CDFS_NEW in CMakeLists.txt
0.4.8-dev-160-g 2b217e4ecf [NTOSKRNL] Mute spam CcSetReadAheadGranularity()
0.4.8-dev-159-g 64cb138a67 [NTOSKRNL] Mute spam CcPurgeCacheSection()
0.4.8-dev-150-g f723d230a0 [CDFS_NEW]
0.4.8-dev-133-g faee3753ea [CDFS_NEW] CORE-14003
0.4.8-dev-132-g 1d777ffab5 [NTOSKRNL] iofunc.c CORE-14003
0.4.8-dev-131-g c3d5a3f2bd [NTOSKRNL] iofunc.c CORE-14003
0.4.8-dev-130-g 3b64f7f8fb [NTOSKRNL] ob/obref.c & co CORE-14003
0.4.8-dev-129-g 7eefe70294 [NTOSKRNL] io/iomgr.c & co CORE-14003
0.4.8-dev-127-g 5f255827d3 [CDFS_NEW]
0.4.8-dev-126-g 1bef48796e [NTOSKRNL] just a comment, superseded later
0.4.8-dev-125-g cbf0430b56 [CDFS_NEW]
0.4.8-dev-123-g f88fe43abd [NTOSKRNL] io/iomgr/device.c (forbidden DPRINT)
0.4.8-dev-122-g 6c73385625 [CDFS_NEW] CORE-13184
0.4.8-dev-97-g 94298313c0 [CDFS_NEW]
0.4.8-dev-95-g e88eeb21af [CDFS_NEW/NTOSKRNL] CcWaitForCurrentLazyWriterActivity() stub return Success
0.4.8-dev-94-g 03d5be6437 [CDFS_NEW]
0.4.8-dev-93-g fa1c60db50 [CDFS_NEW]
0.4.8-dev-92-g 8b2fd60829 [CDFS_NEW]
0.4.8-dev-91-g e4da7ecc50 [CDFS_NEW]
0.4.8-dev-90-g 7b19676e2b [CDFS_NEW]
0.4.8-dev-89-g 3d4b8783fd [CDFS_NEW]
0.4.8-dev-88-g 818025ecc8 [CDFS_NEW]
0.4.8-dev-87-g 2639dd6736 [CDFS_NEW]
0.4.8-dev-86-g 755bdb5d0b [CDFS_NEW]
0.4.8-dev-85-g 3cbcb1bade [CDFS_NEW]

and mute spam in opcode INSTEAD of picking:
0.4.8-dev-165-g 2284a457a3 [NTOSKRNL] oplock.c Fixup
0.4.8-dev-163-g d3d5853956 [NTOSKRNL] oplock.c Implement oplock-support
0.4.12-dev-232-g f488102c86 [CDFS] was also left out for now

I am aware, that the backport introduces white-space-glitches within CDFS_NEW.
I decided to live with them in favor of better sync to master and newer releases.
2022-01-27 21:11:23 +01:00
Joachim Henze 579198c07b [0.4.7][SHELL32] Control panel context menu semantic bugfix (#4078) CORE-17855
Fix ported back from 0.4.15-dev-3396-g 83335d3a81
2022-01-26 12:52:15 +01:00
Joachim Henze c11e06412a [0.4.7][RAPPS] Pick some simplifications from master up to 0.4.15-dev-3726-gc262020 (e.g. CORE-18018 and (#2751))
As the dialog simply displays the copyright names and nothing particular it makes sense to use ShellAboutW() instead.

Several fixes ported back:
0.4.15-dev-3726-g c262020016 README CORE-18018
0.4.15-dev-3724-g 3a7c0d82d2 size fallback part 1 CORE-18018
0.4.15-dev-3569-g b5a6357d93 available.h/.cpp Strip 3 useless functions
0.4.15-dev-384-g 393a2c42fe CDPath in README
0.4.15-dev-227-g a6084d7440 ShellAbout() (#2751)
and some whitespace corrections
2022-01-24 10:33:53 +01:00
Joachim Henze 0e86fe0bf8 [0.4.7][COMCTL32] Workaround regression with toolbar in 7zip CORE-16169
The regression was introduced by SVN r68553 == git 3b13364f05

Many thanks to the author Doug Lyons for excellent
cooperation once more. Always a pleasure.

Fix cherry picked from commits:
0.4.15-dev-663-g cd7db5df89 and
0.4.15-dev-664-g 7c909cbc7c
2022-01-23 14:01:25 +01:00
Joachim Henze 0bdf4f5317 [0.4.7][SNDREC32] Fast-Forward to 0.4.15-dev-3294-ge98684e state (CORE-17815 and several PRs)
My main motivation was a fix for the bug
CORE-17815 'Fix incorrect opaque text rendering' (#2760)
which was unhidden by 0.4.12-dev-824-g d57f7becc3 .
That specific and most important fix
was picked from 0.4.15-dev-190-g d839e3d9b4
We left out the additional WIN32SS-hardening in this context in the backport to older
releases for now.

Then I looked further in sndrec32 and compared each file of that module on master
head with both: current 0.4.14RC and also current 0.4.7rls and found the rare
situation that I liked each and every change within since 2017.
Specifically this will also backport (#2754), and various translation PRs, whitespace-cleanup,
and (for older releases than 0.4.14RC) it will also bring some x64-improvements.

So I decided to take everything from current master head except the changes in CMakeLists.txt
and some hebrew RTL addition
because that subset is applicable and a win for all ros releases down to 0.4.7.
2022-01-17 22:45:48 +01:00
Joachim Henze 332a660a70 [0.4.7][SYSDM] MSVC warnings RC4206 : title string too long; truncated at 256 CORE-17827
Fix picked from:
0.4.15-dev-3699-g b1264c13f7 for el-GR.rc
0.4.15-dev-3700-g 98999eebe4 for sk-SK.rc
0.4.15-dev-3701-g bacc0479ce for sq-AL.rc
The pt-PT.rc file (also affected on master) did not exist in this ancient branch yet.
2022-01-16 18:03:15 +01:00
Joachim Henze 55062f0648 [0.4.7][PROGMAN][USER32][SHELL32] Do not use LoadLibraryEx() NT6+ flags (#3152) CORE-12004
LOAD_LIBRARY_AS_IMAGE_RESOURCE and LOAD_LIBRARY_SEARCH_SYSTEM32 are Vista+

This fixes some blurry icons in systray when 2k3sp2 kernel32.dll is used in ros CORE-12004
That part in user32 was a regression of SVN r71609 == git a44dfe6c76
While we are at it we do fix some other modules as well, that used those NT6+flags.

The fix was picked from 0.4.15-dev-788-g a04831677e
--------
That second part in SHELL32 regressed even earlier by
SVN r51768 == git 6ced137ce2
and was fixed on master by chance when the PickIconDlg() was overhauled entirely via
git 0.4.10-dev-106-g 222534a5a2 . But that is not the solution I ported back today.
2022-01-15 12:55:46 +01:00
Joachim Henze c5b06a1b5d [0.4.7][WIN32K] Revert NtGdiStretchDIBitsInternal to Previous Logic (#3774)
Fixes gdi32:dib / gdi32:bitmap tests and

CORE-16236 "SIMS graphics", which regressed by
SVN 51005 == git 2bbd8711a7

Thanks to the patches author Doug Lyons.

It also fixed
CORE-16621 Kompozer 0.7.10 from rapps, exe does not show an icon, but does on 2k3sp2

fix picked from 0.4.15-dev-2850-g 847b037fe9
--------------
By taking the above, we also have to pick its addendum
[WIN32K] Fix 'use after free' in NtGdiStretchDIBitsInternal #4122 CORE-17861

0.4.15-dev-3420-g b538b9abb8
to avoid introducing another bug:
CORE-17861 MS Visual Studio 2010 Pro Fatal System Error 0x00000050
--------------
[WIN32K] Don't trust the BITMAPINFOHEADER size

This is not entirely correct yet, but less wrong than before and fixes
CORE-16031 Moo0 Audio Recorder - ReactOS icons are not displayed in the system tray
fix picked from 0.4.14-dev-848-g 53c9a6deaa
2022-01-15 01:31:32 +01:00
Joachim Henze 1480d801ee [0.4.7][RAPPS] Introduce 'SizeBytes' DB entry and use it for display
This will allow us to reduce the DB size a little by avoiding
duplication for each and every entry.
Original patch by JIRA user "swyter"

CORE-10310

fix picked from 0.4.9-dev-633-g 627739aed9
but slightly adopted to leave out some formatting glitches and
also leave out the "fall back to Size string" in available.cpp because
on 2021-10-03 Mark Jansen deleted all old size entries from the rapps database via
551e8cb95716f46e05c3be08996467bd93b1936f
2022-01-14 22:50:13 +01:00
Joachim Henze 7f018efb51 [0.4.7][WIN32K] Revert incorrect part of R50928 for RealizePalette. (#3678)
Revert part of SVN R50928 that causes Durak card suites to have wrong colors.
SVN r50928 == git 5de8339cd1

JIRA issue: CORE-13748 <= Durak Example
JIRA issue: CORE-16510 <= GDIProg Example

The idea was picked from 0.4.15-dev-2735-g c7954134d0
but I was too shy to port the recurrently spamming and slowing DPRINT1 back that far.
Spamming on master should be enough to improve here later.
2022-01-12 06:02:30 +01:00
Joachim Henze 795c5cc31e [0.4.7][EXPLORER] Fix for Start Button Wrong size when Using Themes (#4121) CORE-16742
CORE-16742 'Start button background in themes is scaled incorrectly' (especially MS Luna)

The problem once was unhidden by
0.4.7-dev-705-g 85ae842105

Fix picked from 0.4.15-dev-3441-g 67ad4e7f60
--------------
and while touching the file, do port back also some EOL-whitespace-stripping and
0.4.9-dev-642-g eff4c2138d Remove double 'return' statement CORE-14528
2022-01-10 13:52:37 +01:00
Joachim Henze 4dbb1d4fc0 [0.4.7][NTUSER][USER32] Tracking menu CORE-17338 (#4048), [EXPLORER] Send WM_POPUPSYSTEMMENU asynchronously (#4047) CORE-16353
This prevents the tracking menu from erroneously closing itself right after it was opened in some cases.
Fixes CORE-17338 which got unhidden by 0.4.15-dev-1126-g 58b0558f94
And fixes CORE-15760 which got unhidden by SVN r74972 == git 19dd22d422

Since both symptoms look very similar but the unhiding revisions did differ,
that could mean we do have some kind of race condition here.
I guess this fix is more like a workaround.

2 Fixes picked:
0.4.15-dev-3313-g 6417b2323d [NTUSER][USER32] Workaround tracking menu on CORE-17338 CORE-15760 (#4048)
to prevent the menu from auto-closing

and
0.4.15-dev-3297-g 037c744eb1 [EXPLORER] Send WM_POPUPSYSTEMMENU asynchronously CORE-16353 (#4047)
to make the taskbar button turn into pressed state when the menu opens
2022-01-10 07:20:11 +01:00
Joachim Henze e46f3541d9 [0.4.7][BOOTDATA] Fix formatting glitches in hivesys.inf, e.g. PORTUGESE_BRAZILIAN CORE-17828
PORTUGESE_BRAZILIAN regressed in 2017 with SVN r74654 (commit hash 8e52193 ).

Fix picked from
0.4.15-dev-3317-g 6ce259e694 PORTUGESE_BRAZILIAN
0.4.15-dev-3321-g 4b88a8709c ICELANDIC
0.4.9-dev-XXXX fixes other formatting glitches in LATVIAN, AZERI_CYRILLIC and "MS Transactions"
2022-01-08 13:47:01 +01:00
Joachim Henze a3455e9d65 [0.4.7][UNIATA] Workaround random crashes on Virtual PC (#3377) CORE-12441 CORE-17371
I am not sure why this line in id_queue.cpp was added.
I don't know how I could improve that case.
Then, disable it, for the time being.

It regressed by 4b9cf2e339 (r71252). CORE-12441 CORE-17371

fix picked from 0.4.15-dev-2740-g ba77a09c04

While touching uniata do also PARTIALLY port back some bm_devs.h changes:
0.4.15-dev-1522-g 88d36c93a2 (Properly mark ReactOS diff from upstream)
2021-11-16 22:34:46 +01:00
Joachim Henze 01eb64743c [0.4.7][FLOPPY] Don't wait forever while trying to determine media type. CORE-12908
This should fix some virtual machines and real hardware machine with empty floppy drive
not being able to boot ReactOS (stuck while initializing floppy.sys).

This fixes a regression introduced in SVN r70746 == git 78eb31503a
It could be generalized to other interrupts, floppy controllers not being reliable.

For more information: http://wiki.osdev.org/Floppy_Disk_Controller

It fixes:
CORE-12908 'Virtual PC 2004 SP1 (and 2007), LiveCD (and BootCD): boot hangs on FLOPPY.SYS'
CORE-7935, CORE-13080, ... and a lot of other duplicates of that ticket.

Fix picked from 0.4.8-dev-187-g 4b34e44782
-------
This will sync floppy.sys to the stable state that we had all the way from
0.4.8-release-86-g472a0ec up to 0.4.12-release-53-g3890268
2021-11-16 03:06:56 +01:00
Joachim Henze 30beb6cf9a [0.4.7][NTGDI] Fix potential BSOD 0x1E CORE-17626
in CreateDIBPalette() when passing invalid arguments to CreateDIBSection.
This could be triggered by using the broken test-application "GDIProg".

After this patch not only the BSOD is fixed but also the app does
properly start up, like it is the case on 2k3sp2.

The problem was unhidden by the innocent and unrelated 0.4.12-dev-266-g 8ab3652c01
I was not able to trigger the bug in releases older than 0.4.12,
but it is rather obvious that the mentioned revision is not really 'guilty', which
is why I will port the fix back further into releases even older than 0.4.12 as well.

Thanks to the patches author Doug Lyons.

a squashed port of:
0.4.15-dev-2734-g 514147776a (fixes the BSOD)
0.4.15-dev-2775-g c596fd3ef6 (improvement #3758)
0.4.15-dev-2776-g 4130f0b1c5 (compilation fix)
and some white-space tweaking that was committed after those.
2021-11-15 12:10:02 +01:00
Joachim Henze a2e5d3e570 [0.4.7][NTOS/MM] Properly handle page faults in regions marked with PAGE_NOACCESS or PAGE_GUARD CORE-14694
This was part of the commits for ROSTESTS-110, but much more important:
It fixes CORE-14694 "reproducible BSOD 0x1A MEMORY_MANAGEMENT in OllyDbg v2.01"

Fix picked from 0.4.11-dev-650-g 47ac7a2b28

which also requires me to "Move up MmAlterViewAttributes() for later use in MmNotPresentFaultSectionView()"
like it was done in: 0.4.11-dev-649-g 47ac7a2b28
Ofc I moved the function up individually in each branch I do port this back to, without modifying the func.
2021-11-15 01:17:07 +01:00
Joachim Henze 1c3ae3043a [0.4.7][UDFS] Fix crash on boot in release builds with UDFS removable media inserted (#4061) CORE-17598
Changes to specific files and their effects are as follows:
create.cpp - Allows booting past second stage with UDFS media inserted without BSOD
close.cpp - Allows shutdown without hang
dircntrl.cpp - Allows New Hardware Wizard not to hang on initial third phase install

It began to crash with the introduction of the UDFS driver in SVN r74901 == git 3a104c8f20

Fix picked from 0.4.15-dev-3326-g a91f5e8e4d
2021-11-14 21:23:05 +01:00
Joachim Henze 61f3a30fef [0.4.7][NETSHELL] Fix MSVC compiler warning in de-DE.rc
MSVC2010 compiler warning shellext\netshell\lang/de-DE.rc(118) : warning RC4206 : title string too long; truncated at 256
introduced by SVN r71434 == git 6ce8ee357a

The string was displayed properly and was not truncated even before this patch.

Fix picked from 0.4.15-dev-2885-g 7962db4cc1
2021-07-07 02:24:33 +02:00
Joachim Henze 85ebf53437 [0.4.7][DESK] Fix GetDC/ReleaseDC error management
Fix missing ReleaseDC related to the spectrum (color depth)

We leaked one device context for each bpp change within the
desk.cpl-session, which gave the following logging when closing desk.cpl:
(win32ss/user/ntuser/windc.c:749) err: [00060138] GetDC() without ReleaseDC()!
1 time for each leak.

Partial backport of (#2707)
Fix picked from 0.4.15-dev-2867-g d635ce0cc0
2021-07-06 00:52:18 +02:00
Joachim Henze 73b9fcfa88 [0.4.7][WORDPAD] Fix icons for toolbar and formatbar (#3792) CORE-5823
* CORE-5823 Fix icons for toolbar and formatbar in Wordpad.
which regressed by SVN r47776 == git 5dbfbb5201

* Add wordpad_ros.diff noting toolbar.bmp and formatbar.bmp are not wine-synced

Thanks to the patches author Doug Lyons.

Fix picked from 0.4.15-dev-2862-g e068c68452
2021-07-04 14:51:47 +02:00
Joachim Henze d339297585 [0.4.7][LSASRV] LsapLogonUser(): Fix 'AuthenticatingAuthority' copypasta (#2839)
Reported by contributor 'qarmin', found by static code analysis.
CORE-17074

The glitch once was introduced 7 years ago by SVN r58933 == git 7934e35cdf
There is no real-world-issue known to date caused by this bug.

fix cherry picked from commit 0.4.15-dev-303-g 99d0a348aa
2021-06-20 15:42:10 +02:00
Joachim Henze 54e7bcf564 [0.4.7][SHELL32] Update all languages RCs to fix possible text truncation CORE-15765
IDD_BROWSE_FOR_FOLDER displays text controlled by the calling applications in
IDC_BROWSE_FOR_FOLDER_TITLE. Its old height could lead to text truncation
for existing 3rd party apps.
The new height value for IDC_BROWSE_FOR_FOLDER_TITLE
was inspired by IDC with the same from dialog IDD_BROWSE_FOR_FOLDER_NEW.
I could change all languages to the same height,
as dimensions of the dialog and surrounding controls were same.

picked from 0.4.12-dev-781-g 1d7287288d
2021-05-16 03:18:01 +02:00
Joachim Henze 8e02756722 [0.4.7][SHELL32] Fix version string in Shell About dlg CORE-16571, & some de-DE
It "regressed" and was displayed cut-off since the switch to git
(our string got longer back then).

Fixed by porting back 2 commits:

0.4.14-dev-976-g 6ce72ba172
0.4.14-dev-884-g a57f7b50c0

and also port back some german translation updates and
trivial whitespace fixes at the same time in *.rc.
2021-05-15 04:42:44 +02:00
Joachim Henze 560cb2d378 [0.4.7][SYSDM] Restore the general tabs layout and soft localization update
Although the new layout that I committed in the previous commit
was favored by community ratings votes 8:0,
some devs still preferred the old layout with the bigger logo
because they liked the easteregg. So this commit restores
that.

But it syncs to that features latest&greatest implementation
we have in 0.4.15-dev-1685-gd0c237a instead of reverting the
previous commit to not unnecessarily have many bugs with it
that were still affecting the older releases beforehand.

Aside from the general tabs dialogs layout this commit does
also fix some minor issues in the translations for the oldest
branches in pl-PL, jp-JA, zh-CN and zh-TW.

And it fixes an x64 issue in general.c for 0.4.7 and 0.4.8.
2021-02-01 22:02:32 +01:00
Joachim Henze f4a20411d9 [0.4.7][SYSDM] Fix version string cutoff CORE-17429
The version string cutoff started to happen when we switched from SVN
with its short revision number to git with the longer hashes.
0.4.7-dev-502-gc2c66af was the first git-only rev (2017-Oct-03)

and brings the dialogs layout closer to XP.
Also fixes some other truncations for specific languages.
And unifies the touched text controls sizes for all languages.

The credits have been moved to readme.txt where they are more present and
we can avoid having to groom all languages files each time we want to add
a new dev (and sysdm.cpl to grow each time). Less maintenance.

sysdm.cpl binary size I18N=all
master before 925.696bytes  after 705.024bytes  gcc 8.4.0 dbg RosBE2.2.1
0.4.14 before 923.136bytes  after 702.464bytes  gcc 8.4.0 dbg RosBE2.2.1
0.4.13 before 904.192bytes  after 684.544bytes  gcc 4.7.2 dbg RosBE2.1.6
0.4.12 before 881.664bytes  after 665.600bytes  gcc 4.7.2 dbg RosBE2.1.6
0.4.11 before 836.096bytes  after 618.496bytes  gcc 4.7.2 dbg RosBE2.1.6
0.4.10 before 806.912bytes  after 588.800bytes  gcc 4.7.2 dbg RosBE2.1.6
0.4. 9 before 788.480bytes  after 585.728bytes  gcc 4.7.2 dbg RosBE2.1.6
0.4. 8 before 788.480bytes  after 585.728bytes  gcc 4.7.2 dbg RosBE2.1.6
0.4. 7 before 788.992bytes  after 585.728bytes  gcc 4.7.2 dbg RosBE2.1.6

readme.txt still fits into a single NTFS cluster afterwards with 3702bytes

Also a very! soft update of some translations ported back.
2021-01-30 21:07:54 +01:00
Joachim Henze 6ece2bbe9c [0.4.7][SYSDM] Make the GPL text ASCII. CORE-14278
symptom CORE-14278 "View License in the System Properties shows corrupted text for git-clones on Windows"

This is better than wasting space on null chars (and having Git mangle it).
Also ensure that it gets CRLF newlines since its contents go in the binary.

This fixes CORE-14278 regression introduced by 0.4.7-dev-515-g 9ebf43567d

It will also shrink the binary size of sysdm.cpl RosBE2.1.6 GCC4.7.2 dbg
from 807.936bytes to 788.992bytes

Fix picked from 0.4.8-dev-1031-g c0a227d9a5
2021-01-30 04:04:06 +01:00
Joachim Henze d68b4c4a10 [0.4.7][SHELL32] Fix regression CORE-12364 explorer-sorting
The sorting in explorer broke by
SVN r73128 == git 24fcf531e7

Thanks to Doug Lyons for providing this patch.
2021-01-19 18:23:25 +01:00
Joachim Henze 848570fc55 [0.4.7][COMCTL32] Treeview undo handling of WM_SYSKEYDOWN (#2731) CORE-12203 CORE-17020
Remove WM_SYSKEYDOWN handling at component level, in consistency with other components (ListView,...)
Early embodiement of the fix proposed to WineHQ:
https://bugs.winehq.org/show_bug.cgi?id=49097 in order to remove functional limitation in ReactOS.

Fixes regressions CORE-17020 and CORE-12203 that were once introduced
by SVN r72320 == git 297e33f228
during COMCTL32 WineSync 1.9.16 CORE-11866

Fix picked from 0.4.15-dev-191-g 295ba62820
2021-01-18 01:37:47 +01:00
Joachim Henze 52f6ad7d23 [0.4.7][APPWIZ] Don't hung up in Gecko download cancellation #3049 CORE-14538
Do not call EndDialog outside the dialog procedure.

fix picked from commit 0.4.15-dev-511-g 90456e54a4

This hang/crash in 2nd stage setup did *not* affect our official carrier-releaser isos that
we host on sourceforge, because those come bundled with Gecko already and therefore always
skipped the download.
Most users were safe in the past therefore.
Still everyone that would like to build an iso by himself could potentially run
into those crashes, and it did not only happen upon user-driven cancellation,
but also often crashed upon network failure / timeout.
A very important fix therefore.
For some unknown reason the likelihood of this crash gradually increased from
0.4.7 where it happened almost never, until 0.4.14 where it crashed much more likely.
Not well understood, maybe depends on memory layout or something similar.
2021-01-17 22:53:15 +01:00
Joachim Henze 77a1d1062b [0.4.7][MMSYS] 100% sync of the module to 0.4.11-release-46-g12d8367
All of those are super safe commits. Fixes CORE-13508

-excerpt of 0.4.11-dev-909-g 07b120bd56 zh-CN [TRANSLATION] Update Simplified Chinese translation. (#1094)
-excerpt of 0.4.11-dev-149-g 31019e8c0c ro-RO [TRANSLATION] Update Romanian translation (#851)
-excerpt of 0.4.9-dev-126-g 0182dcd71b sounds.c x64 compatibility issue, possible pointer truncation
-0.4.9-dev-104-g 9e9f053eec fixes CORE-13508 fr-FR "Sound settings : narrow elements (french)"
-excerpt of 0.4.8-dev-644-g ba3f074320 tr-TR whitespace noise
-excerpt of 0.4.8-dev-627-g fe50c655aa zh-CN [TRANSLATION] Update Simplified Chinese translations and font settings. (#266)
-excerpt of 0.4.8-dev-533-g 2b91b29642 zh-CN/zh-TW [CPL] Control Panel Applets: Use correct font name in Chinese resources, CORE-9566 (#220).

mmsys.cpl binary size in bytes RosBE2.1.6 GCC4.7.2 dbg I18N=all decreases for 0.4.7 thanks to the chinese changes:
0.4.11    which is the source 741.376
0.4.10  old 741.376   patched 741.376
0.4. 9  old 741.376   patched 741.376
0.4. 8  old 741.376   patched 741.376
0.4. 7  old 741.888   patched 741.376

Syncing the module will simplify future backmerges.
2021-01-17 20:48:06 +01:00
Joachim Henze e751ba51d9 [0.4.7][MMSYS] Fix combo box and play icon on "Sound" properties page (#2690)
CORE-16935

I merged that back, because at least the play-icon was a regression.
It regressed by SVN r68073 == git 888c2fb967

Ftr we did not always use an icon here, but instead earlier we just had some
font glyph displaying the play-symbol. It was once changed to icon to improve
display for some asian localization (japanese? iirc).

fix picked from commit 0.4.15-dev-86-g bdb4da009a

The patch also decreases binary size
mmsys.cpl binary size in bytes RosBE2.1.6 GCC4.7.2 dbg I18N=all:
0.4.13  old 786.944   patched 782.848
0.4.12  old 786.944   patched 782.848
0.4.11  old 745.472   patched 741.376
0.4.10  old 745.472   patched 741.376
0.4. 9  old 745.472   patched 741.376
0.4. 8  old 745.472   patched 741.376
0.4. 7  old 745.984   patched 741.888
2021-01-17 17:28:10 +01:00
Joachim Henze f0d5d1517a [0.4.7][DESK] Update zh-CN.rc & zh-TW.rc
Improves some strings, but actually I ported that back to reduce binary size.
The translated strings are shorter even than the english ones. Win-win!
Source was state of 0.4.12-release-31-g62822df.

desk.cpl built with RosBE2.1.6 on Windows with GCC4.7.2 debug building with I18N=all:
                                   539.136bytes for 0.4.12-release-31-g62822df (was source)
0.4.11 before 539.648bytes   after 539.136bytes
0.4.10 before 539.648bytes   after 539.136bytes
0.4. 9 before 539.648bytes   after 539.136bytes
0.4. 8 before 539.648bytes   after 539.136bytes
0.4. 7 before 528.896bytes   after 528.384bytes
2021-01-17 07:38:07 +01:00
Abdulganiev Rafael 57ec09c16c [0.4.7][DESK.CPL] Remove monitor resource scaling (#876)
This improves both: the visual quality of the dialog and also
decreases desk.cpl binary size.

Fix picked from 0.4.11-dev-244-g 6f138e2811

------------------------------
But it also inherently includes
0.4.11-dev-94-g 25f4ed75a0
"[CPL][DESK] Update monitor resource (#816)"
which replaces the CRT bmp with a TFT bitmap
2021-01-16 21:37:23 +01:00
Stanislav Motylkov 320a4df8f4 [0.4.7][DESK.CPL] Fix dialog appearance in 640x480 resolution (#343)
CORE-14274 "Display settings dialog is too big"

fix picked from commit 0.4.8-dev-939-g 2595538558
2021-01-16 20:40:39 +01:00
Joachim Henze dbd3a057ff [0.4.7][WIN32SS] Fix BSOD 0x1E nullptr deref via Git-bash CORE-16586
Thanks to the patches author Doug Lyons!

fix picked from 0.4.15-dev-1457-g 870aa1254f
and the whitespace addendum 0.4.15-dev-1458-g 449a341786
2021-01-16 15:53:21 +01:00
Joachim Henze 2a22277871 [0.4.7][SERVMAN] fix status-bar text truncation, update german localization CORE-14092
cherry picked from commit 0.4.8-dev-387-g 8624801eb8
2021-01-16 14:45:26 +01:00
Joachim Henze d276da45a3 [0.4.7][RAPPS] "Let's encrypt" Certificate-Issuer-Update hamster-wheel
"Let's encrypt" certificate issuer string changed within last 24hours remotely.
Update its name to make RAPPS stop complaining on DB update.

And also fix a bug in rapps mixing A()/W() in the
messagebox that informs about that cert check failure.

Fix is port of
0.4.15-dev-1120-g 12caaece25
0.4.15-dev-1617-g f77f5a30cf

Next time this happens I will relentlessly undefine CMakeLists.txt USE_CERT_PINNING
2021-01-11 21:30:00 +01:00
Joachim Henze 5f0c98f291 [0.4.7][WIN32SS] Fix regression CORE-15558 Font enumeration
Fixes CORE-15558 "AbiWord font listbox should display a specific font only once, but displays each of them many times instead"
which regressed by SVN r75491 == 0.4.7-dev-32-g d10c0ec112

by porting back the commits:
0.4.12-dev-320-g 6e4e5a004c
and
0.4.13-dev-107-g ae8417fd90 to prevent introducing another regression CORE_15785 with the initial fix.
and some more addendums to prevent introducing regression CORE_15755

I verified afterwards that all 3 issues: CORE-15558, CORE_15785 and CORE_15755 are in fixed state.

Actually I don't really like the resulting code due to the qsort() that it introduces into
win32ss/gdi/gdi32/objects/font.c
We did not need that at all before 0.4.7-dev-32-g d10c0ec112
In case that qsort() would ever reveal any new trouble like reduced performance or stack overflow,
we should structurally revert all that context to 0.4.7-dev-31 instead.
IntEnumFontFamilies() is called immediately upon process initialization for many applications and the qsorted-list is *huge*,
so this indeed could be relevant for performance.
2020-12-31 22:12:17 +01:00
Joachim Henze f166e0d9e8 [0.4.7][WIN32SS] Kill unused remnant static global var
The var was part of an ancient workaround.
Fix is a partial port of 0.4.8-dev-18-g 5cb0615147
2020-12-31 19:01:56 +01:00
Joachim Henze 3df41edcca [0.4.7][WIN32K:NTUSER] Properly fix IntSendChildNCPaint() & IntLinkWindow()
Hack has been introduced in IntSendChildNCPaint() in r73532 == 6d7fcc4
to attempt to pseudo-fix CORE-12071 and CORE-12085 while breaking other stuff,
amongst which CORE-14763 is one of the latest manifestations, and re-enable the correct original code.

This fixes painting hangs under diverse situations,
while CORE-12071 and CORE-12085 remain fixed.

When it was hanging like CORE-14763, we could not even ACPI shutdown anymore.

fixed by porting back:
0.4.10-dev-324-g 25004bb5b4
0.4.10-dev-323-g ee0511b49d
0.4.10-dev-322-g 4d057cf626
2020-12-23 02:23:59 +01:00
Joachim Henze a867fe15ae [0.4.7][EVTLIB] Silence some DPRINTs.
picked from 0.4.9-dev-726-g 10ed9621e4
2020-12-21 10:44:24 +01:00
Joachim Henze 42c7efd2ff [0.4.7][WIN32K][NTUSER] Tiny codestyle fix to NtUserLockWindowUpdate (#1066)
Fix indentation (inconsistent with the rest of the file) and return actual BOOL.
picked from 0.4.11-dev-838-g 62ec69278d
2020-12-21 10:14:51 +01:00
Joachim Henze f38e09e9f0 [0.4.7][NTUSER] Silence a noisy trace
picked just that part of 0.4.12-dev-121-g 3ec7b16
2020-12-21 10:03:32 +01:00
Joachim Henze 367b12e75e [0.4.7][WIN32K] Fix DBG_PRINT macro.
picked from 0.4.10-dev-215-g 9d3d5e464d
2020-12-21 09:26:51 +01:00
Joachim Henze aae71ab0f4 [0.4.7][NTOS][USERSRV] Silence noisy debug output.
picked from 0.4.13-dev-82-g f5471b7b4b
2020-12-21 08:54:30 +01:00
Joachim Henze 91b9815658 [0.4.7][FFS] Silence some only-informative KdPrints.
picked from 0.4.13-dev-924-g 4016225269
2020-12-21 07:56:15 +01:00
Joachim Henze 48a775367d [0.4.7][CONSRV] Silence a noisy DPRINT.
picked from 0.4.9-dev-217-g 8bdebb1fed
2020-12-21 06:51:50 +01:00
Joachim Henze f9f3f85a86 [0.4.7][NTOSKRNL] Demote some noisy dprints
picked from 0.4.13-dev-988-g 1539fb1414
2020-12-21 06:20:31 +01:00
Joachim Henze 4d93228e44 [0.4.7][SDK] Add UNIMPLEMENTED_ONCE macro
picked in squashed form from
0.4.8-dev-650-g 81eb3bbceb
0.4.9-dev-622-g c704cf5f87

I also ported that into all other release-branches >= 0.4.8 before.
The same MSVC-rls-fixed implementation.
2020-12-21 06:01:13 +01:00