Commit graph

59347 commits

Author SHA1 Message Date
Jérôme Gardou 0039187504 [NTOS/PS]
- Do not leak a reference to the process object when setting quotas.

svn path=/trunk/; revision=65210
2014-11-03 09:52:08 +00:00
Pierre Schweitzer 21cd59bc0f [DISK]
Add a hack to forcibly set sector size in case of weird input. This is noisy on purpose.
Also, be more informative in case of read rejection. Are we reading beyond partition or do we have invalid sector size?
With the hack, the invalid sector size should disappear.

This is to help debugging the recent errors with the removal of IopParseDevice() hack

svn path=/trunk/; revision=65205
2014-11-02 23:11:22 +00:00
Hervé Poussineau 3fc8b084e5 [NTFS] Implement IRP_MJ_QUERY_INFORMATION/FileNetworkOpenInformation:
We are now able to execute some binaries on a NTFS partition.

svn path=/trunk/; revision=65204
2014-11-02 22:56:53 +00:00
Hervé Poussineau 68487164df [NTFS] Fix IRP_MJ_QUERY_INFORMATION/FileNameInformation, which should handle buffers not big enough
svn path=/trunk/; revision=65203
2014-11-02 22:56:47 +00:00
Hervé Poussineau bdbbb217d5 [NTFS] Update headers
svn path=/trunk/; revision=65202
2014-11-02 22:56:38 +00:00
Pierre Schweitzer f2cbb4ac21 [NTFS]
Update headers.
Hervé, feel free to copy :-P

svn path=/trunk/; revision=65198
2014-11-02 21:50:40 +00:00
Hervé Poussineau 6a520d8fbe [NTFS] Hack fix duplicate directory entries for files having a short name and a long name
svn path=/trunk/; revision=65196
2014-11-02 20:18:34 +00:00
Hervé Poussineau c554032df9 [NTFS] Optimize directory search initialization
svn path=/trunk/; revision=65195
2014-11-02 20:18:27 +00:00
Pierre Schweitzer ffa40006ae [NTFS]
Quickly implement NtfsReadFile().

By quickly, I mean that it works but is under optimal in many ways, and also doesn't support any caching. So, don't expect breaking performances.

BUUUUUUT... This implements reading a file on a NTFS volume on ReactOS! And it works!
Here is a picture of all the achievements of ReactOS with NTFS lately: http://www.heisspiter.net/~Pierre/rostests/NTFS_all.png
-> Volume information
-> Displaying files in explorer
-> Moving across directories
-> Reading a file (with more here)

That's all folks! (for now ;-))

svn path=/trunk/; revision=65192
2014-11-02 19:55:22 +00:00
Pierre Schweitzer 6ea5fe3e43 [NTFS]
Don't attempt to uninitialize cache map with a spin lock held.

svn path=/trunk/; revision=65191
2014-11-02 19:27:58 +00:00
Hervé Poussineau 82f99f5e41 [NTFS] Fix directory listing with search pattern
This fixes name completion in command prompt.

svn path=/trunk/; revision=65190
2014-11-02 18:58:16 +00:00
Hervé Poussineau 3248b9e3b7 [NTOS:CM] Remove some debug prints
svn path=/trunk/; revision=65189
2014-11-02 18:58:09 +00:00
Hervé Poussineau 77e9b087e9 [FDC] Remove some debug prints
svn path=/trunk/; revision=65188
2014-11-02 18:58:04 +00:00
Hervé Poussineau ad03599ffb [SYSSETUP] Disable debug prints (incidentally enabled in r65128)
svn path=/trunk/; revision=65187
2014-11-02 18:57:56 +00:00
Pierre Schweitzer b304d6f14a [NTFS]
Fix a really nasty bug in NTFS: it was possible to perform a buffer overflow when reading the bitmap data.

svn path=/trunk/; revision=65186
2014-11-02 17:53:18 +00:00
Thomas Faber 760375811e [NTOS:SE]
- Call SeAssignSecurityEx from SeAssignSecurity
- Fix a FIXME

svn path=/trunk/; revision=65183
2014-11-02 15:41:20 +00:00
Timo Kreuzer a841fadcaa [HAMMERTIMESTFU]
Silence "a few" DPRINTs

svn path=/trunk/; revision=65181
2014-11-02 11:30:14 +00:00
Eric Kohl 1087501706 [NET]
Net user command:
- Fix typos in the /ACTIVE option.
- Implement the /COUNTRYCODE, /PASSWORDCHG and /PASSWORDREQ options.

svn path=/trunk/; revision=65179
2014-11-02 09:56:18 +00:00
Thomas Faber db79c779e8 [SACDRV]
- Silence debug prints
- Avoid magic numbers

svn path=/trunk/; revision=65178
2014-11-02 07:17:39 +00:00
Pierre Schweitzer a899cf5bdd [USETUP]
Make commented out code build (if ever uncommented ;-))

svn path=/trunk/; revision=65175
2014-11-01 21:13:16 +00:00
Pierre Schweitzer fc65ad4d5f [EXT2LIB]
Whatever happened during format, always unmount the volume.
This allows switching FS in usetup after formating an ext2 volume.

As a record, before (read, with the IopParseDevice) hack, this wasn't possible and if formating with ext2 was possible, kernel would have written with either RawFS or FastFAT driver. Which is not exactly what we want ;-).
But no joy guys... The Ext2Fsd needs to work in ReactOS first before we can effectively install ReactOS on ext2 volumes.

In any case, that's a clear step forward :-)

svn path=/trunk/; revision=65174
2014-11-01 21:09:10 +00:00
Pierre Schweitzer c1bbc436cb [FASTFAT]
Implement some kind of volume dismount in FastFAT (ie, implement VfatDismountVolume())

This is not fully perfect situation, but it does most of the job (+ leaking a few things). So far, this is not dramatic as its main use is for 1st stage. This will have to be improved later on.

CORE-8732 #comment Can you retest please?

svn path=/trunk/; revision=65173
2014-11-01 20:19:52 +00:00
Eric Kohl 2f120e9e6d [NET]
Display user group memberships.

svn path=/trunk/; revision=65172
2014-11-01 19:24:44 +00:00
Thomas Faber 6f9a074461 [FASTFAT]
- The volume FCB is not reference counted, so don't dereference it on close.

svn path=/trunk/; revision=65171
2014-11-01 18:00:15 +00:00
Hermès Bélusca-Maïto 2420e2ff0d [BASESRV]
- Correctly set the VdmPower flag when the process being started is a NT VDM
- Return a correct status code if VDM access is forbidden.

svn path=/trunk/; revision=65170
2014-11-01 17:51:39 +00:00
Hermès Bélusca-Maïto fec7f48782 [KERNEL32]
- Mark almost all of the exported console APIs hotpatchable (normally on windows 2k3, all the exports of kernel32 are hotpatchable...)
- Version check mismatch is not a ReactOS error by itself so adjust the DPRINT a bit.

svn path=/trunk/; revision=65169
2014-11-01 15:35:45 +00:00
Kamil Hornicek fd0e046213 [RAPPS]
- don't resize the richedit window on minimize
CORE-6116

svn path=/trunk/; revision=65168
2014-11-01 12:43:45 +00:00
Eric Kohl 8031de0f5d [NET]
- Display workstations.
- Implement the /ACTIVATE option to enable/disable user accounts.

svn path=/trunk/; revision=65167
2014-11-01 12:32:01 +00:00
Pierre Schweitzer 7fbedc7a2a [NTFS]
Simplify buffer size management in GetNtfsFileRecord(). As tests shown, Windows doesn't care about the real size of the file record and expects the caller to pass the complete size of the record and returns it fully.

CORE-8725

svn path=/trunk/; revision=65166
2014-11-01 10:02:08 +00:00
Pierre Schweitzer 67656096bd [NTFS_TEST]
Add a simple application (à la NTFSInfo & nfi) to dump the data about a NTFS volume using the FSCTL control codes.
This is for both demonstrating how it works and to assess our driver behavior against Windows behavior of these FSCTL.

CORE-8725

svn path=/trunk/; revision=65165
2014-11-01 09:56:33 +00:00
Pierre Schweitzer ce5999a8eb [PSDK]
Add yet another missing NTFS define

svn path=/trunk/; revision=65164
2014-11-01 08:58:41 +00:00
Pierre Schweitzer 139ec81ccb [PSDK]
Add missing NTFS defines

svn path=/trunk/; revision=65163
2014-11-01 08:03:57 +00:00
Kamil Hornicek 0cad6a3b91 [EVENTLOG]
- fix a possible null dereference

svn path=/trunk/; revision=65162
2014-10-31 22:39:19 +00:00
Amine Khaldi 46551d006f [SHELL32]
* Apply Wine commit a2c90524 by Aric Stewart: Improve the FO_MOVE operation.
* More shell32:shlfileop tests run, less fail.
CORE-8540

svn path=/trunk/; revision=65159
2014-10-31 18:46:27 +00:00
Kamil Hornicek 7a2c925aed [KERNEL32]
- rewrite the GEO_FRIENDLYNAME case of GetGeoInfoW which was completely wrong, intl.cpl now shows a valid list of locations
- note: The geo location resource strings have an arbitrary offset so that they don't collide with the nls resources (which shouldn't be there). Once these are moved out of kernel32 into locale.nls this offset alongside with the hack already present in GetLocalisedText can be removed.

svn path=/trunk/; revision=65157
2014-10-31 18:13:36 +00:00
Thomas Faber 52f76a303d [SHELL32]
- Fix a use after free in COpenWithMenu::Initialize. Powered by DPH.

svn path=/trunk/; revision=65156
2014-10-31 18:02:52 +00:00
Thomas Faber e62a1d0299 [NEWDEV]
- Fix buffer overflow in PopulateCustomPathCombo. Powered by DPH.
- Fix a signed vs unsigned comparison

svn path=/trunk/; revision=65154
2014-10-31 17:35:38 +00:00
Thomas Faber b5b1531e3e [MSGINA]
- pszEnvironment is a multi-sz string so make sure to double-null terminate it. Fixes a buffer overrun in winlogon; powered by DPH.

svn path=/trunk/; revision=65153
2014-10-31 17:05:30 +00:00
Kamil Hornicek 175d2a76b3 [KERNEL32]
- fall back to english if a localized resource is not found in GetLocalisedText
- this prevents debug spam and loss of functionality (see CORE-8720) for languages that don't have kernel32 translated

svn path=/trunk/; revision=65152
2014-10-31 16:32:23 +00:00
Kamil Hornicek 56f6fe0862 [WIN32K]
- don't access user mode buffers directly in the Freetype code

svn path=/trunk/; revision=65150
2014-10-31 15:57:09 +00:00
Amine Khaldi 80d683ac8d [SHELL32]
* Rename shellstring.cpp to shellstring.c and update it against Wine 1.7.27.
CORE-8540

svn path=/trunk/; revision=65147
2014-10-31 15:16:51 +00:00
Amine Khaldi 8a1d7dd1c0 [SHELL32]
* Move TRASH_CanTrashFile and TRASH_TrashFile declarations to recyclebin.h.
* Do not include xdg.h in shlfileop.cpp anymore.
* Remove the now unneeded xdg.h.

svn path=/trunk/; revision=65146
2014-10-31 14:29:26 +00:00
Pierre Schweitzer c9d1d86d84 [NTFS]
- Move FSCTL_GET_NTFS_VOLUME_DATA implementation in its own function GetNfsVolumeData(), so remove it from NtfsUserFsRequest()
- Add support for FSCTL_GET_NTFS_FILE_RECORD in NtfsUserFsRequest()
- Implement GetNtfsFileRecord() which returns a file record. Not fully sure about its implementation, this is to be checked.

This does not really improve the nfi situation in any kind yet...

CORE-8725

svn path=/trunk/; revision=65145
2014-10-31 14:21:35 +00:00
Pierre Schweitzer 6635caf5c4 [NTOSKRNL]
Testman confirms that IopParseDevice() hack is no longer required.
So, this is the end of this 8y old hack.

Now ReactOS is able to properly use its storage stack (who said, amazing?)

Bisous IopParseDevice() hack :-)

svn path=/trunk/; revision=65144
2014-10-31 14:16:15 +00:00
Jérôme Gardou da308db0af [OPENGL32]
- Do not crash if thread data was not allocated

svn path=/trunk/; revision=65143
2014-10-31 11:35:32 +00:00
Pierre Schweitzer cfb13ee214 [NTOSKRNL]
Revert r65120...
Which was reverting r65119...
Which was reverting r65117...
Which was reverting r65110...
Which was reverting r65107...
Which was reverting r65104!

To make it short? Fuck you IopParseDevice() hack!
And this time, I hope this is the right one!
I couldn't reproduce any of the previous issues in my WC.

svn path=/trunk/; revision=65142
2014-10-31 11:22:26 +00:00
Pierre Schweitzer afaa63a42c [NTOSKRNL]
Some fixes and missing implementations in RawFS:
- Remove some magic values for VCB state
- Add a local VPB in our VCB. This will allow diverting the IO VPB with ours in case of dismount (and thus, will fix dismount)
- Implement support for said VPB in both RawCheckForDismount() and RawInitializeVcb()
- Now, dismount is handled in RawCheckForDismount() directly, and not in functions calling it
- Handle streams in RawClose
- Handle VCB being dismounted in RawCreate()
- Handle dismount also in RawCleanup() (not only in RawClose())

This fixes volume locking and dismounting in RawFS. And thus, allows FS swap in case of raw volume formating in first stage :-).
More to follow!

svn path=/trunk/; revision=65141
2014-10-31 11:17:43 +00:00
Jérôme Gardou 3d37281ca2 [FASTFAT]
- Fix renaming files in case the target file already exists.
 - Plug a few reference count leaks on FCBs.
CORE-8660 #comment fixed in r65140 #resolve
CORE-8633 #comment fixed in r65140 #resolve
CORE-4758 #comment fixed in r65140 #resolve

svn path=/trunk/; revision=65140
2014-10-31 11:04:12 +00:00
Jérôme Gardou f801abcacf [NTOS/SE]
- Allocate the new ACL for the token with the right pool.
Fixes google chrome BAD_POOL_CALLER bugcheck.

svn path=/trunk/; revision=65139
2014-10-31 11:03:56 +00:00
Amine Khaldi d4eaa22e1f [FTP]
* Plug a leak. CID 513875.
CORE-7975

svn path=/trunk/; revision=65138
2014-10-31 10:40:48 +00:00