Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-04-04 12:39:35 +00:00
Code Issues Projects Releases Packages Wiki Activity

[NEWDEV]

Browse source 
- Fix buffer overflow in PopulateCustomPathCombo. Powered by DPH.
- Fix a signed vs unsigned comparison

svn path=/trunk/; revision=65154
This commit is contained in:
Thomas Faber 2014-10-31 17:35:38 +00:00
parent b5b1531e3e
commit e62a1d0299
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
reactos/dll/win32/newdev/wizard.c
View file

@ -280,7 +280,9 @@ PopulateCustomPathCombo(
TRACE("RegQueryValueEx() failed with error 0x%lx\n", rc);
goto cleanup;
}
Buffer[dwPathLength] = Buffer[dwPathLength + 1] = '\0';
Buffer[dwPathLength / sizeof(WCHAR)] = UNICODE_NULL;
Buffer[dwPathLength / sizeof(WCHAR) + 1] = UNICODE_NULL;
/* Populate combo box */
for (Path = Buffer; *Path; Path += wcslen(Path) + 1)
@ -305,7 +307,7 @@ SaveCustomPath(
LPWSTR Buffer = NULL;
LPWSTR pBuffer; /* Pointer into Buffer */
int ItemsCount, Length;
DWORD i;
int i;
DWORD TotalLength = 0;
BOOL UseCustomPath = TRUE;
HKEY hKey = NULL;