kaboomserver/extras
1
0
Fork 0
mirror of https://github.com/kaboomserver/extras.git synced 2025-08-05 12:03:08 +00:00
Code Issues Projects Releases Wiki Activity

OOB Random Spawn Fix (#316)

Browse source 
* Add warning for "randomizeSpawn" option about the speed of chunk generation

* Limit random spawn to half a million blocks, which should hopefully fix the OOB error

* Recommend users to use Chunky for pre-world generation

* Add missing period

* Fix checkstyle violation
This commit is contained in:
Allink 2022-07-18 18:32:19 +01:00 • committed by GitHub
parent 7f1057df08
commit 5780f1a4a6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/main/java/pw/kaboom/extras/modules/player/PlayerConnection.java
View file

@ -31,7 +31,6 @@ import pw.kaboom.extras.modules.server.ServerTabComplete;
public final class PlayerConnection implements Listener { public final class PlayerConnection implements Listener {
private static final FileConfiguration CONFIG = JavaPlugin.getPlugin(Main.class).getConfig(); private static final FileConfiguration CONFIG = JavaPlugin.getPlugin(Main.class).getConfig();
private static final String TITLE = CONFIG.getString("playerJoinTitle"); private static final String TITLE = CONFIG.getString("playerJoinTitle");
private static final String SUBTITLE = CONFIG.getString("playerJoinSubtitle"); private static final String SUBTITLE = CONFIG.getString("playerJoinSubtitle");
private static final int FADE_IN = 10; private static final int FADE_IN = 10;
@ -128,11 +127,16 @@ public final class PlayerConnection implements Listener {
if (RANDOMIZE_SPAWN if (RANDOMIZE_SPAWN
&& event.getPlayer().getBedSpawnLocation() != event.getSpawnLocation()) { && event.getPlayer().getBedSpawnLocation() != event.getSpawnLocation()) {
final World world = event.getPlayer().getWorld(); final World world = event.getPlayer().getWorld();
final double x = ThreadLocalRandom.current().nextInt(-300000000, 30000000) + .5; final ThreadLocalRandom random = ThreadLocalRandom.current();
final double y = 100;
final double z = ThreadLocalRandom.current().nextInt(-300000000, 30000000) + .5;
event.setSpawnLocation(new Location(world, x, y, z)); final double teleportAmount = 500000D;
final Location location = new Location(
world,
random.nextDouble(-teleportAmount, teleportAmount),
100,
random.nextDouble(-teleportAmount, teleportAmount)
);
event.setSpawnLocation(location);
} }
} }

4
src/main/resources/config.yml
View file

@ -3,6 +3,10 @@ allowJoinOnFullServer: true
enableKick: false enableKick: false
enableJoinRestrictions: false enableJoinRestrictions: false
opOnJoin: true opOnJoin: true
# It's recommended to do this on a pre-generated world
# as chunk generation can be very slow in newer Minecraft
# versions.
# You can use the pre-world generation plugin "Chunky" to achieve this.
randomizeSpawn: false randomizeSpawn: false
maxEntitiesPerChunk: 50 maxEntitiesPerChunk: 50
maxEntitiesPerWorld: 5120 maxEntitiesPerWorld: 5120