julia/Dockerfiles
2
0
Fork 2
Code Issues Pull requests Projects Releases Wiki Activity

Merge patch-1 #1

Merged
julia merged 2 commits from QuadraticKid/Dockerfiles:patch-1 into master 2022-01-16 10:44:05 +00:00
Conversation 2 Commits 2 Files changed 2 +2 -2
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 247614fc5d - Show all commits

4
minecraft-purpur/Dockerfile
View file

@ -7,7 +7,7 @@ RUN chown -R games /usr/games
USER games
WORKDIR /usr/games/minecraft-purpur
RUN curl -o purpur.jar https://api.pl3x.net/v2/purpur/$VERSION/latest/download
RUN curl -o purpur.jar https://api.purpurmc.org/v2/purpur/$VERSION/latest/download
WORKDIR /usr/games/minecraft-purpur/data
CMD [ "java", "-jar", "../purpur.jar" ]
CMD echo "eula=true" > eula.txt && java -jar ../purpur.jar
xfnw commented 2022-02-27 13:09:27 +00:00
Review
Copy link

is there a specific reason for adding eula.txt on every container start, instead of just making it part of the image (ie using a RUN or ADD statement)?

putting it in the CMD statement makes each container a few kb larger because of how OverlayFS works, and more importantly, breaks if the user specifies their own command on container creation

is there a specific reason for adding eula.txt on every container start, instead of just making it part of the image (ie using a RUN or ADD statement)? putting it in the CMD statement makes each container a few kb larger because of how OverlayFS works, and more importantly, breaks if the user specifies their own command on container creation