julia
/
Dockerfiles
2
0
Fork 2
Code Issues Pull Requests Projects Releases Wiki Activity

Merge patch-1 #1

Merged
julia merged 2 commits from QuadraticKid/Dockerfiles:patch-1 into master 2022-01-16 10:44:05 +00:00
Conversation 2 Commits 2 Files Changed 2 +3 -2
QuadraticKid commented 2022-01-16 10:37:48 +00:00
Contributor
Copy Link

Fix purpur endpoint, add auto-EULA accept, and add README for chowning

Fix purpur endpoint, add auto-EULA accept, and add README for chowning
QuadraticKid added 2 commits 2022-01-16 10:37:49 +00:00
julia commented 2022-01-16 10:40:14 +00:00
Owner
Copy Link

Thanks for the submission, I'm going to try it out

Thanks for the submission, I'm going to try it out
julia commented 2022-01-16 10:43:58 +00:00
Owner
Copy Link

Alright, it works. I will be merging it

Alright, it works. I will be merging it
julia merged commit 28a8633c65 into master 2022-01-16 10:44:05 +00:00
xfnw reviewed 2022-02-27 13:09:27 +00:00
minecraft-purpur/Dockerfile
@ -11,3 +11,3 @@
WORKDIR /usr/games/minecraft-purpur/data
CMD [ "java", "-jar", "../purpur.jar" ]
CMD echo "eula=true" > eula.txt && java -jar ../purpur.jar
xfnw commented 2022-02-27 13:09:27 +00:00
First-time contributor
Copy Link

is there a specific reason for adding eula.txt on every container start, instead of just making it part of the image (ie using a RUN or ADD statement)?

putting it in the CMD statement makes each container a few kb larger because of how OverlayFS works, and more importantly, breaks if the user specifies their own command on container creation

is there a specific reason for adding eula.txt on every container start, instead of just making it part of the image (ie using a RUN or ADD statement)? putting it in the CMD statement makes each container a few kb larger because of how OverlayFS works, and more importantly, breaks if the user specifies their own command on container creation
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: julia/Dockerfiles#1
No description provided.
Delete Branch "QuadraticKid/Dockerfiles:patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?