TheDeusGroup/TFM-4.3-Reloaded
1
0
Fork 0
mirror of https://github.com/TheDeus-Group/TFM-4.3-Reloaded.git synced 2024-12-23 07:54:58 +00:00
Code Issues Projects Releases Wiki Activity
TFM-4.3-Reloaded/CONTRIBUTING.md
Dan Jones ec0683f610 Java Code Conventions
2014-06-18 16:36:52 +01:00

3.7 KiB
Raw Blame History

Contributing to TotalFreedomMod

TotalFreedomMod is a CraftBukkit server plugin designed primarily to support the Official TotalFreedom Minecraft Server. However, it can be used in a variety of other configurations with minimal fuss.

For those who wish to contribute, we encourage you to fork the repository and submit pull requests. Below you will find guidelines that will explain this process in further detail.

Getting Started

  • Make sure you have a GitHub account
  • If the issue is a bug, submit a ticket for it, assuming one does not already exist.
    • Clearly describe the issue including steps to reproduce it.
    • Make sure you fill in the earliest version that you know has the issue.
  • Fork the repository on GitHub

Making Changes

  • Create a topic branch from where you want to base your work.
    • This is usually the master branch.
    • Only target release branches if you are certain your addition must be on that branch.
    • To quickly create a topic branch based on master; git checkout -b contribution - Please avoid working directly on the master branch.
  • Make changes and commit where necessary.
  • Check for unnecessary whitespace with git diff --check before committing.
  • Make sure your commit messages are in line with those which are already made.
  • Make sure your changes build (and work!).

Tips - How To Get Your Pull Request Accepted

  • See this picture for help: Imgur

  • Make sure your changes work and compile without difficulty.

  • Make sure your change adds something useful, do not add commands to micromanage the server. (ie: Shorthands for a collection of commands)

    • Commands that make use of org.bukkit.Server.dispatchCommand() will probably be rejected.

  • Features must be in line the general idea of "Total Freedom".

  • Changes must be directed towards the main "TotalFreedom" server. Adding names such as the name of your own TotalFreedom-like server will get your pull request denied.

  • Do not add yourself to the developer list.

  • Ensure that you use the correct whitespace-style. That is: 4 spaces as indentation.

  • Please make sure your changes are written such as other features would be. Eg: commands have their own class and extend TFM_Command.

  • Make sure your code is written in the Allman style, and that it follows Java Code Conventions.

  • Do not increment the version number.

  • If you want to add multiple changes, please make one pull request per change. This way, it's easier to accept your changes faster and won't block the other changes if there is an issue with a specific line of code.

  • Please make sure there are no bugs in your code.

  • Please avoid having to add files in the main namespace where possible.

  • Make sure all changes work before you commit these, this avoids having multiple unnecessary commits.

  • Please refrain from using an excessive amount of commits. As few as possible is generally the best.

  • Please do not spread your addition over several pull-requests.

Submitting Your Changes

  • Push your changes to a topic branch in your fork of the repository.
  • Submit a pull request to this repository.
    • Explain in detail what each one of your commits changes and point out any big changes.
  • Wait as a developer evaluates your changes.

Additional Resources