reactos/dll/win32/comctl32
Joachim Henze 232c45fcd7 [WIN32SS][COMCTL32] Commit Flip_Fix_9.patch
flip_fix_9.patch fixes:
CORE-16984 " 'SPINA Thrulg' / 'SPINA Thyr' / 'Sim Thyr' have images flipped"
CORE-17194 "StretchDIBits test" isn't work correctly"
           "Output of 'Project 3 Test'"
CORE-14701 "DVDStyler 3.0.4 transparent toolbars"
CORE-14701 "DVDStyler 3.0.4 erroneously black around icons of welcome-dlg"
CORE-14671 "'Peazip' shows icons in buttons and menubar vertically flipped"
           "Double Commander shoes icons flipped in buttons, menubar, listview and the treeview"
CORE-13273 "Welcome to Lazarus" icon shows flipped
CORE-13026 "'CudaText app' icon shows flipped"

Not all of those are duplicates, although they appear to be at first glance.
It affects different controls and some of those tickets do have different 'guilty revs' than others.

The patch does consist of 3 parts:

1.) win32ss/gdi/ntgdi/dibobj.c
This one is the most clean part of it, that addresses most of the flipping issues now.

2.) The hack in comctl32.h redefining the version:
We used that in the past to appease some, but not all of the issues listed above.
But it does hide additional issues, e.g. in DvDStyler, therefore we seem to still need that appeasement even today.
Most likely it would make sense to aim to avoid this part in the future.
part 2.) was committed as first appeasement on its own already into
0.4.14-RC-24-g 198b61e
0.4.13-RC-7-g 67211fa
0.4.12-RC-5-g 8449527
0.4.11-RC-16-g b906163
0.4.10-RC-7-g f1e80fe
0.4.9-RC-34-g 9d758ae

3.) toolbar.c change
That part fixes at least the toolbar case for DvDStyler
without relying on the comctl32.h hack any longer,
but it was still not enough to completely get rid of part 2.) yet.

Many thanks to all contributors: 'I_kill_Bugs', Doug Lyons and also 'Julenuri' for testing.

The patch gave nice testbot results:
KVM:  https://reactos.org/testman/compare.php?ids=75704,75714
VBox: https://reactos.org/testman/compare.php?ids=75705,75715

and we also created a summary of manual test-results:
https://jira.reactos.org/browse/CORE-17415?focusedCommentId=126668&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-126668

If you read this comment via git blame and your goal is to get rid of the hack in comctl32.h, I would highly recommend
to redo the tests of that testing table, and if that is asked too much, then please test at least the following cases:
CORE-14701 "DVDStyler 3.0.4 transparent toolbars"
CORE-14701 "DVDStyler 3.0.4 erroneously black around icons of welcome-dlg"
           "DVDStyler 3.0.4 erroneously black/transparent within comboboxes of properties of VMGM menu"
and try to add what might be needed to fix them, and double-check again:
           "DoubleCommander optionsDlg the most complex testcase, contains flip-prone icons in treeview, listview, menubar, buttons, statics". Only some of its flipped icons were impacted by the comctl32.h change before.
2021-01-05 20:30:40 +01:00
..
lang [TRANSLATION] Update Spanish, and add Basque translation (#2667) 2020-05-17 18:46:36 +02:00
animate.c
button.c [COMCTL32] Button.c Fix CORE-17260 2020-10-03 15:38:02 +02:00
CMakeLists.txt [CMAKE] Get rid of add_compile_flags 2020-10-20 21:44:54 +02:00
combo.c
comboex.c
comctl32.h [WIN32SS][COMCTL32] Commit Flip_Fix_9.patch 2021-01-05 20:30:40 +01:00
comctl32.spec
comctl32_ros.diff
comctl32undoc.c
commctrl.c
datetime.c
dpa.c
draglist.c
dsa.c
edit.c
flatsb.c
header.c
hotkey.c
idb_hist_large.bmp
idb_hist_small.bmp
idb_std_large.bmp
idb_std_small.bmp
idb_view_large.bmp
idb_view_small.bmp
idc_copy.cur
idc_divider.cur
idc_divideropen.cur
idc_movebutton.cur
idi_dragarrow.ico
idi_tt_error_sm.ico
idi_tt_info_sm.ico
idi_tt_warn_sm.ico
idt_check.bmp
imagelist.c
ipaddress.c [COMCTL32] Fix wrong behavior about Tab key 2020-10-01 22:53:59 +09:00
listbox.c
listview.c [COMCTL32][SHELL32] Fix arrow keys and reordering on ListView (#3162) 2020-09-17 22:18:34 +09:00
monthcal.c
nativefont.c
pager.c
precomp.h
progress.c
propsheet.c [COMCTL32] Fix recalculation of property-sheet dialog position (#1818) 2020-05-15 18:12:02 +02:00
rebar.c
resource.h
rsrc.rc
smoothscroll.c
static.c [COMCTL32] Fix issue on showing current mouse pointer (#2829) 2020-08-16 18:42:12 +03:00
status.c
string.c
stubs.c
syslink.c
tab.c
taskdialog.c
theme_scrollbar.c
theming.c
toolbar.c [WIN32SS][COMCTL32] Commit Flip_Fix_9.patch 2021-01-05 20:30:40 +01:00
tooltips.c
trackbar.c
treeview.c Fix of comdlg32 Treeview undue handling of WM_SYSKEYDOWN (#2731) 2020-05-09 21:37:26 +09:00
updown.c
x86_microsoft.windows.common-controls_6595b64144ccf1df_5.82.2600.2982_none_deadbeef.manifest
x86_microsoft.windows.common-controls_6595b64144ccf1df_6.0.2600.2982_none_deadbeef.manifest